[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610521#comment-16610521 ] Hudson commented on HBASE-21162: Results for branch branch-1 [build #455 on

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610491#comment-16610491 ] Hudson commented on HBASE-21162: Results for branch branch-1.4 [build #457 on

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610464#comment-16610464 ] Hudson commented on HBASE-21162: Results for branch branch-1 [build #456 on

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-10 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609651#comment-16609651 ] Rushabh S Shah commented on HBASE-21162: {quote}[~shahrs87] We aren't leaking instances of the

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-10 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609549#comment-16609549 ] Andrew Purtell commented on HBASE-21162: Last patch resolved the findbugs nit and tests are all

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-10 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609544#comment-16609544 ] Andrew Purtell commented on HBASE-21162: > Since BoundedByteBufferPool is created just once in

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-10 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609518#comment-16609518 ] Rushabh S Shah commented on HBASE-21162: {quote}I think the change is suspicious and should be

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607885#comment-16607885 ] Hadoop QA commented on HBASE-21162: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607805#comment-16607805 ] Andrew Purtell commented on HBASE-21162: Latest patch fixes checkstyle nit > Revert suspicious

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607803#comment-16607803 ] Andrew Purtell commented on HBASE-21162: TestLoadIncrementalHFilesUseSecurityEndPoint failure is

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607730#comment-16607730 ] Hadoop QA commented on HBASE-21162: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607585#comment-16607585 ] Andrew Purtell commented on HBASE-21162: Updated patch mentions this JIRA in the comment >

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607580#comment-16607580 ] Andrew Purtell commented on HBASE-21162: [~mdrob] Latest patch suppresses warning for

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607570#comment-16607570 ] Mike Drob commented on HBASE-21162: --- What was the error-prone complaint? Can still add a

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Andrew Purtell (JIRA)

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607519#comment-16607519 ] Andrew Purtell commented on HBASE-21162: My bad, no findbugs warnings here, they were/are

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607446#comment-16607446 ] Andrew Purtell commented on HBASE-21162: [~busbey] Ok, let me do a local analysis and add

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-07 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606735#comment-16606735 ] Sean Busbey commented on HBASE-21162: - if you make findbugs warnings, add the exclusions so that we

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606582#comment-16606582 ] Andrew Purtell commented on HBASE-21162: We want the reservoir for its original purpose of

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-06 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606559#comment-16606559 ] Rushabh S Shah commented on HBASE-21162: Thanks [~apurtell] for creating the issue and uploading

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606431#comment-16606431 ] Andrew Purtell commented on HBASE-21162: The test failure in TestHFileCleaner does not seem

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606292#comment-16606292 ] Hadoop QA commented on HBASE-21162: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606071#comment-16606071 ] Andrew Purtell commented on HBASE-21162: Findbugs warnings are expected with this change! >

[jira] [Commented] (HBASE-21162) Revert suspicious change to BoundedByteBufferPool and disable use of direct buffers for IPC reservoir by default

2018-09-06 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606069#comment-16606069 ] Andrew Purtell commented on HBASE-21162: BoundedByteBufferPool was removed in branch-2 and up so