[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660514#comment-16660514 ] Hudson commented on HBASE-21278: Results for branch branch-2.1 [build #517 on

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660465#comment-16660465 ] Hudson commented on HBASE-21278: Results for branch branch-2.0 [build #999 on

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-16 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652972#comment-16652972 ] stack commented on HBASE-21278: --- Should we backport a form of this to branch-2.1 [~Apache9] and adopt the

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651700#comment-16651700 ] Hudson commented on HBASE-21278: Results for branch master [build #549 on

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651652#comment-16651652 ] Hudson commented on HBASE-21278: Results for branch branch-2 [build #1397 on

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650998#comment-16650998 ] Duo Zhang commented on HBASE-21278: --- Ping [~allan163] and [~stack]. Will commit if no other concerns.

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649637#comment-16649637 ] Duo Zhang commented on HBASE-21278: --- If no other concerns let's commit this? Will prepare the patch

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649359#comment-16649359 ] Duo Zhang commented on HBASE-21278: --- OK, good, all green. > Do not rollback successful sub procedures

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649358#comment-16649358 ] Hadoop QA commented on HBASE-21278: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649184#comment-16649184 ] Duo Zhang commented on HBASE-21278: --- For TestEnableTableProcedure, it is because that I changed the

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649163#comment-16649163 ] Duo Zhang commented on HBASE-21278: --- I've replied on RB, the old implementation is not idempotent. We

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649033#comment-16649033 ] stack commented on HBASE-21278: --- Left a few notes up on rb. Do we have to go through all Procedures and

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-13 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648992#comment-16648992 ] Allan Yang commented on HBASE-21278: Just reviewed the patch, +1 for it. I think this patch can go

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648947#comment-16648947 ] Hadoop QA commented on HBASE-21278: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648853#comment-16648853 ] Duo Zhang commented on HBASE-21278: --- Ping [~stack] for reviewing. The old rollback implementation for

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648852#comment-16648852 ] Duo Zhang commented on HBASE-21278: --- Review board link: https://reviews.apache.org/r/69014/ > Do not

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647662#comment-16647662 ] Duo Zhang commented on HBASE-21278: --- OK I think the first problem is that our

[jira] [Commented] (HBASE-21278) Do not rollback successful sub procedures when rolling back a procedure

2018-10-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647644#comment-16647644 ] Duo Zhang commented on HBASE-21278: --- I tried and got 'Corrupted Procedures'... Let me dig more...