[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726624#comment-16726624
]
Allan Yang commented on HBASE-21565:
[~zghaobac],this issue should covered HBASE-20976, let's mark
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725561#comment-16725561
]
Guanghao Zhang commented on HBASE-21565:
[~stack] There is another issue HBASE-20976 for this
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725443#comment-16725443
]
Hudson commented on HBASE-21565:
Results for branch branch-2
[build #1567 on
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724925#comment-16724925
]
Hudson commented on HBASE-21565:
Results for branch master
[build #671 on
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724881#comment-16724881
]
Jingyun Tian commented on HBASE-21565:
--
This failed test is not related to this patch. Pushed to
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724816#comment-16724816
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724709#comment-16724709
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724646#comment-16724646
]
Jingyun Tian commented on HBASE-21565:
--
These failed UTs are flakey, they all passed on my own
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724236#comment-16724236
]
stack commented on HBASE-21565:
---
+1 for branch-2.0 when it passes tests. This is a nice bug fix. Thanks
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724126#comment-16724126
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723850#comment-16723850
]
Jingyun Tian commented on HBASE-21565:
--
Pushed to master already. Branch-2 has some conflicts, I
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723018#comment-16723018
]
Hadoop QA commented on HBASE-21565:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722897#comment-16722897
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722877#comment-16722877
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722750#comment-16722750
]
Jingyun Tian commented on HBASE-21565:
--
[~zghaobac] Before HBASE-21508, there is no ServerNode
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722726#comment-16722726
]
Guanghao Zhang commented on HBASE-21565:
{quote}bq.This patch relies on HBASE-21508, and I think
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722724#comment-16722724
]
Guanghao Zhang commented on HBASE-21565:
{quote}bq. Assert.assertTrue(serverNode != null);
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722719#comment-16722719
]
Jingyun Tian commented on HBASE-21565:
--
[~zghaobac] Thanks for your comment. Added some status
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722713#comment-16722713
]
Hadoop QA commented on HBASE-21565:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722666#comment-16722666
]
stack commented on HBASE-21565:
---
+1 on .007 after addressing [~zghaobac] 's comments. Should go to
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722665#comment-16722665
]
Guanghao Zhang commented on HBASE-21565:
Add assert check for ServerNode in
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721913#comment-16721913
]
Jingyun Tian commented on HBASE-21565:
--
[~stack]
{quote}Its a big change setting holdLock on SCP?
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721769#comment-16721769
]
stack commented on HBASE-21565:
---
Nice find [~tianjingyun].
This log which is above your change needs
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721528#comment-16721528
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719873#comment-16719873
]
Jingyun Tian commented on HBASE-21565:
--
[~Apache9] Failed UT is not related to my patch. And I use
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719841#comment-16719841
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718745#comment-16718745
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718421#comment-16718421
]
Jingyun Tian commented on HBASE-21565:
--
[~Apache9]These 2 failed UTs are not related to my patch.
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716793#comment-16716793
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714343#comment-16714343
]
Jingyun Tian commented on HBASE-21565:
--
[~Apache9] I Ported patch from HBASE-20976 and Set the
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714324#comment-16714324
]
Hadoop QA commented on HBASE-21565:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714258#comment-16714258
]
Jingyun Tian commented on HBASE-21565:
--
[~allan163] Thanks for your comment. I ported your patch to
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713859#comment-16713859
]
Allan Yang commented on HBASE-21565:
There is a similar issue discussing here HBASE-20976
> Delete
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713472#comment-16713472
]
Jingyun Tian commented on HBASE-21565:
--
[~apurtell] Thanks for your reply. I got your point.
bq. I
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713471#comment-16713471
]
Jingyun Tian commented on HBASE-21565:
--
[~Apache9] Yes. I think that should work. Let me dig the
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713132#comment-16713132
]
Andrew Purtell commented on HBASE-21565:
[~tianjingyun] The goal of HBASE-21266 was to fix a
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712731#comment-16712731
]
Duo Zhang commented on HBASE-21565:
---
Is it possible to change the holdLock to true for
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712726#comment-16712726
]
Hadoop QA commented on HBASE-21565:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712627#comment-16712627
]
Jingyun Tian commented on HBASE-21565:
--
[~apurtell] Sir, I found my patch has some conflicts with
39 matches
Mail list logo