[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776097#comment-16776097 ] Hudson commented on HBASE-21922: Results for branch master [build #819 on

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776060#comment-16776060 ] Hudson commented on HBASE-21922: Results for branch branch-2 [build #1705 on

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776058#comment-16776058 ] Hudson commented on HBASE-21922: Results for branch branch-2.2 [build #62 on

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775874#comment-16775874 ] Hadoop QA commented on HBASE-21922: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-22 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775803#comment-16775803 ] Andrew Purtell commented on HBASE-21922: The branch-1 patch wasn’t committed and the issue was

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-22 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775323#comment-16775323 ] stack commented on HBASE-21922: --- Skimmed. +1. Thanks. > BloomContext#sanityCheck may failed when use

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775155#comment-16775155 ] Hadoop QA commented on HBASE-21922: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-22 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774983#comment-16774983 ] Guanghao Zhang commented on HBASE-21922: Add a 002 patch and need to regenerte thrift java file

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-22 Thread Guangxu Cheng (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774901#comment-16774901 ] Guangxu Cheng commented on HBASE-21922: --- HBASE-21220 has started to port this feature to branch-1,

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-22 Thread Guangxu Cheng (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774897#comment-16774897 ] Guangxu Cheng commented on HBASE-21922: --- +1 on removing the ROWPREFIX_DELMITED bloom filter type

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-22 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774893#comment-16774893 ] Guanghao Zhang commented on HBASE-21922: Ping [~andrewcheng]. If no objections, I will prepare a

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774855#comment-16774855 ] stack commented on HBASE-21922: --- Good one lads. Yes, to removing it as not trustworthy after your findings

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774762#comment-16774762 ] Guanghao Zhang commented on HBASE-21922: {quote}If the ASCII of the delimiter is smaller than

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Guangxu Cheng (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774737#comment-16774737 ] Guangxu Cheng commented on HBASE-21922: --- This problem does exist in individual scenarios:(, which

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774690#comment-16774690 ] Guanghao Zhang commented on HBASE-21922: {quote}bq.Will KeyDelimitedRegionSplitPolicy have the

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774682#comment-16774682 ] Duo Zhang commented on HBASE-21922: --- Ping [~stack]. What do you think sir? Thanks. >

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774680#comment-16774680 ] Duo Zhang commented on HBASE-21922: --- Maybe not since we just use the algorithm to get a key, and then

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774674#comment-16774674 ] Duo Zhang commented on HBASE-21922: --- Will KeyDelimitedRegionSplitPolicy have the same problem? >

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774054#comment-16774054 ] Guanghao Zhang commented on HBASE-21922: The ROWPREFIX_DELIMITED bloom filter was introduced by

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773928#comment-16773928 ] Guanghao Zhang commented on HBASE-21922: {quote}I think the problem is by design?  {quote} Yes.

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773794#comment-16773794 ] Duo Zhang commented on HBASE-21922: --- I think the problem is by design? This means we can only use

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-20 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772783#comment-16772783 ] Guanghao Zhang commented on HBASE-21922: One possible soluation is remove the check for bloom

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-19 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772551#comment-16772551 ] Guanghao Zhang commented on HBASE-21922: Remove the BloomContext#sanityCheck is not worked. As

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-19 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772549#comment-16772549 ] Guanghao Zhang commented on HBASE-21922: '1234' is bigger than '123'. >

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-19 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772416#comment-16772416 ] Xu Cang commented on HBASE-21922: - Is '1234' smaller than '123' expected? > BloomContext#sanityCheck

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771584#comment-16771584 ] Hadoop QA commented on HBASE-21922: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-18 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771548#comment-16771548 ] Guanghao Zhang commented on HBASE-21922: [INFO] Running

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-18 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771060#comment-16771060 ] Guanghao Zhang commented on HBASE-21922: Write a ut for this case. But it has problem when read

[jira] [Commented] (HBASE-21922) BloomContext#sanityCheck may failed when use ROWPREFIX_DELIMITED bloom filter

2019-02-18 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770847#comment-16770847 ] Guanghao Zhang commented on HBASE-21922: This sanityCheck was introduced by HBASE-16372. Ping