[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342127#comment-17342127 ] Michael Stack commented on HBASE-25774: --- Thanks for figuring the race [~zhangduo] (My bad too for

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-10 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342077#comment-17342077 ] Nick Dimiduk commented on HBASE-25774: -- Looks like the discussion for how to hand 2.3.5 was split

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341509#comment-17341509 ] Hudson commented on HBASE-25774: Results for branch master [build #287 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341450#comment-17341450 ] Duo Zhang commented on HBASE-25774: --- I think the main point of HBASE-25032 is about region assignment.

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341447#comment-17341447 ] Bharath Vissapragada commented on HBASE-25774: -- Nice find, couldn't think of this race when

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341440#comment-17341440 ] Hudson commented on HBASE-25774: Results for branch branch-2.4 [build #112 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341394#comment-17341394 ] Andrew Kyle Purtell commented on HBASE-25774: - Thanks for the addendum [~zhangduo], I

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341384#comment-17341384 ] Hudson commented on HBASE-25774: Results for branch branch-2 [build #245 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341360#comment-17341360 ] Hudson commented on HBASE-25774: Results for branch branch-2.3 [build #216 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341351#comment-17341351 ] Hudson commented on HBASE-25774: Results for branch branch-1 [build #124 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341176#comment-17341176 ] Hudson commented on HBASE-25774: Results for branch master [build #286 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341095#comment-17341095 ] Andrew Kyle Purtell commented on HBASE-25774: - Yes, I marked the revert with HBASE-25774 . I

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341093#comment-17341093 ] Duo Zhang commented on HBASE-25774: --- Oh, good, just noticed that you committed the revert patch as

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341091#comment-17341091 ] Duo Zhang commented on HBASE-25774: --- We didn't commit anything to branch other than master, so should

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341086#comment-17341086 ] Andrew Kyle Purtell commented on HBASE-25774: - I am reverting HBASE-25032 from master,

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340551#comment-17340551 ] Duo Zhang commented on HBASE-25774: --- {quote} We can revert it in 2.3.5 and make a 2.3.5.1 with just

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340539#comment-17340539 ] Andrew Kyle Purtell commented on HBASE-25774: - We can revert it in 2.3.5 and make a 2.3.5.1

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340536#comment-17340536 ] Duo Zhang commented on HBASE-25774: --- It has already been released in 2.3.5 so I do not think we could

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340534#comment-17340534 ] Andrew Kyle Purtell commented on HBASE-25774: - Better to be sure. Let’s revert and reopen

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340521#comment-17340521 ] Duo Zhang commented on HBASE-25774: --- Skimmed the code, I do not think it is easy to fix as we call

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340510#comment-17340510 ] Duo Zhang commented on HBASE-25774: --- So it does not only effect peer modification related procedures.