[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13016238#comment-13016238
]
Hudson commented on HBASE-3694:
---
Integrated in HBase-TRUNK #1831 (See
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015236#comment-13015236
]
stack commented on HBASE-3694:
--
@Liyin Then your last posted patch is good to go?
high
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015075#comment-13015075
]
Liyin Tang commented on HBASE-3694:
---
I think using AtomicLong is pretty safe here:)
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011589#comment-13011589
]
Ted Yu commented on HBASE-3694:
---
I agree with Todd's comment about the increment call. There
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011675#comment-13011675
]
Liyin Tang commented on HBASE-3694:
---
+1 with the change method name to
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011682#comment-13011682
]
stack commented on HBASE-3694:
--
Use AtomicLong if alternative is not thread safe. Name
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011686#comment-13011686
]
stack commented on HBASE-3694:
--
bq. But Cliff Click Counter is not thread safe.
I thought
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011694#comment-13011694
]
Liyin Tang commented on HBASE-3694:
---
Thanks stack and Ted,
I thought CC Counters was
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011703#comment-13011703
]
Ted Yu commented on HBASE-3694:
---
Here is javadoc for add_if_mask() which is called by add():
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011717#comment-13011717
]
stack commented on HBASE-3694:
--
@Liyin Approx count on get is fine by me. If you need it to
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011414#comment-13011414
]
stack commented on HBASE-3694:
--
Patch looks good but I stumble when I come to this:
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011421#comment-13011421
]
Liyin Tang commented on HBASE-3694:
---
Thanks Stack.
I think adding globalMemstoreSize
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011437#comment-13011437
]
Todd Lipcon commented on HBASE-3694:
I don't want to conflate metrics (things that get
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011444#comment-13011444
]
Ted Yu commented on HBASE-3694:
---
memstoreSizeMB is a member of RegionServerMetrics and is
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011449#comment-13011449
]
Liyin Tang commented on HBASE-3694:
---
The internal accounting makes sense. I just think
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011452#comment-13011452
]
Jonathan Gray commented on HBASE-3694:
--
Do we really want to put things like this
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011457#comment-13011457
]
Todd Lipcon commented on HBASE-3694:
+1 to jgray's suggestion. Please please please
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011461#comment-13011461
]
stack commented on HBASE-3694:
--
bq. In terms of overall design, I would love to see
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011467#comment-13011467
]
Todd Lipcon commented on HBASE-3694:
Sounds good to me.
high multiput latency due to
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011561#comment-13011561
]
stack commented on HBASE-3694:
--
Please do not use HBaseClusterTestCase as basis for your
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011570#comment-13011570
]
Todd Lipcon commented on HBASE-3694:
I don't think we should return the current value
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010974#comment-13010974
]
stack commented on HBASE-3694:
--
RSS has:
{code}
/**
* Returns a reference to the RPC
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010980#comment-13010980
]
Ted Yu commented on HBASE-3694:
---
How about piggybacking HServerInfo:
{code}
public
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010981#comment-13010981
]
Todd Lipcon commented on HBASE-3694:
RpcMetrics seems like the wrong spot to me.
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010983#comment-13010983
]
Jonathan Gray commented on HBASE-3694:
--
Neither of these seem right. Issue with
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010984#comment-13010984
]
stack commented on HBASE-3694:
--
We could add a new method. Just trying to keep the methods
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010986#comment-13010986
]
Ted Yu commented on HBASE-3694:
---
@Liyin can you run your test after incorporating HBASE-3654
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011029#comment-13011029
]
Ted Yu commented on HBASE-3694:
---
HRegion already has this:
{code}
final
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010376#comment-13010376
]
Todd Lipcon commented on HBASE-3694:
I don't think a static variable is the way to go.
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010492#comment-13010492
]
Liyin Tang commented on HBASE-3694:
---
We tried to add this var in RS and passing it to
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010513#comment-13010513
]
Todd Lipcon commented on HBASE-3694:
Just seems to me that static state is just the
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010518#comment-13010518
]
ryan rawson commented on HBASE-3694:
Lets avoid the static if at all possible. Ditto
[
https://issues.apache.org/jira/browse/HBASE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010521#comment-13010521
]
Ted Yu commented on HBASE-3694:
---
HRegion has reference to RegionServerServices
HRegionServer
33 matches
Mail list logo
