[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-17 Thread Manukranth Kolloju (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938275#comment-13938275 ] Manukranth Kolloju commented on HBASE-4012: --- [... I was hoping* to see parity

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938327#comment-13938327 ] stack commented on HBASE-4012: -- Sounds like this is worth a bit of retesting given

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938330#comment-13938330 ] stack commented on HBASE-4012: -- I made HBASE-10775 to look at this again. Further optimize

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-17 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938353#comment-13938353 ] Lars Hofhansl commented on HBASE-4012: -- If [~manukranthk]'s results are right I would

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938390#comment-13938390 ] stack commented on HBASE-4012: -- It is as though we should compare first 5 bytes with old

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-15 Thread Manukranth Kolloju (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936041#comment-13936041 ] Manukranth Kolloju commented on HBASE-4012: --- Yes, In the above paste, prefix ~

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-14 Thread Manukranth Kolloju (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935878#comment-13935878 ] Manukranth Kolloju commented on HBASE-4012: --- I know that this Jira was long

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935977#comment-13935977 ] stack commented on HBASE-4012: -- [~manukranthk] How do I read the above? If the keys have the

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2014-03-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935995#comment-13935995 ] Lars Hofhansl commented on HBASE-4012: -- I did some - entirely unscientific - tests on

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-08-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089228#comment-13089228 ] Hudson commented on HBASE-4012: --- Integrated in HBase-TRUNK #2131 (See

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-07-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058875#comment-13058875 ] stack commented on HBASE-4012: -- @Ted The comments in that issue are kinda funny. They are

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-30 Thread Eric Charles (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057709#comment-13057709 ] Eric Charles commented on HBASE-4012: - sun.msc.Unsafe is still in jdk7

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057578#comment-13057578 ] Ted Yu commented on HBASE-4012: --- I don't think there is a way to suppress the warning:

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-28 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056356#comment-13056356 ] Todd Lipcon commented on HBASE-4012: was figuring I might work on this on Thursday at

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056595#comment-13056595 ] Ted Yu commented on HBASE-4012: --- Test suite got stuck in TestSplitTransactionOnCluster There

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056894#comment-13056894 ] stack commented on HBASE-4012: -- This looks fine to me. +1 Further optimize byte comparison

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056902#comment-13056902 ] Ted Yu commented on HBASE-4012: --- Integrated to TRUNK. Thanks for the review Todd and Stack.

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056937#comment-13056937 ] Hudson commented on HBASE-4012: --- Integrated in HBase-TRUNK #1996 (See

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056969#comment-13056969 ] stack commented on HBASE-4012: -- Interesting. It looks like we've now picked up the below on

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056301#comment-13056301 ] Ted Yu commented on HBASE-4012: --- @Todd: If you don't have time, I can try coming up with a

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-21 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052693#comment-13052693 ] Andrew Purtell commented on HBASE-4012: --- +1 Byte comparison is the top hotspot for

[jira] [Commented] (HBASE-4012) Further optimize byte comparison methods

2011-06-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052698#comment-13052698 ] stack commented on HBASE-4012: -- I like this kinda comment: {code} * Compare 8 bytes