[jira] [Commented] (HBASE-4226) HFileBlock.java style cleanup.

2011-08-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087570#comment-13087570 ] stack commented on HBASE-4226: -- The above sounds smart Li (especially the sneaking stuff in

[jira] [Commented] (HBASE-4226) HFileBlock.java style cleanup.

2011-08-18 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087298#comment-13087298 ] Todd Lipcon commented on HBASE-4226: A lot of these changes actually make it harder to

[jira] [Commented] (HBASE-4226) HFileBlock.java style cleanup.

2011-08-18 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087337#comment-13087337 ] Li Pi commented on HBASE-4226: -- Gotcha. Will fix.

[jira] [Commented] (HBASE-4226) HFileBlock.java style cleanup.

2011-08-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087533#comment-13087533 ] stack commented on HBASE-4226: -- @Li Who every told you it was a good idea to make stylistic

[jira] [Commented] (HBASE-4226) HFileBlock.java style cleanup.

2011-08-18 Thread Li Pi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087539#comment-13087539 ] Li Pi commented on HBASE-4226: -- I'm gonna cut this patch down to the single bit about