[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132371#comment-13132371
]
Hudson commented on HBASE-4626:
---
Integrated in HBase-TRUNK #2348 (See
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131878#comment-13131878
]
stack commented on HBASE-4626:
--
+1 on patch. I'm fine w/ it in 0.92 (doesn't have to go into
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132299#comment-13132299
]
Lars Hofhansl commented on HBASE-4626:
--
Committed to trunk.
Filters
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132318#comment-13132318
]
Lars Hofhansl commented on HBASE-4626:
--
In the widest sense this could be considered
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131047#comment-13131047
]
Ted Yu commented on HBASE-4626:
---
Interesting finding.
WritableByteArrayComparable should be
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131086#comment-13131086
]
Lars Hofhansl commented on HBASE-4626:
--
Exactly!
There are a bunch subclasses of
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131203#comment-13131203
]
Lars Hofhansl commented on HBASE-4626:
--
Also there are many more filters that do this
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131207#comment-13131207
]
Ted Yu commented on HBASE-4626:
---
Nice work.
Please fill in javadoc for return value:
{code}
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131354#comment-13131354
]
Lars Hofhansl commented on HBASE-4626:
--
I will commit this to trunk tomorrow, unless
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131355#comment-13131355
]
Ted Yu commented on HBASE-4626:
---
Since this is a bug, I think it should go to 0.92 as well.
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131358#comment-13131358
]
Lars Hofhansl commented on HBASE-4626:
--
All tests pass BTW. (TestHFileBlock fails
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131360#comment-13131360
]
Lars Hofhansl commented on HBASE-4626:
--
Well, actually... It is a performance
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131370#comment-13131370
]
Ted Yu commented on HBASE-4626:
---
@Lars:
Since you have confidence in the patch, I think we
[
https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131378#comment-13131378
]
Jonathan Gray commented on HBASE-4626:
--
I'm okay with this in 92 but would prefer it
14 matches
Mail list logo
