[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-31 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140825#comment-13140825 ] Hudson commented on HBASE-4641: --- Integrated in HBase-0.92 #90 (See

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-29 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139462#comment-13139462 ] stack commented on HBASE-4641: -- Smile. Seems like two of us are voting for v4 but v1 gets

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138114#comment-13138114 ] Ted Yu commented on HBASE-4641: --- Initially I was thinking of resorting to: {code}

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138118#comment-13138118 ] stack commented on HBASE-4641: -- I'm not sure that will work since the Configuration is shared

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138126#comment-13138126 ] Ted Yu commented on HBASE-4641: --- I think the fact that Configuration object may be shared by

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138634#comment-13138634 ] Ted Yu commented on HBASE-4641: --- Patch v4 uses the approach from comment @ 28/Oct/11 06:38

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138670#comment-13138670 ] stack commented on HBASE-4641: -- +1 on commit Its hacky but until we break apart cache config

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread Jonathan Gray (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138792#comment-13138792 ] Jonathan Gray commented on HBASE-4641: -- I like v4 much less than the other changes.

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138800#comment-13138800 ] Ted Yu commented on HBASE-4641: --- One benefit for patch v4 is that it allows different

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread Jonathan Gray (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138809#comment-13138809 ] Jonathan Gray commented on HBASE-4641: -- Opened HBASE-4697 to deal with real solution.

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-28 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138991#comment-13138991 ] Hudson commented on HBASE-4641: --- Integrated in HBase-TRUNK #2380 (See

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-27 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137622#comment-13137622 ] Ted Yu commented on HBASE-4641: --- I haven't found other code path leading to block cache

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-27 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138041#comment-13138041 ] stack commented on HBASE-4641: -- @Jon Why clone a Configuration down in CreateTableHandler?

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-27 Thread Jonathan Gray (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138053#comment-13138053 ] Jonathan Gray commented on HBASE-4641: -- Stack, that's what I had in v1. I felt like

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-27 Thread Jonathan Gray (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138061#comment-13138061 ] Jonathan Gray commented on HBASE-4641: -- The real fix is for the block cache to be

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-27 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138066#comment-13138066 ] stack commented on HBASE-4641: -- @Jon Sorry. Missed your v1. Yes, its not right either.

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-21 Thread Jonathan Gray (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132854#comment-13132854 ] Jonathan Gray commented on HBASE-4641: -- Thanks Ted. You see any others?

[jira] [Commented] (HBASE-4641) Block cache can be mistakenly instantiated on Master

2011-10-20 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13132303#comment-13132303 ] Ted Yu commented on HBASE-4641: --- For HMaster.finishInitialization(), ROOT region is created.