[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177327#comment-13177327
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177342#comment-13177342
]
Zhihong Yu commented on HBASE-5099:
---
bq. We shouldn't pass 1 here since that means 1
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177351#comment-13177351
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177311#comment-13177311
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177363#comment-13177363
]
Zhihong Yu commented on HBASE-5099:
---
TestMasterZKSessionRecovery is a good name for the
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177369#comment-13177369
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177373#comment-13177373
]
Zhihong Yu commented on HBASE-5099:
---
bq. How about just throw ExecutionException?
That
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177375#comment-13177375
]
Hadoop QA commented on HBASE-5099:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177376#comment-13177376
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177386#comment-13177386
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177394#comment-13177394
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177397#comment-13177397
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177404#comment-13177404
]
Zhihong Yu commented on HBASE-5099:
---
@Jimmy:
Do you mind producing a patch for 0.92 ?
I
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177410#comment-13177410
]
Zhihong Yu commented on HBASE-5099:
---
Will integrate tomorrow morning if I don't get
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177417#comment-13177417
]
Jimmy Xiang commented on HBASE-5099:
@Ted, thanks!
ZK event thread
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177421#comment-13177421
]
Zhihong Yu commented on HBASE-5099:
---
@Jimmy:
Can you put the patch on a real cluster and
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177431#comment-13177431
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177433#comment-13177433
]
Zhihong Yu commented on HBASE-5099:
---
I think executor.shutdown() is appropriate here
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177438#comment-13177438
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177439#comment-13177439
]
Lars Hofhansl commented on HBASE-5099:
--
Sorry I did not state this clearly. I meant
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177441#comment-13177441
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177443#comment-13177443
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177446#comment-13177446
]
Jimmy Xiang commented on HBASE-5099:
There is no harm to call shutdownNow() even if
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177449#comment-13177449
]
Lars Hofhansl commented on HBASE-5099:
--
Yep... That's better.
ZK
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177477#comment-13177477
]
Hadoop QA commented on HBASE-5099:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177487#comment-13177487
]
Hadoop QA commented on HBASE-5099:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177489#comment-13177489
]
Hadoop QA commented on HBASE-5099:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176778#comment-13176778
]
Jimmy Xiang commented on HBASE-5099:
Cool, let me submit a patch.
ZK
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176783#comment-13176783
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176798#comment-13176798
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176826#comment-13176826
]
Hadoop QA commented on HBASE-5099:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176859#comment-13176859
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176867#comment-13176867
]
jirapos...@reviews.apache.org commented on HBASE-5099:
--
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176923#comment-13176923
]
Hadoop QA commented on HBASE-5099:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176406#comment-13176406
]
Zhihong Yu commented on HBASE-5099:
---
bq. Another one is to abort the master
The above
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176430#comment-13176430
]
Jimmy Xiang commented on HBASE-5099:
This is good. If introducing a timeout, I prefer
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176447#comment-13176447
]
Jimmy Xiang commented on HBASE-5099:
tryRecoveringExpiredZKSession() is only called by
[
https://issues.apache.org/jira/browse/HBASE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176454#comment-13176454
]
Zhihong Yu commented on HBASE-5099:
---
Timing out tryRecoveringExpiredZKSession() is good.
38 matches
Mail list logo