[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-22 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213825#comment-13213825 ] Phabricator commented on HBASE-5387: mbautin has committed the revision [jira]

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-21 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213408#comment-13213408 ] Phabricator commented on HBASE-5387: Karthik has commented on the revision [jira]

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-21 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13213409#comment-13213409 ] Phabricator commented on HBASE-5387: Karthik has accepted the revision [jira]

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-16 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209387#comment-13209387 ] ramkrishna.s.vasudevan commented on HBASE-5387: --- We are facing the same

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-15 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209171#comment-13209171 ] Phabricator commented on HBASE-5387: mbautin has committed the revision [jira]

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206758#comment-13206758 ] Mikhail Bautin commented on HBASE-5387: --- Those reported test failures seem

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206916#comment-13206916 ] Zhihong Yu commented on HBASE-5387: --- I ran the following tests with latest patch and

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206985#comment-13206985 ] Lars Hofhansl commented on HBASE-5387: -- +1 Reuse compression

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207018#comment-13207018 ] ramkrishna.s.vasudevan commented on HBASE-5387: --- +1 Reuse

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207108#comment-13207108 ] Zhihong Yu commented on HBASE-5387: --- @Mikhail: Can you integrate the patch so that we

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207111#comment-13207111 ] Mikhail Bautin commented on HBASE-5387: --- @Ted: sure. I was rebasing and running a

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207124#comment-13207124 ] Zhihong Yu commented on HBASE-5387: --- Thanks for being prudent. Reuse

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207252#comment-13207252 ] Zhihong Yu commented on HBASE-5387: --- Looks like patch has been integrated. Please

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206435#comment-13206435 ] Zhihong Yu commented on HBASE-5387: --- The failure of Phabricator attaching patches might

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-12 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206654#comment-13206654 ] Hadoop QA commented on HBASE-5387: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206072#comment-13206072 ] Hadoop QA commented on HBASE-5387: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206150#comment-13206150 ] Zhihong Yu commented on HBASE-5387: --- I looked at https://reviews.facebook.net/D1719 and

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206156#comment-13206156 ] stack commented on HBASE-5387: -- IIRC, the BAOS will keep the outline of the largest

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206157#comment-13206157 ] Zhihong Yu commented on HBASE-5387: --- I went through

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206183#comment-13206183 ] Phabricator commented on HBASE-5387: lhofhansl has commented on the revision [jira]

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206271#comment-13206271 ] stack commented on HBASE-5387: -- @Ted Yeah, I took a look at BAOS. Reset just sets count to

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206273#comment-13206273 ] Zhihong Yu commented on HBASE-5387: --- Something like that. Reuse

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206287#comment-13206287 ] Lars Hofhansl commented on HBASE-5387: -- We could also do something heuristically. Get

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206300#comment-13206300 ] Mikhail Bautin commented on HBASE-5387: --- The BAOS in question only exists during the

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206303#comment-13206303 ] Lars Hofhansl commented on HBASE-5387: -- I see, so it seems that there is nothing to

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206313#comment-13206313 ] Lars Hofhansl commented on HBASE-5387: -- @Mikhail: So we're still creating a new

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206325#comment-13206325 ] Mikhail Bautin commented on HBASE-5387: --- @Lars: where are we creating a new

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206337#comment-13206337 ] Phabricator commented on HBASE-5387: tedyu has commented on the revision [jira]

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Phabricator (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206340#comment-13206340 ] Phabricator commented on HBASE-5387: mbautin has commented on the revision [jira]

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Mikhail Bautin (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206361#comment-13206361 ] Mikhail Bautin commented on HBASE-5387: --- @Ted: thanks for attaching the patch. I

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206009#comment-13206009 ] Zhihong Yu commented on HBASE-5387: --- Looks like TestHFileBlock passes this time.

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206017#comment-13206017 ] Lars Hofhansl commented on HBASE-5387: -- Patch looks good to me. Can you mark the

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206020#comment-13206020 ] Zhihong Yu commented on HBASE-5387: --- I ran TestSplitTransactionOnCluster twice on

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206026#comment-13206026 ] stack commented on HBASE-5387: -- Any reason for hardcoding of 32K for buffer size: +

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206030#comment-13206030 ] Zhihong Yu commented on HBASE-5387: --- w.r.t. the second comment above, I see the

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206040#comment-13206040 ] Zhihong Yu commented on HBASE-5387: --- See