[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258269#comment-13258269 ] Zhihong Yu commented on HBASE-5824: --- Implication of this JIRA is that the type of

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258293#comment-13258293 ] Zhihong Yu commented on HBASE-5824: --- Constraint is in 0.94 This change causes regression

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258297#comment-13258297 ] stack commented on HBASE-5824: -- This patch only makes sense in trunk, not in 0.94. What are

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258313#comment-13258313 ] Zhihong Yu commented on HBASE-5824: --- In 0.94, client only needs to deal with

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258373#comment-13258373 ] Jimmy Xiang commented on HBASE-5824: Yes, this patch is for 0.96 only.

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258377#comment-13258377 ] Zhihong Yu commented on HBASE-5824: --- @Jimmy: Shall we pursue your proposal in a separate

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258381#comment-13258381 ] Jimmy Xiang commented on HBASE-5824: @Ted, I filed HBASE-5845. Thanks for pointing

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258390#comment-13258390 ] Zhihong Yu commented on HBASE-5824: --- I talked with Jimmy offline. We agree that single

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258400#comment-13258400 ] Zhihong Yu commented on HBASE-5824: --- Integrated addendum v2 to trunk.

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258411#comment-13258411 ] Hadoop QA commented on HBASE-5824: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258463#comment-13258463 ] Hudson commented on HBASE-5824: --- Integrated in HBase-TRUNK #2791 (See

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258777#comment-13258777 ] Hudson commented on HBASE-5824: --- Integrated in HBase-TRUNK-security #177 (See

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Elliott Clark (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257848#comment-13257848 ] Elliott Clark commented on HBASE-5824: -- Looking through it everything seems to be

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257849#comment-13257849 ] stack commented on HBASE-5824: -- +1 on the Jimmy patch. @Elliott At least add a deprecate

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257859#comment-13257859 ] Zhihong Yu commented on HBASE-5824: --- {code} +if (autoFlush puts.size() == 1) {

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257865#comment-13257865 ] Jimmy Xiang commented on HBASE-5824: If autoFlush is not enabled, Puts are most likely

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257874#comment-13257874 ] Zhihong Yu commented on HBASE-5824: --- Minor comment: The line below exceeds 100

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257881#comment-13257881 ] Hadoop QA commented on HBASE-5824: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257893#comment-13257893 ] Hadoop QA commented on HBASE-5824: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257904#comment-13257904 ] Jimmy Xiang commented on HBASE-5824: I am looking into it.

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257928#comment-13257928 ] Hudson commented on HBASE-5824: --- Integrated in HBase-TRUNK #2788 (See

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257961#comment-13257961 ] Zhihong Yu commented on HBASE-5824: --- +1 on Addendum. The two tests pass with addendum:

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257963#comment-13257963 ] Zhihong Yu commented on HBASE-5824: --- Integrated addendum to TRUNK. Thanks for the quick

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257965#comment-13257965 ] Hadoop QA commented on HBASE-5824: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257989#comment-13257989 ] Hudson commented on HBASE-5824: --- Integrated in HBase-TRUNK #2790 (See

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-19 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258024#comment-13258024 ] Hudson commented on HBASE-5824: --- Integrated in HBase-TRUNK-security #176 (See

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-18 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257083#comment-13257083 ] Jimmy Xiang commented on HBASE-5824: I will add a unit test for this and fix it.

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-18 Thread Elliott Clark (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257110#comment-13257110 ] Elliott Clark commented on HBASE-5824: -- Thanks. Looks like single puts are also only

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

2012-04-18 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257143#comment-13257143 ] Jimmy Xiang commented on HBASE-5824: I looked into it and it seems not a bug.