[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428569#comment-13428569
]
Lars Hofhansl commented on HBASE-6505:
--
Thanks Andy.
I do have a new patch that uses
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428577#comment-13428577
]
Hadoop QA commented on HBASE-6505:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428642#comment-13428642
]
Andrew Purtell commented on HBASE-6505:
---
bq. If you think that part is overkill and
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428674#comment-13428674
]
Lars Hofhansl commented on HBASE-6505:
--
I'm having a hard time proving in a test that
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428679#comment-13428679
]
Lars Hofhansl commented on HBASE-6505:
--
Argghhh... Forgot that string constants are
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428690#comment-13428690
]
Hadoop QA commented on HBASE-6505:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428697#comment-13428697
]
Zhihong Ted Yu commented on HBASE-6505:
---
Looks good overall.
{code}
+ protected
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428765#comment-13428765
]
Lars Hofhansl commented on HBASE-6505:
--
Thanks Ted. A previous patch had specific
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428767#comment-13428767
]
Lars Hofhansl commented on HBASE-6505:
--
I ran the 3 failed tests from last HadoopQA
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428404#comment-13428404
]
Lars Hofhansl commented on HBASE-6505:
--
Looking for some reviewers :)
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428405#comment-13428405
]
Zhihong Ted Yu commented on HBASE-6505:
---
Since the sharedData map resides per
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428426#comment-13428426
]
Lars Hofhansl commented on HBASE-6505:
--
The sharedData map resides per CP class per
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428443#comment-13428443
]
Hadoop QA commented on HBASE-6505:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428494#comment-13428494
]
Gary Helmling commented on HBASE-6505:
--
minor nit: in
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428529#comment-13428529
]
Andrew Purtell commented on HBASE-6505:
---
+1 looks good Lars.
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428530#comment-13428530
]
Lars Hofhansl commented on HBASE-6505:
--
Thanks Gary and Andy.
Was thinking about
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428550#comment-13428550
]
Lars Hofhansl commented on HBASE-6505:
--
Actually while trying to write a test for
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428554#comment-13428554
]
Andrew Purtell commented on HBASE-6505:
---
Yes that is my fault I Should have thought
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428556#comment-13428556
]
Lars Hofhansl commented on HBASE-6505:
--
NP, and yes a singleton map is better than
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428559#comment-13428559
]
Lars Hofhansl commented on HBASE-6505:
--
Is it safe to key the sharedDataMap with
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428562#comment-13428562
]
Andrew Purtell commented on HBASE-6505:
---
bq. So I should probably key that map with
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13428565#comment-13428565
]
Andrew Purtell commented on HBASE-6505:
---
And maybe we'll not get around to making
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427732#comment-13427732
]
Andrew Purtell commented on HBASE-6505:
---
bq. Generally, what can one do with statics
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427733#comment-13427733
]
Andrew Purtell commented on HBASE-6505:
---
Patch looks good to me but I could only
[
https://issues.apache.org/jira/browse/HBASE-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427734#comment-13427734
]
Lars Hofhansl commented on HBASE-6505:
--
Happy landings :)
In HBASE-6496 you mention
25 matches
Mail list logo
