[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502523#comment-13502523 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #270 (See [https

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502522#comment-13502522 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK #3558 (See [https://builds.apach

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502488#comment-13502488 ] Ted Yu commented on HBASE-6787: --- IncrementCounterProcessorTestProtos.java was missing in the

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502480#comment-13502480 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #269 (See [https

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502476#comment-13502476 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK #3557 (See [https://builds.apach

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502449#comment-13502449 ] Ted Yu commented on HBASE-6787: --- Thanks for clarification, Gary. I will read your comments

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502448#comment-13502448 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Gary Helmling (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502438#comment-13502438 ] Gary Helmling commented on HBASE-6787: -- After completing review, post-facto +1 on 678

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502433#comment-13502433 ] stack commented on HBASE-6787: -- I don't see +1s on the patch yet. I see an encouraging comme

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Gary Helmling (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502424#comment-13502424 ] Gary Helmling commented on HBASE-6787: -- Did anyone +1 this patch yet? The -6 version

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502409#comment-13502409 ] Ted Yu commented on HBASE-6787: --- Integrated to trunk. Thanks for the patch, Devaraj. Thank

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502402#comment-13502402 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-21 Thread Gary Helmling (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502218#comment-13502218 ] Gary Helmling commented on HBASE-6787: -- Since HBASE-7185 went in (moving .proto files

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-18 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499983#comment-13499983 ] Devaraj Das commented on HBASE-6787: Test TestRegionServerCoprocessorExceptionWithAbor

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499981#comment-13499981 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-18 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499857#comment-13499857 ] Devaraj Das commented on HBASE-6787: bq. Yeah.. that's true. Should we move this work

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499653#comment-13499653 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499541#comment-13499541 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-17 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499537#comment-13499537 ] Devaraj Das commented on HBASE-6787: Thanks, Ted for catching that assert (I had forgo

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499535#comment-13499535 ] Ted Yu commented on HBASE-6787: --- nit: on review board, I can see a few white spaces. {code}

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499520#comment-13499520 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497619#comment-13497619 ] stack commented on HBASE-6787: -- +1 for enforcing PB going forward especially if it means can

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-14 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497562#comment-13497562 ] Devaraj Das commented on HBASE-6787: bq. between this and the ColumnInterpreter stuff

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-11-13 Thread Gary Helmling (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496394#comment-13496394 ] Gary Helmling commented on HBASE-6787: -- Sorry for the delay in the review. Overall t

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-10-22 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481469#comment-13481469 ] Devaraj Das commented on HBASE-6787: Did my response to the questions make sense, [~st

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-10-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480555#comment-13480555 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-10-19 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480261#comment-13480261 ] Devaraj Das commented on HBASE-6787: bq. This ability to add arbitrary bytes? If so, d

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-10-19 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480219#comment-13480219 ] Devaraj Das commented on HBASE-6787: Thanks for taking a look, [~stack]. The overall

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-10-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479645#comment-13479645 ] stack commented on HBASE-6787: -- Thanks for doing this DD. Looking at this: {code} -if (

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-10-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479591#comment-13479591 ] Hadoop QA commented on HBASE-6787: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service

2012-10-18 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479541#comment-13479541 ] Devaraj Das commented on HBASE-6787: BTW I fixed some minor things here that I noticed