[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506586#comment-13506586 ] Hadoop QA commented on HBASE-7215: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-29 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506662#comment-13506662 ] stack commented on HBASE-7215: -- I'm running hadoopqa manually. Rerunning again after the

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506704#comment-13506704 ] Hadoop QA commented on HBASE-7215: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506720#comment-13506720 ] Lars Hofhansl commented on HBASE-7215: -- That looks pretty good! Should probably still

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-29 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506721#comment-13506721 ] stack commented on HBASE-7215: -- +1 on commit Put, Delete, Increment, and

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-29 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506733#comment-13506733 ] stack commented on HBASE-7215: -- Make new issues for the two probs above?

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-29 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506739#comment-13506739 ] Lars Hofhansl commented on HBASE-7215: -- Filed two sub tasks. OK will commit in the

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505299#comment-13505299 ] Hadoop QA commented on HBASE-7215: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505815#comment-13505815 ] stack commented on HBASE-7215: -- The changes in

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-28 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506055#comment-13506055 ] Lars Hofhansl commented on HBASE-7215: -- HadoopQA is on holiday it seems.

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506196#comment-13506196 ] stack commented on HBASE-7215: -- These failed on me: {code} Results : Failed tests:

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506245#comment-13506245 ] stack commented on HBASE-7215: -- Ugh. These tests fail w/o this patch. These are the only

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506246#comment-13506246 ] stack commented on HBASE-7215: -- I spent time looking at the failure. For

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504750#comment-13504750 ] stack commented on HBASE-7215: -- [~lhofhansl] We can't release 0.96 till all Writables are

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504817#comment-13504817 ] stack commented on HBASE-7215: -- I started to review but it is going to take a while and it

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Gregory Chanan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504866#comment-13504866 ] Gregory Chanan commented on HBASE-7215: --- I think your rant is justified, no need to

Re: [jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Gary Helmling
For coprocessor endpoints, we have https://issues.apache.org/jira/browse/HBASE-6895 as an umbrella issue for removing the Writable based CoprocessorProtocol support. There are still a few subtasks to work through to get there, but once done we can pull out CoprocessorProtocol, Exec, ExecResult,

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Gary Helmling (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504879#comment-13504879 ] Gary Helmling commented on HBASE-7215: -- For coprocessor endpoints, we have

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504888#comment-13504888 ] Andrew Purtell commented on HBASE-7215: --- bq. I will only believe that we protobuf'ed

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504928#comment-13504928 ] stack commented on HBASE-7215: -- I have a few test failures when I run the patch. Let me try

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504967#comment-13504967 ] Lars Hofhansl commented on HBASE-7215: -- [~gchanan] Yep, need to remove the

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504998#comment-13504998 ] stack commented on HBASE-7215: -- [~lhofhansl] I'm on it Put, Delete,

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504999#comment-13504999 ] stack commented on HBASE-7215: -- [~lhofhansl] Currently trying to figure out how to make MR

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505042#comment-13505042 ] Lars Hofhansl commented on HBASE-7215: -- bq. next used to overwrite the Result you

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505043#comment-13505043 ] Lars Hofhansl commented on HBASE-7215: -- Do you have a list of failing tests, maybe we

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505059#comment-13505059 ] stack commented on HBASE-7215: -- [~lhofhansl] I see that now. Its ugly but works (smile)

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505078#comment-13505078 ] Hadoop QA commented on HBASE-7215: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505102#comment-13505102 ] Hadoop QA commented on HBASE-7215: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505122#comment-13505122 ] Lars Hofhansl commented on HBASE-7215: -- Did you forget to include MutableResult? :)

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505124#comment-13505124 ] Lars Hofhansl commented on HBASE-7215: -- Let's do that instead (MutableResult)

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505126#comment-13505126 ] Lars Hofhansl commented on HBASE-7215: -- All the M/R tests fail... I'll have a look at

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505134#comment-13505134 ] stack commented on HBASE-7215: -- I'll redo the patch w/ MutableResult included. Will also

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505143#comment-13505143 ] Hadoop QA commented on HBASE-7215: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505147#comment-13505147 ] Lars Hofhansl commented on HBASE-7215: -- I see. Result.kvs could have never been null

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505192#comment-13505192 ] Lars Hofhansl commented on HBASE-7215: -- The M/R tests fail because: # for mapred I

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505196#comment-13505196 ] Lars Hofhansl commented on HBASE-7215: -- Or more to the point. In order to support

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505264#comment-13505264 ] stack commented on HBASE-7215: -- I changed my mind about MutateResult. We are already going

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-27 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505269#comment-13505269 ] Lars Hofhansl commented on HBASE-7215: -- I have found the problem with M/R. protobuf's

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504023#comment-13504023 ] Lars Hofhansl commented on HBASE-7215: -- How about I make a patch with that, and then

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504025#comment-13504025 ] stack commented on HBASE-7215: -- I thought the MR requirement that we do Writables was undone

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504128#comment-13504128 ] stack commented on HBASE-7215: -- In hadoop, there is a

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504157#comment-13504157 ] Lars Hofhansl commented on HBASE-7215: -- I see, cool. Makes we want to delete my

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504387#comment-13504387 ] Lars Hofhansl commented on HBASE-7215: -- TestFromClientSide passed without the changes

[jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result still implement Writable

2012-11-26 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13504431#comment-13504431 ] Lars Hofhansl commented on HBASE-7215: -- Tracked it down anyway. In