[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593163#comment-13593163
]
Hudson commented on HBASE-7814:
---
Integrated in HBase-0.94-security-on-Hadoop-23 #12 (See
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577794#comment-13577794
]
Gary Helmling commented on HBASE-7814:
--
bq. IS_SECURE_HADOOP is set only when we can
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576844#comment-13576844
]
Jonathan Hsieh commented on HBASE-7814:
---
So this requires means this won't compile
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576850#comment-13576850
]
Ted Yu commented on HBASE-7814:
---
I followed the same style in existing code:
{code}
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576855#comment-13576855
]
Sergey Shelukhin commented on HBASE-7814:
-
Why not invoke the method via
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576864#comment-13576864
]
Ted Yu commented on HBASE-7814:
---
Patch v3 invokes the method from Method object obtained
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576871#comment-13576871
]
Jonathan Hsieh commented on HBASE-7814:
---
I agree with Sergey. The v3 invoke is
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576887#comment-13576887
]
Jonathan Hsieh commented on HBASE-7814:
---
lgtm. ideally this is tested before commit
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576910#comment-13576910
]
Ted Yu commented on HBASE-7814:
---
I looked through 0.92 pom.xml and found no profile for
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577044#comment-13577044
]
Lars Hofhansl commented on HBASE-7814:
--
+1
(Test with older version would be nice,
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577053#comment-13577053
]
Ted Yu commented on HBASE-7814:
---
Integrated to 0.94
Thanks for the reviews, Jon, Sergey and
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577137#comment-13577137
]
Hudson commented on HBASE-7814:
---
Integrated in HBase-0.94 #840 (See
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577166#comment-13577166
]
Hudson commented on HBASE-7814:
---
Integrated in HBase-0.94-security #110 (See
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577202#comment-13577202
]
Enis Soztutar commented on HBASE-7814:
--
Sorry to come in late, but doesn't
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577206#comment-13577206
]
Ted Yu commented on HBASE-7814:
---
I checked src/core/org/apache/hadoop/security/User.java
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577208#comment-13577208
]
Lars Hofhansl commented on HBASE-7814:
--
Oh. Good call, [~enis-2].
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577209#comment-13577209
]
Lars Hofhansl commented on HBASE-7814:
--
Well... Only that that call would fail with
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577226#comment-13577226
]
Enis Soztutar commented on HBASE-7814:
--
Why do you think it will fail with exception.
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577228#comment-13577228
]
Lars Hofhansl commented on HBASE-7814:
--
This will fail if getShortUserName does not
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577258#comment-13577258
]
Enis Soztutar commented on HBASE-7814:
--
bq. This will fail if getShortUserName does
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576073#comment-13576073
]
Hadoop QA commented on HBASE-7814:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576107#comment-13576107
]
Jimmy Xiang commented on HBASE-7814:
+1
Port HBASE-6963 'unable to
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576183#comment-13576183
]
Hudson commented on HBASE-7814:
---
Integrated in HBase-0.94 #836 (See
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576232#comment-13576232
]
Jonathan Hsieh commented on HBASE-7814:
---
There was a concern on the original
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576250#comment-13576250
]
Jean-Marc Spaggiari commented on HBASE-7814:
My opinion: I don't think such
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576253#comment-13576253
]
Lars Hofhansl commented on HBASE-7814:
--
I agree... I'll revert the patch. This is
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576255#comment-13576255
]
Jimmy Xiang commented on HBASE-7814:
Oh, I remember now why it is not checked in 0.94
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576292#comment-13576292
]
Lars Hofhansl commented on HBASE-7814:
--
Being able to run hbck on secure cluster
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576294#comment-13576294
]
Ted Yu commented on HBASE-7814:
---
I agree.
We can use reflection to detect whether the new
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576303#comment-13576303
]
Lars Hofhansl commented on HBASE-7814:
--
OK... Reopened for 0.94.6 to think about it.
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576307#comment-13576307
]
Hudson commented on HBASE-7814:
---
Integrated in HBase-0.94 #837 (See
[
https://issues.apache.org/jira/browse/HBASE-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576312#comment-13576312
]
Jonathan Hsieh commented on HBASE-7814:
---
I'm fine if this is done in a compatible
32 matches
Mail list logo
