[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607324#comment-13607324
]
Anoop Sam John commented on HBASE-8151:
---
+1 for doing #2.
We can check the
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607337#comment-13607337
]
Hadoop QA commented on HBASE-8151:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607342#comment-13607342
]
ramkrishna.s.vasudevan commented on HBASE-8151:
---
+1 on patch.
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607921#comment-13607921
]
Lars Hofhansl commented on HBASE-8151:
--
[~anoopsamjohn] Comparing against the
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608270#comment-13608270
]
Hadoop QA commented on HBASE-8151:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608620#comment-13608620
]
Lars Hofhansl commented on HBASE-8151:
--
Thanks Ted.
What do folks think? It's hard to
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608621#comment-13608621
]
Lars Hofhansl commented on HBASE-8151:
--
I could do #1 here and # in a separate jira.
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608652#comment-13608652
]
stack commented on HBASE-8151:
--
#2 in new issue makes sense to me (I have a small mind)
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608676#comment-13608676
]
Lars Hofhansl commented on HBASE-8151:
--
[~stack] Just saw your comment now. Let me do
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608677#comment-13608677
]
Lars Hofhansl commented on HBASE-8151:
--
Unless there are objections I will commit the
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607257#comment-13607257
]
stack commented on HBASE-8151:
--
+1 on simple patch
Small optimization in
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607270#comment-13607270
]
Ted Yu commented on HBASE-8151:
---
Toward the end of patch:
{code}
+ } else {
+
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607279#comment-13607279
]
Lars Hofhansl commented on HBASE-8151:
--
No, since it defaults to 0 and it is never
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607281#comment-13607281
]
Lars Hofhansl commented on HBASE-8151:
--
Do you guys think it is worth doing #2 above?
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607284#comment-13607284
]
stack commented on HBASE-8151:
--
Sure if we can save the decoding too.
How would it work?
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607289#comment-13607289
]
Lars Hofhansl commented on HBASE-8151:
--
[~stack] Upon compaction we'd check all the
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607294#comment-13607294
]
stack commented on HBASE-8151:
--
[~lhofhansl] v1 is gone in trunk (smile). Call it
[
https://issues.apache.org/jira/browse/HBASE-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607300#comment-13607300
]
Lars Hofhansl commented on HBASE-8151:
--
I mean Do not even write the memstoreTS to
18 matches
Mail list logo
