[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-11-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816414#comment-13816414 ] Ted Yu commented on HBASE-9295: --- Integrated to trunk. Thanks for the review, Jesse. Allow

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-11-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816879#comment-13816879 ] Hudson commented on HBASE-9295: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #831

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-11-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816904#comment-13816904 ] Hudson commented on HBASE-9295: --- SUCCESS: Integrated in HBase-TRUNK #4672 (See

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-31 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810421#comment-13810421 ] Jesse Yates commented on HBASE-9295: +1 Allow test-patch.sh to detect TreeMap keyed

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809790#comment-13809790 ] Ted Yu commented on HBASE-9295: --- Can I interpret the above as +1 ? Allow test-patch.sh to

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-21 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800917#comment-13800917 ] Jesse Yates commented on HBASE-9295: I think that we can make it a little bit more

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-10-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799968#comment-13799968 ] Ted Yu commented on HBASE-9295: --- Since the detection is based on scanning a single line,

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-09-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769689#comment-13769689 ] Ted Yu commented on HBASE-9295: --- Here is sample output where the tested patch omits

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-09-17 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769736#comment-13769736 ] Jesse Yates commented on HBASE-9295: I was thinking that each anti-pattern would

[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

2013-09-17 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769713#comment-13769713 ] Jesse Yates commented on HBASE-9295: Would be nice if each anti-patter came with a