[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455492#comment-16455492
]
Andrew Purtell commented on HBASE-9465:
---
Ok, I filed HBASE-20496
> Push entries to peer clusters
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453226#comment-16453226
]
Duo Zhang commented on HBASE-9465:
--
Let’s open a new issue to address it if the addendum is not a one
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453222#comment-16453222
]
Andrew Purtell commented on HBASE-9465:
---
Not sure why we didn't catch it earlier, but with the
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245092#comment-16245092
]
Hudson commented on HBASE-9465:
---
FAILURE: Integrated in Jenkins build HBase-1.4 #1005 (See
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244790#comment-16244790
]
Andrew Purtell commented on HBASE-9465:
---
Tests look good, no failures after multiple runs. I'm just
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244753#comment-16244753
]
Sean Busbey commented on HBASE-9465:
bq. Running replication tests. Will commit if it looks good.
If
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244750#comment-16244750
]
Sean Busbey commented on HBASE-9465:
ooof precommit is failing on compiling a file that's deleted by
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244738#comment-16244738
]
Sean Busbey commented on HBASE-9465:
thanks Andrew. wow, precommit was super unhappy with me.
> Push
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1621#comment-1621
]
Andrew Purtell commented on HBASE-9465:
---
Applied with {{git am -s}}, produces two signed off revert
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1620#comment-1620
]
Andrew Purtell commented on HBASE-9465:
---
Looking at the revert patch now.
> Push entries to peer
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243563#comment-16243563
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243233#comment-16243233
]
Duo Zhang commented on HBASE-9465:
--
I'm OK with pull it out from 1.4 even branch-1. But for 2.0 we'd like
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242847#comment-16242847
]
Andrew Purtell commented on HBASE-9465:
---
If you need help let me know.
> Push entries to peer
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242837#comment-16242837
]
Andrew Purtell commented on HBASE-9465:
---
No objections [~busbey], please pull from branch-1.4 today.
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785936#comment-15785936
]
stack commented on HBASE-9465:
--
bq. For compatibility I didn't want to change this column so I create a new
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784611#comment-15784611
]
Phil Yang commented on HBASE-9465:
--
Thanks [~stack] for your comment.
bq. The latter keeps only the
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784438#comment-15784438
]
Phil Yang commented on HBASE-9465:
--
Sorry for missing this comment, sounds reasonable, I'll check it and
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783447#comment-15783447
]
stack commented on HBASE-9465:
--
[~yangzhe1991] You see above by [~vincentpoon]?
The design doc is great. I
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530835#comment-15530835
]
Vincent Poon commented on HBASE-9465:
-
I think you need the code addition above 'continue" here - if
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413430#comment-15413430
]
Hudson commented on HBASE-9465:
---
FAILURE: Integrated in HBase-1.4 #344 (See
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413298#comment-15413298
]
Hudson commented on HBASE-9465:
---
FAILURE: Integrated in HBase-Trunk_matrix #1383 (See
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413131#comment-15413131
]
Phil Yang commented on HBASE-9465:
--
Thanks all for reviewing.
> Push entries to peer clusters serially
>
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413025#comment-15413025
]
Duo Zhang commented on HBASE-9465:
--
The findbugs warnings and failed UTs are unrelated.
Will commit
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412858#comment-15412858
]
Phil Yang commented on HBASE-9465:
--
Can not seen the failure message in Test Results, and it can pass
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412855#comment-15412855
]
Phil Yang commented on HBASE-9465:
--
Seems this result is tests of master, but the output is not
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411814#comment-15411814
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411796#comment-15411796
]
Duo Zhang commented on HBASE-9465:
--
Is TestReplicationSourceManager related?
> Push entries to peer
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411778#comment-15411778
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411516#comment-15411516
]
Duo Zhang commented on HBASE-9465:
--
[~yangzhe1991] Can you please upload a rebased patch? Thanks.
> Push
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411513#comment-15411513
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411369#comment-15411369
]
Duo Zhang commented on HBASE-9465:
--
Good. Thanks for reviewing.
Will commit shortly.
> Push entries to
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411354#comment-15411354
]
Ashish Singhi commented on HBASE-9465:
--
No.
> Push entries to peer clusters serially
>
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411348#comment-15411348
]
Ashish Singhi commented on HBASE-9465:
--
OK.
> Push entries to peer clusters serially
>
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411314#comment-15411314
]
Duo Zhang commented on HBASE-9465:
--
[~ashish singhi] Any other concerns?
Thanks,
> Push entries to peer
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409501#comment-15409501
]
Phil Yang commented on HBASE-9465:
--
I think TestSerialReplication already tests this scenario by
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409363#comment-15409363
]
Ashish Singhi commented on HBASE-9465:
--
Can you try to add test case for the mentioned scenario in
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409358#comment-15409358
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407292#comment-15407292
]
Ashish Singhi commented on HBASE-9465:
--
Added review comments on the RB.
Is it possible to add a test
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407239#comment-15407239
]
Ashish Singhi commented on HBASE-9465:
--
OK. Thanks.
> Push entries to peer clusters serially
>
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407234#comment-15407234
]
Phil Yang commented on HBASE-9465:
--
There are two new families whose row keys are both
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407222#comment-15407222
]
Ashish Singhi commented on HBASE-9465:
--
Hi [~yangzhe1991],
Sorry to come in late. I was on travel to
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407211#comment-15407211
]
Duo Zhang commented on HBASE-9465:
--
For master, I do not think we need to run findbugs on the files
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407190#comment-15407190
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407168#comment-15407168
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405828#comment-15405828
]
Phil Yang commented on HBASE-9465:
--
Will upload rebased patch tomorrow
> Push entries to peer clusters
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405815#comment-15405815
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405794#comment-15405794
]
Phil Yang commented on HBASE-9465:
--
This feature relies on zk-less assignment, and conflicts with
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405673#comment-15405673
]
Phil Yang commented on HBASE-9465:
--
Branch-1 is different from master, will upload patch for branch-1
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405176#comment-15405176
]
Duo Zhang commented on HBASE-9465:
--
Fine...
Will commit this evening if no objections.
Thanks.
> Push
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403507#comment-15403507
]
Duo Zhang commented on HBASE-9465:
--
Also +1 on v3.
[~stack] [~lhofhansl] [~enis] Any concerns?
Thanks.
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401819#comment-15401819
]
Ted Yu commented on HBASE-9465:
---
+1 on v3.
> Push entries to peer clusters serially
>
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399018#comment-15399018
]
Ted Yu commented on HBASE-9465:
---
That should be fine.
We can keep the current logic.
> Push entries to peer
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398898#comment-15398898
]
Phil Yang commented on HBASE-9465:
--
Read HBASE-15156 , I have no idea when it will be committed to master
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398810#comment-15398810
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397670#comment-15397670
]
Ted Yu commented on HBASE-9465:
---
Mind attaching patch v3 for QA run ?
Thanks
> Push entries to peer
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397397#comment-15397397
]
Ted Yu commented on HBASE-9465:
---
Here is the issue for assigning daughter region:
HBASE-15156
> Push
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397333#comment-15397333
]
Phil Yang commented on HBASE-9465:
--
I have not noticed the on-going work, may I know the issue number? If
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396689#comment-15396689
]
Ted Yu commented on HBASE-9465:
---
bq. region spliting and merging. However, three related regions must be in
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393481#comment-15393481
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391364#comment-15391364
]
Phil Yang commented on HBASE-9465:
--
HBASE-16281
> Push entries to peer clusters serially
>
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391287#comment-15391287
]
Duo Zhang commented on HBASE-9465:
--
I think we should open a new issue to revisit this testcase. We need
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391278#comment-15391278
]
Phil Yang commented on HBASE-9465:
--
Failing message is "Waited too much time for replication" because of
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390549#comment-15390549
]
Duo Zhang commented on HBASE-9465:
--
Is the failed UT related?
> Push entries to peer clusters serially
>
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383945#comment-15383945
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383853#comment-15383853
]
Hadoop QA commented on HBASE-9465:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383728#comment-15383728
]
Phil Yang commented on HBASE-9465:
--
Upload v2 to rb https://reviews.apache.org/r/50183/
Any comments are
66 matches
Mail list logo