[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321306#comment-14321306
]
Ashish Singhi commented on HBASE-9531:
--
Thanks Andrew.
a command line (hbase
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321086#comment-14321086
]
Hudson commented on HBASE-9531:
---
FAILURE: Integrated in HBase-0.98 #852 (See
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321212#comment-14321212
]
Hudson commented on HBASE-9531:
---
SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #811 (See
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318827#comment-14318827
]
Andrew Purtell commented on HBASE-9531:
---
The V3 patch looks good. I'm going to apply
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317956#comment-14317956
]
Ashish Singhi commented on HBASE-9531:
--
Addressed the test case failure. Interface
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319378#comment-14319378
]
Hudson commented on HBASE-9531:
---
FAILURE: Integrated in HBase-1.0 #734 (See
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319369#comment-14319369
]
Hudson commented on HBASE-9531:
---
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #808 (See
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319401#comment-14319401
]
Hudson commented on HBASE-9531:
---
FAILURE: Integrated in HBase-TRUNK #6125 (See
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319280#comment-14319280
]
Hudson commented on HBASE-9531:
---
FAILURE: Integrated in HBase-1.1 #173 (See
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319278#comment-14319278
]
Demai Ni commented on HBASE-9531:
-
[~ashish singhi], Thank you so much for picking it up
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317893#comment-14317893
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317823#comment-14317823
]
Ashish Singhi commented on HBASE-9531:
--
Thanks [~andrew.purt...@gmail.com] for the
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319494#comment-14319494
]
Hudson commented on HBASE-9531:
---
SUCCESS: Integrated in HBase-0.98 #850 (See
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318183#comment-14318183
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318201#comment-14318201
]
Ashish Singhi commented on HBASE-9531:
--
V3 patch addressing checkstyle errors.
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318418#comment-14318418
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316564#comment-14316564
]
Andrew Purtell commented on HBASE-9531:
---
Another minor issue is the patch proposed
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316557#comment-14316557
]
Andrew Purtell commented on HBASE-9531:
---
Thanks for stepping up [~ashish singhi].
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14315894#comment-14315894
]
Ashish Singhi commented on HBASE-9531:
--
After having a offline chat with [~nidmhbase]
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14315956#comment-14315956
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203086#comment-14203086
]
Andrew Purtell commented on HBASE-9531:
---
The other day I wish I had this. Will bring
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155131#comment-14155131
]
Andrew Purtell commented on HBASE-9531:
---
Want to take a look at this for an upcoming
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122376#comment-14122376
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094323#comment-14094323
]
Demai Ni commented on HBASE-9531:
-
again, the '-1 lineLengths' are for the generated
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093772#comment-14093772
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080992#comment-14080992
]
Demai Ni commented on HBASE-9531:
-
bq. -1 lineLengths. The patch introduces the following
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081367#comment-14081367
]
Andrew Purtell commented on HBASE-9531:
---
Strings in previous patches have been
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081485#comment-14081485
]
Demai Ni commented on HBASE-9531:
-
[~apurtell]
so we shouldn't expose protobuf objects to
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081486#comment-14081486
]
Andrew Purtell commented on HBASE-9531:
---
Right, create local classes
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081731#comment-14081731
]
Demai Ni commented on HBASE-9531:
-
[~apurtell], thanks for the tip. I will be out of town
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081740#comment-14081740
]
Andrew Purtell commented on HBASE-9531:
---
Thanks [~nidmhbase], ok.
a command line
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080450#comment-14080450
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073432#comment-14073432
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073454#comment-14073454
]
Demai Ni commented on HBASE-9531:
-
the failure
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073559#comment-14073559
]
Andrew Purtell commented on HBASE-9531:
---
Ok, I'm going to commit this to 0.98+ in a
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073769#comment-14073769
]
Enis Soztutar commented on HBASE-9531:
--
This looks ok for branch-1. However, I would
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073785#comment-14073785
]
Andrew Purtell commented on HBASE-9531:
---
bq. Should we not carry the metrics as
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073817#comment-14073817
]
Demai Ni commented on HBASE-9531:
-
[~enis], good point. I will provide a revised patch
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070490#comment-14070490
]
Andrew Purtell commented on HBASE-9531:
---
The findbugs and test failure seem
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050360#comment-14050360
]
stack commented on HBASE-9531:
--
Not you [~nidmhbase] Hadooqa was broke for a few days. I
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050487#comment-14050487
]
Demai Ni commented on HBASE-9531:
-
[~stack], thanks a lot demai
a command line
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050589#comment-14050589
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050649#comment-14050649
]
Demai Ni commented on HBASE-9531:
-
three issues from the hadoopQA report:
* -1
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049475#comment-14049475
]
Demai Ni commented on HBASE-9531:
-
strange that the patch submitted a few days ago didn't
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046562#comment-14046562
]
Demai Ni commented on HBASE-9531:
-
[~apurtell],
can you please take a look at the new
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044138#comment-14044138
]
Andrew Purtell commented on HBASE-9531:
---
bq. The code in admin.rb will only check
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042936#comment-14042936
]
Andrew Purtell commented on HBASE-9531:
---
This looks plausible to me and I like the
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14043004#comment-14043004
]
Demai Ni commented on HBASE-9531:
-
[~apurtell],
thanks for the review and comments.
bq.
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009979#comment-14009979
]
Hadoop QA commented on HBASE-9531:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010064#comment-14010064
]
Demai Ni commented on HBASE-9531:
-
'The patch introduces the following lines longer than
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010084#comment-14010084
]
Demai Ni commented on HBASE-9531:
-
about the release audit warning(31 of them), this file
[
https://issues.apache.org/jira/browse/HBASE-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010262#comment-14010262
]
Demai Ni commented on HBASE-9531:
-
[~jdcryans], may I know your takes about this feature?
52 matches
Mail list logo