[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-17 Thread Aditya Kishore (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798851#comment-13798851 ] Aditya Kishore commented on HBASE-9737: --- I looked at the callers of the function dow

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-17 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798817#comment-13798817 ] Lars Hofhansl commented on HBASE-9737: -- The behavior is slightly different now, right

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-17 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798670#comment-13798670 ] Lars Hofhansl commented on HBASE-9737: -- Yes please. > Resource leak if a corrupt HFi

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-17 Thread Aditya Kishore (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798518#comment-13798518 ] Aditya Kishore commented on HBASE-9737: --- [~lhofhansl] Would you like to pull this in

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791027#comment-13791027 ] Hadoop QA commented on HBASE-9737: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791020#comment-13791020 ] Hadoop QA commented on HBASE-9737: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790976#comment-13790976 ] Lars Hofhansl commented on HBASE-9737: -- Oops. Didn't see that Elliot suggested the sa

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790975#comment-13790975 ] Lars Hofhansl commented on HBASE-9737: -- Good catch! I agree this is critical. We do n

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Aditya Kishore (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790964#comment-13790964 ] Aditya Kishore commented on HBASE-9737: --- That make much more sense, thanks Elliott.

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790961#comment-13790961 ] Elliott Clark commented on HBASE-9737: -- Why not just move the close (wrapped in its o

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Aditya Kishore (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790934#comment-13790934 ] Aditya Kishore commented on HBASE-9737: --- Submitting patch for trunk to Hadoop QA. >

[jira] [Commented] (HBASE-9737) Resource leak if a corrupt HFile presents itself in a region leading to Region Server OOM

2013-10-09 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790907#comment-13790907 ] Ted Yu commented on HBASE-9737: --- Patch looks good overall. {code} + if (errorWhileOpeni