[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-24 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804998#comment-13804998 ] Lars Hofhansl commented on HBASE-9807: -- Nope. Does not fail with the patch. Also saw

[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-22 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802413#comment-13802413 ] stack commented on HBASE-9807: -- lgtm The test failure yours? scanning with block encoding

[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802468#comment-13802468 ] Lars Hofhansl commented on HBASE-9807: -- Yeah. Looks suspicious, will have a look.

[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800091#comment-13800091 ] Lars Hofhansl commented on HBASE-9807: -- This is just the default implementation,

[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800270#comment-13800270 ] Lars Hofhansl commented on HBASE-9807: -- [~mcorgan], wanna have a look? Can you think

[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800287#comment-13800287 ] Hadoop QA commented on HBASE-9807: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-19 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800077#comment-13800077 ] Lars Hofhansl commented on HBASE-9807: -- Should be a boon for Phoenix, which typically

[jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek

2013-10-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800083#comment-13800083 ] stack commented on HBASE-9807: -- You have this still + ByteBuffer bb = getKey(); +