[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836703#comment-13836703 ] takeshi.miao commented on HBASE-9992: - @Jonathan Tks for your patch, I also learned fr

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830821#comment-13830821 ] Hudson commented on HBASE-9992: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #849 (Se

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830812#comment-13830812 ] Hudson commented on HBASE-9992: --- SUCCESS: Integrated in hbase-0.96-hadoop2 #129 (See [https

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830785#comment-13830785 ] Hudson commented on HBASE-9992: --- SUCCESS: Integrated in HBase-TRUNK #4694 (See [https://bui

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830782#comment-13830782 ] Hudson commented on HBASE-9992: --- SUCCESS: Integrated in hbase-0.96 #201 (See [https://build

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828236#comment-13828236 ] Nick Dimiduk commented on HBASE-9992: - +1 > [hbck] Refactor so that arbitrary -D cmdl

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828203#comment-13828203 ] Jonathan Hsieh commented on HBASE-9992: --- Ok, tested against the hbasefsck.erroreport

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827938#comment-13827938 ] Nick Dimiduk commented on HBASE-9992: - I take it all back. I thought there was a way t

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827885#comment-13827885 ] Jonathan Hsieh commented on HBASE-9992: --- So you means having HBaseFsck class extend

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826936#comment-13826936 ] Nick Dimiduk commented on HBASE-9992: - Sure -- the class itself would extend Tool. >

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826929#comment-13826929 ] Jonathan Hsieh commented on HBASE-9992: --- Hm.. this is directly extending Tool, just

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826818#comment-13826818 ] Nick Dimiduk commented on HBASE-9992: - Hacky in that it does not follow the pattern of

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826766#comment-13826766 ] Jonathan Hsieh commented on HBASE-9992: --- I don't see how this is hacky -- can you ex

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826715#comment-13826715 ] Nick Dimiduk commented on HBASE-9992: - So the wrapper class is to avoid changing tests

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826534#comment-13826534 ] Hadoop QA commented on HBASE-9992: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825929#comment-13825929 ] Jonathan Hsieh commented on HBASE-9992: --- I was thinking something much more localize

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825773#comment-13825773 ] Elliott Clark commented on HBASE-9992: -- AbstractHBaseTool ? > [hbck] Refactor so tha

[jira] [Commented] (HBASE-9992) [hbck] Refactor so that arbitrary -D cmdline options are included

[ https://issues.apache.org/jira/browse/HBASE-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825754#comment-13825754 ] Nick Dimiduk commented on HBASE-9992: - Sounds like good cleanup. > [hbck] Refactor so