Jean-Marc Spaggiari created HBASE-10540: -------------------------------------------
Summary: HBaseAdmin.createTable(HTableDescriptor, splitKeys) doesn't need to call isLegalTableName. Key: HBASE-10540 URL: https://issues.apache.org/jira/browse/HBASE-10540 Project: HBase Issue Type: Bug Affects Versions: 0.94.16 Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor {code} public void createTable(final HTableDescriptor desc, byte [][] splitKeys) throws IOException { HTableDescriptor.isLegalTableName(desc.getName()); try { createTableAsync(desc, splitKeys); } catch (SocketTimeoutException ste) { LOG.warn("Creating " + desc.getNameAsString() + " took too long", ste); } {code} crateTable calls isLegalTableName and few lines after, createTableAsync. However, createTableAsync also calls isLegalTableName which results to a double call. Therefor, we can remove the call to isLegalTableName from crateTable. Trunk does'nt call isLegalTableName (Should it?). Nor is 0.96. -- This message was sent by Atlassian JIRA (v6.1.5#6160)