David Mollitor created HBASE-25936: -------------------------------------- Summary: Improve Logging Statement Formatting Key: HBASE-25936 URL: https://issues.apache.org/jira/browse/HBASE-25936 Project: HBase Issue Type: Improvement Reporter: David Mollitor Assignee: David Mollitor
I reviewed most of the TRACE/DEBUG log statements and wanted to clean up the first tier issues: * Use logging anchors {{{}}} where previously was concatenating (without logging guard) * Remove String.format and use logging anchors {{{}}} * Remove logging guards around statements which use anchors (kind of defeats the purpose of anchors) * Remove logging guards around log statements which have no parameters (not concatenation) * Remove explicit calls to toString() that defeat the purpose of anchors * Remove Objects.toString() - logging framework will handle {{null}} values * Remove StringUtils ExceptionStackTrace logging - logging framework will handle pretty-print of Exception messages and stack traces * Remove logging guards around INFO messages. They will just about always be printed in production systems, no need to try to protect them from happening The goal here is, maybe a tiny bump in performance, but to reduce the size of the code and to make logging statement more clear to developers. -- This message was sent by Atlassian Jira (v8.3.4#803005)