Use builder pattern in StoreFile, HFile, and HColumnDescriptor instantiation
----------------------------------------------------------------------------

                 Key: HBASE-5357
                 URL: https://issues.apache.org/jira/browse/HBASE-5357
             Project: HBase
          Issue Type: Improvement
            Reporter: Mikhail Bautin
            Assignee: Mikhail Bautin


We have five ways to create an HFile writer, two ways to create a StoreFile 
writer, and the sets of parameters keep changing, creating a lot of confusion, 
especially when porting patches across branches. The same thing is happening to 
HColumnDescriptor. I think we should move to a "builder pattern" solution, e.g.

{code:java}
  HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
      .setParameter1(value1)
      .setParameter2(value2)
      ...
      .instantiate();
{code}

Each parameter setter being on the same line will make merges/cherry-pick work 
properly, we will not have to even mention default parameters again, and we can 
eliminate a dozen impossible-to-remember constructors.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to