[ https://issues.apache.org/jira/browse/HBASE-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-18830. ------------------------------------ Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.5.0 1.4.0 3.0.0 2.0.0 Pushed to branch-1.4 and up > TestCanaryTool does not check Canary monitor's error code > --------------------------------------------------------- > > Key: HBASE-18830 > URL: https://issues.apache.org/jira/browse/HBASE-18830 > Project: HBase > Issue Type: Bug > Reporter: Chinmay Kulkarni > Assignee: Chinmay Kulkarni > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0 > > Attachments: HBASE-18830.001.patch > > > None of the tests inside TestCanaryTool check Canary monitor's error code. > Thus, it is possible that the monitor has registered an error and yet the > tests pass. We should check the value returned by the _ToolRunner.run()_ > method inside each unit test. -- This message was sent by Atlassian JIRA (v6.4.14#64029)