[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13007861#comment-13007861
]
Hudson commented on HBASE-3514:
---
Integrated in HBase-TRUNK #1792 (See
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005905#comment-13005905
]
ryan rawson commented on HBASE-3514:
this new patch is showing a modest improvement of
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005991#comment-13005991
]
stack commented on HBASE-3514:
--
Thats worth commit Ryan?
Speedup HFile.Writer append
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13002805#comment-13002805
]
Matteo Bertozzi commented on HBASE-3514:
@ryan
trunk-v2c.patch trims the buffer
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13002364#comment-13002364
]
ryan rawson commented on HBASE-3514:
a test failure caused me to dig into this, and
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13002416#comment-13002416
]
Hudson commented on HBASE-3514:
---
Integrated in HBase-TRUNK #1767 (See
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001340#comment-13001340
]
Matteo Bertozzi commented on HBASE-3514:
@ryan
I still don't have looked tests in
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001343#comment-13001343
]
ryan rawson commented on HBASE-3514:
Yes you are correct, I forgot to commit that, ill
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001219#comment-13001219
]
ryan rawson commented on HBASE-3514:
I think we should go back to pre-direct write
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000559#comment-13000559
]
ryan rawson commented on HBASE-3514:
a few comments here:
- why do you use a 256MB
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000572#comment-13000572
]
ryan rawson commented on HBASE-3514:
I looked at the unit test, and it looks like the
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999757#comment-12999757
]
Matteo Bertozzi commented on HBASE-3514:
@Ted
Of course there's an
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999582#comment-12999582
]
Ted Yu commented on HBASE-3514:
---
v2 of the patches produced the following in
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998738#comment-12998738
]
ryan rawson commented on HBASE-3514:
This is breaking the build, here is the output:
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998790#comment-12998790
]
Hudson commented on HBASE-3514:
---
Integrated in HBase-TRUNK #1750 (See
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998810#comment-12998810
]
Matteo Bertozzi commented on HBASE-3514:
@ryan
Errors are caused by block size
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999029#comment-12999029
]
Ted Yu commented on HBASE-3514:
---
Since the buffer managed by ByteArrayOutputStream can grow,
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999058#comment-12999058
]
Matteo Bertozzi commented on HBASE-3514:
@Ted
Yep, I've added the 0.90-v2 and
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998639#comment-12998639
]
ryan rawson commented on HBASE-3514:
im putting this to trunk, it won't apply cleanly
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991836#comment-12991836
]
ryan rawson commented on HBASE-3514:
how does the performance numbers look like on a
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991837#comment-12991837
]
Matteo Bertozzi commented on HBASE-3514:
@ryan I've only a single node cluster, so
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992008#comment-12992008
]
stack commented on HBASE-3514:
--
@Matteo Patch looks great. The speedup comes from not doing
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992091#comment-12992091
]
Matteo Bertozzi commented on HBASE-3514:
@stack The first patch that I've written
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992214#comment-12992214
]
Dave Latham commented on HBASE-3514:
{quote}
// pre-allocates the byte stream to the
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992250#comment-12992250
]
Jonathan Gray commented on HBASE-3514:
--
I didn't review the code just now, but I
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992252#comment-12992252
]
ryan rawson commented on HBASE-3514:
the hfile writer append code does:
private
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992273#comment-12992273
]
Jonathan Gray commented on HBASE-3514:
--
Thanks for looking that up Ryan. Sorry for
[
https://issues.apache.org/jira/browse/HBASE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992278#comment-12992278
]
ryan rawson commented on HBASE-3514:
if you file a jira and post a patch i'll review
28 matches
Mail list logo
