sbernauer commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1825298942
Created https://github.com/apache/hbase/pull/5537 as a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sbernauer commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1825246145
Thanks a lot for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lfrancke merged PR #5515:
URL: https://github.com/apache/hbase/pull/5515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lfrancke commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1825208179
Thank you! I'll merge it then and we'll get the second PR up as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Apache9 commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1825078843
I'm OK with backporting all these issues to 2.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lfrancke commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1820469675
Ah! Yes, sorry.
We have a
[patch](https://github.com/stackabletech/docker-images/blob/main/hbase/stackable/patches/2.4.12/004-HBASE-25336-2.4.12.patch)
for that as well and can put
Apache9 commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1820454903
See HBASE-25335.
I think at least we should also backport HBASE-25336?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lfrancke commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1820449836
Yep, we find that without it, running 2.4.x on Kubernetes is very unstable
across restarts because of DNS issues.
We're also happy to just maintain the patch on our end for the rest
Apache9 commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1820397442
@sbernauer Thanks for opening this PR.
So you guys needs this on branch-2.4? The patch here removes a
configuration, so typically we do not want to include it in a patch release.
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1808512473
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1808483615
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1808201820
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1807260963
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1807259065
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1807221114
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1807211109
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 9s |
lfrancke commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1807209809
Thank you. This is looking good to me but since I was involved in creating
this patch I'll give @apurtell (or others) a chance to take a look as well.
Thank you @sbernauer!
--
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1807208856
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 30s |
Apache-HBase commented on PR #5515:
URL: https://github.com/apache/hbase/pull/5515#issuecomment-1807174269
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 25s |
19 matches
Mail list logo
