Apache9 merged PR #5520:
URL: https://github.com/apache/hbase/pull/5520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1838081723
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1838062371
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1837846036
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache9 commented on code in PR #5520:
URL: https://github.com/apache/hbase/pull/5520#discussion_r1413345887
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureEnv.java:
##
@@ -84,6 +93,19 @@ public MasterProcedureEnv(final MasterServices
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1837518826
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1837517010
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1837515989
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
carp84 commented on code in PR #5520:
URL: https://github.com/apache/hbase/pull/5520#discussion_r1413130042
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java:
##
@@ -249,25 +272,31 @@ private void removeMirrorMetaLocation(int
carp84 commented on code in PR #5520:
URL: https://github.com/apache/hbase/pull/5520#discussion_r1413129837
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureEnv.java:
##
@@ -84,6 +93,19 @@ public MasterProcedureEnv(final MasterServices
Apache9 commented on code in PR #5520:
URL: https://github.com/apache/hbase/pull/5520#discussion_r1413126492
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNodeLock.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation
Apache9 commented on code in PR #5520:
URL: https://github.com/apache/hbase/pull/5520#discussion_r1413126430
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java:
##
@@ -249,25 +272,31 @@ private void removeMirrorMetaLocation(int
carp84 commented on code in PR #5520:
URL: https://github.com/apache/hbase/pull/5520#discussion_r1413117349
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNodeLock.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation
Apache9 commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1831916890
Good news. We passed a 10B ITBLL run with the PR in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-189011
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1822215552
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 10s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1822034289
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1820900910
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1820827010
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1820483864
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1817094104
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1817040154
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1816725587
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1815175212
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1815170673
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 20s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1814736420
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1814400913
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1813737762
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1812896976
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1811931844
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache9 commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1811743652
OK, it should be a race, just like what we have done in
`MigrateReplicationQueueFromZkToTableProcedure`, we need to make sure that the
procedure has already been suspended before we add it
Apache9 commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1811728011
```
2023-11-14T14:58:15,503 INFO [PEWorker-5 {}]
procedure2.ProcedureExecutor$WorkerThread(1963): ASSERT pid=100
java.lang.AssertionError: pid=100, ppid=76,
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1810948707
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1810454390
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 17s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1810423386
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1810108489
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1809992910
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1809992651
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1809985350
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 51s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1809912950
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1809909728
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
Apache-HBase commented on PR #5520:
URL: https://github.com/apache/hbase/pull/5520#issuecomment-1809903726
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
42 matches
Mail list logo
