Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil merged PR #5793: URL: https://github.com/apache/hbase/pull/5793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2043004482 @wchevreuil, it seems like most of the tests have passed, and any failures were due to flaky tests. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042968954 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042894870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

jhungund commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1555856302 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1555847930 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

jhungund commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1555814598 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042385473 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042266090 > LTGM, can we just address latest spotless failure? That's because of the Javadoc in the `TestDataTieringManager` class, where I included the structure of the

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2042252076 LTGM, can we just address latest spotless failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040824093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040820860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040590074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040537932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040481765 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553980810 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553979182 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040058881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553348860 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553318202 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553288683 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553240987 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553235776 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553235776 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037800563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037736939 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552061992 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552053165 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552050096 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552047719 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

vinayakphegde commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037647435 > Overall, looks good, I just think we need to add javadoc on public methods and explain properly when we will consider a file/block as cold/hot, specially when dealing with default

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1551838394 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037183945 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |