[jira] [Updated] (HBASE-22664) Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22664: -- Component/s: rsgroup Region Assignment > Move protobuf stuff in hbase-rsgroup to

[jira] [Updated] (HBASE-22664) Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22664: -- Fix Version/s: HBASE-22514 > Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded >

[jira] [Updated] (HBASE-22664) Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22664: -- Component/s: Protobufs > Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded >

[jira] [Resolved] (HBASE-22664) Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22664. --- Resolution: Fixed Hadoop Flags: Reviewed Pushed to branch HBASE-22514. Thanks [~zghaobac]

[jira] [Comment Edited] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880403#comment-16880403 ] Yechao Chen edited comment on HBASE-22665 at 7/9/19 3:26 AM: - Thanks for

[jira] [Updated] (HBASE-22667) [Flush] NPE when region flushs

2019-07-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22667: -- Description: {code} 2019-07-09 08:02:14,262 FATAL

[jira] [Created] (HBASE-22667) [Flush] NPE when region flushs

2019-07-08 Thread Reid Chan (JIRA)
Reid Chan created HBASE-22667: - Summary: [Flush] NPE when region flushs Key: HBASE-22667 URL: https://issues.apache.org/jira/browse/HBASE-22667 Project: HBase Issue Type: Bug

[jira] [Updated] (HBASE-22667) [Flush] NPE when region flushs

2019-07-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-22667: -- Affects Version/s: 1.4.6 > [Flush] NPE when region flushs > -- > >

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2019-07-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880922#comment-16880922 ] Hudson commented on HBASE-20952: Results for branch HBASE-20952 [build #97 on

[GitHub] [hbase] jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM…

2019-07-08 Thread GitBox
jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM… URL: https://github.com/apache/hbase/pull/354#discussion_r301347251 ## File path:

[GitHub] [hbase] jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM…

2019-07-08 Thread GitBox
jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM… URL: https://github.com/apache/hbase/pull/354#discussion_r301347171 ## File path:

[GitHub] [hbase] jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM…

2019-07-08 Thread GitBox
jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM… URL: https://github.com/apache/hbase/pull/354#discussion_r301347039 ## File path:

[GitHub] [hbase] jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM…

2019-07-08 Thread GitBox
jatsakthi commented on a change in pull request #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM… URL: https://github.com/apache/hbase/pull/354#discussion_r301346868 ## File path:

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-07-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880890#comment-16880890 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #1 on

[jira] [Commented] (HBASE-22667) [Flush] NPE when region flushs

2019-07-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880919#comment-16880919 ] Reid Chan commented on HBASE-22667: --- I haven't dig out the root cause yet, just file it first. >

[jira] [Commented] (HBASE-21751) WAL creation fails during region open may cause region assign forever fail

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880844#comment-16880844 ] Duo Zhang commented on HBASE-21751: --- Ping [~allan163] [~luffy123]. > WAL creation fails during region

[GitHub] [hbase] openinx opened a new pull request #365: HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocat

2019-07-08 Thread GitBox
openinx opened a new pull request #365: HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator named HEAP URL: https://github.com/apache/hbase/pull/365

[jira] [Commented] (HBASE-22667) [Flush] NPE when region flushs

2019-07-08 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880931#comment-16880931 ] Reid Chan commented on HBASE-22667: --- It's werid, since null check for memStoreScanners is done in line

[GitHub] [hbase] Apache9 merged pull request #362: HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
Apache9 merged pull request #362: HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880897#comment-16880897 ] Duo Zhang commented on HBASE-22665: --- {quote} Duo Zhang, would you think we should clean out

[jira] [Assigned] (HBASE-22662) Move RSGroupInfoManager to hbase-server

2019-07-08 Thread kevin su (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kevin su reassigned HBASE-22662: Assignee: kevin su > Move RSGroupInfoManager to hbase-server >

[jira] [Updated] (HBASE-22662) Move RSGroupInfoManager to hbase-server

2019-07-08 Thread kevin su (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kevin su updated HBASE-22662: - Attachment: HBASE-22662.v0.patch > Move RSGroupInfoManager to hbase-server >

[GitHub] [hbase] a516072575 closed pull request #366: HBASE-22658 region_mover.rb should choose same rsgroup servers as target servers

2019-07-08 Thread GitBox
a516072575 closed pull request #366: HBASE-22658 region_mover.rb should choose same rsgroup servers as target servers URL: https://github.com/apache/hbase/pull/366 This is an automated message from the Apache Git Service.

[GitHub] [hbase] a516072575 commented on issue #366: HBASE-22658 region_mover.rb should choose same rsgroup servers as target servers

2019-07-08 Thread GitBox
a516072575 commented on issue #366: HBASE-22658 region_mover.rb should choose same rsgroup servers as target servers URL: https://github.com/apache/hbase/pull/366#issuecomment-509499859 I chose the wrong branch. This is an

[GitHub] [hbase] a516072575 opened a new pull request #367: region_mover.rb should choose same rsgroup servers as target servers

2019-07-08 Thread GitBox
a516072575 opened a new pull request #367: region_mover.rb should choose same rsgroup servers as target servers URL: https://github.com/apache/hbase/pull/367 There are many retries when I am using graceful_stop.sh to shutdown region server after using regroup, because the target server in

[GitHub] [hbase] a516072575 opened a new pull request #366: HBASE-22658 region_mover.rb should choose same rsgroup servers as target servers

2019-07-08 Thread GitBox
a516072575 opened a new pull request #366: HBASE-22658 region_mover.rb should choose same rsgroup servers as target servers URL: https://github.com/apache/hbase/pull/366 There are many retries when i am using graceful_stop.sh to shutdown region server after using regroup, because the

[jira] [Commented] (HBASE-22662) Move RSGroupInfoManager to hbase-server

2019-07-08 Thread kevin su (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880952#comment-16880952 ] kevin su commented on HBASE-22662: -- I also move RSGroupProtobufUtil to hbase-server, because 

[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-07-08 Thread Pierre Zemb (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880361#comment-16880361 ] Pierre Zemb commented on HBASE-22618: - Cool, I will make the implementation based on master then.

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880403#comment-16880403 ] Yechao Chen commented on HBASE-22665: - Thanks for reply [~Apache9][~wchevreuil]   {quote}So the RS

[jira] [Commented] (HBASE-22075) Potential data loss when MOB compaction fails

2019-07-08 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880489#comment-16880489 ] Sean Busbey commented on HBASE-22075: - My current opinion is that there are a couple of different

[jira] [Commented] (HBASE-22666) Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880533#comment-16880533 ] Hudson commented on HBASE-22666: Results for branch branch-1 [build #939 on

[jira] [Updated] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-08 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated HBASE-22623: Summary: Add RegionObserver coprocessor hook for preWALAppend (was: Add coprocessor

[jira] [Updated] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yechao Chen updated HBASE-22665: Attachment: jstack_20190704_1 jstack_20190625 jstack_20190704_2 >

[jira] [Created] (HBASE-22664) Move protobuf sutff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-22664: - Summary: Move protobuf sutff in hbase-rsgroup to hbase-protocol-shaded Key: HBASE-22664 URL: https://issues.apache.org/jira/browse/HBASE-22664 Project: HBase

[jira] [Updated] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yechao Chen updated HBASE-22665: Attachment: image-2019-07-08-16-07-37-664.png > RegionServer abort failed when

[jira] [Updated] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yechao Chen updated HBASE-22665: Attachment: image-2019-07-08-16-08-26-777.png > RegionServer abort failed when

[jira] [Updated] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yechao Chen updated HBASE-22665: Attachment: image-2019-07-08-16-14-43-455.png > RegionServer abort failed when

[jira] [Created] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
Yechao Chen created HBASE-22665: --- Summary: RegionServer abort failed when AbstractFSWAL.shutdown hang Key: HBASE-22665 URL: https://issues.apache.org/jira/browse/HBASE-22665 Project: HBase

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880112#comment-16880112 ] Yechao Chen commented on HBASE-22665: - check the the code and jstack ,   the wal log roller stuck

[jira] [Commented] (HBASE-22664) Move protobuf sutff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880115#comment-16880115 ] Duo Zhang commented on HBASE-22664: --- [~zghaobac] PTAL. Plan to do this on a feature branch,

[jira] [Assigned] (HBASE-22664) Move protobuf sutff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-22664: - Assignee: Duo Zhang > Move protobuf sutff in hbase-rsgroup to hbase-protocol-shaded >

[GitHub] [hbase] Apache9 opened a new pull request #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
Apache9 opened a new pull request #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362 …aded This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-07-08 Thread GitBox
Apache-HBase commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#issuecomment-509127869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880331#comment-16880331 ] Wellington Chevreuil commented on HBASE-22665: -- {quote}RegionServer aborted failed when

[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

2019-07-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880332#comment-16880332 ] Hudson commented on HBASE-21879: Results for branch HBASE-21879 [build #171 on

[GitHub] [hbase] petersomogyi merged pull request #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread GitBox
petersomogyi merged pull request #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle URL: https://github.com/apache/hbase/pull/364 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-22661) list_regions command in hbase shell is broken

2019-07-08 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880345#comment-16880345 ] Toshihiro Suzuki commented on HBASE-22661: -- I started hbase as a local mode. Is it related? >

[GitHub] [hbase] petersomogyi commented on issue #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread GitBox
petersomogyi commented on issue #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle URL: https://github.com/apache/hbase/pull/364#issuecomment-509225382 Failure in TestRegionMergeTransactionOnCluster is unrelated.

[jira] [Commented] (HBASE-22417) DeleteTableProcedure.deleteFromMeta method should remove table from Master's table descriptors cache

2019-07-08 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880416#comment-16880416 ] Wellington Chevreuil commented on HBASE-22417: -- This latest test failure, I do believe is

[GitHub] [hbase] Apache9 commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
Apache9 commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362#issuecomment-509218901 Any other concerns? @infraio Thanks. This is an

[jira] [Updated] (HBASE-22666) Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22666: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks [~Apache9] for

[jira] [Commented] (HBASE-22567) HBCK2 addMissingRegionsToMeta

2019-07-08 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880435#comment-16880435 ] stack commented on HBASE-22567: --- [~wchevreuil] Sounds good sir. > HBCK2 addMissingRegionsToMeta >

[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-07-08 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880342#comment-16880342 ] Wellington Chevreuil commented on HBASE-22618: -- Oh, sorry for the confusion, thought this

[jira] [Updated] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yechao Chen updated HBASE-22665: Attachment: rs.log.part1 > RegionServer abort failed when AbstractFSWAL.shutdown hang >

[jira] [Assigned] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-08 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-21606: --- Assignee: Szalay-Beko Mate (was: Sean Busbey) that looks like a great write up! feel free

[jira] [Updated] (HBASE-22664) Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22664: -- Summary: Move protobuf stuff in hbase-rsgroup to hbase-protocol-shaded (was: Move protobuf sutff in

[jira] [Comment Edited] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Yechao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880112#comment-16880112 ] Yechao Chen edited comment on HBASE-22665 at 7/8/19 8:33 AM: - check the the

[jira] [Comment Edited] (HBASE-22567) HBCK2 addMissingRegionsToMeta

2019-07-08 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880125#comment-16880125 ] Wellington Chevreuil edited comment on HBASE-22567 at 7/8/19 8:40 AM:

[jira] [Commented] (HBASE-22567) HBCK2 addMissingRegionsToMeta

2019-07-08 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880125#comment-16880125 ] Wellington Chevreuil commented on HBASE-22567: -- {quote}Maybe we doc the Daisuke Kobayashi

[GitHub] [hbase] infraio commented on a change in pull request #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
infraio commented on a change in pull request #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362#discussion_r300995309 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
Apache-HBase commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362#issuecomment-509154536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-07-08 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880174#comment-16880174 ] Wellington Chevreuil commented on HBASE-22618: -- Thanks for sharing this, [~PierreZ]. Had

[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-07-08 Thread Pierre Zemb (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880118#comment-16880118 ] Pierre Zemb commented on HBASE-22618: - Hi! Thanks [~apurtell] for your comment. I worked a bit on it

[jira] [Comment Edited] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-07-08 Thread Pierre Zemb (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880118#comment-16880118 ] Pierre Zemb edited comment on HBASE-22618 at 7/8/19 8:25 AM: - Hi! Thanks

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880138#comment-16880138 ] Duo Zhang commented on HBASE-22514: --- Then why not just use zookeeper directly... > Move rsgroup

[GitHub] [hbase] Apache-HBase commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
Apache-HBase commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362#issuecomment-509149555 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 commented on a change in pull request #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
Apache9 commented on a change in pull request #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362#discussion_r301005287 ## File path:

[GitHub] [hbase] Braavos96 opened a new pull request #363: Add unit tests for org.apache.hadoop.hbase.util.Strings

2019-07-08 Thread GitBox
Braavos96 opened a new pull request #363: Add unit tests for org.apache.hadoop.hbase.util.Strings URL: https://github.com/apache/hbase/pull/363 I've analysed your codebase and noticed that `org.apache.hadoop.hbase.util.Strings` is not fully tested. I've written some tests for the

[jira] [Created] (HBASE-22666) Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread Peter Somogyi (JIRA)
Peter Somogyi created HBASE-22666: - Summary: Add missing @Test annotation to TestQuotaThrottle Key: HBASE-22666 URL: https://issues.apache.org/jira/browse/HBASE-22666 Project: HBase Issue

[GitHub] [hbase] petersomogyi opened a new pull request #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread GitBox
petersomogyi opened a new pull request #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle URL: https://github.com/apache/hbase/pull/364 This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (HBASE-22666) Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22666: -- Status: Patch Available (was: Open) > Add missing @Test annotation to TestQuotaThrottle >

[GitHub] [hbase] Apache-HBase commented on issue #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM…

2019-07-08 Thread GitBox
Apache-HBase commented on issue #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM… URL: https://github.com/apache/hbase/pull/354#issuecomment-509164869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #363: Add unit tests for org.apache.hadoop.hbase.util.Strings

2019-07-08 Thread GitBox
Apache-HBase commented on issue #363: Add unit tests for org.apache.hadoop.hbase.util.Strings URL: https://github.com/apache/hbase/pull/363#issuecomment-509170491 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Comment Edited] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-07-08 Thread Pierre Zemb (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880118#comment-16880118 ] Pierre Zemb edited comment on HBASE-22618 at 7/8/19 8:26 AM: - Hi! Thanks

[jira] [Commented] (HBASE-19893) restore_snapshot is broken in master branch when region splits

2019-07-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880126#comment-16880126 ] Hudson commented on HBASE-19893: Results for branch branch-2.0 [build #1735 on

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-07-08 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880129#comment-16880129 ] Guanghao Zhang commented on HBASE-22514: {quote}bq.And I think there will be a big challenge is

[jira] [Commented] (HBASE-19893) restore_snapshot is broken in master branch when region splits

2019-07-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880133#comment-16880133 ] Hudson commented on HBASE-19893: Results for branch branch-2.1 [build #1342 on

[GitHub] [hbase] syedmurtazahassan commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag

2019-07-08 Thread GitBox
syedmurtazahassan commented on a change in pull request #302: HBASE-22571 Javadoc Warnings related to @return tag URL: https://github.com/apache/hbase/pull/302#discussion_r301003774 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java

[GitHub] [hbase] Apache-HBase commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-07-08 Thread GitBox
Apache-HBase commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#issuecomment-509165250 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880170#comment-16880170 ] Duo Zhang commented on HBASE-22665: --- I think the WAL has already been broken before shutting down...

[GitHub] [hbase] virajjasani removed a comment on issue #345: HBASE-22638 : Zookeeper Utility enhancements

2019-07-08 Thread GitBox
virajjasani removed a comment on issue #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#issuecomment-508059880 Please review @jatsakthi @wchevreuil This is an automated

[GitHub] [hbase] virajjasani removed a comment on issue #345: HBASE-22638 : Zookeeper Utility enhancements

2019-07-08 Thread GitBox
virajjasani removed a comment on issue #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#issuecomment-508073090 @HorizonNet This is an automated message from the Apache Git

[GitHub] [hbase] virajjasani commented on issue #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-08 Thread GitBox
virajjasani commented on issue #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#issuecomment-509336776 @busbey Could you please review this patch?

[GitHub] [hbase] virajjasani commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-07-08 Thread GitBox
virajjasani commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r300344249 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@

[GitHub] [hbase] Apache-HBase commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-07-08 Thread GitBox
Apache-HBase commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#issuecomment-509343430 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22075) Potential data loss when MOB compaction fails

2019-07-08 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880569#comment-16880569 ] Vladimir Rodionov commented on HBASE-22075: --- To prevent non-atomic failures we will need acid

[GitHub] [hbase] virajjasani commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements

2019-07-08 Thread GitBox
virajjasani commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#issuecomment-509337863 @HorizonNet Could you please take a final look? This is an automated

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-08 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880645#comment-16880645 ] Wellington Chevreuil commented on HBASE-22665: -- Thanks [~chenyechao]! My theory here is

[GitHub] [hbase] Apache-HBase commented on issue #352: HBASE-22622 - WALKey Extended Attributes

2019-07-08 Thread GitBox
Apache-HBase commented on issue #352: HBASE-22622 - WALKey Extended Attributes URL: https://github.com/apache/hbase/pull/352#issuecomment-509382880 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] gjacoby126 commented on issue #352: HBASE-22622 - WALKey Extended Attributes

2019-07-08 Thread GitBox
gjacoby126 commented on issue #352: HBASE-22622 - WALKey Extended Attributes URL: https://github.com/apache/hbase/pull/352#issuecomment-509390346 @apurtell @saintstack @Apache9 - adding extended attributes to WALKey as discussed in HBASE-22622. I wasn't able to use a protobuf map class

[jira] [Comment Edited] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-08 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880747#comment-16880747 ] Geoffrey Jacoby edited comment on HBASE-22623 at 7/8/19 10:08 PM: -- As

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-08 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880747#comment-16880747 ] Geoffrey Jacoby commented on HBASE-22623: - As an alternative to adding

[GitHub] [hbase] Apache-HBase commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh…

2019-07-08 Thread GitBox
Apache-HBase commented on issue #362: HBASE-22664 Move protobuf sutff in hbase-rsgroup to hbase-protocol-sh… URL: https://github.com/apache/hbase/pull/362#issuecomment-509182266 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-6519) FSRegionScanner should be in its own file

2019-07-08 Thread kevin su (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880213#comment-16880213 ] kevin su commented on HBASE-6519: - *[~rvadali]*  {color:#33}link not working{color} >

[GitHub] [hbase] syedmurtazahassan commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-07-08 Thread GitBox
syedmurtazahassan commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#issuecomment-509214999 @jatsakthi @HorizonNet Adressed the comments. Kindly have a look when you have time. Thanks.

[GitHub] [hbase] Apache-HBase commented on issue #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle

2019-07-08 Thread GitBox
Apache-HBase commented on issue #364: HBASE-22666 Add missing @Test annotation to TestQuotaThrottle URL: https://github.com/apache/hbase/pull/364#issuecomment-509215239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #302: HBASE-22571 Javadoc Warnings related to @return tag

2019-07-08 Thread GitBox
Apache-HBase commented on issue #302: HBASE-22571 Javadoc Warnings related to @return tag URL: https://github.com/apache/hbase/pull/302#issuecomment-509216428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment

2019-07-08 Thread Pierre Zemb (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880297#comment-16880297 ] Pierre Zemb commented on HBASE-22618: - Thank you [~wchevreuil] for your comments!   Master branch