[GitHub] [hbase] Apache-HBase commented on pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1789: URL: https://github.com/apache/hbase/pull/1789#issuecomment-635120785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24451) Remove the HasThread because the related bug had been fixed since jdk7

2020-05-27 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24451: --- Description: The HasThread was introduced as a wrapper of Thread to workaround a deadlock bug, and

[jira] [Created] (HBASE-24451) Remove the HasThread because the related bug had been fixed since jdk7

2020-05-27 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-24451: -- Summary: Remove the HasThread because the related bug had been fixed since jdk7 Key: HBASE-24451 URL: https://issues.apache.org/jira/browse/HBASE-24451 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #1795: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1795: URL: https://github.com/apache/hbase/pull/1795#issuecomment-635102127 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
huaxiangsun commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431580567 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SplitPlanFirstComparator.java ## @@ -0,0 +1,40 @@ +/* + * Licensed

[GitHub] [hbase] huaxiangsun commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-05-27 Thread GitBox
huaxiangsun commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-635095629 Test failure is a flaky, HBASE-24429 This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1792: URL: https://github.com/apache/hbase/pull/1792#issuecomment-635093780 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn opened a new pull request #1795: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-05-27 Thread GitBox
anoopsjohn opened a new pull request #1795: URL: https://github.com/apache/hbase/pull/1795 …overed edits data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] infraio commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-05-27 Thread GitBox
infraio commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r431573270 ## File path: hbase-protocol-shaded/src/main/protobuf/server/rsgroup/RSGroupAdmin.proto ## @@ -183,4 +191,7 @@ service RSGroupAdminService { rpc

[jira] [Updated] (HBASE-24189) WALSplit recreates region dirs for deleted table with recovered edits data

2020-05-27 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-24189: --- Summary: WALSplit recreates region dirs for deleted table with recovered edits data (was:

[GitHub] [hbase] infraio commented on a change in pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-05-27 Thread GitBox
infraio commented on a change in pull request #1789: URL: https://github.com/apache/hbase/pull/1789#discussion_r431571750 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -77,6 +81,23 @@ private volatile

[GitHub] [hbase] infraio commented on a change in pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-05-27 Thread GitBox
infraio commented on a change in pull request #1789: URL: https://github.com/apache/hbase/pull/1789#discussion_r431571480 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -77,6 +81,23 @@ private volatile

[GitHub] [hbase] infraio commented on a change in pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-05-27 Thread GitBox
infraio commented on a change in pull request #1789: URL: https://github.com/apache/hbase/pull/1789#discussion_r431571294 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -77,6 +81,23 @@ private volatile

[jira] [Commented] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118282#comment-17118282 ] niuyulin commented on HBASE-24450: -- client side will retry, we have config

[GitHub] [hbase] Apache-HBase commented on pull request #1789: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1789: URL: https://github.com/apache/hbase/pull/1789#issuecomment-635081799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24428) Priority compaction for recently split daughter regions

2020-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118277#comment-17118277 ] Hudson commented on HBASE-24428: Results for branch branch-2 [build #2680 on

[jira] [Commented] (HBASE-24434) fix building cpp-example DemoClient

2020-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118278#comment-17118278 ] Hudson commented on HBASE-24434: Results for branch branch-2 [build #2680 on

[jira] [Comment Edited] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread yukunpeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118274#comment-17118274 ] yukunpeng edited comment on HBASE-24450 at 5/28/20, 3:51 AM: - When bulk load

[jira] [Updated] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread yukunpeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yukunpeng updated HBASE-24450: -- Attachment: (was: image-2020-05-28-11-44-14-142.png) > There was a partial failure due to IO when

[jira] [Commented] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread yukunpeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118274#comment-17118274 ] yukunpeng commented on HBASE-24450: --- When bulk load some hfiles, IO exception occurred in hadoop, how

[jira] [Issue Comment Deleted] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread yukunpeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yukunpeng updated HBASE-24450: -- Comment: was deleted (was: !image-2020-05-28-11-44-14-142.png!) > There was a partial failure due to

[jira] [Commented] (HBASE-24289) Heterogeneous Storage for Date Tiered Compaction

2020-05-27 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118273#comment-17118273 ] Guanghao Zhang commented on HBASE-24289: {quote}any other date-based compaction policies or

[jira] [Created] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread yukunpeng (Jira)
yukunpeng created HBASE-24450: - Summary: There was a partial failure due to IO when attempting to load Key: HBASE-24450 URL: https://issues.apache.org/jira/browse/HBASE-24450 Project: HBase

[jira] [Commented] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread yukunpeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118269#comment-17118269 ] yukunpeng commented on HBASE-24450: --- !image-2020-05-28-11-44-14-142.png! > There was a partial

[jira] [Updated] (HBASE-24450) There was a partial failure due to IO when attempting to load

2020-05-27 Thread yukunpeng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yukunpeng updated HBASE-24450: -- Attachment: image-2020-05-28-11-44-14-142.png > There was a partial failure due to IO when attempting

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-635062821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1792: URL: https://github.com/apache/hbase/pull/1792#issuecomment-635062664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-635061935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-635060887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1793: HBASE-23941 : FilterBy operator support in get_slowlog_responses API

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1793: URL: https://github.com/apache/hbase/pull/1793#issuecomment-635056963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-15550) Backport HBASE-12220 hedgedRead metrics to 1.2+

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-15550: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [hbase] ddupg commented on pull request #1788: backport: HBASE-24416 RegionNormalizer spliting region should not be limited by…

2020-05-27 Thread GitBox
ddupg commented on pull request #1788: URL: https://github.com/apache/hbase/pull/1788#issuecomment-635053759 > @ddupg multiple tests are failing. Can you please take a look once? How are they doing locally? Thanks @virajjasani for taking a look here. The following is unit log, it

[jira] [Updated] (HBASE-15550) Backport HBASE-12220 hedgedRead metrics to 1.2+

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-15550: -- Component/s: metrics > Backport HBASE-12220 hedgedRead metrics to 1.2+ >

[jira] [Updated] (HBASE-15550) Backport HBASE-12220 hedgedRead metrics to 1.2+

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-15550: -- Fix Version/s: 1.7.0 > Backport HBASE-12220 hedgedRead metrics to 1.2+ >

[jira] [Commented] (HBASE-15550) Backport HBASE-12220 hedgedRead metrics to 1.2+

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118234#comment-17118234 ] Reid Chan commented on HBASE-15550: --- It is back-ported to branch-1, fixed in 1.7 > Backport

[jira] [Commented] (HBASE-24435) Bring back hedged reads metrics to branch-1

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118232#comment-17118232 ] Reid Chan commented on HBASE-24435: --- Take the credit and assign yourself after that is done. Thanks

[jira] [Commented] (HBASE-24435) Bring back hedged reads metrics to branch-1

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118230#comment-17118230 ] Reid Chan commented on HBASE-24435: --- [~akiraluca] Please send a request to dev mail for being added to

[jira] [Resolved] (HBASE-24435) Bring back hedged reads metrics to branch-1

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-24435. --- Hadoop Flags: Reviewed Resolution: Fixed > Bring back hedged reads metrics to branch-1 >

[jira] [Updated] (HBASE-24435) Bring back hedged reads metrics to branch-1

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24435: -- Component/s: metrics > Bring back hedged reads metrics to branch-1 >

[jira] [Updated] (HBASE-24435) Bring back hedged reads metrics to branch-1

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24435: -- Issue Type: Improvement (was: Bug) > Bring back hedged reads metrics to branch-1 >

[jira] [Updated] (HBASE-24435) Bring back hedged reads metrics to branch-1

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24435: -- Fix Version/s: 1.7.0 > Bring back hedged reads metrics to branch-1 >

[GitHub] [hbase] Reidddddd merged pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-27 Thread GitBox
Reidd merged pull request #1781: URL: https://github.com/apache/hbase/pull/1781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] VicoWu commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

2020-05-27 Thread GitBox
VicoWu commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-635050379 > @jojochuang > This issue is found by our cluster incident. > But my current commit still has some problem which need to be resolved before finally adopted: > > In

[jira] [Resolved] (HBASE-24448) Flaky tests for region server in branch-1

2020-05-27 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-24448. --- Resolution: Not A Bug > Flaky tests for region server in branch-1 >

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-05-27 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118226#comment-17118226 ] Guanghao Zhang commented on HBASE-11288: BTW: For higher availability master and reduce zk

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

2020-05-27 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118219#comment-17118219 ] Guanghao Zhang commented on HBASE-23296: {quote}bq.But if the index and bloom miss, we may need

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-05-27 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118217#comment-17118217 ] Guanghao Zhang commented on HBASE-11288: I thought we are consistent on this point: need a

[jira] [Commented] (HBASE-24389) Introduce a new master rpc service to locate meta region through root region

2020-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118214#comment-17118214 ] Michael Stack commented on HBASE-24389: --- Mind doing a bit of a write up on what this is doing. On

[GitHub] [hbase] VicoWu commented on a change in pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-05-27 Thread GitBox
VicoWu commented on a change in pull request #1764: URL: https://github.com/apache/hbase/pull/1764#discussion_r431533385 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java ## @@ -382,22 +382,27 @@ public String

[GitHub] [hbase] VicoWu commented on a change in pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-05-27 Thread GitBox
VicoWu commented on a change in pull request #1764: URL: https://github.com/apache/hbase/pull/1764#discussion_r431532580 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java ## @@ -382,22 +382,27 @@ public String

[GitHub] [hbase] VicoWu commented on a change in pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-05-27 Thread GitBox
VicoWu commented on a change in pull request #1764: URL: https://github.com/apache/hbase/pull/1764#discussion_r431532167 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java ## @@ -382,22 +382,27 @@ public String

[jira] [Commented] (HBASE-24371) Add more details when print CompactionConfiguration info

2020-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118206#comment-17118206 ] Hudson commented on HBASE-24371: Results for branch branch-2.2 [build #878 on

[jira] [Commented] (HBASE-24379) CatalogJanitor misreports region holes when there are actually over laps.

2020-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118208#comment-17118208 ] Hudson commented on HBASE-24379: Results for branch branch-2.2 [build #878 on

[jira] [Commented] (HBASE-24428) Priority compaction for recently split daughter regions

2020-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118207#comment-17118207 ] Hudson commented on HBASE-24428: Results for branch branch-2.2 [build #878 on

[GitHub] [hbase] busbey commented on a change in pull request #1714: HBASE-24373 Implement JvmMetrics in HBase instead of using the one in hadoop

2020-05-27 Thread GitBox
busbey commented on a change in pull request #1714: URL: https://github.com/apache/hbase/pull/1714#discussion_r431527682 ## File path: hbase-logging/src/main/java/org/apache/log4j/Logger.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] busbey commented on a change in pull request #1714: HBASE-24373 Implement JvmMetrics in HBase instead of using the one in hadoop

2020-05-27 Thread GitBox
busbey commented on a change in pull request #1714: URL: https://github.com/apache/hbase/pull/1714#discussion_r431527371 ## File path: hbase-logging/src/main/java/org/apache/log4j/Logger.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] Apache-HBase commented on pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1792: URL: https://github.com/apache/hbase/pull/1792#issuecomment-635023960 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24438) Stale ServerCrashProcedure task in HBase Master UI

2020-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118186#comment-17118186 ] Michael Stack commented on HBASE-24438: --- So, what is the issue? The staleness? Or difference

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-635019009 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1793: HBASE-23941 : FilterBy operator support in get_slowlog_responses API

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1793: URL: https://github.com/apache/hbase/pull/1793#issuecomment-635017402 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1792: URL: https://github.com/apache/hbase/pull/1792#issuecomment-635010715 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1794: URL: https://github.com/apache/hbase/pull/1794#issuecomment-635009624 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1794: URL: https://github.com/apache/hbase/pull/1794#issuecomment-635009277 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1794: URL: https://github.com/apache/hbase/pull/1794#issuecomment-635007327 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-635006849 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #2: HBASE-24400: Fixup cmake infrastructure to allow dependencies to be built locally

2020-05-27 Thread GitBox
bharathv commented on a change in pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r431501510 ## File path: cmake/DownloadFolly.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #2: HBASE-24400: Fixup cmake infrastructure to allow dependencies to be built locally

2020-05-27 Thread GitBox
bharathv commented on a change in pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r431501510 ## File path: cmake/DownloadFolly.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [hbase] bharathv opened a new pull request #1794: HBASE-24449: Generate version.h include file during compilation.

2020-05-27 Thread GitBox
bharathv opened a new pull request #1794: URL: https://github.com/apache/hbase/pull/1794 This is needed for the hbase-native-client to compile. Also ships the includes in the assembly tar. This is an automated message

[jira] [Created] (HBASE-24449) Generate version.h include file during compilation

2020-05-27 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24449: Summary: Generate version.h include file during compilation Key: HBASE-24449 URL: https://issues.apache.org/jira/browse/HBASE-24449 Project: HBase

[jira] [Commented] (HBASE-22041) [k8s] The crashed node exists in onlineServer forever, and if it holds the meta data, master will start up hang.

2020-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118159#comment-17118159 ] Michael Stack commented on HBASE-22041: --- The TRACE-level logs really help. Thanks [~timoha] It

[GitHub] [hbase] ndimiduk commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-05-27 Thread GitBox
ndimiduk commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r431486691 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java ## @@ -251,6 +260,25 @@ private void

[jira] [Created] (HBASE-24448) Flaky tests for region server in branch-1

2020-05-27 Thread Clara Xiong (Jira)
Clara Xiong created HBASE-24448: --- Summary: Flaky tests for region server in branch-1 Key: HBASE-24448 URL: https://issues.apache.org/jira/browse/HBASE-24448 Project: HBase Issue Type: Bug

[GitHub] [hbase] Apache-HBase commented on pull request #1792: HBASE-24447: Contribute a Test class that shows some examples for usi…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1792: URL: https://github.com/apache/hbase/pull/1792#issuecomment-634983048 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken should cache token after acquired a new one

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-634981783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431473726 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -18,126 +17,436 @@ */ package

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-634968890 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-05-27 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r431469964 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java ## @@ -251,6 +260,25 @@ private void

[GitHub] [hbase] saintstack commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
saintstack commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634963002 Interesting. Wonder why the change was made. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-05-27 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r431464432 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java ## @@ -251,6 +260,25 @@ private void

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
ndimiduk commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634960241 > Generally, I think the default is too aggressive. @saintstack Looks liked we originally ran the normalizer on a 30min period. This was reduced to 5 min for 2.0,

[GitHub] [hbase] Apache-HBase commented on pull request #1793: HBASE-23941 : FilterBy operator support in get_slowlog_responses API

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1793: URL: https://github.com/apache/hbase/pull/1793#issuecomment-634955841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24434) fix building cpp-example DemoClient

2020-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24434: - Component/s: (was: native-client) > fix building cpp-example DemoClient >

[GitHub] [hbase] huaxiangsun edited a comment on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
huaxiangsun edited a comment on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634951336 ``` diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java

[GitHub] [hbase] huaxiangsun edited a comment on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
huaxiangsun edited a comment on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634951336 `diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java

[GitHub] [hbase] huaxiangsun commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
huaxiangsun commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634951336 diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
huaxiangsun commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431452897 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java ## @@ -69,517 +78,347 @@ public

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
huaxiangsun commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431452085 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java ## @@ -69,517 +78,347 @@ public

[jira] [Commented] (HBASE-24434) fix building cpp-example DemoClient

2020-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118110#comment-17118110 ] Bharath Vissapragada commented on HBASE-24434: -- Committed to branch-1/2/2.3. Thanks for

[jira] [Resolved] (HBASE-24434) fix building cpp-example DemoClient

2020-05-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-24434. -- Fix Version/s: 2.4.0 1.7.0 2.3.0

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken should cache token after acquired a new one

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-634949224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-634948652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24371) Add more details when print CompactionConfiguration info

2020-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118104#comment-17118104 ] Hudson commented on HBASE-24371: Results for branch branch-2 [build #2679 on

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-05-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118103#comment-17118103 ] Michael Stack commented on HBASE-11288: --- Updated Split Meta Design link so sharable. > Splittable

[jira] [Commented] (HBASE-24371) Add more details when print CompactionConfiguration info

2020-05-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118100#comment-17118100 ] Hudson commented on HBASE-24371: Results for branch branch-2.3 [build #108 on

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-27 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-634940763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431442449 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java ## @@ -69,517 +78,347 @@ public

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
huaxiangsun commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431383688 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -400,6 +401,8 @@ public void run() { private final

[GitHub] [hbase] brfrn169 commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-05-27 Thread GitBox
brfrn169 commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-634936795 Ping @joshelser This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] ndimiduk commented on a change in pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-27 Thread GitBox
ndimiduk commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431437782 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1911,43 +1912,51 @@ public boolean normalizeRegions() throws

[jira] [Commented] (HBASE-22285) A normalizer which merges very small size regions with adjacent regions.(MergeToNormalize)

2020-05-27 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118076#comment-17118076 ] Sean Busbey commented on HBASE-22285: - bq. Same comment re: this being a question for the release

  1   2   3   >