[GitHub] [hbase] Apache-HBase commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662832516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-662838726 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-662833671 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] WenFeiYi commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-23 Thread GitBox
WenFeiYi commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459233528 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -58,31 +58,31 @@ protected static final String

[GitHub] [hbase] Apache-HBase commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-662840010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] WenFeiYi commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-23 Thread GitBox
WenFeiYi commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459235284 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -58,31 +58,31 @@ protected static final String

[GitHub] [hbase] virajjasani commented on pull request #2120: Backport "HBASE-24696 Include JVM information on Web UI under "Software Attributes"" to branch-2.1

2020-07-23 Thread GitBox
virajjasani commented on pull request #2120: URL: https://github.com/apache/hbase/pull/2120#issuecomment-662862754 I think we don't have active builds for branch-2.1. This is an automated message from the Apache Git Service.

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163350#comment-17163350 ] Duo Zhang commented on HBASE-24759: --- [~pankajkumar] HBASE-22820 is the time where the only thing in

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-662907673 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163383#comment-17163383 ] Sun Xin commented on HBASE-24759: - In HBASE-24431 , an idea was mentioned {quote}Use special RSGroup

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163426#comment-17163426 ] Sun Xin commented on HBASE-24759: - I think the core problem you [~pankajkumar] had is that the system

[GitHub] [hbase] WenFeiYi commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-23 Thread GitBox
WenFeiYi commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459238534 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -58,31 +58,31 @@ protected static final String

[jira] [Assigned] (HBASE-24752) NPE/500 accessing webui on master startup

2020-07-23 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-24752: --- Assignee: wenfeiyi666 > NPE/500 accessing webui on master startup >

[jira] [Created] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Sun Xin (Jira)
Sun Xin created HBASE-24759: --- Summary: Persisting configuration of default rsgroup Key: HBASE-24759 URL: https://issues.apache.org/jira/browse/HBASE-24759 Project: HBase Issue Type: New Feature

[GitHub] [hbase] taklwu edited a comment on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
taklwu edited a comment on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662866824 yup, it should be only the case of ALL WALs (user table WAL and MasterRegion WALs) has been flushed but removed, it should have no data loss. You're right that the new set

[GitHub] [hbase] ddupg opened a new pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-07-23 Thread GitBox
ddupg opened a new pull request #2126: URL: https://github.com/apache/hbase/pull/2126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163346#comment-17163346 ] Pankaj Kumar commented on HBASE-24759: -- Any use case scenario to store additional info in default

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163415#comment-17163415 ] Duo Zhang commented on HBASE-11288: --- {quote} I’ll do my best to get ITBLL to pass. {quote} You do not

[jira] [Updated] (HBASE-24760) Allow system tables fallback to any rs groups

2020-07-23 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24760: Description: In HBASE-22738 we allow tables fallback to specific rs groups, If there is no online

[GitHub] [hbase] Apache9 commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
Apache9 commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662844100 I haven't gotten the point of 'Unknown Servers' here. When setting up a region server, we will create a WAL directory for it. And when restarting master, we will pull the

[GitHub] [hbase] virajjasani commented on pull request #2119: Backport "HBASE-24696 Include JVM information on Web UI under "Software Attributes"" to branch-2.2

2020-07-23 Thread GitBox
virajjasani commented on pull request #2119: URL: https://github.com/apache/hbase/pull/2119#issuecomment-662862203 Triggered one more run. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-662874012 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-23 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163315#comment-17163315 ] ramkrishna.s.vasudevan commented on HBASE-23634: We don't do that. If

[GitHub] [hbase] Apache-HBase commented on pull request #2122: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2122: URL: https://github.com/apache/hbase/pull/2122#issuecomment-662878052 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2124: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2124: URL: https://github.com/apache/hbase/pull/2124#issuecomment-662888285 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-662926329 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-23 Thread GitBox
ramkrish86 commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459374807 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -58,31 +58,31 @@ protected static final String

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-23 Thread GitBox
anoopsjohn commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459256398 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -58,31 +58,31 @@ protected static final String

[GitHub] [hbase] Apache9 commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
Apache9 commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662859269 OK, just saw this on jira > They were in a separate WAL directory. The assumption here is that all the data has been flushed and there is no data needing to be replayed

[GitHub] [hbase] taklwu commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
taklwu commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662866824 yup, it should be only the case of ALL WALs (user table WAL and MasterRegion WALs) has been flushed but removed, it should have no data loss. You're right that the new set of

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1716#comment-1716 ] Duo Zhang commented on HBASE-24759: --- Ah, this is a pain, hope we do not need to persist the region

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163342#comment-17163342 ] Sun Xin commented on HBASE-24759: - {quote}this is a pain, hope we do not need to persist the region

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-23 Thread Francis Christopher Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163398#comment-17163398 ] Francis Christopher Liu commented on HBASE-11288: - [~stack] and [~zhangduo] thank you

[GitHub] [hbase] Apache-HBase commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-662927465 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24759: Issue Type: Bug (was: New Feature) > Persisting configuration of default rsgroup >

[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-662867634 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache9 commented on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
Apache9 commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662876047 > You're right that the new set of region servers start on new environment that they are identified as 'Unknown server'. I think the old server will be unknown servers, not

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163356#comment-17163356 ] Pankaj Kumar commented on HBASE-24759: -- Yeah [~zhangduo], I'm inline to HBASE-24431. Persisting

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163420#comment-17163420 ] Anoop Sam John commented on HBASE-23634: The incomplete HFiles will be under the

[jira] [Created] (HBASE-24760) Allow system tables fallback to any rs groups

2020-07-23 Thread Sun Xin (Jira)
Sun Xin created HBASE-24760: --- Summary: Allow system tables fallback to any rs groups Key: HBASE-24760 URL: https://issues.apache.org/jira/browse/HBASE-24760 Project: HBase Issue Type: New Feature

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163290#comment-17163290 ] Anoop Sam John commented on HBASE-23634: bq.One question, if we only partially write an HFile

[jira] [Comment Edited] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163346#comment-17163346 ] Pankaj Kumar edited comment on HBASE-24759 at 7/23/20, 8:45 AM: Any use

[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories

2020-07-23 Thread gurmukh singh (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163371#comment-17163371 ] gurmukh singh commented on HBASE-22561: --- Thanks [~wchevreuil] , I am on 2.1.0. Will upgrade in the

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163438#comment-17163438 ] Anoop Sam John commented on HBASE-23634: bq.Then one issue is how the system can know whether it

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-662955563 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-662979595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163558#comment-17163558 ] Duo Zhang commented on HBASE-24749: --- IIRC there is a issue for storing the compacted files in HFile's

[jira] [Created] (HBASE-24762) Purge protobuf java 2.5.0 dependency

2020-07-23 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24762: - Summary: Purge protobuf java 2.5.0 dependency Key: HBASE-24762 URL: https://issues.apache.org/jira/browse/HBASE-24762 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #2122: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2122: URL: https://github.com/apache/hbase/pull/2122#issuecomment-662864609 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] taklwu edited a comment on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
taklwu edited a comment on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662866824 yup, it should be only the case of ALL WALs (user table WAL and MasterRegion WALs) has been flushed but removed, it should have no data loss. You're right that the new set

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-23 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163364#comment-17163364 ] Guanghao Zhang commented on HBASE-23634: {quote}We don't do that. If 'hbase.skip.errors' set to

[GitHub] [hbase] ramkrish86 commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-07-23 Thread GitBox
ramkrish86 commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-662916393 Seems the null check was causing some issues as the finally was not getting executed. This is an automated

[jira] [Commented] (HBASE-24759) Persisting configuration of default rsgroup

2020-07-23 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163396#comment-17163396 ] Pankaj Kumar commented on HBASE-24759: -- Ok, got it..  Recently we met a blocking issue (in

[jira] [Commented] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163417#comment-17163417 ] Hudson commented on HBASE-24696: Results for branch branch-1 [build #1332 on

[GitHub] [hbase] anoopsjohn edited a comment on pull request #2113: HBASE-24286: HMaster won't become healthy after after cloning or crea…

2020-07-23 Thread GitBox
anoopsjohn edited a comment on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662958329 >Typically, you can just disable all the tables, restart the whole cluster on a new environment, and then enable all the tables. Agree to Duo. That might be a

[jira] [Commented] (HBASE-24632) Enable procedure-based log splitting as default in hbase3

2020-07-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163551#comment-17163551 ] Anoop Sam John commented on HBASE-24632: So for every WAL file, it will add a sub procedure in

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163552#comment-17163552 ] ramkrishna.s.vasudevan commented on HBASE-24749: I think in flushes this is possible to

[jira] [Updated] (HBASE-24665) MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

2020-07-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-24665: --- Summary: MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll (was: all

[GitHub] [hbase] Apache-HBase commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-662978376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Work started] (HBASE-24757) ReplicationSink should limit the batch size for batch mutations based on hbase.rpc.rows.warning.threshold

2020-07-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24757 started by Viraj Jasani. > ReplicationSink should limit the batch size for batch mutations based on >

[GitHub] [hbase] brfrn169 commented on pull request #2094: HBASE-24680 Refactor the checkAndMutate code on the server side

2020-07-23 Thread GitBox
brfrn169 commented on pull request #2094: URL: https://github.com/apache/hbase/pull/2094#issuecomment-663010093 @joshelser Thank you very much for reviewing this! I will wait for any other opinions/objections until tomorrow. If nothing, will commit this.

[jira] [Resolved] (HBASE-24761) Support hadoop 3.3.0

2020-07-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24761. --- Resolution: Duplicate > Support hadoop 3.3.0 > > > Key:

[jira] [Updated] (HBASE-24762) Purge protobuf java 2.5.0 dependency

2020-07-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24762: -- Parent Issue: HBASE-22953 (was: HBASE-24761) > Purge protobuf java 2.5.0 dependency >

[GitHub] [hbase] Apache-HBase commented on pull request #2127: HBASE-24757 : ReplicationSink should limit row size in batch mutation based on hbase.rpc.rows.warning.threshold

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2127: URL: https://github.com/apache/hbase/pull/2127#issuecomment-663023627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-19256) [hbase-thirdparty] shade jetty

2020-07-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163611#comment-17163611 ] Duo Zhang commented on HBASE-19256: --- Hadoop 3.3.0 is out. Let's move forward. [~weichiu] Hope you do

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-23 Thread GitBox
ramkrish86 commented on a change in pull request #2021: URL: https://github.com/apache/hbase/pull/2021#discussion_r459384595 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java ## @@ -148,53 +147,49 @@ private void abort(String reason,

[jira] [Commented] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-23 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163464#comment-17163464 ] Anoop Sam John commented on HBASE-24665: Will wait till tomorrow if we have any more comments.

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-662962818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2119: Backport "HBASE-24696 Include JVM information on Web UI under "Software Attributes"" to branch-2.2

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2119: URL: https://github.com/apache/hbase/pull/2119#issuecomment-662966432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-662975082 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2094: HBASE-24680 Refactor the checkAndMutate code on the server side

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2094: URL: https://github.com/apache/hbase/pull/2094#issuecomment-663032975 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] Apache-HBase commented on pull request #2125: HBASE-24713 RS startup with FSHLog throws NPE after HBASE-21751

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2125: URL: https://github.com/apache/hbase/pull/2125#issuecomment-662980878 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani opened a new pull request #2127: HBASE-24757 : ReplicationSink should limit row size in batch mutation based on hbase.rpc.rows.warning.threshold

2020-07-23 Thread GitBox
virajjasani opened a new pull request #2127: URL: https://github.com/apache/hbase/pull/2127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (HBASE-23285) walArchiveDir does not exist when separate the old WALs into different regionserver directories

2020-07-23 Thread xuqinya (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuqinya updated HBASE-23285: Summary: walArchiveDir does not exist when separate the old WALs into different regionserver directories

[jira] [Created] (HBASE-24761) Support hadoop 3.3.0

2020-07-23 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24761: - Summary: Support hadoop 3.3.0 Key: HBASE-24761 URL: https://issues.apache.org/jira/browse/HBASE-24761 Project: HBase Issue Type: Umbrella Components:

[GitHub] [hbase] Apache9 opened a new pull request #2128: HBASE-24762 Purge protobuf java 2.5.0 dependency

2020-07-23 Thread GitBox
Apache9 opened a new pull request #2128: URL: https://github.com/apache/hbase/pull/2128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-15519) Add per-user metrics

2020-07-23 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164035#comment-17164035 ] Michael Stack commented on HBASE-15519: --- Let me set the default as off. It seems like the lossy

[GitHub] [hbase] Apache-HBase commented on pull request #2130: HBASE-24765: Dynamic master discovery

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2130: URL: https://github.com/apache/hbase/pull/2130#issuecomment-663289529 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164037#comment-17164037 ] Tak-Lon (Stephen) Wu commented on HBASE-24749: -- bq. If an HFile is written successfully but

[jira] [Comment Edited] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164037#comment-17164037 ] Tak-Lon (Stephen) Wu edited comment on HBASE-24749 at 7/24/20, 12:03 AM:

[GitHub] [hbase] infraio merged pull request #2122: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-23 Thread GitBox
infraio merged pull request #2122: URL: https://github.com/apache/hbase/pull/2122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack opened a new pull request #2132: HBASE-24767 Change default to false for HBASE-15519 per-user metrics

2020-07-23 Thread GitBox
saintstack opened a new pull request #2132: URL: https://github.com/apache/hbase/pull/2132 Set hbase.regionserver.user.metrics.enabled default to false; i.e. off. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] infraio commented on pull request #2122: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-23 Thread GitBox
infraio commented on pull request #2122: URL: https://github.com/apache/hbase/pull/2122#issuecomment-663291310 Ok. All UT passed. Let me merge it. This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164048#comment-17164048 ] Guanghao Zhang edited comment on HBASE-24749 at 7/24/20, 12:19 AM: ---

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-23 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164052#comment-17164052 ] Guanghao Zhang commented on HBASE-23634: {quote}Say if HFile was placed under

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-23 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164059#comment-17164059 ] Zach York commented on HBASE-11288: --- Since (as Duo pointed out) this is relevant to the work to store

[GitHub] [hbase] Apache-HBase commented on pull request #2132: HBASE-24767 Change default to false for HBASE-15519 per-user metrics

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2132: URL: https://github.com/apache/hbase/pull/2132#issuecomment-663302313 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2131: HBASE-24766 Document Remote Procedure Execution

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2131: URL: https://github.com/apache/hbase/pull/2131#issuecomment-663288955 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164041#comment-17164041 ] Hudson commented on HBASE-24696: Results for branch branch-2.2 [build #918 on

[jira] [Commented] (HBASE-24675) On Master restart all servers are assigned to default rsgroup.

2020-07-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164042#comment-17164042 ] Hudson commented on HBASE-24675: Results for branch branch-2.2 [build #918 on

[jira] [Created] (HBASE-24767) Change default to false for HBASE-15519 per-user metrics

2020-07-23 Thread Michael Stack (Jira)
Michael Stack created HBASE-24767: - Summary: Change default to false for HBASE-15519 per-user metrics Key: HBASE-24767 URL: https://issues.apache.org/jira/browse/HBASE-24767 Project: HBase

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164039#comment-17164039 ] Zach York commented on HBASE-24749: --- [~anoop.hbase] Can you expand on how we can get in a situation

[jira] [Comment Edited] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164037#comment-17164037 ] Tak-Lon (Stephen) Wu edited comment on HBASE-24749 at 7/24/20, 12:03 AM:

[GitHub] [hbase] infraio merged pull request #2124: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-23 Thread GitBox
infraio merged pull request #2124: URL: https://github.com/apache/hbase/pull/2124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on pull request #2124: HBASE-24743 Reject to add a peer which replicate to itself earlier

2020-07-23 Thread GitBox
infraio commented on pull request #2124: URL: https://github.com/apache/hbase/pull/2124#issuecomment-663291501 Ok. All ut passed. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (HBASE-24743) Reject to add a peer which replicate to itself earlier

2020-07-23 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24743. Resolution: Fixed All ut passed. Pushed to branch-2 and master. > Reject to add a peer

[jira] [Comment Edited] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164048#comment-17164048 ] Guanghao Zhang edited comment on HBASE-24749 at 7/24/20, 12:18 AM: ---

[jira] [Commented] (HBASE-24749) Direct insert HFiles and Persist in-memory HFile tracking

2020-07-23 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164048#comment-17164048 ] Guanghao Zhang commented on HBASE-24749: {quote}bq. it should be HBASE-20724, so for compaction

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-23 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164054#comment-17164054 ] Michael Stack commented on HBASE-23634: --- IIRC recovered.edits system does the right thing. >

[GitHub] [hbase] Apache-HBase commented on pull request #2130: HBASE-24765: Dynamic master discovery

2020-07-23 Thread GitBox
Apache-HBase commented on pull request #2130: URL: https://github.com/apache/hbase/pull/2130#issuecomment-663301795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   3   >