[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR
[
https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258729#comment-17258729
]
Hudson commented on HBASE-25447:
Results for branch master
[build #175 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> remoteProc is suspended due to OOM ERROR
>
>
> Key: HBASE-25447
> URL: https://issues.apache.org/jira/browse/HBASE-25447
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Affects Versions: 3.0.0-alpha-1, 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image-2020-12-26-11-49-38-018.png
>
>
> https://github.com/apache/hbase/blob/0f868da05d7ffabe4512a0cae110ed097b033ebf/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L317
> If resource leakage occurs due to other components or reasons,
> BufferNode#dispatch() may fail. and then TimeoutExecutorThread will exit the
> while (running.get()), and some procs will stuck...
> !image-2020-12-26-11-49-38-018.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25457) Possible race in AsyncConnectionImpl between getChoreService and close
[
https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258728#comment-17258728
]
Hudson commented on HBASE-25457:
Results for branch master
[build #175 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/175/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Possible race in AsyncConnectionImpl between getChoreService and close
> --
>
> Key: HBASE-25457
> URL: https://issues.apache.org/jira/browse/HBASE-25457
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> On branch HBASE-22120, spotbugs reported a high priority error about this
> problem, but the problem also exists on master.
> Let's fix it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258691#comment-17258691 ] mokai commented on HBASE-25445: --- Got it. Thanks for the PR. > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > Attachments: ServerCrashWrongFSError.png > > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different > filesystem, SplitWALRemoteProcedure archived split WAL failed since > SplitWALManager using wrong fs instance. SplitWALManager should use WAL > corresponding fs instance. > Steps to Reproduce: > * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to > different fs instances. > * Start HBase with multiple RS. > * Create a couple of tables and some rows in them so that the RSs get > assigned with some regions. > * Take any RS with non-zero number of regions offline. > * Check master logs for "Wrong FS" error as shown in the screenshot > attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258685#comment-17258685 ] Viraj Jasani commented on HBASE-25445: -- [~mokai87] To avoid misunderstanding, we should assign Jira to ourself when we start working on it even if it is going to take more time coming up with PR. The longer we keep Jira unassigned, more contributors will assume that no one is working on Jira as of now and hence they can assign it to themselves. Once you assign Jira to yourself, no one will try to reassign Jira to them without your formal permission on Jira :) Thanks for filing this nice Jira! > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > Attachments: ServerCrashWrongFSError.png > > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different > filesystem, SplitWALRemoteProcedure archived split WAL failed since > SplitWALManager using wrong fs instance. SplitWALManager should use WAL > corresponding fs instance. > Steps to Reproduce: > * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to > different fs instances. > * Start HBase with multiple RS. > * Create a couple of tables and some rows in them so that the RSs get > assigned with some regions. > * Take any RS with non-zero number of regions offline. > * Check master logs for "Wrong FS" error as shown in the screenshot > attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-754415158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | master passed | | +1 :green_heart: | checkstyle | 1m 11s | master passed | | +1 :green_heart: | spotbugs | 2m 11s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | the patch passed | | +1 :green_heart: | checkstyle | 1m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 49m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2844 | | JIRA Issue | HBASE-25445 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux e6622e37ddf6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 600be60a4b | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-754409106 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | shadedjars | 6m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 6m 43s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 7m 7s | hbase-server in the patch failed. | | | | 34m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2844 | | JIRA Issue | HBASE-25445 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 12cca84bd54a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 600be60a4b | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/testReport/ | | Max. process+thread count | 726 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] dasanjan1296 commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager
dasanjan1296 commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-754405883 @ramkrish86 I have added some testing details in the corresponding [JIRA](https://issues.apache.org/jira/projects/HBASE/issues/HBASE-25445) for reproducing the error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly
Apache-HBase commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-754405005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | -0 :warning: | checkstyle | 1m 6s | hbase-server: The patch generated 6 new + 53 unchanged - 0 fixed = 59 total (was 53) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 2m 11s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 39m 31s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Dead store to allRegionInfos in org.apache.hadoop.hbase.regionserver.HRegionServer.getOnlineRegionInfos() At HRegionServer.java:org.apache.hadoop.hbase.regionserver.HRegionServer.getOnlineRegionInfos() At HRegionServer.java:[line 2956] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2843/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2843 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 28399e9669f1 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 600be60a4b | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2843/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2843/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2843/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-25460) Expose drainingServers as cluster metric
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhey Rana reassigned HBASE-25460: -- Assignee: Abhey Rana > Expose drainingServers as cluster metric > > > Key: HBASE-25460 > URL: https://issues.apache.org/jira/browse/HBASE-25460 > Project: HBase > Issue Type: New Feature >Affects Versions: 1.6.0, 2.4.0 >Reporter: Viraj Jasani >Assignee: Abhey Rana >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0 > > > Due to some reason, we had significantly high number of servers put in > decommissioned mode and for significant time, they continued being in the > same state serving no regions at all. This put heavy load on rest of live > servers and it was too late before one could recognize the issues with > improper balancing of the cluster. And as expected, balancing such cluster > with/without *runMaxSteps* can bring up sudden spike of RITs in proportion to > the degree of imbalanced regions in the cluster. > Although running into such situation is rare, we can take some precautions by > exposing metric. We should expose list of draining RegionServers as jmx > metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. > Such metric can help configure alerts with threshold on % of total RS that > are allowed to go in draining mode (e.g during rolling upgrades) in any > circumstances. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258665#comment-17258665 ] Anjan Das commented on HBASE-25445: --- [~vjasani] [~mokai87] I have raised a PR with the fix. Please take a look. > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > Attachments: ServerCrashWrongFSError.png > > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different > filesystem, SplitWALRemoteProcedure archived split WAL failed since > SplitWALManager using wrong fs instance. SplitWALManager should use WAL > corresponding fs instance. > Steps to Reproduce: > * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to > different fs instances. > * Start HBase with multiple RS. > * Create a couple of tables and some rows in them so that the RSs get > assigned with some regions. > * Take any RS with non-zero number of regions offline. > * Check master logs for "Wrong FS" error as shown in the screenshot > attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] dasanjan1296 closed pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager
dasanjan1296 closed pull request #2844: URL: https://github.com/apache/hbase/pull/2844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Affects Version/s: 2.4.0 > Expose drainingServers as cluster metric > > > Key: HBASE-25460 > URL: https://issues.apache.org/jira/browse/HBASE-25460 > Project: HBase > Issue Type: New Feature >Affects Versions: 1.6.0, 2.4.0 >Reporter: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0 > > > Due to some reason, we had significantly high number of servers put in > decommissioned mode and for significant time, they continued being in the > same state serving no regions at all. This put heavy load on rest of live > servers and it was too late before one could recognize the issues with > improper balancing of the cluster. And as expected, balancing such cluster > with/without *runMaxSteps* can bring up sudden spike of RITs in proportion to > the degree of imbalanced regions in the cluster. > Although running into such situation is rare, we can take some precautions by > exposing metric. We should expose list of draining RegionServers as jmx > metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. > Such metric can help configure alerts with threshold on % of total RS that > are allowed to go in draining mode (e.g during rolling upgrades) in any > circumstances. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] dasanjan1296 opened a new pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager
dasanjan1296 opened a new pull request #2844: URL: https://github.com/apache/hbase/pull/2844 - If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem instances, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Description: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, SplitWALRemoteProcedure split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. Steps to Reproduce: * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to different fs instances. * Start HBase with multiple RS. * Create a couple of tables and some rows in them so that the RSs get assigned with some regions. * Take any RS with non-zero number of regions offline. * Check master logs for "Wrong FS" error as shown in the screenshot attached. was: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. Steps to Reproduce: * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to different fs instances. * Start HBase with multiple RS. * Create a couple of tables and some rows in them so that the RSs get assigned with some regions. * Take any RS with non-zero number of regions offline. * Check master logs for "Wrong FS" error as shown in the screenshot attached. > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > Attachments: ServerCrashWrongFSError.png > > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different > filesystem, SplitWALRemoteProcedure split WAL failed since SplitWALManager > using wrong fs instance. SplitWALManager should use WAL corresponding fs > instance. > Steps to Reproduce: > * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to > different fs instances. > * Start HBase with multiple RS. > * Create a couple of tables and some rows in them so that the RSs get > assigned with some regions. > * Take any RS with non-zero number of regions offline. > * Check master logs for "Wrong FS" error as shown in the screenshot > attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Description: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. Steps to Reproduce: * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to different fs instances. * Start HBase with multiple RS. * Create a couple of tables and some rows in them so that the RSs get assigned with some regions. * Take any RS with non-zero number of regions offline. * Check master logs for "Wrong FS" error as shown in the screenshot attached. was: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, SplitWALRemoteProcedure split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. Steps to Reproduce: * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to different fs instances. * Start HBase with multiple RS. * Create a couple of tables and some rows in them so that the RSs get assigned with some regions. * Take any RS with non-zero number of regions offline. * Check master logs for "Wrong FS" error as shown in the screenshot attached. > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > Attachments: ServerCrashWrongFSError.png > > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different > filesystem, SplitWALRemoteProcedure archived split WAL failed since > SplitWALManager using wrong fs instance. SplitWALManager should use WAL > corresponding fs instance. > Steps to Reproduce: > * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to > different fs instances. > * Start HBase with multiple RS. > * Create a couple of tables and some rows in them so that the RSs get > assigned with some regions. > * Take any RS with non-zero number of regions offline. > * Check master logs for "Wrong FS" error as shown in the screenshot > attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] cuibo01 opened a new pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly
cuibo01 opened a new pull request #2843: URL: https://github.com/apache/hbase/pull/2843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Description: If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. Steps to Reproduce: * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to different fs instances. * Start HBase with multiple RS. * Create a couple of tables and some rows in them so that the RSs get assigned with some regions. * Take any RS with non-zero number of regions offline. * Check master logs for "Wrong FS" error as shown in the screenshot attached. was:If 'hbase.wal.dir' and 'hbase.rootdir' are configured to diffrent filesystem, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > Attachments: ServerCrashWrongFSError.png > > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different > filesystem, SplitWALRemoteProcedure archived split WAL failed since > SplitWALManager using wrong fs instance. SplitWALManager should use WAL > corresponding fs instance. > Steps to Reproduce: > * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to > different fs instances. > * Start HBase with multiple RS. > * Create a couple of tables and some rows in them so that the RSs get > assigned with some regions. > * Take any RS with non-zero number of regions offline. > * Check master logs for "Wrong FS" error as shown in the screenshot > attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated HBASE-25445: -- Attachment: ServerCrashWrongFSError.png > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > Attachments: ServerCrashWrongFSError.png > > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different > filesystem, SplitWALRemoteProcedure archived split WAL failed since > SplitWALManager using wrong fs instance. SplitWALManager should use WAL > corresponding fs instance. > Steps to Reproduce: > * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to > different fs instances. > * Start HBase with multiple RS. > * Create a couple of tables and some rows in them so that the RSs get > assigned with some regions. > * Take any RS with non-zero number of regions offline. > * Check master logs for "Wrong FS" error as shown in the screenshot > attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25445 started by Anjan Das. - > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to diffrent filesystem, > SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using > wrong fs instance. SplitWALManager should use WAL corresponding fs instance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25461) when the cluster has many tables, UI can't be opened quickly
[ https://issues.apache.org/jira/browse/HBASE-25461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25461: - Summary: when the cluster has many tables, UI can't be opened quickly (was: when the cluster has many tables, UI can be opened quickly) > when the cluster has many tables, UI can't be opened quickly > > > Key: HBASE-25461 > URL: https://issues.apache.org/jira/browse/HBASE-25461 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > > my cluster has 60+K tables, and UI is opened slowly. > From the following code, we can reduce steps of class conversion > rsgroup.jsp > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/rsgroup.jsp#L439 > snapshot.jsp > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp#L42 > RegionStates.java > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L538 > RSStatusTmpl.jamon > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon#L47 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] leyangyueshan edited a comment on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
leyangyueshan edited a comment on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-754344918 @saintstack @virajjasani Could you help to review this pr? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan commented on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
leyangyueshan commented on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-754344918 @saintstack @virajjasani please review ! thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
leyangyueshan commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-754343634 - [ ] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan closed pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
leyangyueshan closed pull request #2842: URL: https://github.com/apache/hbase/pull/2842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
leyangyueshan commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-754342388 > I don't think we should add logic dealing with the specifics of a 3rd party project (phoenix) into hbase wal handling. > > What about changing HBase WALFactory to allow pluggable custom wal providers implementations? Then this phoenix specific logic could be implemented on a Phoenix wal provider, keeping hbase agnostic to phoenix. AbstractFSWALProvider/WALProvider interfaces are all marked as IA Private, though, so it would be challenging maintain compatibility of custom wal providers. I think you are right! I will close this pr! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25457) Possible race in AsyncConnectionImpl between getChoreService and close
[
https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258624#comment-17258624
]
Hudson commented on HBASE-25457:
Results for branch branch-2.4
[build #22 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Possible race in AsyncConnectionImpl between getChoreService and close
> --
>
> Key: HBASE-25457
> URL: https://issues.apache.org/jira/browse/HBASE-25457
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> On branch HBASE-22120, spotbugs reported a high priority error about this
> problem, but the problem also exists on master.
> Let's fix it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25435) Slow metric value can be configured
[
https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258623#comment-17258623
]
Hudson commented on HBASE-25435:
Results for branch branch-2.4
[build #22 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/22/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Slow metric value can be configured
> ---
>
> Key: HBASE-25435
> URL: https://issues.apache.org/jira/browse/HBASE-25435
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: xijiawen
>Assignee: xijiawen
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.4, 2.5.0, 2.4.1
>
>
> The slow time in MetricsRegionServer is hard code (value :1000)
> it's should be configured when some cluster is sensitived
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-25461) when the cluster has many tables, UI can be opened quickly
[ https://issues.apache.org/jira/browse/HBASE-25461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-25461: -- Assignee: Bo Cui > when the cluster has many tables, UI can be opened quickly > -- > > Key: HBASE-25461 > URL: https://issues.apache.org/jira/browse/HBASE-25461 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > > my cluster has 60+K tables, and UI is opened slowly. > From the following code, we can reduce steps of class conversion > rsgroup.jsp > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/rsgroup.jsp#L439 > snapshot.jsp > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp#L42 > RegionStates.java > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L538 > RSStatusTmpl.jamon > https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon#L47 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25461) when the cluster has many tables, UI can be opened quickly
Bo Cui created HBASE-25461: -- Summary: when the cluster has many tables, UI can be opened quickly Key: HBASE-25461 URL: https://issues.apache.org/jira/browse/HBASE-25461 Project: HBase Issue Type: Improvement Components: UI Affects Versions: 3.0.0-alpha-1 Reporter: Bo Cui my cluster has 60+K tables, and UI is opened slowly. >From the following code, we can reduce steps of class conversion rsgroup.jsp https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/rsgroup.jsp#L439 snapshot.jsp https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp#L42 RegionStates.java https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L538 RSStatusTmpl.jamon https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon#L47 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] z-york commented on pull request #2800: HBASE-25249 Adding StoreContext
z-york commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-754322209 LGTM. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext
taklwu commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r551656699
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreContext.java
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.CellComparator;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileContext;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import java.net.InetSocketAddress;
+import java.util.Collection;
+import java.util.function.Supplier;
+
+/**
+ * This carries the information on some of the meta data about the HStore. This
+ * meta data can be used across the HFileWriter/Readers and other HStore
consumers without the
+ * need of passing around the complete store.
+ */
+@InterfaceAudience.Private
+public class HStoreContext {
Review comment:
fixed and implemented `heapSize()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext
taklwu commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r551656590
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##
@@ -2559,7 +2572,7 @@ public boolean needsCompaction() {
* @return cache configuration for this Store.
*/
public CacheConfig getCacheConfig() {
-return this.cacheConf;
+return storeContext.getCacheConf();
}
public static final long FIXED_OVERHEAD =
ClassSize.estimateBase(HStore.class, false);
Review comment:
this has been change as well, can you have another look ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext
taklwu commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r551656408
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##
@@ -474,33 +501,14 @@ public long getBlockingFileCount() {
}
/* End implementation of StoreConfigInformation */
- /**
- * Returns the configured bytesPerChecksum value.
- * @param conf The configuration
- * @return The bytesPerChecksum that is set in the configuration
- */
- public static int getBytesPerChecksum(Configuration conf) {
-return conf.getInt(HConstants.BYTES_PER_CHECKSUM,
- HFile.DEFAULT_BYTES_PER_CHECKSUM);
- }
-
- /**
- * Returns the configured checksum algorithm.
- * @param conf The configuration
- * @return The checksum algorithm that is set in the configuration
- */
- public static ChecksumType getChecksumType(Configuration conf) {
-String checksumName = conf.get(HConstants.CHECKSUM_TYPE_NAME);
-if (checksumName == null) {
- return ChecksumType.getDefaultChecksumType();
-} else {
- return ChecksumType.nameToType(checksumName);
-}
- }
@Override
public ColumnFamilyDescriptor getColumnFamilyDescriptor() {
-return this.family;
+return this.storeContext.getFamily();
+ }
+
+ public Encryption.Context getCryptoContext() {
Review comment:
I have changed that in the latest update, please see if you have more
comments, and I marked it as resolved first
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] caroliney14 commented on pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time
caroliney14 commented on pull request #2762: URL: https://github.com/apache/hbase/pull/2762#issuecomment-754316224 @virajjasani @bharathv do you mind taking a look at this? thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] caroliney14 commented on pull request #2770: HBASE-25032 Wait for region server to become online before adding it to online servers in Master
caroliney14 commented on pull request #2770: URL: https://github.com/apache/hbase/pull/2770#issuecomment-754316052 @virajjasani @bharathv do you mind taking a look at this and sharing your thoughts? thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Description: Due to some reason, we had significantly high number of servers put in decommissioned mode and for significant time, they continued being in the same state serving no regions at all. This put heavy load on rest of live servers and it was too late before one could recognize the issues with improper balancing of the cluster. And as expected, balancing such cluster with/without *runMaxSteps* can bring up sudden spike of RITs in proportion to the degree of imbalanced regions in the cluster. Although running into such situation is rare, we can take some precautions by exposing metric. We should expose list of draining RegionServers as jmx metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. Such metric can help configure alerts with threshold on % of total RS that are allowed to go in draining mode (e.g during rolling upgrades) in any circumstances. was: Due to some reason, we had significantly high number of servers put in decommissioned mode and for significant time, they continued being in the same state serving no regions at all. This put heavy load on rest of live servers and it was too late before one could recognize the issues with improper balancing of the cluster. The cluster was imbalanced to the point where SLB was not balancing the cluster until one turns on *_hbase.master.balancer.stochastic.runMaxSteps_* because calculated steps were too high. And as expected, such balancing brings up sudden spike of RITs immediately. Although running into such situation is rare, we can take some precautions by exposing metric. We should expose list of draining RegionServers as jmx metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. Such metric can help configure alerts with threshold on % of total RS that are allowed to go in draining mode (e.g during rolling upgrades) in any circumstances. > Expose drainingServers as cluster metric > > > Key: HBASE-25460 > URL: https://issues.apache.org/jira/browse/HBASE-25460 > Project: HBase > Issue Type: New Feature >Affects Versions: 1.6.0 >Reporter: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0 > > > Due to some reason, we had significantly high number of servers put in > decommissioned mode and for significant time, they continued being in the > same state serving no regions at all. This put heavy load on rest of live > servers and it was too late before one could recognize the issues with > improper balancing of the cluster. And as expected, balancing such cluster > with/without *runMaxSteps* can bring up sudden spike of RITs in proportion to > the degree of imbalanced regions in the cluster. > Although running into such situation is rare, we can take some precautions by > exposing metric. We should expose list of draining RegionServers as jmx > metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. > Such metric can help configure alerts with threshold on % of total RS that > are allowed to go in draining mode (e.g during rolling upgrades) in any > circumstances. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] apurtell commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…
apurtell commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-754165376 @Apache9 Yes the issue is mostly the dependency on Guava. For documenting why a method is visible, unless there is some static analysis (which we don't have and don't use) an annotation is literally just text, no better than a comment placed at the same place in the file. This is not arguable. However as long as we are not taking a (again IMHO useless) Guava dependency for this purpose, I don't have a strong opinion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25435) Slow metric value can be configured
[
https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258434#comment-17258434
]
Hudson commented on HBASE-25435:
Results for branch branch-2
[build #146 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/146/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/146/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/146/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/146/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/146/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Slow metric value can be configured
> ---
>
> Key: HBASE-25435
> URL: https://issues.apache.org/jira/browse/HBASE-25435
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: xijiawen
>Assignee: xijiawen
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.4, 2.5.0, 2.4.1
>
>
> The slow time in MetricsRegionServer is hard code (value :1000)
> it's should be configured when some cluster is sensitived
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Fix Version/s: 2.5.0 1.7.0 3.0.0-alpha-1 > Expose drainingServers as cluster metric > > > Key: HBASE-25460 > URL: https://issues.apache.org/jira/browse/HBASE-25460 > Project: HBase > Issue Type: New Feature >Affects Versions: 1.6.0 >Reporter: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0 > > > Due to some reason, we had significantly high number of servers put in > decommissioned mode and for significant time, they continued being in the > same state serving no regions at all. This put heavy load on rest of live > servers and it was too late before one could recognize the issues with > improper balancing of the cluster. The cluster was imbalanced to the point > where SLB was not balancing the cluster until one turns on > *_hbase.master.balancer.stochastic.runMaxSteps_* because calculated steps > were too high. And as expected, such balancing brings up sudden spike of RITs > immediately. > Although running into such situation is rare, we can take some precautions by > exposing metric. We should expose list of draining RegionServers as jmx > metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. > Such metric can help configure alerts with threshold on % of total RS that > are allowed to go in draining mode (e.g during rolling upgrades) in any > circumstances. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25460) Expose drainingServers as cluster metric
[ https://issues.apache.org/jira/browse/HBASE-25460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25460: - Affects Version/s: 1.6.0 > Expose drainingServers as cluster metric > > > Key: HBASE-25460 > URL: https://issues.apache.org/jira/browse/HBASE-25460 > Project: HBase > Issue Type: New Feature >Affects Versions: 1.6.0 >Reporter: Viraj Jasani >Priority: Major > > Due to some reason, we had significantly high number of servers put in > decommissioned mode and for significant time, they continued being in the > same state serving no regions at all. This put heavy load on rest of live > servers and it was too late before one could recognize the issues with > improper balancing of the cluster. The cluster was imbalanced to the point > where SLB was not balancing the cluster until one turns on > *_hbase.master.balancer.stochastic.runMaxSteps_* because calculated steps > were too high. And as expected, such balancing brings up sudden spike of RITs > immediately. > Although running into such situation is rare, we can take some precautions by > exposing metric. We should expose list of draining RegionServers as jmx > metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. > Such metric can help configure alerts with threshold on % of total RS that > are allowed to go in draining mode (e.g during rolling upgrades) in any > circumstances. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25460) Expose drainingServers as cluster metric
Viraj Jasani created HBASE-25460: Summary: Expose drainingServers as cluster metric Key: HBASE-25460 URL: https://issues.apache.org/jira/browse/HBASE-25460 Project: HBase Issue Type: New Feature Reporter: Viraj Jasani Due to some reason, we had significantly high number of servers put in decommissioned mode and for significant time, they continued being in the same state serving no regions at all. This put heavy load on rest of live servers and it was too late before one could recognize the issues with improper balancing of the cluster. The cluster was imbalanced to the point where SLB was not balancing the cluster until one turns on *_hbase.master.balancer.stochastic.runMaxSteps_* because calculated steps were too high. And as expected, such balancing brings up sudden spike of RITs immediately. Although running into such situation is rare, we can take some precautions by exposing metric. We should expose list of draining RegionServers as jmx metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. Such metric can help configure alerts with threshold on % of total RS that are allowed to go in draining mode (e.g during rolling upgrades) in any circumstances. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-754148230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | master passed | | +1 :green_heart: | compile | 1m 9s | master passed | | +1 :green_heart: | shadedjars | 7m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 24s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 6m 58s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 45s | hbase-server in the patch passed. | | | | 169m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2313 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4b73703a21a8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 600be60a4b | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/testReport/ | | Max. process+thread count | 3867 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-754147518 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | shadedjars | 6m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 6m 58s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 53s | hbase-server in the patch passed. | | | | 168m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2313 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 55cc8b7360b5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 600be60a4b | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/testReport/ | | Max. process+thread count | 4353 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24813) ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination
[ https://issues.apache.org/jira/browse/HBASE-24813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258356#comment-17258356 ] Josh Elser commented on HBASE-24813: This should be re-resolved since the bug was addressed in HBASE-25117, yes? > ReplicationSource should clear buffer usage on ReplicationSourceManager upon > termination > > > Key: HBASE-24813 > URL: https://issues.apache.org/jira/browse/HBASE-24813 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0-alpha-1, 2.3.1, 2.2.6 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0 > > Attachments: TestReplicationSyncUpTool.log, > image-2020-10-09-10-50-00-372.png > > > Following investigations on the issue described by [~elserj] on HBASE-24779, > we found out that once a peer is removed, thus killing peers related > *ReplicationSource* instance, it may leave > *ReplicationSourceManager.totalBufferUsed* inconsistent. This can happen if > *ReplicationSourceWALReader* had put some entries on its queue to be > processed by *ReplicationSourceShipper,* but the peer removal killed the > shipper before it could process the pending entries. When > *ReplicationSourceWALReader* thread add entries to the queue, it increments > *ReplicationSourceManager.totalBufferUsed* with the sum of the entries sizes. > When those entries are read by *ReplicationSourceShipper,* > *ReplicationSourceManager.totalBufferUsed* is then decreased. We should also > decrease *ReplicationSourceManager.totalBufferUsed* when *ReplicationSource* > is terminated, otherwise those unprocessed entries size would be consuming > *ReplicationSourceManager.totalBufferUsed __*indefinitely, unless the RS gets > restarted. This may be a problem for deployments with multiple peers, or if > new peers are added.** -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25435) Slow metric value can be configured
[
https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258328#comment-17258328
]
Hudson commented on HBASE-25435:
Results for branch branch-2.3
[build #138 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/138/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/138/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/138/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/138/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/138/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Slow metric value can be configured
> ---
>
> Key: HBASE-25435
> URL: https://issues.apache.org/jira/browse/HBASE-25435
> Project: HBase
> Issue Type: Improvement
> Components: metrics
>Reporter: xijiawen
>Assignee: xijiawen
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.4, 2.5.0, 2.4.1
>
>
> The slow time in MetricsRegionServer is hard code (value :1000)
> it's should be configured when some cluster is sensitived
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-754080913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 2m 2s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 1m 4s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 40m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2313 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux f3c054dcc249 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 600be60a4b | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2313/6/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258292#comment-17258292 ] Pankaj Kumar commented on HBASE-25447: -- Ping [~zghao], [~ndimiduk] & [~andrew.purt...@gmail.com] shall we merge this in 2.2, 2.3 & 2.4 branches? > remoteProc is suspended due to OOM ERROR > > > Key: HBASE-25447 > URL: https://issues.apache.org/jira/browse/HBASE-25447 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > Attachments: image-2020-12-26-11-49-38-018.png > > > https://github.com/apache/hbase/blob/0f868da05d7ffabe4512a0cae110ed097b033ebf/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L317 > If resource leakage occurs due to other components or reasons, > BufferNode#dispatch() may fail. and then TimeoutExecutorThread will exit the > while (running.get()), and some procs will stuck... > !image-2020-12-26-11-49-38-018.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258291#comment-17258291 ] Pankaj Kumar commented on HBASE-25447: -- Pushed to master & branch-2, thanks [~zhangduo] & [~stack] for the review. > remoteProc is suspended due to OOM ERROR > > > Key: HBASE-25447 > URL: https://issues.apache.org/jira/browse/HBASE-25447 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Attachments: image-2020-12-26-11-49-38-018.png > > > https://github.com/apache/hbase/blob/0f868da05d7ffabe4512a0cae110ed097b033ebf/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L317 > If resource leakage occurs due to other components or reasons, > BufferNode#dispatch() may fail. and then TimeoutExecutorThread will exit the > while (running.get()), and some procs will stuck... > !image-2020-12-26-11-49-38-018.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25447) remoteProc is suspended due to OOM ERROR
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25447: - Fix Version/s: 2.5.0 3.0.0-alpha-1 > remoteProc is suspended due to OOM ERROR > > > Key: HBASE-25447 > URL: https://issues.apache.org/jira/browse/HBASE-25447 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > Attachments: image-2020-12-26-11-49-38-018.png > > > https://github.com/apache/hbase/blob/0f868da05d7ffabe4512a0cae110ed097b033ebf/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L317 > If resource leakage occurs due to other components or reasons, > BufferNode#dispatch() may fail. and then TimeoutExecutorThread will exit the > while (running.get()), and some procs will stuck... > !image-2020-12-26-11-49-38-018.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] pankaj72981 merged pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR
pankaj72981 merged pull request #2824: URL: https://github.com/apache/hbase/pull/2824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache9 merged pull request #2839: URL: https://github.com/apache/hbase/pull/2839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-754022194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | master passed | | +1 :green_heart: | checkstyle | 0m 25s | master passed | | +1 :green_heart: | spotbugs | 1m 4s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | checkstyle | 0m 26s | hbase-client: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 24s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 1m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 35m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2839 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 7b9ea19a48e2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-754016926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 0m 31s | master passed | | +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | shadedjars | 6m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. | | | | 26m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2839 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a66739271cc7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/testReport/ | | Max. process+thread count | 282 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-754016644 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 7m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 32s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed | | +1 :green_heart: | javac | 0m 28s | the patch passed | | +1 :green_heart: | shadedjars | 6m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. | | | | 25m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2839 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1f0c8bfa4b88 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/testReport/ | | Max. process+thread count | 340 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25439) Add BYTE unit in PrettyPrinter.Unit
[
https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258198#comment-17258198
]
Hudson commented on HBASE-25439:
Results for branch master
[build #174 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/174/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/174/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/174/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/174/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add BYTE unit in PrettyPrinter.Unit
>
>
> Key: HBASE-25439
> URL: https://issues.apache.org/jira/browse/HBASE-25439
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
> Attachments: image-2020-12-23-16-12-42-210.png
>
>
> Currently only TTL supports PrettyPrinter, and MAX_FILESIZE is not human
> readable：
> !image-2020-12-23-16-12-42-210.png!
> This issue add a new unit 'BYTE' to pretty print value of size, such as
> MAX_FILESIZE, MEMSTORE_FLUSHSIZE.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25130) Masters in-memory serverHoldings map is not cleared during hbck repair
[
https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258189#comment-17258189
]
Rahul Kumar edited comment on HBASE-25130 at 1/4/21, 1:01 PM:
--
Possible approaches I could think of tackling the above issue:
1. Remove the the region entry from serverHolding map in case of mergeOverlap
repair.
* Once deleteMetaRegion() gets executed, we can call HbckRepair to remove the
region from serverHoldings.
* Here HbckRepair would call ServerManager and ServerManager will manage to
call AssignmentManager to remove the region entry from serverHolding map via
RegionStates.
2. Keep cleaning out the unwanted entries from serverHoldings map via chore
cleaner, if the entries for the region is not present in META. This could be an
expensive operation, also would it be safe to cleanup based on the above logic ?
[~apurtell] [~vjasani] Please let me know your feedback on the above
approaches or if we can handle it better. Thanks
was (Author: rkrahul324):
Possible approaches I could think of tackling the above issue:
1. Remove the the region entry from serverHolding map in case of mergeOverlap
repair.
* Once deleteMetaRegion() gets executed, we can call HbckRepair to remove the
region from serverHoldings.
* Here HbckRepair would call ServerManager and ServerManager will manage to
call AssignmentManager to remove the region entry from serverHolding map via
RegionStates.
2. Keep cleaning out the unwanted entries from serverHoldings map via chore
cleaner, if the entries for the region is not present in META. This could be an
expensive operation, also would it be safe to cleanup based on the above logic ?
[~apurtell] [~vjasani] Looking for feedback on the above approaches or if we
can handle it better.
> Masters in-memory serverHoldings map is not cleared during hbck repair
> --
>
> Key: HBASE-25130
> URL: https://issues.apache.org/jira/browse/HBASE-25130
> Project: HBase
> Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Rahul Kumar
>Priority: Major
>
> {color:#1d1c1d}Incase of repairing overlaps, hbck essentially calls the
> closeRegion RPC on RS followed by offline RPC on Master to offline all the
> overlap regions that would be merged into a new region. {color}
> {color:#1d1c1d}However the offline RPC doesn’t remove it from the
> serverHoldings map unless the new state is MERGED/SPLIT
> ([https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java#L719])
> b{color}{color:#1d1c1d}ut the new state in this case is OFFLINE. {color}
> {color:#1d1c1d}This is actually intended to match with the META entries and
> would be removed later when the region is online on a different server.
> However, in our case , the region would never be online on a new server,
> hence the region info is never cleared from the map that is used by balancer
> and SCP for incorrect reeassignment.{color}
> {color:#1d1c1d}We might need to tackle this by removing the entries from the
> map when hbck actually deletes{color}{color:#1d1c1d} the meta entries for
> this region which kind of matches the in-memory map’s expectation with the
> META state.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25130) Masters in-memory serverHoldings map is not cleared during hbck repair
[
https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258189#comment-17258189
]
Rahul Kumar commented on HBASE-25130:
-
Possible approaches I could think of tackling the above issue:
1. Remove the the region entry from serverHolding map in case of mergeOverlap
repair.
* Once deleteMetaRegion() gets executed, we can call HbckRepair to remove the
region from serverHoldings.
* Here HbckRepair would call ServerManager and ServerManager will manage to
call AssignmentManager to remove the region entry from serverHolding map via
RegionStates.
2. Keep cleaning out the unwanted entries from serverHoldings map via chore
cleaner, if the entries for the region is not present in META. This could be an
expensive operation, also would it be safe to cleanup based on the above logic ?
[~apurtell] [~vjasani] Looking for feedback on the above approaches or if we
can handle it better.
> Masters in-memory serverHoldings map is not cleared during hbck repair
> --
>
> Key: HBASE-25130
> URL: https://issues.apache.org/jira/browse/HBASE-25130
> Project: HBase
> Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Rahul Kumar
>Priority: Major
>
> {color:#1d1c1d}Incase of repairing overlaps, hbck essentially calls the
> closeRegion RPC on RS followed by offline RPC on Master to offline all the
> overlap regions that would be merged into a new region. {color}
> {color:#1d1c1d}However the offline RPC doesn’t remove it from the
> serverHoldings map unless the new state is MERGED/SPLIT
> ([https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java#L719])
> b{color}{color:#1d1c1d}ut the new state in this case is OFFLINE. {color}
> {color:#1d1c1d}This is actually intended to match with the META entries and
> would be removed later when the region is online on a different server.
> However, in our case , the region would never be online on a new server,
> hence the region info is never cleared from the map that is used by balancer
> and SCP for incorrect reeassignment.{color}
> {color:#1d1c1d}We might need to tackle this by removing the entries from the
> map when hbck actually deletes{color}{color:#1d1c1d} the meta entries for
> this region which kind of matches the in-memory map’s expectation with the
> META state.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753946956 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 38s | master passed | | +1 :green_heart: | compile | 2m 52s | master passed | | +1 :green_heart: | shadedjars | 9m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 24s | the patch passed | | +1 :green_heart: | compile | 2m 18s | the patch passed | | +1 :green_heart: | javac | 2m 18s | the patch passed | | +1 :green_heart: | shadedjars | 9m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 18s | hbase-common in the patch passed. | | -1 :x: | unit | 22m 6s | hbase-server in the patch failed. | | | | 69m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2842 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e5a742c7fe80 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/testReport/ | | Max. process+thread count | 424 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753937204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 35s | master passed | | +1 :green_heart: | compile | 1m 20s | master passed | | +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 56s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | shadedjars | 6m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 40s | hbase-common in the patch passed. | | -1 :x: | unit | 17m 28s | hbase-server in the patch failed. | | | | 47m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2842 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0e80dfa78e69 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/testReport/ | | Max. process+thread count | 788 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753935314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | branch-2 passed | | +1 :green_heart: | compile | 1m 11s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 6m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 45s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 2m 33s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 8m 16s | hbase-shell in the patch passed. | | | | 47m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2840 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d1aedb3e03de 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e517bf7058 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/testReport/ | | Max. process+thread count | 1615 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753934910 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 41s | master passed | | +1 :green_heart: | checkstyle | 1m 28s | master passed | | +1 :green_heart: | spotbugs | 2m 44s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | -0 :warning: | checkstyle | 0m 24s | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -0 :warning: | checkstyle | 1m 2s | hbase-server: The patch generated 4 new + 11 unchanged - 0 fixed = 15 total (was 11) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 2m 9s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 41m 52s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.regionserver.wal.SequenceIdAccounting.getLowestSequenceIdWithPhoenix(Map) makes inefficient use of keySet iterator instead of entrySet iterator At SequenceIdAccounting.java:keySet iterator instead of entrySet iterator At SequenceIdAccounting.java:[line 274] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2842 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux a7715e0796d6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753932761 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 7s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 19s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 6s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | -0 :warning: | checkstyle | 0m 27s | hbase-common: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | -0 :warning: | rubocop | 0m 11s | The patch generated 5 new + 354 unchanged - 5 fixed = 359 total (was 359) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 37s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 41m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2840 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux 008e08da20ff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e517bf7058 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753932640 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 19s | branch-2 passed | | +1 :green_heart: | compile | 1m 24s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 10s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 12s | the patch passed | | +1 :green_heart: | compile | 1m 22s | the patch passed | | +1 :green_heart: | javac | 1m 22s | the patch passed | | +1 :green_heart: | shadedjars | 6m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 49s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 2m 27s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 6m 51s | hbase-shell in the patch passed. | | | | 41m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2840 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2567704786de 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e517bf7058 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/testReport/ | | Max. process+thread count | 2408 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25456) setRegionStateInMeta need security check
[ https://issues.apache.org/jira/browse/HBASE-25456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25456: -- Release Note: setRegionStateInMeta can be accessed only through Admin rights > setRegionStateInMeta need security check > > > Key: HBASE-25456 > URL: https://issues.apache.org/jira/browse/HBASE-25456 > Project: HBase > Issue Type: Bug >Reporter: lujie >Assignee: lujie >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.4, 2.5.0, 2.4.1 > > > [Viraj > Jasani|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=vjasani] > it seems that we miss setRegionStateInMeta -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Release Note: setTableStateInMeta and fixMeta can be accessed only through Admin rights > we should add security checks for setTableStateInMeta and fixMeta > - > > Key: HBASE-25432 > URL: https://issues.apache.org/jira/browse/HBASE-25432 > Project: HBase > Issue Type: Bug >Reporter: lujie >Assignee: lujie >Priority: Blocker > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1 > > Attachments: HBASE-25432_1.patch > > > setTableStateInMeta and fixMeta can be accessed only through Admin rights -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25432: -- Description: setTableStateInMeta and fixMeta can be accessed only through Admin rights > we should add security checks for setTableStateInMeta and fixMeta > - > > Key: HBASE-25432 > URL: https://issues.apache.org/jira/browse/HBASE-25432 > Project: HBase > Issue Type: Bug >Reporter: lujie >Assignee: lujie >Priority: Blocker > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1 > > Attachments: HBASE-25432_1.patch > > > setTableStateInMeta and fixMeta can be accessed only through Admin rights -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753915889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 28s | master passed | | +1 :green_heart: | compile | 2m 8s | master passed | | +1 :green_heart: | shadedjars | 9m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 25s | the patch passed | | +1 :green_heart: | compile | 2m 12s | the patch passed | | +1 :green_heart: | javac | 2m 12s | the patch passed | | +1 :green_heart: | shadedjars | 9m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 29s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 23s | hbase-common in the patch passed. | | -1 :x: | unit | 22m 23s | hbase-server in the patch failed. | | | | 69m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2842 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c5af760d1714 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/testReport/ | | Max. process+thread count | 425 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25211) Rack awareness in region_mover
[ https://issues.apache.org/jira/browse/HBASE-25211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258145#comment-17258145 ] Viraj Jasani commented on HBASE-25211: -- PR is open for review: https://github.com/apache/hbase/pull/2795 > Rack awareness in region_mover > -- > > Key: HBASE-25211 > URL: https://issues.apache.org/jira/browse/HBASE-25211 > Project: HBase > Issue Type: Improvement >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > region_mover should provide an option to ensure while unloading all regions, > all destination servers are selected from different racks and not the one > where server (where region_mover unload is getting executed) belongs to. This > might be helpful option if we want to avail rack downtime (or rack upgrade) > by stopping all Regionservers that belong to same rack for few hours. Without > this option, we don't have any control over which destination server is > selected and hence, some regions might keep bouncing from server A to B in > the same rack all the way until they are finally moved to RS that belongs to > separate rack. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25441) add security check for some APIs in RSRpcServices
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258144#comment-17258144 ] Viraj Jasani edited comment on HBASE-25441 at 1/4/21, 11:10 AM: [~xiaoheipangzi] can you please take care of updating release notes for other 2 Jiras: HBASE-25432 and HBASE-25456 ? Thanks was (Author: vjasani): [~xiaoheipangzi] can you please take care of updating release notes for other 2 Jiras? Thanks > add security check for some APIs in RSRpcServices > - > > Key: HBASE-25441 > URL: https://issues.apache.org/jira/browse/HBASE-25441 > Project: HBase > Issue Type: Bug >Reporter: lujie >Assignee: lujie >Priority: Critical > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1 > > > > ||API||Severity||symptom|| > |clearRegionBlockCache|Severe|The API will call > LruBlockCache.evictBlocksByHfileName, > who is declared as an expensive operation(see its comments), thus non-amin > may result Dos| > |clearSlowLogsResponses|Normal|clears queue records from ringbuffer| > |updateConfiguration|Normal|non-admin user can make RS reload configutation > from disk by this API. | > |updateRegionFavoredNodesMapping|Normal|Non-admin user can change the > region's best storage location by this api| > |stopServer|low|stopServer on RS is slient, which make client think he/she > success shutdown RS. > Add preRpcCheck ont only make client receive the failed message, > but also prevent the non-admin user stop the RS, > even the hbase.coprocessor.regionserver.classes are not configured.| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258144#comment-17258144 ] Viraj Jasani commented on HBASE-25441: -- [~xiaoheipangzi] can you please take care of updating release notes for other 2 Jiras? Thanks > add security check for some APIs in RSRpcServices > - > > Key: HBASE-25441 > URL: https://issues.apache.org/jira/browse/HBASE-25441 > Project: HBase > Issue Type: Bug >Reporter: lujie >Assignee: lujie >Priority: Critical > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1 > > > > ||API||Severity||symptom|| > |clearRegionBlockCache|Severe|The API will call > LruBlockCache.evictBlocksByHfileName, > who is declared as an expensive operation(see its comments), thus non-amin > may result Dos| > |clearSlowLogsResponses|Normal|clears queue records from ringbuffer| > |updateConfiguration|Normal|non-admin user can make RS reload configutation > from disk by this API. | > |updateRegionFavoredNodesMapping|Normal|Non-admin user can change the > region's best storage location by this api| > |stopServer|low|stopServer on RS is slient, which make client think he/she > success shutdown RS. > Add preRpcCheck ont only make client receive the failed message, > but also prevent the non-admin user stop the RS, > even the hbase.coprocessor.regionserver.classes are not configured.| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
virajjasani commented on a change in pull request #2839:
URL: https://github.com/apache/hbase/pull/2839#discussion_r551248865
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##
@@ -187,6 +185,9 @@ private void spawnRenewalChore(final UserGroupInformation
user) {
* @return ChoreService
*/
synchronized ChoreService getChoreService() {
+if (closed.get()) {
Review comment:
Can we use `isClosed()` directly?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753906284 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 54s | master passed | | +1 :green_heart: | compile | 1m 37s | master passed | | +1 :green_heart: | shadedjars | 7m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 6m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 33s | hbase-common in the patch passed. | | -1 :x: | unit | 17m 1s | hbase-server in the patch failed. | | | | 50m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2842 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 206187575ab4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/testReport/ | | Max. process+thread count | 794 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-25441) add security check for some APIs in RSRpcServices
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-25441: Assignee: lujie > add security check for some APIs in RSRpcServices > - > > Key: HBASE-25441 > URL: https://issues.apache.org/jira/browse/HBASE-25441 > Project: HBase > Issue Type: Bug >Reporter: lujie >Assignee: lujie >Priority: Critical > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1 > > > > ||API||Severity||symptom|| > |clearRegionBlockCache|Severe|The API will call > LruBlockCache.evictBlocksByHfileName, > who is declared as an expensive operation(see its comments), thus non-amin > may result Dos| > |clearSlowLogsResponses|Normal|clears queue records from ringbuffer| > |updateConfiguration|Normal|non-admin user can make RS reload configutation > from disk by this API. | > |updateRegionFavoredNodesMapping|Normal|Non-admin user can change the > region's best storage location by this api| > |stopServer|low|stopServer on RS is slient, which make client think he/she > success shutdown RS. > Add preRpcCheck ont only make client receive the failed message, > but also prevent the non-admin user stop the RS, > even the hbase.coprocessor.regionserver.classes are not configured.| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25441) add security check for some APIs in RSRpcServices
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25441: - Release Note: RsRpcServices APIs that can be accessed only through Admin rights: - stopServer - updateFavoredNodes - updateConfiguration - clearRegionBlockCache - clearSlowLogsResponses > add security check for some APIs in RSRpcServices > - > > Key: HBASE-25441 > URL: https://issues.apache.org/jira/browse/HBASE-25441 > Project: HBase > Issue Type: Bug >Reporter: lujie >Priority: Critical > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1 > > > > ||API||Severity||symptom|| > |clearRegionBlockCache|Severe|The API will call > LruBlockCache.evictBlocksByHfileName, > who is declared as an expensive operation(see its comments), thus non-amin > may result Dos| > |clearSlowLogsResponses|Normal|clears queue records from ringbuffer| > |updateConfiguration|Normal|non-admin user can make RS reload configutation > from disk by this API. | > |updateRegionFavoredNodesMapping|Normal|Non-admin user can change the > region's best storage location by this api| > |stopServer|low|stopServer on RS is slient, which make client think he/she > success shutdown RS. > Add preRpcCheck ont only make client receive the failed message, > but also prevent the non-admin user stop the RS, > even the hbase.coprocessor.regionserver.classes are not configured.| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices
[
https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258138#comment-17258138
]
Viraj Jasani commented on HBASE-25441:
--
{quote}All need Admin access level right?
{quote}
That's correct [~anoop.hbase].
> add security check for some APIs in RSRpcServices
> -
>
> Key: HBASE-25441
> URL: https://issues.apache.org/jira/browse/HBASE-25441
> Project: HBase
> Issue Type: Bug
>Reporter: lujie
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1
>
>
>
> ||API||Severity||symptom||
> |clearRegionBlockCache|Severe|The API will call
> LruBlockCache.evictBlocksByHfileName,
> who is declared as an expensive operation(see its comments), thus non-amin
> may result Dos|
> |clearSlowLogsResponses|Normal|clears queue records from ringbuffer|
> |updateConfiguration|Normal|non-admin user can make RS reload configutation
> from disk by this API. |
> |updateRegionFavoredNodesMapping|Normal|Non-admin user can change the
> region's best storage location by this api|
> |stopServer|low|stopServer on RS is slient, which make client think he/she
> success shutdown RS.
> Add preRpcCheck ont only make client receive the failed message,
> but also prevent the non-admin user stop the RS,
> even the hbase.coprocessor.regionserver.classes are not configured.|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
Apache-HBase commented on pull request #2842: URL: https://github.com/apache/hbase/pull/2842#issuecomment-753903594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | checkstyle | 1m 30s | master passed | | +1 :green_heart: | spotbugs | 2m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | -0 :warning: | checkstyle | 0m 24s | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 4 new + 11 unchanged - 0 fixed = 15 total (was 11) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 26s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | -1 :x: | spotbugs | 2m 8s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 44m 20s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.regionserver.wal.SequenceIdAccounting.getLowestSequenceIdWithPhoenix(Map) makes inefficient use of keySet iterator instead of entrySet iterator At SequenceIdAccounting.java:keySet iterator instead of entrySet iterator At SequenceIdAccounting.java:[line 274] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2842 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux b815ca370a43 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2842/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-25459) WAL can't be cleaned with phoenix5
[ https://issues.apache.org/jira/browse/HBASE-25459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xijiawen reassigned HBASE-25459: Assignee: xijiawen > WAL can't be cleaned with phoenix5 > -- > > Key: HBASE-25459 > URL: https://issues.apache.org/jira/browse/HBASE-25459 > Project: HBase > Issue Type: Bug >Reporter: xijiawen >Assignee: xijiawen >Priority: Major > > phoenix jira : https://issues.apache.org/jira/browse/PHOENIX-5250 > it's still open! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] nyl3532016 commented on a change in pull request #2814: HBASE-25442 Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()
nyl3532016 commented on a change in pull request #2814:
URL: https://github.com/apache/hbase/pull/2814#discussion_r551230988
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
##
@@ -185,7 +191,7 @@ public void completeAndWait(WriteEntry e) {
*/
public boolean complete(WriteEntry writeEntry) {
synchronized (writeQueue) {
- writeEntry.markCompleted();
+ writeEntry.markCompleted(true);
Review comment:
Yes,will use it in the place:
`WriteEntry e =
cachedWriteEntries.get().setWriteNumber(nextWriteNumber).markCompleted(false);`
Let me use `setCompleted` instead
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] leyangyueshan opened a new pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5
leyangyueshan opened a new pull request #2842: URL: https://github.com/apache/hbase/pull/2842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)
Apache-HBase commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-753874804 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | master passed | | +1 :green_heart: | checkstyle | 0m 28s | master passed | | +1 :green_heart: | spotbugs | 1m 2s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 1m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 37m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2841 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4fda94a324b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)
Apache-HBase commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-753871931 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 7m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 5s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 7m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 22s | hbase-client in the patch passed. | | | | 28m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2841 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cafaca09ebc9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/testReport/ | | Max. process+thread count | 220 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)
Apache-HBase commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-753871046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | master passed | | +1 :green_heart: | compile | 0m 28s | master passed | | +1 :green_heart: | shadedjars | 6m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | the patch passed | | +1 :green_heart: | compile | 0m 29s | the patch passed | | +1 :green_heart: | javac | 0m 29s | the patch passed | | +1 :green_heart: | shadedjars | 6m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. | | | | 26m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2841 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 092b05fe31a1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2841/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753868116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit
Apache-HBase commented on pull request #2840: URL: https://github.com/apache/hbase/pull/2840#issuecomment-753864982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 35s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 12s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 53s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | -0 :warning: | checkstyle | 0m 26s | hbase-common: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12) | | -0 :warning: | rubocop | 0m 9s | The patch generated 5 new + 354 unchanged - 5 fixed = 359 total (was 359) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 35m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2840 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux c3aaee376b08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e517bf7058 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2840/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25459) WAL can't be cleaned with phoenix5
xijiawen created HBASE-25459: Summary: WAL can't be cleaned with phoenix5 Key: HBASE-25459 URL: https://issues.apache.org/jira/browse/HBASE-25459 Project: HBase Issue Type: Bug Reporter: xijiawen phoenix jira : https://issues.apache.org/jira/browse/PHOENIX-5250 it's still open! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2838: HBASE-25458 HRegion methods cleanup
Apache-HBase commented on pull request #2838: URL: https://github.com/apache/hbase/pull/2838#issuecomment-753859392 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 6m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 146m 59s | hbase-server in the patch passed. | | | | 177m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6ade80c5b380 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/testReport/ | | Max. process+thread count | 4141 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25439) Add BYTE unit in PrettyPrinter.Unit
[ https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258088#comment-17258088 ] Baiqiang Zhao commented on HBASE-25439: --- When backport to branch-2, I found MEMSTORE_FLUSHSIZE is missing in TableDescriptorBuilder.getUnit method. PR#2841 is addendum, please review [~stack] > Add BYTE unit in PrettyPrinter.Unit > > > Key: HBASE-25439 > URL: https://issues.apache.org/jira/browse/HBASE-25439 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1 >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Major > Fix For: 3.0.0-alpha-1 > > Attachments: image-2020-12-23-16-12-42-210.png > > > Currently only TTL supports PrettyPrinter, and MAX_FILESIZE is not human > readable： > !image-2020-12-23-16-12-42-210.png! > This issue add a new unit 'BYTE' to pretty print value of size, such as > MAX_FILESIZE, MEMSTORE_FLUSHSIZE. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ZhaoBQ opened a new pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)
ZhaoBQ opened a new pull request #2841: URL: https://github.com/apache/hbase/pull/2841 MEMSTORE_FLUSHSIZE is missing in TableDescriptorBuilder.getUnit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2838: HBASE-25458 HRegion methods cleanup
Apache-HBase commented on pull request #2838: URL: https://github.com/apache/hbase/pull/2838#issuecomment-753853713 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 6m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 137m 42s | hbase-server in the patch passed. | | | | 166m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c59803b60d33 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/testReport/ | | Max. process+thread count | 4105 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ZhaoBQ opened a new pull request #2840: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit
ZhaoBQ opened a new pull request #2840: URL: https://github.com/apache/hbase/pull/2840 backport [HBASE-25439](https://issues.apache.org/jira/browse/HBASE-25439) to branch-2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258054#comment-17258054 ] Anoop Sam John commented on HBASE-25441: Can add a Release notes? API names and expected rights to do the op. All need Admin access level right? > add security check for some APIs in RSRpcServices > - > > Key: HBASE-25441 > URL: https://issues.apache.org/jira/browse/HBASE-25441 > Project: HBase > Issue Type: Bug >Reporter: lujie >Priority: Critical > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.4, 2.5.0, 2.4.1 > > > > ||API||Severity||symptom|| > |clearRegionBlockCache|Severe|The API will call > LruBlockCache.evictBlocksByHfileName, > who is declared as an expensive operation(see its comments), thus non-amin > may result Dos| > |clearSlowLogsResponses|Normal|clears queue records from ringbuffer| > |updateConfiguration|Normal|non-admin user can make RS reload configutation > from disk by this API. | > |updateRegionFavoredNodesMapping|Normal|Non-admin user can change the > region's best storage location by this api| > |stopServer|low|stopServer on RS is slient, which make client think he/she > success shutdown RS. > Add preRpcCheck ont only make client receive the failed message, > but also prevent the non-admin user stop the RS, > even the hbase.coprocessor.regionserver.classes are not configured.| > -- This message was sent by Atlassian Jira (v8.3.4#803005)
