[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-755956024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-755959907 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] cuibo01 commented on a change in pull request #2779: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2021-01-07 Thread GitBox
cuibo01 commented on a change in pull request #2779: URL: https://github.com/apache/hbase/pull/2779#discussion_r553172257 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java ## @@ -92,12 +96,20 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2854: HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2854: URL: https://github.com/apache/hbase/pull/2854#issuecomment-755976407 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
virajjasani commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-755954985 New build is triggered This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-755965822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25472) HBASE-24260 breaks JDK7 compilation in branch-1

2021-01-07 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HBASE-25472. - Resolution: Duplicate Oh yeah you're right. My local tree wasn't updated. Close this as

[GitHub] [hbase] Apache-HBase commented on pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2853: URL: https://github.com/apache/hbase/pull/2853#issuecomment-755983208 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] cuibo01 commented on a change in pull request #2779: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2021-01-07 Thread GitBox
cuibo01 commented on a change in pull request #2779: URL: https://github.com/apache/hbase/pull/2779#discussion_r553172257 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java ## @@ -92,12 +96,20 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-755965976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] virajjasani commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
virajjasani commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-756012978 Build is taking more time. Let me merge this PR, I have validated test locally and we also have result available here

[GitHub] [hbase] virajjasani merged pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
virajjasani merged pull request #2844: URL: https://github.com/apache/hbase/pull/2844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (HBASE-25474) Update HBase version to 2.5.0 in branch-2 pom.xml

2021-01-07 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-25474: Summary: Update HBase version to 2.5.0 in branch-2 pom.xml Key: HBASE-25474 URL: https://issues.apache.org/jira/browse/HBASE-25474 Project: HBase Issue

[jira] [Commented] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260384#comment-17260384 ] Hudson commented on HBASE-24755: Results for branch branch-2.3 [build #140 on

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260385#comment-17260385 ] Hudson commented on HBASE-25447: Results for branch branch-2.3 [build #140 on

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-756068681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2853: URL: https://github.com/apache/hbase/pull/2853#issuecomment-756050481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-24676) Meta region assignment is blocked when all RS in meta table group are restarted.

2021-01-07 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad resolved HBASE-24676. - Resolution: Not A Problem After HBASE-22738 & HBASE-24760 if no live server in current

[GitHub] [hbase] wchevreuil commented on a change in pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
wchevreuil commented on a change in pull request #2844: URL: https://github.com/apache/hbase/pull/2844#discussion_r553288289 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java ## @@ -86,6 +98,58 @@ public void teardown() throws

[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-756000387 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-07 Thread GitBox
virajjasani commented on pull request #2762: URL: https://github.com/apache/hbase/pull/2762#issuecomment-756002541 I just realized that this branch-1 backport PR also has review comments. Since consolidated discussion is happening on Jira, when @caroliney14 refresh PRs, we can start

[jira] [Commented] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260380#comment-17260380 ] Hudson commented on HBASE-24755: Results for branch branch-2 [build #149 on

[jira] [Commented] (HBASE-25458) HRegion methods cleanup

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260377#comment-17260377 ] Hudson commented on HBASE-25458: Results for branch master [build #177 on

[jira] [Commented] (HBASE-25458) HRegion methods cleanup

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260381#comment-17260381 ] Hudson commented on HBASE-25458: Results for branch branch-2 [build #149 on

[jira] [Commented] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260378#comment-17260378 ] Hudson commented on HBASE-24755: Results for branch master [build #177 on

[jira] [Resolved] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25445. -- Hadoop Flags: Reviewed Resolution: Fixed Thanks for the contribution [~dasanjan1296] 

[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-756004145 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] arshadmohammad closed pull request #1592: HBASE-24244 Move Region Command fails to move region of a table to another RS which is a part of different RSGroup without giving error.

2021-01-07 Thread GitBox
arshadmohammad closed pull request #1592: URL: https://github.com/apache/hbase/pull/1592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] arshadmohammad commented on pull request #1592: HBASE-24244 Move Region Command fails to move region of a table to another RS which is a part of different RSGroup without giving error

2021-01-07 Thread GitBox
arshadmohammad commented on pull request #1592: URL: https://github.com/apache/hbase/pull/1592#issuecomment-756061673 Issue is no value add or there is no correct fix. lets close it without fix This is an automated message

[jira] [Assigned] (HBASE-24244) Region move to different rsgroup server should fail fast.

2021-01-07 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad reassigned HBASE-24244: --- Assignee: (was: Mohammad Arshad) > Region move to different rsgroup server

[GitHub] [hbase] Apache-HBase commented on pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2853: URL: https://github.com/apache/hbase/pull/2853#issuecomment-756041528 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25470) Add unitest for HBASE-25445 - SplitWALRemoteProcedure failed to archive split WAL

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-25470: Assignee: (was: Anjan Das) > Add unitest for HBASE-25445 - SplitWALRemoteProcedure

[jira] [Resolved] (HBASE-25470) Add unitest for HBASE-25445 - SplitWALRemoteProcedure failed to archive split WAL

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25470. -- Fix Version/s: (was: 2.4.1) (was: 2.5.0)

[GitHub] [hbase] arshadmohammad commented on pull request #2112: HBASE-24676: Meta region assignment is blocked when all RS in meta ta…

2021-01-07 Thread GitBox
arshadmohammad commented on pull request #2112: URL: https://github.com/apache/hbase/pull/2112#issuecomment-756060359 After HBASE-22738 & HBASE-24760 if no live server in current group then table regions will be moved to default group or other group where live servers exist, so meta will

[GitHub] [hbase] arshadmohammad closed pull request #2112: HBASE-24676: Meta region assignment is blocked when all RS in meta ta…

2021-01-07 Thread GitBox
arshadmohammad closed pull request #2112: URL: https://github.com/apache/hbase/pull/2112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (HBASE-24212) HMaster UI hangs when rsgorup is enabled and meta-region is not available

2021-01-07 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad resolved HBASE-24212. - Resolution: Not A Problem * Moving rsgroup code to server is not the available option.

[GitHub] [hbase] Apache-HBase commented on pull request #2844: HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2844: URL: https://github.com/apache/hbase/pull/2844#issuecomment-756067248 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Reopened] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-25441: -- Reopening for branch-2.2 backport. > add security check for some APIs in RSRpcServices >

[jira] [Work started] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

2021-01-07 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25475 started by Anjan Das. - > Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive >

[GitHub] [hbase] Apache9 commented on pull request #2851: HBASE-22947 Client Should not be able to disable Systems table

2021-01-07 Thread GitBox
Apache9 commented on pull request #2851: URL: https://github.com/apache/hbase/pull/2851#issuecomment-756130181 For me, sometimes I will disable a table and then enable it to fix the incorrect state of its regions. This could also be used for system tables other than meta table. So I think

[jira] [Resolved] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25441. -- Fix Version/s: 2.2.7 Resolution: Fixed Backported to branch-2.2. > add security check

[GitHub] [hbase] dasanjan1296 commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-07 Thread GitBox
dasanjan1296 commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-756126132 @wchevreuil Thanks for the feedback on #2844. Please take a look. This is an automated message from the

[jira] [Created] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

2021-01-07 Thread Anjan Das (Jira)
Anjan Das created HBASE-25475: - Summary: Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL Key: HBASE-25475 URL: https://issues.apache.org/jira/browse/HBASE-25475

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-756125581 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] dasanjan1296 opened a new pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-07 Thread GitBox
dasanjan1296 opened a new pull request #2855: URL: https://github.com/apache/hbase/pull/2855 - This is to address post-merge feedback from #2844 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25475: - Fix Version/s: (was: 2.3.4) 2.3.5 2.4.1

[jira] [Created] (HBASE-25476) Enable error prone check in pre commit

2021-01-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25476: - Summary: Enable error prone check in pre commit Key: HBASE-25476 URL: https://issues.apache.org/jira/browse/HBASE-25476 Project: HBase Issue Type: Improvement

[jira] [Work started] (HBASE-25476) Enable error prone check in pre commit

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25476 started by Duo Zhang. - > Enable error prone check in pre commit > -- >

[jira] [Updated] (HBASE-25476) Enable error prone check in pre commit

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25476: -- Component/s: build > Enable error prone check in pre commit > --

[jira] [Assigned] (HBASE-25476) Enable error prone check in pre commit

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25476: - Assignee: Duo Zhang > Enable error prone check in pre commit >

[jira] [Resolved] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25432. -- Fix Version/s: 2.2.7 Resolution: Fixed Backported to branch-2.2. > we should add

[jira] [Reopened] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-25432: -- Reopening for branch-2.2 backport. > we should add security checks for setTableStateInMeta and

[GitHub] [hbase] Apache-HBase commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-756136013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260736#comment-17260736 ] Hudson commented on HBASE-25447: Results for branch branch-2.4 [build #25 on

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260737#comment-17260737 ] Hudson commented on HBASE-25445: Results for branch branch-2.4 [build #25 on

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260774#comment-17260774 ] Hudson commented on HBASE-25447: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260776#comment-17260776 ] Hudson commented on HBASE-25432: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25467) Fix error prone problems on branch-2.2

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260778#comment-17260778 ] Hudson commented on HBASE-25467: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260775#comment-17260775 ] Hudson commented on HBASE-25445: Results for branch branch-2.2 [build #146 on

[jira] [Commented] (HBASE-25441) add security check for some APIs in RSRpcServices

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260777#comment-17260777 ] Hudson commented on HBASE-25441: Results for branch branch-2.2 [build #146 on

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-756332977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-756335040 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260768#comment-17260768 ] Hudson commented on HBASE-25445: Results for branch branch-2 [build #150 on

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260769#comment-17260769 ] Viraj Jasani commented on HBASE-23887: -- Please feel free to create a new PR. Current PR has some

[jira] [Commented] (HBASE-25287) Forgetting to unbuffer streams results in many CLOSE_WAIT sockets when loading files

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260771#comment-17260771 ] Hudson commented on HBASE-25287: Results for branch branch-1 [build #74 on

[GitHub] [hbase] Apache-HBase commented on pull request #1257: HBASE 23887 Up to 3x increase BlockCache performance

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #1257: URL: https://github.com/apache/hbase/pull/1257#issuecomment-756335604 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260764#comment-17260764 ] Viraj Jasani commented on HBASE-23887: -- [~pustota] Let's just make this an extended LruCache rather

[jira] [Commented] (HBASE-25445) Old WALs archive fails in procedure based WAL split

2021-01-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260810#comment-17260810 ] Hudson commented on HBASE-25445: Results for branch branch-2.3 [build #141 on

[jira] [Commented] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-01-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260849#comment-17260849 ] Michael Stack commented on HBASE-25473: --- The hbase-shaded-testing-util jar just fails when you

[jira] [Created] (HBASE-25480) NPE when getting metrics of backup master

2021-01-07 Thread Andrey Elenskiy (Jira)
Andrey Elenskiy created HBASE-25480: --- Summary: NPE when getting metrics of backup master Key: HBASE-25480 URL: https://issues.apache.org/jira/browse/HBASE-25480 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2855: HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2855: URL: https://github.com/apache/hbase/pull/2855#issuecomment-756149468 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 opened a new pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache9 opened a new pull request #2856: URL: https://github.com/apache/hbase/pull/2856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] petersomogyi commented on a change in pull request #2850: HBASE-25467 Fix error prone problems on branch-2.2

2021-01-07 Thread GitBox
petersomogyi commented on a change in pull request #2850: URL: https://github.com/apache/hbase/pull/2850#discussion_r553409589 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -68,7 +68,7 @@ * */ @InterfaceAudience.Public

[GitHub] [hbase] virajjasani commented on a change in pull request #2850: HBASE-25467 Fix error prone problems on branch-2.2

2021-01-07 Thread GitBox
virajjasani commented on a change in pull request #2850: URL: https://github.com/apache/hbase/pull/2850#discussion_r553400462 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -68,7 +68,7 @@ * */ @InterfaceAudience.Public

[GitHub] [hbase-filesystem] petersomogyi opened a new pull request #19: HBASE-25477 Purge use of VisibleForTesting

2021-01-07 Thread GitBox
petersomogyi opened a new pull request #19: URL: https://github.com/apache/hbase-filesystem/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756248314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-filesystem] wchevreuil merged pull request #19: HBASE-25477 Purge use of VisibleForTesting

2021-01-07 Thread GitBox
wchevreuil merged pull request #19: URL: https://github.com/apache/hbase-filesystem/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (HBASE-25477) [filesystem] Purge use of VisibleForTesting

2021-01-07 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25477. -- Resolution: Fixed > [filesystem] Purge use of VisibleForTesting >

[jira] [Updated] (HBASE-25477) [filesystem] Purge use of VisibleForTesting

2021-01-07 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25477: - Fix Version/s: hbase-filesystem-1.0.0-alpha2 > [filesystem] Purge use of

[GitHub] [hbase-filesystem] petersomogyi commented on pull request #19: HBASE-25477 Purge use of VisibleForTesting

2021-01-07 Thread GitBox
petersomogyi commented on pull request #19: URL: https://github.com/apache/hbase-filesystem/pull/19#issuecomment-756264226 Thanks @wchevreuil for the quick review! This is an automated message from the Apache Git Service. To

[GitHub] [hbase] petersomogyi merged pull request #2850: HBASE-25467 Fix error prone problems on branch-2.2

2021-01-07 Thread GitBox
petersomogyi merged pull request #2850: URL: https://github.com/apache/hbase/pull/2850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-25467) Fix error prone problems on branch-2.2

2021-01-07 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-25467. --- Fix Version/s: 2.2.7 Resolution: Fixed Pushed to branch-2.2. > Fix error prone

[jira] [Commented] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-01-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260882#comment-17260882 ] Michael Stack commented on HBASE-25473: --- Still fails cryptic even w/ debug in it and the shaded

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756529822 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread Caroline (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260986#comment-17260986 ] Caroline commented on HBASE-25032: -- [~bharathv] Thanks for the explanation, I think that makes sense. I

[GitHub] [hbase] Apache-HBase commented on pull request #2856: test error prone check

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2856: URL: https://github.com/apache/hbase/pull/2856#issuecomment-756541059 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] caroliney14 commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread GitBox
caroliney14 commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-756540324 @Apache9 @bharathv Thanks for the suggestion. I looked at the code some more and I believe we only need to remove the `checkAndRecordNewServer()` line from `ServerManager`'s

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-756552901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-01-07 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261018#comment-17261018 ] Viraj Jasani commented on HBASE-23887: -- Let me know if you have any doubts. On high level, we can

[GitHub] [hbase] infraio commented on a change in pull request #2853: HBASE-25471 Move RegionScannerImpl out of HRegion

2021-01-07 Thread GitBox
infraio commented on a change in pull request #2853: URL: https://github.com/apache/hbase/pull/2853#discussion_r553758795 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4039,7 +4031,7 @@ private static Get toGet(final

[jira] [Created] (HBASE-25483) set the loadMeta log level to debug.

2021-01-07 Thread Bo Cui (Jira)
Bo Cui created HBASE-25483: -- Summary: set the loadMeta log level to debug. Key: HBASE-25483 URL: https://issues.apache.org/jira/browse/HBASE-25483 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache9 merged pull request #2857: HBASE-25481 Add host and port attribute when tracing rpc call at clie…

2021-01-07 Thread GitBox
Apache9 merged pull request #2857: URL: https://github.com/apache/hbase/pull/2857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2848: HBASE-25459 WAL can't be cleaned in some scenes

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2848: URL: https://github.com/apache/hbase/pull/2848#issuecomment-756521129 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25481) Add host and port attribute when tracing rpc call at client side

2021-01-07 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25481: - Summary: Add host and port attribute when tracing rpc call at client side Key: HBASE-25481 URL: https://issues.apache.org/jira/browse/HBASE-25481 Project: HBase

[jira] [Updated] (HBASE-25401) Add trace support for async call in rpc client

2021-01-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25401: -- Component/s: rpc > Add trace support for async call in rpc client >

[GitHub] [hbase] ZhaoBQ opened a new pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-07 Thread GitBox
ZhaoBQ opened a new pull request #2858: URL: https://github.com/apache/hbase/pull/2858 [HBASE-25482](https://issues.apache.org/jira/browse/HBASE-25482) If the table is set NormalizerTargetRegionSize, we take NormalizerTargetRegionSize as avgRegionSize and return it. So the totalSizeMb

[GitHub] [hbase] Apache-HBase commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-756600287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2858: URL: https://github.com/apache/hbase/pull/2858#issuecomment-756600150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2848: HBASE-25459 WAL can't be cleaned in some scenes

2021-01-07 Thread GitBox
Apache-HBase commented on pull request #2848: URL: https://github.com/apache/hbase/pull/2848#issuecomment-756554177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25483) set the loadMeta log level to debug.

2021-01-07 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-25483: -- Assignee: Bo Cui > set the loadMeta log level to debug. > > >

  1   2   >