[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-26 Thread Baiqiang Zhao (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272535#comment-17272535
 ] 

Baiqiang Zhao commented on HBASE-25533:
---

My current idea is to remove the metadata if it is set to an empty string, just 
like null. Because empty string is meaningless. And maybe HBCK should support 
to repair this extreme situation. Ping [~stack] [~zhangduo] [~vjasani]

>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-26 Thread Baiqiang Zhao (Jira)
Baiqiang Zhao created HBASE-25533:
-

 Summary:  The metadata of the table and family should not be an 
empty string
 Key: HBASE-25533
 URL: https://issues.apache.org/jira/browse/HBASE-25533
 Project: HBase
  Issue Type: Bug
Reporter: Baiqiang Zhao
Assignee: Baiqiang Zhao


If the metadata of the table is set to null, the metadata will be removed. The 
code is:

[https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]

But if set metadata as empty string, serious errors may occur. Some metadata is 
number, 
it will throw a NumberFormatException when converting empty string to a number. 
If the exception is thrown when the region is initialized, all regions of the 
table will be in RIT.

The following command can reproduced this issue. *Note: Please execute in the 
test environment.*
{code:java}
alter 'test_table', CONFIGURATION => 
{'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25523) Region normalizer chore thread is getting killed

2021-01-26 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272519#comment-17272519
 ] 

Hudson commented on HBASE-25523:


Results for branch branch-2.4
[build #41 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/41/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/41/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/41/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/41/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/41/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Region normalizer chore thread is getting killed
> 
>
> Key: HBASE-25523
> URL: https://issues.apache.org/jira/browse/HBASE-25523
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1, 1.6.0, 2.4.1
>Reporter: Aman Poonia
>Assignee: Aman Poonia
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> Region normalizer chore thread is getting killed when the region is not found 
> on any server.
> As per the method
> {code:java}
> // code placeholder
> /**
>  * @param serverName
>  * @return ServerLoad if serverName is known else null
>  */
> public ServerLoad getLoad(final ServerName serverName) {
>   return this.onlineServers.get(serverName);
> }
> {code}
>  So ideally we should check for the returned null in SimpleRegionNormalizer
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] taklwu commented on a change in pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2021-01-26 Thread GitBox


taklwu commented on a change in pull request #2237:
URL: https://github.com/apache/hbase/pull/2237#discussion_r564936787



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java
##
@@ -166,4 +170,35 @@ protected void completionCleanup(MasterProcedureEnv env) {
   public void await() throws InterruptedException {
 latch.await();
   }
+
+  private static boolean deleteMetaTableDirectoryIfPartial(FileSystem 
rootDirectoryFs,
+Path metaTableDir) throws IOException {
+boolean isPartial = true;
+try {
+  TableDescriptor metaDescriptor =
+FSTableDescriptors.getTableDescriptorFromFs(rootDirectoryFs, 
metaTableDir);
+  // when entering the state of INIT_META_WRITE_FS_LAYOUT, if a meta table 
directory is found,
+  // the meta table should not have any useful data and considers as 
partial.
+  // if we find any valid HFiles, operator should fix the meta e.g. via 
HBCK.
+  if (metaDescriptor != null && metaDescriptor.getColumnFamilyCount() > 0) 
{
+RemoteIterator iterator = 
rootDirectoryFs.listFiles(metaTableDir, true);
+while (iterator.hasNext()) {
+  LocatedFileStatus status = iterator.next();
+  if (StoreFileInfo.isHFile(status.getPath()) && HFile
+.isHFileFormat(rootDirectoryFs, status.getPath())) {
+isPartial = false;
+break;
+  }
+}
+  }
+} finally {
+  if (!isPartial) {
+throw new IOException("Meta table is not partial, please sideline this 
meta directory "
+  + "or run HBCK to fix this meta table, e.g. rebuild the server 
hostname in ZNode for the "

Review comment:
   good point on documentation, I need more time to figure out if there is 
existing command(s)/option(s) other than manually sidelining the meta directory 
to a different location. let's mark it as a blocker/requirement before I 
merging this PR. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (HBASE-25531) Minor improvement to Profiler Servlet doc

2021-01-26 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk resolved HBASE-25531.
--
Resolution: Fixed

> Minor improvement to Profiler Servlet doc
> -
>
> Key: HBASE-25531
> URL: https://issues.apache.org/jira/browse/HBASE-25531
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 3.0.0-alpha-1
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> Minor cleanup to the Profiler Servlet Background and Prerequisites sections, 
> http://hbase.apache.org/book.html#_prerequisites_2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] ndimiduk commented on pull request #2905: HBASE-25531 Minor improvement to Profiler Servlet doc

2021-01-26 Thread GitBox


ndimiduk commented on pull request #2905:
URL: https://github.com/apache/hbase/pull/2905#issuecomment-767915690


   Thanks @busbey !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk merged pull request #2905: HBASE-25531 Minor improvement to Profiler Servlet doc

2021-01-26 Thread GitBox


ndimiduk merged pull request #2905:
URL: https://github.com/apache/hbase/pull/2905


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (HBASE-25530) hbase 3.0.0 example source not usable due to hbase-asyncfs-3.0.0-SNAPSHOT jar not found

2021-01-26 Thread Sean Busbey (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272492#comment-17272492
 ] 

Sean Busbey commented on HBASE-25530:
-

Please do the build at the top of the project, those dependencies are things 
that should be built as a part of the maven multi-module build.

> hbase 3.0.0 example source not usable due to hbase-asyncfs-3.0.0-SNAPSHOT jar 
> not found
> ---
>
> Key: HBASE-25530
> URL: https://issues.apache.org/jira/browse/HBASE-25530
> Project: HBase
>  Issue Type: Task
>Reporter: Richard Tkatch
>Priority: Major
>
> tried to run maven on the example client pom for hbase 3.0.0. 
> [ERROR] Failed to execute goal on project hbase-examples: Could not resolve 
> dependencies for project org.apache.hbase:hbase-examples:jar:3.0.0-SNAPSHOT: 
> The following artifacts could not be resolved: 
> org.apache.hbase:hbase-asyncfs:jar:3.0.0-SNAPSHOT, 
> org.apache.hbase:hbase-replication:jar:3.0.0-SNAPSHOT: Failure to find 
> org.apache.hbase:hbase-asyncfs:jar:3.0.0-SNAPSHOT in 
> https://repository.apache.org/snapshots was cached in the local repository, 
> resolution will not be reattempted until the update interval of 
> apache.snapshots has elapsed or updates are forced -> [Help 1]
>  
> I can't seem to find this jar and the link that points to the jar is dead. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #80: HBASE-25529 [hbase-operator-tools] Fix OOME "unable to create new nat…

2021-01-26 Thread GitBox


Apache-HBase commented on pull request #80:
URL: 
https://github.com/apache/hbase-operator-tools/pull/80#issuecomment-767847249


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +0 :ok: |  spotbugs  |   0m  0s |  spotbugs executables are not available. 
 |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
1 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 44s |  master passed  |
   | +1 :green_heart: |  compile  |   0m  8s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m  6s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m  7s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m  9s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m  7s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m  7s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m  3s |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m  5s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 46s |  hbase-tools in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m  5s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   4m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/2/artifact/yetus-precommit-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/80 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit spotbugs findbugs checkstyle compile |
   | uname | Linux 7303532fb0f8 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 GNU/Linux |
   | Build tool | maven |
   | git revision | master / 9760397 |
   | Default Java | Oracle Corporation-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/2/testReport/
 |
   | Max. process+thread count | 1271 (vs. ulimit of 5000) |
   | modules | C: hbase-tools U: hbase-tools |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/2/console
 |
   | versions | git=2.20.1 shellcheck=0.5.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #80: HBASE-25529 [hbase-operator-tools] Fix OOME "unable to create new nat…

2021-01-26 Thread GitBox


Apache-HBase commented on pull request #80:
URL: 
https://github.com/apache/hbase-operator-tools/pull/80#issuecomment-767835822


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  4s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  3s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no 
output?  |
   |  |   |   1m 34s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/1/artifact/yetus-precommit-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/80 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 3aa407b63649 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 GNU/Linux |
   | Build tool | maven |
   | git revision | master / 9760397 |
   | Max. process+thread count | 34 (vs. ulimit of 5000) |
   | modules | C:  U:  |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/1/console
 |
   | versions | git=2.20.1 shellcheck=0.5.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] wchevreuil opened a new pull request #80: HBASE-25529 [hbase-operator-tools] Fix OOME "unable to create new nat…

2021-01-26 Thread GitBox


wchevreuil opened a new pull request #80:
URL: https://github.com/apache/hbase-operator-tools/pull/80


   …ive thread" on UTs



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-thirdparty] busbey closed pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything

2021-01-26 Thread GitBox


busbey closed pull request #36:
URL: https://github.com/apache/hbase-thirdparty/pull/36


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #2905: HBASE-25531 Minor improvement to Profiler Servlet doc

2021-01-26 Thread GitBox


Apache-HBase commented on pull request #2905:
URL: https://github.com/apache/hbase/pull/2905#issuecomment-767774623


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 32s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  master passed  |
   | +0 :ok: |  refguide  |   3m 32s |  branch has no errors when building the 
reference guide. See footer for rendered docs, which you should manually 
inspect.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 27s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +0 :ok: |  refguide  |   3m 23s |  patch has no errors when building the 
reference guide. See footer for rendered docs, which you should manually 
inspect.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 17s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  16m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2905/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/2905 |
   | Optional Tests | dupname asflicense refguide |
   | uname | Linux 3af9b9c4fb2e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / f9ef663314 |
   | refguide | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2905/1/artifact/yetus-general-check/output/branch-site/book.html
 |
   | refguide | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2905/1/artifact/yetus-general-check/output/patch-site/book.html
 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2905/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (HBASE-25532) Add 2.4.1 to the downloads page

2021-01-26 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-25532.
-
Resolution: Fixed

> Add 2.4.1 to the downloads page
> ---
>
> Key: HBASE-25532
> URL: https://issues.apache.org/jira/browse/HBASE-25532
> Project: HBase
>  Issue Type: Task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25532) Add 2.4.1 to the downloads page

2021-01-26 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25532:
---

 Summary: Add 2.4.1 to the downloads page
 Key: HBASE-25532
 URL: https://issues.apache.org/jira/browse/HBASE-25532
 Project: HBase
  Issue Type: Task
Reporter: Andrew Kyle Purtell
Assignee: Andrew Kyle Purtell






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on pull request #2905: HBASE-25531 Minor improvement to Profiler Servlet doc

2021-01-26 Thread GitBox


Apache-HBase commented on pull request #2905:
URL: https://github.com/apache/hbase/pull/2905#issuecomment-767765909







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Work started] (HBASE-25531) Minor improvement to Profiler Servlet doc

2021-01-26 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-25531 started by Nick Dimiduk.

> Minor improvement to Profiler Servlet doc
> -
>
> Key: HBASE-25531
> URL: https://issues.apache.org/jira/browse/HBASE-25531
> Project: HBase
>  Issue Type: Task
>  Components: documentation
>Affects Versions: 3.0.0-alpha-1
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> Minor cleanup to the Profiler Servlet Background and Prerequisites sections, 
> http://hbase.apache.org/book.html#_prerequisites_2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] ndimiduk opened a new pull request #2905: HBASE-25531 Minor improvement to Profiler Servlet doc

2021-01-26 Thread GitBox


ndimiduk opened a new pull request #2905:
URL: https://github.com/apache/hbase/pull/2905


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (HBASE-25531) Minor improvement to Profiler Servlet doc

2021-01-26 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25531:


 Summary: Minor improvement to Profiler Servlet doc
 Key: HBASE-25531
 URL: https://issues.apache.org/jira/browse/HBASE-25531
 Project: HBase
  Issue Type: Task
  Components: documentation
Affects Versions: 3.0.0-alpha-1
Reporter: Nick Dimiduk
Assignee: Nick Dimiduk
 Fix For: 3.0.0-alpha-1


Minor cleanup to the Profiler Servlet Background and Prerequisites sections, 
http://hbase.apache.org/book.html#_prerequisites_2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25530) hbase 3.0.0 example source not usable due to hbase-asyncfs-3.0.0-SNAPSHOT jar not found

2021-01-26 Thread Richard Tkatch (Jira)
Richard Tkatch created HBASE-25530:
--

 Summary: hbase 3.0.0 example source not usable due to 
hbase-asyncfs-3.0.0-SNAPSHOT jar not found
 Key: HBASE-25530
 URL: https://issues.apache.org/jira/browse/HBASE-25530
 Project: HBase
  Issue Type: Task
Reporter: Richard Tkatch


tried to run maven on the example client pom for hbase 3.0.0. 

[ERROR] Failed to execute goal on project hbase-examples: Could not resolve 
dependencies for project org.apache.hbase:hbase-examples:jar:3.0.0-SNAPSHOT: 
The following artifacts could not be resolved: 
org.apache.hbase:hbase-asyncfs:jar:3.0.0-SNAPSHOT, 
org.apache.hbase:hbase-replication:jar:3.0.0-SNAPSHOT: Failure to find 
org.apache.hbase:hbase-asyncfs:jar:3.0.0-SNAPSHOT in 
https://repository.apache.org/snapshots was cached in the local repository, 
resolution will not be reattempted until the update interval of 
apache.snapshots has elapsed or updates are forced -> [Help 1]

 

I can't seem to find this jar and the link that points to the jar is dead. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25523) Region normalizer chore thread is getting killed

2021-01-26 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272304#comment-17272304
 ] 

Hudson commented on HBASE-25523:


Results for branch branch-2
[build #164 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/164/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/164/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/164/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/164/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/164/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Region normalizer chore thread is getting killed
> 
>
> Key: HBASE-25523
> URL: https://issues.apache.org/jira/browse/HBASE-25523
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1, 1.6.0, 2.4.1
>Reporter: Aman Poonia
>Assignee: Aman Poonia
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> Region normalizer chore thread is getting killed when the region is not found 
> on any server.
> As per the method
> {code:java}
> // code placeholder
> /**
>  * @param serverName
>  * @return ServerLoad if serverName is known else null
>  */
> public ServerLoad getLoad(final ServerName serverName) {
>   return this.onlineServers.get(serverName);
> }
> {code}
>  So ideally we should check for the returned null in SimpleRegionNormalizer
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25523) Region normalizer chore thread is getting killed

2021-01-26 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272268#comment-17272268
 ] 

Hudson commented on HBASE-25523:


Results for branch branch-2.3
[build #158 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/158/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/158/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/158/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/158/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/158/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Region normalizer chore thread is getting killed
> 
>
> Key: HBASE-25523
> URL: https://issues.apache.org/jira/browse/HBASE-25523
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1, 1.6.0, 2.4.1
>Reporter: Aman Poonia
>Assignee: Aman Poonia
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> Region normalizer chore thread is getting killed when the region is not found 
> on any server.
> As per the method
> {code:java}
> // code placeholder
> /**
>  * @param serverName
>  * @return ServerLoad if serverName is known else null
>  */
> public ServerLoad getLoad(final ServerName serverName) {
>   return this.onlineServers.get(serverName);
> }
> {code}
>  So ideally we should check for the returned null in SimpleRegionNormalizer
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25523) Region normalizer chore thread is getting killed

2021-01-26 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272165#comment-17272165
 ] 

Hudson commented on HBASE-25523:


Results for branch branch-1
[build #77 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Region normalizer chore thread is getting killed
> 
>
> Key: HBASE-25523
> URL: https://issues.apache.org/jira/browse/HBASE-25523
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1, 1.6.0, 2.4.1
>Reporter: Aman Poonia
>Assignee: Aman Poonia
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> Region normalizer chore thread is getting killed when the region is not found 
> on any server.
> As per the method
> {code:java}
> // code placeholder
> /**
>  * @param serverName
>  * @return ServerLoad if serverName is known else null
>  */
> public ServerLoad getLoad(final ServerName serverName) {
>   return this.onlineServers.get(serverName);
> }
> {code}
>  So ideally we should check for the returned null in SimpleRegionNormalizer
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25525) WALKey Extended Attributes don't serialize to ReplicationSink

2021-01-26 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272164#comment-17272164
 ] 

Hudson commented on HBASE-25525:


Results for branch branch-1
[build #77 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/77//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> WALKey Extended Attributes don't serialize to ReplicationSink
> -
>
> Key: HBASE-25525
> URL: https://issues.apache.org/jira/browse/HBASE-25525
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Fix For: 1.7.0
>
>
> HBASE-22622 introduced extended attributes on the WALKey object and protobuf, 
> and HBASE-22623 created a coprocessor hook, preWALAppend, so that 
> coprocessors can create and insert their own extended attributes. 
> These attributes are readable on the source-side, such as in a custom 
> ReplicationEndpoint. However, in branch-1 ReplicationProtbufUtil doesn't 
> correctly populate the extended attributes on the WALKey protobuf. (In 2.1+, 
> HBASE-20625 incidentally fixes this as part of a larger refactoring of 
> WALCellCodec logic.)
> This means that a custom ReplicationSink can't read extended attributes on a 
> WALKey.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase-thirdparty] busbey commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything

2021-01-26 Thread GitBox


busbey commented on pull request #36:
URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-767556978


   Yep! And an existing install can delete the normal htrace jar and put this 
one in place.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] virajjasani commented on a change in pull request #2904: HBASE-25528: Dedicated merge dispatch thread pool on master

2021-01-26 Thread GitBox


virajjasani commented on a change in pull request #2904:
URL: https://github.com/apache/hbase/pull/2904#discussion_r564526039



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##
@@ -208,14 +208,21 @@ public void setMasterServices(final MasterServices 
masterServices) {
   ctx.getTableRegions().size());
 
 final List plans = new ArrayList<>();
+int splitPlansCount = 0;
 if (proceedWithSplitPlanning) {
-  plans.addAll(computeSplitNormalizationPlans(ctx));
+  List splitPlans = computeSplitNormalizationPlans(ctx);
+  splitPlansCount = splitPlans.size();
+  plans.addAll(splitPlans);
 }
+int mergePlansCount = 0;
 if (proceedWithMergePlanning) {
-  plans.addAll(computeMergeNormalizationPlans(ctx));
+  List mergePlans = computeMergeNormalizationPlans(ctx);
+  mergePlansCount = mergePlans.size();
+  plans.addAll(mergePlans);
 }
 
-LOG.debug("Computed {} normalization plans for table {}", plans.size(), 
table);
+LOG.debug("Computed {} normalization plans for table {}. Split plans: {}, 
merge plans: {}",
+plans.size(), table, splitPlansCount, mergePlansCount);

Review comment:
   Nice log. One small nit: `Computed total {} normalization plans`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (HBASE-25529) [hbase-operator-tools]Fix OOME "unable to create new native thread" on UTs

2021-01-26 Thread Wellington Chevreuil (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wellington Chevreuil updated HBASE-25529:
-
Affects Version/s: hbase-operator-tools-1.0.0

> [hbase-operator-tools]Fix OOME "unable to create new native thread" on UTs
> --
>
> Key: HBASE-25529
> URL: https://issues.apache.org/jira/browse/HBASE-25529
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-operator-tools
>Affects Versions: hbase-operator-tools-1.0.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Have noticed some UTs sporadically failing with OOME "unable to create new 
> native thread". This does happen when running locally. Talked to [~psomogyi] 
> and he was suggesting some environment changes to be set on docker 
> personality script. Opening this one to try having this fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25529) [hbase-operator-tools]Fix OOME "unable to create new native thread" on UTs

2021-01-26 Thread Wellington Chevreuil (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wellington Chevreuil updated HBASE-25529:
-
Component/s: hbase-operator-tools

> [hbase-operator-tools]Fix OOME "unable to create new native thread" on UTs
> --
>
> Key: HBASE-25529
> URL: https://issues.apache.org/jira/browse/HBASE-25529
> Project: HBase
>  Issue Type: Bug
>  Components: hbase-operator-tools
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
>
> Have noticed some UTs sporadically failing with OOME "unable to create new 
> native thread". This does happen when running locally. Talked to [~psomogyi] 
> and he was suggesting some environment changes to be set on docker 
> personality script. Opening this one to try having this fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25529) [hbase-operator-tools]Fix OOME "unable to create new native thread" on UTs

2021-01-26 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-25529:


 Summary: [hbase-operator-tools]Fix OOME "unable to create new 
native thread" on UTs
 Key: HBASE-25529
 URL: https://issues.apache.org/jira/browse/HBASE-25529
 Project: HBase
  Issue Type: Bug
Reporter: Wellington Chevreuil
Assignee: Wellington Chevreuil


Have noticed some UTs sporadically failing with OOME "unable to create new 
native thread". This does happen when running locally. Talked to [~psomogyi] 
and he was suggesting some environment changes to be set on docker personality 
script. Opening this one to try having this fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)