[GitHub] [hbase] saintstack merged pull request #2752: HBASE-25374 Make REST Client connection and socket time out configurable

saintstack merged pull request #2752: URL: https://github.com/apache/hbase/pull/2752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #3043: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949

Apache-HBase commented on pull request #3043: URL: https://github.com/apache/hbase/pull/3043#issuecomment-799854911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3052: HBASE-25639 meta replica state is not respected during active master …

Apache-HBase commented on pull request #3052: URL: https://github.com/apache/hbase/pull/3052#issuecomment-799924066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25374) Make REST Client connection and socket time out configurable

[ https://issues.apache.org/jira/browse/HBASE-25374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302206#comment-17302206 ] Pankaj Kumar commented on HBASE-25374: -- Thank you [~stack] Sir... > Make REST Client connection

[jira] [Resolved] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25594. --- Fix Version/s: 2.4.3 2.5.0 3.0.0-alpha-1 Hadoop

[GitHub] [hbase] javierluca edited a comment on pull request #3048: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn

javierluca edited a comment on pull request #3048: URL: https://github.com/apache/hbase/pull/3048#issuecomment-799958984 @saintstack In my opinion, your change was better than mine because we could use `"localhost"` as argument, and that will work very well with `regionservers.sh` which

[GitHub] [hbase] Apache-HBase commented on pull request #3018: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

Apache-HBase commented on pull request #3018: URL: https://github.com/apache/hbase/pull/3018#issuecomment-799959223 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] javierluca commented on pull request #3048: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn

javierluca commented on pull request #3048: URL: https://github.com/apache/hbase/pull/3048#issuecomment-799958984 @saintstack In my opinion, your change was better because we could use "localhost" as argument, and that will work very well with `regionservers.sh` which will bypass the ssh

[GitHub] [hbase] Apache-HBase commented on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

Apache-HBase commented on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799971045 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

Apache-HBase commented on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799970796 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

saintstack commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-799847038 Closing out draft. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] saintstack commented on pull request #2469: HBASE-25112 Add new procedure metrics for master UI only

saintstack commented on pull request #2469: URL: https://github.com/apache/hbase/pull/2469#issuecomment-799846799 Looks good. Whats it add to the UI @Joseph295 ? Put an image up on the JIRA? What failed here? Want me to rerun the PR so you can see what failed (not there any more it

[GitHub] [hbase] saintstack closed pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

saintstack closed pull request #2445: URL: https://github.com/apache/hbase/pull/2445 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache9 commented on pull request #3050: HBASE-25662 Fix spotbugs warning in RoundRobinTableInputFormat

Apache9 commented on pull request #3050: URL: https://github.com/apache/hbase/pull/3050#issuecomment-799854070 IIRC in the current java world, you should never make use of LinkedList. It will be slower than ArrayList for most cases. And if taking from the first element does matter, we

[GitHub] [hbase] Apache9 commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache9 commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-799859021 > This looks great. > > What are the implications? Add them as release note. There is the xml format for configuring. What else? Call out your exclude of log4j1. It looks

[GitHub] [hbase] javierluca closed pull request #2973: HBASE-25594 graceful_stop.sh fails to unload regions when ran at localhost

javierluca closed pull request #2973: URL: https://github.com/apache/hbase/pull/2973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] javierluca commented on pull request #2973: HBASE-25594 graceful_stop.sh fails to unload regions when ran at localhost

javierluca commented on pull request #2973: URL: https://github.com/apache/hbase/pull/2973#issuecomment-799868302 Seems this was better solved at https://github.com/apache/hbase/pull/3048. So will close this PR. This is

[GitHub] [hbase] Apache-HBase commented on pull request #3046: HBASE-25653 Add units and round off region size to 2 digits after decimal

Apache-HBase commented on pull request #3046: URL: https://github.com/apache/hbase/pull/3046#issuecomment-799881168 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3043: HBASE-25568 Upgrade Thrift jar to fix CVE-2020-13949

Apache-HBase commented on pull request #3043: URL: https://github.com/apache/hbase/pull/3043#issuecomment-799889549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on a change in pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

bsglz commented on a change in pull request #3049: URL: https://github.com/apache/hbase/pull/3049#discussion_r594837551 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java ## @@ -873,6 +885,13 @@ public boolean

[GitHub] [hbase] taklwu commented on pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

taklwu commented on pull request #2931: URL: https://github.com/apache/hbase/pull/2931#issuecomment-799918388 fixed the commit from [fd649ce544553a7b2a2cfe9df0ea8a9bc49fa571](https://github.com/apache/hbase/commit/fd649ce544553a7b2a2cfe9df0ea8a9bc49fa571) to

[GitHub] [hbase] Apache-HBase commented on pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

Apache-HBase commented on pull request #3049: URL: https://github.com/apache/hbase/pull/3049#issuecomment-799946861 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2988: HBASE-25608 Support HFileOutputFormat locality sensitive even destination cluster is different from source cluster

Apache-HBase commented on pull request #2988: URL: https://github.com/apache/hbase/pull/2988#issuecomment-799958044 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2988: HBASE-25608 Support HFileOutputFormat locality sensitive even destination cluster is different from source cluster

Apache-HBase commented on pull request #2988: URL: https://github.com/apache/hbase/pull/2988#issuecomment-799963062 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] javierluca edited a comment on pull request #3048: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn

javierluca edited a comment on pull request #3048: URL: https://github.com/apache/hbase/pull/3048#issuecomment-799958984 @saintstack In my opinion, your change was better than mine because we could use `"localhost"` as argument, and that will work very well with `regionservers.sh` which

[GitHub] [hbase] saintstack commented on pull request #2663: HBASE-24637 - Reseek regression related to filter SKIP hinting

saintstack commented on pull request #2663: URL: https://github.com/apache/hbase/pull/2663#issuecomment-799840766 @ramkrish86 Any update here sir? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache9 commented on a change in pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache9 commented on a change in pull request #1708: URL: https://github.com/apache/hbase/pull/1708#discussion_r594784640 ## File path: bin/hbase ## @@ -658,7 +663,10 @@ elif [ "$COMMAND" = "mapredcp" ] ; then for f in "${HBASE_HOME}"/lib/client-facing-thirdparty/*.jar;

[GitHub] [hbase] Apache9 commented on a change in pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache9 commented on a change in pull request #1708: URL: https://github.com/apache/hbase/pull/1708#discussion_r594784683 ## File path: bin/hbase ## @@ -775,25 +783,31 @@ HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR" HBASE_OPTS="$HBASE_OPTS

[GitHub] [hbase] Apache-HBase commented on pull request #3018: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

Apache-HBase commented on pull request #3018: URL: https://github.com/apache/hbase/pull/3018#issuecomment-799880173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25395) Introduce PersistedStoreEngine and PersistedStoreFileManager

[ https://issues.apache.org/jira/browse/HBASE-25395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-25395: - Affects Version/s: 3.0.0-alpha-1 > Introduce PersistedStoreEngine and

[GitHub] [hbase] saintstack commented on pull request #3048: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn

saintstack commented on pull request #3048: URL: https://github.com/apache/hbase/pull/3048#issuecomment-799927706 @javierluca Thank you for taking a look. Looks like the stripServer needs to handle 'localhost'. Let me make an addendum

[GitHub] [hbase] Apache-HBase commented on pull request #3018: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

Apache-HBase commented on pull request #3018: URL: https://github.com/apache/hbase/pull/3018#issuecomment-799944591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799974235 cc @saintstack First commit revives your previous changes. Second one is addressing the commented issue with RegionMover.

[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799974235 cc @saintstack First commit revives your previous changes. Second one addresses the commented issue with RegionMover.

[GitHub] [hbase] javierluca edited a comment on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

javierluca edited a comment on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799974235 cc @saintstack First commit is yours. Second one is addressing the commented issue with RegionMover.

[GitHub] [hbase] saintstack commented on a change in pull request #3001: HBASE-25518 Support separate child regions to different region servers

saintstack commented on a change in pull request #3001: URL: https://github.com/apache/hbase/pull/3001#discussion_r594754063 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManagerUtil.java ## @@ -189,6 +190,67 @@ private static

[GitHub] [hbase] saintstack commented on a change in pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

saintstack commented on a change in pull request #2780: URL: https://github.com/apache/hbase/pull/2780#discussion_r594762484 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1127,7 +1128,9 @@ private boolean

[jira] [Commented] (HBASE-25597) Add row info in Exception when cell size exceeds maxCellSize

[ https://issues.apache.org/jira/browse/HBASE-25597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302166#comment-17302166 ] Baiqiang Zhao commented on HBASE-25597: --- Thank you [~stack] ! > Add row info in Exception when

[GitHub] [hbase] taklwu merged pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

taklwu merged pull request #2931: URL: https://github.com/apache/hbase/pull/2931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #3046: HBASE-25653 Add units and round off region size to 2 digits after decimal

Apache-HBase commented on pull request #3046: URL: https://github.com/apache/hbase/pull/3046#issuecomment-799924438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25395) Introduce PersistedStoreEngine and PersistedStoreFileManager

[ https://issues.apache.org/jira/browse/HBASE-25395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-25395. -- Release Note: Added `hbase.storefile.tracking.persist.enabled` to enable

[GitHub] [hbase] saintstack commented on pull request #3048: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn

saintstack commented on pull request #3048: URL: https://github.com/apache/hbase/pull/3048#issuecomment-799936784 Or, let me just revert this and commit your patch; it works for you. This is an automated message from the

[jira] [Updated] (HBASE-25663) Make graceful_stop localhostname compare match even if fqdn

[ https://issues.apache.org/jira/browse/HBASE-25663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25663: -- Fix Version/s: (was: 2.4.3) (was: 2.5.0)

[GitHub] [hbase] Apache-HBase commented on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

Apache-HBase commented on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799970407 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #2543: HBASE-25184 Move RegionLocationFinder to hbase-balancer

saintstack commented on a change in pull request #2543: URL: https://github.com/apache/hbase/pull/2543#discussion_r594871640 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java ## @@ -17,235 +17,187 @@ */ package

[GitHub] [hbase] saintstack commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

saintstack commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-799834561 Thank you @caroliney14 . This is a nice patch. Would be great to land it. This is an automated message from

[GitHub] [hbase] huaxiangsun opened a new pull request #3052: HBASE-25639 meta replica state is not respected during active master …

huaxiangsun opened a new pull request #3052: URL: https://github.com/apache/hbase/pull/3052 …switch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HBASE-25374) Make REST Client connection and socket time out configurable

[ https://issues.apache.org/jira/browse/HBASE-25374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302103#comment-17302103 ] Michael Stack commented on HBASE-25374: --- Merged to branch-2.3+ for [~pankajkumar] > Make REST

[GitHub] [hbase] saintstack commented on pull request #2626: HBASE-25029 Resolve the TODO of AssignmentManager's loadMeta() method.

saintstack commented on pull request #2626: URL: https://github.com/apache/hbase/pull/2626#issuecomment-799843476 Any update here @sanjeetnishad95 ? Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3018: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

sandeepvinayak commented on a change in pull request #3018: URL: https://github.com/apache/hbase/pull/3018#discussion_r594786984 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java ## @@

[GitHub] [hbase] bsglz commented on a change in pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

bsglz commented on a change in pull request #3049: URL: https://github.com/apache/hbase/pull/3049#discussion_r594806546 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8416,6 +8416,10 @@ public void

[GitHub] [hbase] taklwu edited a comment on pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

taklwu edited a comment on pull request #2931: URL: https://github.com/apache/hbase/pull/2931#issuecomment-799918388 fixed the commit from fd649ce544553a7b2a2cfe9df0ea8a9bc49fa571 to cca4cbf173f4320dcb9262e9a97deba27f7de15e with adding `Reviewed-by:` and `Signed-off-by:` to branch

[GitHub] [hbase] sandeepvinayak commented on pull request #3018: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

sandeepvinayak commented on pull request #3018: URL: https://github.com/apache/hbase/pull/3018#issuecomment-799947829 @wchevreuil do you mind reviewing this one? This is after your review [here](https://github.com/apache/hbase/pull/3009)

[jira] [Commented] (HBASE-25649) Complete the work on moving all the balancer related classes to hbase-balancer module

[ https://issues.apache.org/jira/browse/HBASE-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302228#comment-17302228 ] Michael Stack commented on HBASE-25649: --- Sorry. Late to design. Left a comment. > Complete the

[GitHub] [hbase] javierluca opened a new pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

javierluca opened a new pull request #3053: URL: https://github.com/apache/hbase/pull/3053 Previous: https://github.com/apache/hbase/pull/3048 Adding it again because it was revered: https://github.com/apache/hbase/commit/c36e40eb1c0e794358de3f0635df1e5848c7ac89 And

[GitHub] [hbase] javierluca commented on pull request #2973: HBASE-25594 graceful_stop.sh fails to unload regions when ran at localhost

javierluca commented on pull request #2973: URL: https://github.com/apache/hbase/pull/2973#issuecomment-799973621 Actually changes made it to master here: https://github.com/apache/hbase/commit/59ec375d679dcbf1701a92d4206ecc676a8fb069

[GitHub] [hbase] javierluca edited a comment on pull request #2973: HBASE-25594 graceful_stop.sh fails to unload regions when ran at localhost

javierluca edited a comment on pull request #2973: URL: https://github.com/apache/hbase/pull/2973#issuecomment-799973621 Actually changes made it to master here: https://github.com/apache/hbase/commit/59ec375d679dcbf1701a92d4206ecc676a8fb069 Trying further improvements at

[GitHub] [hbase] javierluca commented on pull request #3053: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn and unload regions

javierluca commented on pull request #3053: URL: https://github.com/apache/hbase/pull/3053#issuecomment-799974235 cc @saintstack This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HBASE-25184) Move RegionLocationFinder to hbase-balancer

[ https://issues.apache.org/jira/browse/HBASE-25184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302084#comment-17302084 ] Michael Stack commented on HBASE-25184: --- hbase-balancer doesn't seem like right place for

[jira] [Resolved] (HBASE-25374) Make REST Client connection and socket time out configurable

[ https://issues.apache.org/jira/browse/HBASE-25374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25374. --- Fix Version/s: 2.4.3 2.3.5 2.5.0 Hadoop Flags:

[jira] [Updated] (HBASE-25374) Make REST Client connection and socket time out configurable

[ https://issues.apache.org/jira/browse/HBASE-25374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25374: -- Affects Version/s: 2.4.3 2.5.0 3.0.0-alpha-1

[jira] [Commented] (HBASE-25184) Move RegionLocationFinder to hbase-balancer

[ https://issues.apache.org/jira/browse/HBASE-25184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302132#comment-17302132 ] Duo Zhang commented on HBASE-25184: --- RegionLocationFinder is only used by balancer related classes.

[GitHub] [hbase] bsglz commented on a change in pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

bsglz commented on a change in pull request #3049: URL: https://github.com/apache/hbase/pull/3049#discussion_r594808025 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java ## @@ -127,20 +127,22 @@ public MemStoreFlusher(final

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-799912356 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25663) Make graceful_stop localhostname compare match even if fqdn

[ https://issues.apache.org/jira/browse/HBASE-25663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302208#comment-17302208 ] Michael Stack commented on HBASE-25663: --- Reverted from branch-2.4+ > Make graceful_stop

[jira] [Reopened] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-25594: --- Reopening to apply the fix here instead of what was over in HBASE-25663. > graceful_stop.sh

[GitHub] [hbase] bitterfox commented on a change in pull request #2988: HBASE-25608 Support HFileOutputFormat locality sensitive even destination cluster is different from source cluster

bitterfox commented on a change in pull request #2988: URL: https://github.com/apache/hbase/pull/2988#discussion_r594873850 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java ## @@ -657,6 +683,49 @@ public static void

[GitHub] [hbase] saintstack merged pull request #2976: HBASE-25597 Add row info in Exception when cell size exceeds maxCellSize

saintstack merged pull request #2976: URL: https://github.com/apache/hbase/pull/2976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-25597) Add row info in Exception when cell size exceeds maxCellSize

[ https://issues.apache.org/jira/browse/HBASE-25597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25597. --- Fix Version/s: 2.4.3 2.3.5 2.5.0

[GitHub] [hbase] mnpoonia commented on pull request #2991: HBASE-25593 Backport changes from HBASE-24418 to branch-1

mnpoonia commented on pull request #2991: URL: https://github.com/apache/hbase/pull/2991#issuecomment-799834899 @virajjasani Can you help me review this in your free cycles This is an automated message from the Apache Git

[GitHub] [hbase] saintstack merged pull request #2690: HBASE-24395 Backport HBASE-20589 to branch-1

saintstack merged pull request #2690: URL: https://github.com/apache/hbase/pull/2690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #3052: HBASE-25639 meta replica state is not respected during active master …

Apache-HBase commented on pull request #3052: URL: https://github.com/apache/hbase/pull/3052#issuecomment-799856806 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] DivyeshChandra commented on a change in pull request #3046: HBASE-25653 Add units and round off region size to 2 digits after decimal

DivyeshChandra commented on a change in pull request #3046: URL: https://github.com/apache/hbase/pull/3046#discussion_r594789222 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -284,7 +284,7 @@ private

[GitHub] [hbase] Apache9 commented on a change in pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache9 commented on a change in pull request #1708: URL: https://github.com/apache/hbase/pull/1708#discussion_r594792572 ## File path: bin/hbase ## @@ -775,25 +783,31 @@ HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR" HBASE_OPTS="$HBASE_OPTS

[jira] [Comment Edited] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302137#comment-17302137 ] Javier Akira Luca de Tena edited comment on HBASE-25594 at 3/16/21, 1:19 AM:

[GitHub] [hbase] Apache-HBase commented on pull request #3052: HBASE-25639 meta replica state is not respected during active master …

Apache-HBase commented on pull request #3052: URL: https://github.com/apache/hbase/pull/3052#issuecomment-799896778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

Apache-HBase commented on pull request #3049: URL: https://github.com/apache/hbase/pull/3049#issuecomment-799905272 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302194#comment-17302194 ] Javier Akira Luca de Tena commented on HBASE-25594: --- [~stack] I left a comment in your

[jira] [Commented] (HBASE-25395) Introduce PersistedStoreEngine and PersistedStoreFileManager

[ https://issues.apache.org/jira/browse/HBASE-25395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302201#comment-17302201 ] Tak-Lon (Stephen) Wu commented on HBASE-25395: -- committed to feature branch

[GitHub] [hbase] xcangCRM commented on a change in pull request #3018: HBASE-25627: HBase replication should have a metric to represent if the source is stuck getting initialized

xcangCRM commented on a change in pull request #3018: URL: https://github.com/apache/hbase/pull/3018#discussion_r594861844 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/DynamicMetricsRegistry.java ## @@ -452,6 +450,41 @@ public

[jira] [Commented] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302137#comment-17302137 ] Javier Akira Luca de Tena commented on HBASE-25594: --- I think that will perfectly work

[GitHub] [hbase] Apache-HBase commented on pull request #3046: HBASE-25653 Add units and round off region size to 2 digits after decimal

Apache-HBase commented on pull request #3046: URL: https://github.com/apache/hbase/pull/3046#issuecomment-799923132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #2729: Remove the use of term segregate

saintstack commented on pull request #2729: URL: https://github.com/apache/hbase/pull/2729#issuecomment-799838050 Closing incomplete (if a good idea) This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] saintstack commented on pull request #2747: HBASE-24850 CellComparator perf improvement

saintstack commented on pull request #2747: URL: https://github.com/apache/hbase/pull/2747#issuecomment-799837711 Closing. You can read the comments here even if closed @ramkrish86 This is an automated message from the

[GitHub] [hbase] saintstack closed pull request #2747: HBASE-24850 CellComparator perf improvement

saintstack closed pull request #2747: URL: https://github.com/apache/hbase/pull/2747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack closed pull request #2729: Remove the use of term segregate

saintstack closed pull request #2729: URL: https://github.com/apache/hbase/pull/2729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-24395) ServerName#getHostname() is case sensitive

[ https://issues.apache.org/jira/browse/HBASE-24395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24395: -- Status: In Progress (was: Patch Available) > ServerName#getHostname() is case sensitive >

[jira] [Resolved] (HBASE-24395) ServerName#getHostname() is case sensitive

[ https://issues.apache.org/jira/browse/HBASE-24395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24395. --- Fix Version/s: 1.7.0 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[GitHub] [hbase] saintstack commented on pull request #2562: HBASE-25199 Remove deprecated HStore#getStoreHomedir methods

saintstack commented on pull request #2562: URL: https://github.com/apache/hbase/pull/2562#issuecomment-799844904 Any update here @HorizonNet ? Thanks boss. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-799848896 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #2352: HBASE-24925 SCP reduce unnecessary get requests

saintstack commented on a change in pull request #2352: URL: https://github.com/apache/hbase/pull/2352#discussion_r594777019 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java ## @@ -318,4 +326,39 @@ protected void

[jira] [Resolved] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Akira Luca de Tena resolved HBASE-25594. --- Resolution: Duplicate > graceful_stop.sh fails to unload regions

[jira] [Comment Edited] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302194#comment-17302194 ] Javier Akira Luca de Tena edited comment on HBASE-25594 at 3/16/21, 3:21 AM:

[GitHub] [hbase] taklwu commented on pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

taklwu commented on pull request #2931: URL: https://github.com/apache/hbase/pull/2931#issuecomment-799913582 > Minor comments, approved. Hey Zach @z-york since your comment are minor and I will implement them in the upcoming JIRA, I will push the commit AS IS to save another around

[GitHub] [hbase] bitterfox commented on a change in pull request #2988: HBASE-25608 Support HFileOutputFormat locality sensitive even destination cluster is different from source cluster

bitterfox commented on a change in pull request #2988: URL: https://github.com/apache/hbase/pull/2988#discussion_r594846183 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java ## @@ -657,6 +683,49 @@ public static void

[jira] [Reopened] (HBASE-25663) Make graceful_stop localhostname compare match even if fqdn

[ https://issues.apache.org/jira/browse/HBASE-25663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-25663: --- Reopening to revert in favor of HBASE-25594 > Make graceful_stop localhostname compare match

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-799947457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2988: HBASE-25608 Support HFileOutputFormat locality sensitive even destination cluster is different from source cluster

Apache-HBase commented on pull request #2988: URL: https://github.com/apache/hbase/pull/2988#issuecomment-799956588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25184) Move RegionLocationFinder to hbase-balancer

[ https://issues.apache.org/jira/browse/HBASE-25184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302224#comment-17302224 ] Michael Stack commented on HBASE-25184: --- I see now. Its even package private to the balancer

[GitHub] [hbase] javierluca commented on pull request #3048: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn

javierluca commented on pull request #3048: URL: https://github.com/apache/hbase/pull/3048#issuecomment-799969668 @saintstack addressing it at https://github.com/apache/hbase/pull/3053. Please have a look  This is an

  1   2   3   >