[GitHub] [hbase] Apache-HBase commented on pull request #3074: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3074: URL: https://github.com/apache/hbase/pull/3074#issuecomment-809752999 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication

2021-03-29 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25692: --- Fix Version/s: 2.2.7 > Failure to instantiate WALCellCodec leaks socket in replication >

[jira] [Updated] (HBASE-25498) [Documentation] Add a comment when using Secure HTTP (HTTPS) for the Web UI

2021-03-29 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25498: Component/s: documentation > [Documentation] Add a comment when using Secure HTTP (HTTPS) for the

[GitHub] [hbase] Apache-HBase commented on pull request #3104: HBASE-25712 backport HBASE-25962 to branch-1

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3104: URL: https://github.com/apache/hbase/pull/3104#issuecomment-809867057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3074: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3074: URL: https://github.com/apache/hbase/pull/3074#issuecomment-809756116 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25712) Port failure to close InputStream to 1.x

2021-03-29 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311049#comment-17311049 ] Josh Elser commented on HBASE-25712: Had to change the patch enough that I wanted to see a new QA

[jira] [Updated] (HBASE-25712) Port failure to close InputStream to 1.x

2021-03-29 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25712: --- Status: Patch Available (was: Open) > Port failure to close InputStream to 1.x >

[GitHub] [hbase] Apache-HBase commented on pull request #3093: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3093: URL: https://github.com/apache/hbase/pull/3093#issuecomment-809825414 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3093: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3093: URL: https://github.com/apache/hbase/pull/3093#issuecomment-809883026 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] brfrn169 merged pull request #3098: HBASE-25703 Support conditional update in MultiRowMutationEndpoint

2021-03-29 Thread GitBox
brfrn169 merged pull request #3098: URL: https://github.com/apache/hbase/pull/3098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] brfrn169 commented on a change in pull request #3099: HBASE-25706 Support specifying a base split policy class in KeyPrefix…

2021-03-29 Thread GitBox
brfrn169 commented on a change in pull request #3099: URL: https://github.com/apache/hbase/pull/3099#discussion_r603709462 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java ## @@ -77,12 +81,51 @@ protected void

[GitHub] [hbase] lujiefsi commented on a change in pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
lujiefsi commented on a change in pull request #3101: URL: https://github.com/apache/hbase/pull/3101#discussion_r603709386 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -963,6 +963,12 @@ public SplitTableRegionResponse

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809793660 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3099: HBASE-25706 Support specifying a base split policy class in KeyPrefix…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3099: URL: https://github.com/apache/hbase/pull/3099#issuecomment-809845030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809755351 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25712) Port failure to close InputStream to 1.x

2021-03-29 Thread Josh Elser (Jira)
Josh Elser created HBASE-25712: -- Summary: Port failure to close InputStream to 1.x Key: HBASE-25712 URL: https://issues.apache.org/jira/browse/HBASE-25712 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] joshelser commented on pull request #3104: HBASE-25712 backport HBASE-25962 to branch-1

2021-03-29 Thread GitBox
joshelser commented on pull request #3104: URL: https://github.com/apache/hbase/pull/3104#issuecomment-809816337 Only ran TestWALFactory locally. Expecting other things to break, but I'll let QA report those. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] joshelser opened a new pull request #3104: HBASE-25712 backport HBASE-25962 to branch-1

2021-03-29 Thread GitBox
joshelser opened a new pull request #3104: URL: https://github.com/apache/hbase/pull/3104 HBASE-25692 ensures that we do not leak any InputStream (Socket) which would otherwise remain as CLOSE_WAIT until the java process exits. These orphaned sockets would eventually saturate Linux

[jira] [Commented] (HBASE-25682) Add a new command to update the configuration of all RSs in a RSGroup

2021-03-29 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311109#comment-17311109 ] Baiqiang Zhao commented on HBASE-25682: --- Thank you [~stack]. My plan is branch-2 and master, is

[jira] [Updated] (HBASE-25682) Add a new command to update the configuration of all RSs in a RSGroup

2021-03-29 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Baiqiang Zhao updated HBASE-25682: -- Affects Version/s: 2.5.0 3.0.0-alpha-1 > Add a new command to update

[jira] [Commented] (HBASE-25713) Make an hbase-wal module

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311128#comment-17311128 ] Michael Stack commented on HBASE-25713: --- #3105 makes an hbase-coprocessor module. > Make an

[GitHub] [hbase] Apache-HBase commented on pull request #3099: HBASE-25706 Support specifying a base split policy class in KeyPrefix…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3099: URL: https://github.com/apache/hbase/pull/3099#issuecomment-809889667 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25675) Shrink size of hbase-server module

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311108#comment-17311108 ] Michael Stack commented on HBASE-25675: --- Let me work on branch named for this issue. > Shrink

[jira] [Created] (HBASE-25713) Make an hbase-wal module

2021-03-29 Thread Michael Stack (Jira)
Michael Stack created HBASE-25713: - Summary: Make an hbase-wal module Key: HBASE-25713 URL: https://issues.apache.org/jira/browse/HBASE-25713 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #3099: HBASE-25706 Support specifying a base split policy class in KeyPrefix…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3099: URL: https://github.com/apache/hbase/pull/3099#issuecomment-809912923 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-25675) Shrink size of hbase-server module

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311108#comment-17311108 ] Michael Stack edited comment on HBASE-25675 at 3/30/21, 4:38 AM: - Let me

[GitHub] [hbase] saintstack opened a new pull request #3105: HBASE-25713 Make an hbase-wal module

2021-03-29 Thread GitBox
saintstack opened a new pull request #3105: URL: https://github.com/apache/hbase/pull/3105 First extract an hbase-coprocessor module used by hbase-client, hbase-server. This is prerequisite to extracting an hbase-wal module. M

[GitHub] [hbase] lujiefsi commented on a change in pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
lujiefsi commented on a change in pull request #3101: URL: https://github.com/apache/hbase/pull/3101#discussion_r603781566 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -963,6 +963,12 @@ public SplitTableRegionResponse

[GitHub] [hbase] Apache-HBase commented on pull request #3093: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3093: URL: https://github.com/apache/hbase/pull/3093#issuecomment-809907855 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-809925790 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25687) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 and branch-1

2021-03-29 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1731#comment-1731 ] Baiqiang Zhao commented on HBASE-25687: --- Thanks [~stack] for review. > Backport "HBASE-25681 Add

[GitHub] [hbase] Apache-HBase commented on pull request #3105: HBASE-25713 Make an hbase-wal module

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-809932562 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25675) Shrink size of hbase-server module

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311105#comment-17311105 ] Michael Stack commented on HBASE-25675: --- Tried hbase-wal. The core will come out mostl but needs a

[GitHub] [hbase] saintstack commented on a change in pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
saintstack commented on a change in pull request #3101: URL: https://github.com/apache/hbase/pull/3101#discussion_r603765821 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -963,6 +963,12 @@ public SplitTableRegionResponse

[jira] [Commented] (HBASE-25682) Add a new command to update the configuration of all RSs in a RSGroup

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311131#comment-17311131 ] Michael Stack commented on HBASE-25682: --- Sounds good. > Add a new command to update the

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809174985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on a change in pull request #3100: HBASE-25707 When restoring a table, create a namespace if it does not exist

2021-03-29 Thread GitBox
wchevreuil commented on a change in pull request #3100: URL: https://github.com/apache/hbase/pull/3100#discussion_r603095951 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/RestoreTool.java ## @@ -487,12 +489,21 @@ private void

[GitHub] [hbase] lujiefsi opened a new pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
lujiefsi opened a new pull request #3101: URL: https://github.com/apache/hbase/pull/3101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] lujiefsi closed pull request #2937: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
lujiefsi closed pull request #2937: URL: https://github.com/apache/hbase/pull/2937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] lujiefsi commented on pull request #2937: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
lujiefsi commented on pull request #2937: URL: https://github.com/apache/hbase/pull/2937#issuecomment-809145582 close with new pull request https://github.com/apache/hbase/pull/2937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (HBASE-25709) Close region may stuck when region is compacting and skipping most cells read

2021-03-29 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-25709: -- Summary: Close region may stuck when region is compacting and skipping most cells read Key: HBASE-25709 URL: https://issues.apache.org/jira/browse/HBASE-25709 Project:

[jira] [Updated] (HBASE-25709) Close region may stuck when region is compacting and skipped most cells read

2021-03-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25709: --- Attachment: (was: RS-UI.png) > Close region may stuck when region is compacting and skipped

[jira] [Updated] (HBASE-25709) Close region may stuck when region is compacting and skipped most cells read

2021-03-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25709: --- Description: We found in our cluster about stop region stuck. The region is compacting, and its

[jira] [Updated] (HBASE-25709) Close region may stuck when region is compacting and skipped most cells read

2021-03-29 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25709: --- Summary: Close region may stuck when region is compacting and skipped most cells read (was: Close

[jira] [Created] (HBASE-25710) During the recovery process, an error is thrown if there is an incremental backup of data that has not been updated

2021-03-29 Thread shenshengli (Jira)
shenshengli created HBASE-25710: --- Summary: During the recovery process, an error is thrown if there is an incremental backup of data that has not been updated Key: HBASE-25710 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #3102: HBASE-25705 Convert proto to RSGroupInfo is costly

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3102: URL: https://github.com/apache/hbase/pull/3102#issuecomment-809344160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3102: HBASE-25705 Convert proto to RSGroupInfo is costly

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3102: URL: https://github.com/apache/hbase/pull/3102#issuecomment-809342517 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3102: HBASE-25705 Convert proto to RSGroupInfo is costly

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3102: URL: https://github.com/apache/hbase/pull/3102#issuecomment-809346481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25706) Support specifying a base split policy class in KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy

2021-03-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310668#comment-17310668 ] Duo Zhang commented on HBASE-25706: --- I do not think it is a good idea to add new features to

[GitHub] [hbase] mokai87 opened a new pull request #3102: HBASE-25705 Convert proto to RSGroupInfo is costly

2021-03-29 Thread GitBox
mokai87 opened a new pull request #3102: URL: https://github.com/apache/hbase/pull/3102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3103: HBASE-25710 Warning and skip when restoring incremental backups with no data updates

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3103: URL: https://github.com/apache/hbase/pull/3103#issuecomment-809367151 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3103: HBASE-25710 Warning and skip when restoring incremental backups with no data updates

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3103: URL: https://github.com/apache/hbase/pull/3103#issuecomment-809366465 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809366921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3103: HBASE-25710 Warning and skip when restoring incremental backups with no data updates

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3103: URL: https://github.com/apache/hbase/pull/3103#issuecomment-809379573 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m

[GitHub] [hbase] lujiefsi commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
lujiefsi commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809212405 > Same comment as posted in previous PR: If you want to add an audit log, you should use the `AUDITLOG` logger, instead of `LOG`. changed to AUDITLOG -- This is an

[jira] [Commented] (HBASE-25634) The client frequently exceeds the quota, which causes the meta table scan to be too high

2021-03-29 Thread zhengsicheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310529#comment-17310529 ] zhengsicheng commented on HBASE-25634: -- [~stack]  review code thank you! > The client frequently

[GitHub] [hbase] Apache-HBase commented on pull request #3100: HBASE-25707 When restoring a table, create a namespace if it does not exist

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3100: URL: https://github.com/apache/hbase/pull/3100#issuecomment-809299032 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809322446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809324668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809327123 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shenshengli opened a new pull request #3103: HBASE-25710 Warning and skip when restoring incremental backups with no data updates

2021-03-29 Thread GitBox
shenshengli opened a new pull request #3103: URL: https://github.com/apache/hbase/pull/3103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] shenshengli commented on a change in pull request #3100: HBASE-25707 When restoring a table, create a namespace if it does not exist

2021-03-29 Thread GitBox
shenshengli commented on a change in pull request #3100: URL: https://github.com/apache/hbase/pull/3100#discussion_r603183370 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/RestoreTool.java ## @@ -487,12 +489,21 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809274173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3100: HBASE-25707 When restoring a table, create a namespace if it does not exist

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3100: URL: https://github.com/apache/hbase/pull/3100#issuecomment-809293909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3100: HBASE-25707 When restoring a table, create a namespace if it does not exist

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3100: URL: https://github.com/apache/hbase/pull/3100#issuecomment-809293538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809309554 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3093: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3093: URL: https://github.com/apache/hbase/pull/3093#issuecomment-809478388 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809481940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3093: HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3093: URL: https://github.com/apache/hbase/pull/3093#issuecomment-809482676 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809527051 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25706) Support specifying a base split policy class in KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310807#comment-17310807 ] Michael Stack commented on HBASE-25706: --- I like the [~zhangduo] suggested break up of concerns;

[GitHub] [hbase] saintstack merged pull request #3090: HBASE-25692 Always try to close the WAL reader when we catch any exce…

2021-03-29 Thread GitBox
saintstack merged pull request #3090: URL: https://github.com/apache/hbase/pull/3090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25692. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to 2.3+. Shout if you want it to go

[jira] [Updated] (HBASE-25692) Failure to instantiate WALCellCodec leaks socket in replication

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25692: -- Fix Version/s: 2.3.6 2.4.3 2.5.0

[GitHub] [hbase] saintstack merged pull request #3082: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-29 Thread GitBox
saintstack merged pull request #3082: URL: https://github.com/apache/hbase/pull/3082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (HBASE-25687) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 and branch-1

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310942#comment-17310942 ] Michael Stack commented on HBASE-25687: --- Merged branch-1 patch. Waiting on re-build before merging

[jira] [Updated] (HBASE-25687) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 and branch-1

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25687: -- Release Note: Adds flags to disable server and table metrics. They are default on.

[GitHub] [hbase] saintstack commented on pull request #3074: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-29 Thread GitBox
saintstack commented on pull request #3074: URL: https://github.com/apache/hbase/pull/3074#issuecomment-809651482 Retrying builds. Failures look unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HBASE-25682) Add a new command to update the configuration of all RSs in a RSGroup

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310945#comment-17310945 ] Michael Stack commented on HBASE-25682: --- Seems good [~DeanZ]. What versions are you targetting?

[GitHub] [hbase] joshelser commented on pull request #3090: HBASE-25692 Always try to close the WAL reader when we catch any exce…

2021-03-29 Thread GitBox
joshelser commented on pull request #3090: URL: https://github.com/apache/hbase/pull/3090#issuecomment-809659322 Thanks for merging this in, Stack. Had it on my list but other things kept bumping it off. I'll follow up checking 1.x in Jira. -- This is an automated message from

[GitHub] [hbase] saintstack commented on a change in pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…

2021-03-29 Thread GitBox
saintstack commented on a change in pull request #3067: URL: https://github.com/apache/hbase/pull/3067#discussion_r603565022 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java ## @@ -522,6 +536,51 @@ public boolean

[GitHub] [hbase] saintstack commented on a change in pull request #3099: HBASE-25706 Support specifying a base split policy class in KeyPrefix…

2021-03-29 Thread GitBox
saintstack commented on a change in pull request #3099: URL: https://github.com/apache/hbase/pull/3099#discussion_r603494388 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java ## @@ -77,12 +81,51 @@ protected void

[jira] [Resolved] (HBASE-25710) During the recovery process, an error is thrown if there is an incremental backup of data that has not been updated

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25710. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[GitHub] [hbase] saintstack merged pull request #3103: HBASE-25710 Warning and skip when restoring incremental backups with no data updates

2021-03-29 Thread GitBox
saintstack merged pull request #3103: URL: https://github.com/apache/hbase/pull/3103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
saintstack commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809635427 Rerunning. Failures look unrelated. One comment above otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] saintstack commented on a change in pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
saintstack commented on a change in pull request #3101: URL: https://github.com/apache/hbase/pull/3101#discussion_r603541406 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -963,6 +963,12 @@ public SplitTableRegionResponse

[GitHub] [hbase] saintstack merged pull request #3100: HBASE-25707 When restoring a table, create a namespace if it does not exist

2021-03-29 Thread GitBox
saintstack merged pull request #3100: URL: https://github.com/apache/hbase/pull/3100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack merged pull request #3102: HBASE-25705 Convert proto to RSGroupInfo is costly

2021-03-29 Thread GitBox
saintstack merged pull request #3102: URL: https://github.com/apache/hbase/pull/3102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HBASE-25705) Convert proto to RSGroupInfo is costly

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25705. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[jira] [Created] (HBASE-25711) Setting wrong data block encoding through ColumnFamilyDescriptorBuilder#setValue leading to servers down

2021-03-29 Thread Rajeshbabu Chintaguntla (Jira)
Rajeshbabu Chintaguntla created HBASE-25711: --- Summary: Setting wrong data block encoding through ColumnFamilyDescriptorBuilder#setValue leading to servers down Key: HBASE-25711 URL:

[jira] [Resolved] (HBASE-25707) When restoring a table, create a namespace if it does not exist

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25707. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[jira] [Commented] (HBASE-25711) Setting wrong data block encoding through ColumnFamilyDescriptorBuilder#setValue leading to servers down

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310952#comment-17310952 ] Michael Stack commented on HBASE-25711: --- This is an old issue if you choose wrong encoder, or

[GitHub] [hbase] saintstack commented on pull request #3059: HBASE-25670 Backport HBASE-25665 to branch-1

2021-03-29 Thread GitBox
saintstack commented on pull request #3059: URL: https://github.com/apache/hbase/pull/3059#issuecomment-809673896 The .xml looks fine to me. Must be issue building w/ 1.7 jdk. Lets merge and see how it does. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (HBASE-25670) Backport HBASE-25665 to branch-1

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25670. --- Fix Version/s: 1.7.0 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[GitHub] [hbase] saintstack merged pull request #3059: HBASE-25670 Backport HBASE-25665 to branch-1

2021-03-29 Thread GitBox
saintstack merged pull request #3059: URL: https://github.com/apache/hbase/pull/3059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3101: HBASE-25558:Adding audit log for execMasterService

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3101: URL: https://github.com/apache/hbase/pull/3101#issuecomment-809683233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3074: HBASE-25687 Backport "HBASE-25681 Add a switch for server/table query…

2021-03-29 Thread GitBox
Apache-HBase commented on pull request #3074: URL: https://github.com/apache/hbase/pull/3074#issuecomment-809689478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #3030: HBASE-25634 The client scan frequently exceeds the quota, which cause…

2021-03-29 Thread GitBox
saintstack commented on a change in pull request #3030: URL: https://github.com/apache/hbase/pull/3030#discussion_r603598505 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedException.java ## @@ -48,7 +48,7 @@ public

[jira] [Commented] (HBASE-25634) The client frequently exceeds the quota, which causes the meta table scan to be too high

2021-03-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310968#comment-17310968 ] Michael Stack commented on HBASE-25634: --- See PR [~zhengsicheng] > The client frequently exceeds

[GitHub] [hbase] saintstack commented on a change in pull request #3030: HBASE-25634 The client scan frequently exceeds the quota, which cause…

2021-03-29 Thread GitBox
saintstack commented on a change in pull request #3030: URL: https://github.com/apache/hbase/pull/3030#discussion_r603598168 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java ## @@ -102,7 +103,13 @@ public T

  1   2   >