[GitHub] [hbase] Apache-HBase commented on pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…
Apache-HBase commented on pull request #3124: URL: https://github.com/apache/hbase/pull/3124#issuecomment-814613828 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 43s | master passed | | +1 :green_heart: | compile | 1m 45s | master passed | | +1 :green_heart: | shadedjars | 8m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 44s | the patch passed | | +1 :green_heart: | compile | 1m 48s | the patch passed | | +1 :green_heart: | javac | 1m 48s | the patch passed | | +1 :green_heart: | shadedjars | 8m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 1m 14s | hbase-client in the patch failed. | | -1 :x: | unit | 207m 12s | hbase-server in the patch failed. | | | | 244m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3124 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6d0234dd1595 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/testReport/ | | Max. process+thread count | 3136 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] gjacoby126 opened a new pull request #3130: HBASE-25740 - Backport HBASE-25629 to branch-1
gjacoby126 opened a new pull request #3130: URL: https://github.com/apache/hbase/pull/3130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…
Apache-HBase commented on pull request #3124: URL: https://github.com/apache/hbase/pull/3124#issuecomment-814589866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 46s | master passed | | +1 :green_heart: | compile | 1m 27s | master passed | | +1 :green_heart: | shadedjars | 7m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 38s | the patch passed | | +1 :green_heart: | compile | 1m 25s | the patch passed | | +1 :green_heart: | javac | 1m 25s | the patch passed | | +1 :green_heart: | shadedjars | 7m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 55s | hbase-client in the patch failed. | | -1 :x: | unit | 145m 56s | hbase-server in the patch failed. | | | | 177m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3124 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cb646ad1be04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/testReport/ | | Max. process+thread count | 5027 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24086) Disable output stream capability enforcement when running in standalone mode
[ https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315933#comment-17315933 ] Reid Chan commented on HBASE-24086: --- Oh, I see the invert in later commits, pardon~. > Disable output stream capability enforcement when running in standalone mode > > > Key: HBASE-24086 > URL: https://issues.apache.org/jira/browse/HBASE-24086 > Project: HBase > Issue Type: Task > Components: master, Operability >Affects Versions: 3.0.0-alpha-1, 2.3.0 >Reporter: Nick Dimiduk >Priority: Critical > > {noformat} > $ > JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home > mvn clean install -DskipTests > $ > JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home > ./bin/hbase master start > {noformat} > gives > {noformat} > 2020-03-30 17:12:43,857 ERROR > [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to > become active master > > java.io.IOException: cannot get log writer > > > at > org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118) > > > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704) > > > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710) > > > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128) > > > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839) > > > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549) > > > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490) > > > at > org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156) > > > at > org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61) > > > at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297) > > > at > org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256) > > > at > org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273) > > > at > org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482) > > > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587) > > > at > org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575) > > > at > org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961) > > > at >
[jira] [Commented] (HBASE-24086) Disable output stream capability enforcement when running in standalone mode
[ https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315931#comment-17315931 ] Reid Chan commented on HBASE-24086: --- Resolution is Won't Fix, but I see it applied to some branches, but there's no Fix version/s.. > Disable output stream capability enforcement when running in standalone mode > > > Key: HBASE-24086 > URL: https://issues.apache.org/jira/browse/HBASE-24086 > Project: HBase > Issue Type: Task > Components: master, Operability >Affects Versions: 3.0.0-alpha-1, 2.3.0 >Reporter: Nick Dimiduk >Priority: Critical > > {noformat} > $ > JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home > mvn clean install -DskipTests > $ > JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home > ./bin/hbase master start > {noformat} > gives > {noformat} > 2020-03-30 17:12:43,857 ERROR > [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to > become active master > > java.io.IOException: cannot get log writer > > > at > org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118) > > > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704) > > > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710) > > > at > org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128) > > > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839) > > > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549) > > > at > org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490) > > > at > org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156) > > > at > org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61) > > > at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297) > > > at > org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256) > > > at > org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273) > > > at > org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482) > > > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587) > > > at > org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575) > > > at > org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961) > > > at >
[jira] [Updated] (HBASE-24081) Provide documentation for running Yetus with HBase
[ https://issues.apache.org/jira/browse/HBASE-24081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24081: -- Fix Version/s: 1.7.0 > Provide documentation for running Yetus with HBase > -- > > Key: HBASE-24081 > URL: https://issues.apache.org/jira/browse/HBASE-24081 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0 > > > A colleague asked how to use Yetus with HBase, so I wrote up a little how-to > doc. Maybe it's useful to someone else? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24016) Change nightly poll from cron @daily to pollSCM @daily; i.e. run nightly if a change ONLY
[ https://issues.apache.org/jira/browse/HBASE-24016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24016: -- Fix Version/s: 1.7.0 > Change nightly poll from cron @daily to pollSCM @daily; i.e. run nightly if a > change ONLY > - > > Key: HBASE-24016 > URL: https://issues.apache.org/jira/browse/HBASE-24016 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 1.3.7, 1.7.0, 2.1.10, 1.4.14, 2.2.5 > > Attachments: > 0001-HBASE-24016-Change-nightly-poll-from-cron-daily-to-p.patch > > > Change build on branch-1.3, 1.4, 2.1, and feature branches > HBASE-23162-branch-1 and HBASE-22114-branch-1 to be pollSCM @daily -- i.e. > poll once a day and if change run nightly -- rather than build every night > regardless. > See > https://lists.apache.org/thread.html/r5dca2cacc123f2e5719c622add6853ac62b56b2a77885fe0b2eb53c3%40%3Cdev.hbase.apache.org%3E > for dev list discussion on downing our nightly load. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24305) Handle deprecations in ServerName
[ https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315914#comment-17315914 ] Hudson commented on HBASE-24305: Results for branch branch-2.4 [build #90 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/90/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/90/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/90/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/90/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/90/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Handle deprecations in ServerName > - > > Key: HBASE-24305 > URL: https://issues.apache.org/jira/browse/HBASE-24305 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0-alpha-1 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > Some functions in {{ServerName}} were deprecated in 2.0.0 and should be > removed for version 3.0.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…
Apache-HBase commented on pull request #3124: URL: https://github.com/apache/hbase/pull/3124#issuecomment-814552016 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 4m 9s | master passed | | +1 :green_heart: | checkstyle | 1m 33s | master passed | | +1 :green_heart: | spotbugs | 3m 4s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | -1 :x: | compile | 0m 43s | hbase-client in the patch failed. | | -0 :warning: | javac | 0m 43s | hbase-client in the patch failed. | | -0 :warning: | checkstyle | 0m 28s | hbase-client: The patch generated 4 new + 51 unchanged - 1 fixed = 55 total (was 52) | | -0 :warning: | checkstyle | 1m 3s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 52s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 3m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 52m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3124 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9edf470269cc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/patch-compile-hbase-client.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 95 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25735) Add target Region to connection exceptions
[ https://issues.apache.org/jira/browse/HBASE-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25735. --- Fix Version/s: 2.4.3 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch-2.4+. Thanks for review [~wchevreuil] > Add target Region to connection exceptions > -- > > Key: HBASE-25735 > URL: https://issues.apache.org/jira/browse/HBASE-25735 > Project: HBase > Issue Type: Bug > Components: rpc >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > We spent a bit of time making it so exceptions included the remote host name. > Looks like we can add the target Region name too with a bit of manipulation; > will help figuring hot-spotting or problem Region on serverside. For > example, here is what I was seeing recently on client-side when a RS was was > timing out requests: > {code} > 2021-04-06T02:18:23.533Z, RpcRetryingCaller{globalStartTime=1617675482894, > pause=100, maxAttempts=4}, org.apache.hadoop.hbase.ipc.CallTimeoutException: > Call to ps0989.example.org/1.1.1.1:16020 failed on local exception: > org.apache.hadoop.hbase.ipc.CallTimeoutException: > Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 > at > org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:145) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:383) > at org.apache.hadoop.hbase.client.HTable.get(HTable.java:357) > ... > Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to > ps0989.bot.parsec.apple.com/17.58.114.206:16020 failed on local exception: > org.apache.hadoop.hbase.ipc.CallTimeoutException: > Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 > at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:209) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:378) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:89) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:409) > at > org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:405) > at org.apache.hadoop.hbase.ipc.Call.setTimeout(Call.java:110) > at > org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:136) > at > org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:672) > at > org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:747) > at > org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:472) > ... 1 more > Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: > Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 > at > org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:137) > ... 4 more > {code} > I wanted the region it was hitting. I wanted to know if it was a server > problem or a Region issue. If clients only having issue w/ one Region, then I > could focus on it. > After the PR the exception (from another context) looks like this: > {code} > org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to > address=127.0.0.1:12345, regionInfo=hbase:meta,,1.1588230740 failed on local > exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: error > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25741) Replication Source still having the replication metrics for peer ID which doesn't exist.
Sandeep Pal created HBASE-25741: --- Summary: Replication Source still having the replication metrics for peer ID which doesn't exist. Key: HBASE-25741 URL: https://issues.apache.org/jira/browse/HBASE-25741 Project: HBase Issue Type: Bug Affects Versions: 1.8.0 Reporter: Sandeep Pal Assignee: Sandeep Pal We have observed that replication source metrics for peer exists on some region servers even though peer has been removed. This is because when we encounter the NoNodeException in ReplicationSource, it calls the `peerRemoved` workflow which should eventually terminate the source and removes the source from the source manager. Now, the problem is ReplicationSource thread terminates itself and thus the action to removePeer is not complete leaving the metrics there forever for source. This is the flow, replication source trying to clean wals [here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L801] and on NoNodeException it calls the [peerRemoved|https://github.com/apache/hbase/blob/b231dd620f107b488b88599e16dc846eb856972c/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java#L244] and terminate the source (itself), leaving the terminated source there in sourcemanager and not clearing it's [metrics|https://github.com/apache/hbase/blob/b231dd620f107b488b88599e16dc846eb856972c/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java#L645]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] chrajeshbabu commented on pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…
chrajeshbabu commented on pull request #3124: URL: https://github.com/apache/hbase/pull/3124#issuecomment-814536464 @joshelser Thanks for review please review updated changes. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] chrajeshbabu commented on a change in pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…
chrajeshbabu commented on a change in pull request #3124: URL: https://github.com/apache/hbase/pull/3124#discussion_r608280016 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java ## @@ -282,6 +283,8 @@ private final static Set RESERVED_KEYWORDS = new HashSet<>(); + private final static Map> ATTRIBUTE_VALIDATOR = new HashMap<>(); Review comment: Moved those to separate class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] chrajeshbabu commented on a change in pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…
chrajeshbabu commented on a change in pull request #3124: URL: https://github.com/apache/hbase/pull/3124#discussion_r608279896 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java ## @@ -305,6 +308,30 @@ RESERVED_KEYWORDS.add(new Bytes(Bytes.toBytes(IS_MOB))); RESERVED_KEYWORDS.add(new Bytes(Bytes.toBytes(MOB_THRESHOLD))); RESERVED_KEYWORDS.add(new Bytes(Bytes.toBytes(MOB_COMPACT_PARTITION_POLICY))); +initValidator(); + } + + private static void initValidator() { +ATTRIBUTE_VALIDATOR.put(DATA_BLOCK_ENCODING_BYTES, + (d) -> DataBlockEncoding.valueOf(d.toString())); +ATTRIBUTE_VALIDATOR.put(COMPRESSION_BYTES, + (ca) -> Compression.Algorithm.valueOf(ca.toString())); +ATTRIBUTE_VALIDATOR.put(BLOOMFILTER_BYTES, (bl) -> BloomType.valueOf(bl.toString())); +ATTRIBUTE_VALIDATOR.put(REPLICATION_SCOPE_BYTES, (rs) -> Integer.valueOf(rs.toString())); +ATTRIBUTE_VALIDATOR.put(MIN_VERSIONS_BYTES, (min) -> Integer.valueOf(min.toString())); +ATTRIBUTE_VALIDATOR.put(MAX_VERSIONS_BYTES, (max) -> Integer.valueOf(max.toString())); +ATTRIBUTE_VALIDATOR.put(BLOCKSIZE_BYTES, (bs) -> Integer.valueOf(bs.toString())); +ATTRIBUTE_VALIDATOR.put(KEEP_DELETED_CELLS_BYTES, + (k) -> KeepDeletedCells.valueOf(k.toString())); +ATTRIBUTE_VALIDATOR.put(TTL_BYTES, (ttl) -> Integer.valueOf(ttl.toString())); +ATTRIBUTE_VALIDATOR.put(DFS_REPLICATION_BYTES, (dr) -> Integer.valueOf(dr.toString())); +ATTRIBUTE_VALIDATOR.put(MOB_THRESHOLD_BYTES, (mt) -> Long.valueOf(mt.toString())); +ATTRIBUTE_VALIDATOR.put(MOB_COMPACT_PARTITION_POLICY_BYTES, + (mc) -> MobCompactPartitionPolicy.valueOf(mc.toString())); +ATTRIBUTE_VALIDATOR.put(IN_MEMORY_COMPACTION_BYTES, + (im) -> MemoryCompactionPolicy.valueOf(im.toString())); +ATTRIBUTE_VALIDATOR.put(COMPRESSION_COMPACT_BYTES, + (ca) -> Compression.Algorithm.valueOf(ca.toString())); Review comment: TableDescriptorChecker handling most of the validations but checking for valid data block encoding is missed so added that so it should be fine both create and modify cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] chrajeshbabu commented on a change in pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…
chrajeshbabu commented on a change in pull request #3124: URL: https://github.com/apache/hbase/pull/3124#discussion_r608279361 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java ## @@ -1376,5 +1404,16 @@ public ModifyableColumnFamilyDescriptor setStoragePolicy(String policy) { return setValue(STORAGE_POLICY_BYTES, policy); } +/** + * Validates values of HBase defined column family attributes. + * Throws {@link IllegalArgumentException} if the value of attribute is not proper format. + * @param key + * @param value + */ +public void validateAttributeValue(Bytes key, Bytes value) { + if(ATTRIBUTE_VALIDATOR.containsKey(key)) { +ATTRIBUTE_VALIDATOR.get(key).apply(value); Review comment: Printing error message what attribute failed to parse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…
Apache-HBase commented on pull request #3067: URL: https://github.com/apache/hbase/pull/3067#issuecomment-814526928 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 7m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 7m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 148m 26s | hbase-server in the patch passed. | | | | 177m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3067 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4315ee259dba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/testReport/ | | Max. process+thread count | 4154 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…
Apache-HBase commented on pull request #3067: URL: https://github.com/apache/hbase/pull/3067#issuecomment-814523852 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 1m 12s | master passed | | +1 :green_heart: | shadedjars | 7m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 7m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 136m 39s | hbase-server in the patch passed. | | | | 166m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3067 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f440a0415345 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/testReport/ | | Max. process+thread count | 4120 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #3113: HBASE-25640 Support hbase rpc compression for remote rpc only
huaxiangsun commented on a change in pull request #3113: URL: https://github.com/apache/hbase/pull/3113#discussion_r608243054 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java ## @@ -89,7 +90,18 @@ protected RpcConnection(Configuration conf, HashedWheelTimer timeoutTimer, Conne MetricsConnection metrics) throws IOException { this.timeoutTimer = timeoutTimer; this.codec = codec; -this.compressor = compressor; +if (compressor != null) { + // Only enable compression for remote rpcs. + InetSocketAddress remoteAddr = Address.toSocketAddress(remoteId.getAddress()); Review comment: will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #3113: HBASE-25640 Support hbase rpc compression for remote rpc only
huaxiangsun commented on a change in pull request #3113: URL: https://github.com/apache/hbase/pull/3113#discussion_r608242892 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java ## @@ -89,7 +90,18 @@ protected RpcConnection(Configuration conf, HashedWheelTimer timeoutTimer, Conne MetricsConnection metrics) throws IOException { this.timeoutTimer = timeoutTimer; this.codec = codec; -this.compressor = compressor; +if (compressor != null) { Review comment: Checking if compressor is null is that it can avoid a dns resolution if compressor is null (no compression is configured), which is the common use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…
Apache-HBase commented on pull request #3067: URL: https://github.com/apache/hbase/pull/3067#issuecomment-814484374 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | master passed | | +1 :green_heart: | compile | 3m 12s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 2m 6s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | compile | 3m 10s | the patch passed | | +1 :green_heart: | javac | 3m 10s | the patch passed | | -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 1 new + 84 unchanged - 17 fixed = 85 total (was 101) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 47m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3067 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux e3bcdda46afc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3067/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25740) Backport HBASE-25629 to branch-1
Geoffrey Jacoby created HBASE-25740: --- Summary: Backport HBASE-25629 to branch-1 Key: HBASE-25740 URL: https://issues.apache.org/jira/browse/HBASE-25740 Project: HBase Issue Type: Test Affects Versions: 1.7.0 Reporter: Geoffrey Jacoby Assignee: Geoffrey Jacoby HBASE-25629 recently fixed an issue where TestCurrentHourProvider consistently failed on certain OSes due to quirks in time zone implementations. This test is also failing in branch-1, so in order to expedite a potential 1.7.0 release we should backport to branch-1 as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3129: HBASE-25738 Backport HBASE-24305 to branch-2.2
Apache-HBase commented on pull request #3129: URL: https://github.com/apache/hbase/pull/3129#issuecomment-814460635 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 14 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 27s | branch-2.2 passed | | +1 :green_heart: | compile | 1m 45s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 2m 42s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 21s | branch-2.2 passed | | +0 :ok: | spotbugs | 3m 29s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 32s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 8s | the patch passed | | +1 :green_heart: | compile | 1m 43s | the patch passed | | +1 :green_heart: | javac | 1m 43s | the patch passed | | +1 :green_heart: | checkstyle | 0m 27s | hbase-common: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25) | | +1 :green_heart: | checkstyle | 0m 40s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 34s | hbase-server: The patch generated 0 new + 279 unchanged - 3 fixed = 279 total (was 282) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 23s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 28m 17s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 1m 18s | the patch passed | | +1 :green_heart: | findbugs | 5m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 2s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 3m 39s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 113m 52s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 1m 10s | The patch does not generate ASF License warnings. | | | | 200m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3129/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3129 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a75788124e43 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3129/out/precommit/personality/provided.sh | | git revision | branch-2.2 / a227a4aa37 | | Default Java | Oracle Corporation-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3129/1/testReport/ | | Max. process+thread count | 2244 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3129/1/console | | versions | git=2.20.1 maven=3.6.3 findbugs=3.1.11 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…
clarax commented on a change in pull request #3067: URL: https://github.com/apache/hbase/pull/3067#discussion_r608188206 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -816,65 +821,30 @@ protected void regionMoved(int region, int oldServer, int newServer) { * * @param stats the costs * @return a scaled set of costs. - */ -protected double costFromArray(double[] stats) { + */ protected double costFromArray(double[] stats) { Review comment: It was a deletion of eol. but I will put it back for styling -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…
clarax commented on a change in pull request #3067: URL: https://github.com/apache/hbase/pull/3067#discussion_r608187077 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java ## @@ -834,22 +908,20 @@ void regionMoved(int region, int oldServer, int newServer) { int tableIndex = regionIndexToTableIndex[region]; if (oldServer >= 0) { numRegionsPerServerPerTable[oldServer][tableIndex]--; +// update regionSkewPerTable for the move from old server +regionSkewByTable += +Math.abs(numRegionsPerServerPerTable[oldServer][tableIndex] + - meanRegionsPerTable[tableIndex]) + - Math.abs(numRegionsPerServerPerTable[oldServer][tableIndex] + 1 + - meanRegionsPerTable[tableIndex]); } numRegionsPerServerPerTable[newServer][tableIndex]++; - - //check whether this caused maxRegionsPerTable in the new Server to be updated - if (numRegionsPerServerPerTable[newServer][tableIndex] > numMaxRegionsPerTable[tableIndex]) { -numMaxRegionsPerTable[tableIndex] = numRegionsPerServerPerTable[newServer][tableIndex]; - } else if (oldServer >= 0 && (numRegionsPerServerPerTable[oldServer][tableIndex] + 1) - == numMaxRegionsPerTable[tableIndex]) { -//recompute maxRegionsPerTable since the previous value was coming from the old server -numMaxRegionsPerTable[tableIndex] = 0; -for (int[] aNumRegionsPerServerPerTable : numRegionsPerServerPerTable) { - if (aNumRegionsPerServerPerTable[tableIndex] > numMaxRegionsPerTable[tableIndex]) { -numMaxRegionsPerTable[tableIndex] = aNumRegionsPerServerPerTable[tableIndex]; - } -} - } + // update regionSkewPerTable for the move to new server + regionSkewByTable += +Math.abs(numRegionsPerServerPerTable[newServer][tableIndex] + - meanRegionsPerTable[tableIndex]) + - Math.abs(numRegionsPerServerPerTable[newServer][tableIndex] - 1 + - meanRegionsPerTable[tableIndex]); Review comment: It I s not a duplicate. The previous was "- Math.abs(numRegionsPerServerPerTable[newServer][tableIndex] + 1" vs line 923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25713) Make an hbase-wal module
[ https://issues.apache.org/jira/browse/HBASE-25713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25713. --- Resolution: Won't Fix Resolving as failed experiment > Make an hbase-wal module > > > Key: HBASE-25713 > URL: https://issues.apache.org/jira/browse/HBASE-25713 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Major > > Extract an hbase-wal module upon which hbase-server can depend; makes > hbase-server smaller and maybe we could do an hbase-wal standalone... This is > an experiment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] clarax commented on a change in pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…
clarax commented on a change in pull request #3067: URL: https://github.com/apache/hbase/pull/3067#discussion_r608178962 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java ## @@ -522,6 +536,51 @@ public boolean serverHasTooFewRegions(int server) { return numRegions < minLoad; } +/** + * Return the min skew of distribution + */ +public static double getMinSkew(double total, double numServers) { Review comment: Yes. They are used else where so that they are also static. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315844#comment-17315844 ] Clara Xiong commented on HBASE-25739: - https://github.com/apache/hbase/pull/3067 > TableSkewCostFunction need to use aggregated deviation > -- > > Key: HBASE-25739 > URL: https://issues.apache.org/jira/browse/HBASE-25739 > Project: HBase > Issue Type: Sub-task > Components: Balancer, master >Reporter: Clara Xiong >Priority: Major > > TableSkewCostFunction uses the sum of the max deviation region per server for > all tables as the measure of unevenness. It doesn't work in a very common > scenario in operations. Say we have 100 regions on 50 nodes, two on each. We > add 50 new nodes and they have 0 each. The max deviation from the mean is 1, > compared to 99 in the worst case scenario of 100 regions on a single server. > The normalized cost is 1/99 = 0.011 < default threshold of 0.05. Balancer > wouldn't move. The proposal is to use the standard deviation of the count > per region server to detect this scenario, generating a cost of 3.1/31 = 0.1 > in this case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation
Clara Xiong created HBASE-25739: --- Summary: TableSkewCostFunction need to use aggregated deviation Key: HBASE-25739 URL: https://issues.apache.org/jira/browse/HBASE-25739 Project: HBase Issue Type: Sub-task Components: Balancer, master Reporter: Clara Xiong TableSkewCostFunction uses the sum of the max deviation region per server for all tables as the measure of unevenness. It doesn't work in a very common scenario in operations. Say we have 100 regions on 50 nodes, two on each. We add 50 new nodes and they have 0 each. The max deviation from the mean is 1, compared to 99 in the worst case scenario of 100 regions on a single server. The normalized cost is 1/99 = 0.011 < default threshold of 0.05. Balancer wouldn't move. The proposal is to use the standard deviation of the count per region server to detect this scenario, generating a cost of 3.1/31 = 0.1 in this case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack commented on pull request #3105: URL: https://github.com/apache/hbase/pull/3105#issuecomment-814434224 Failed project. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack closed pull request #3105: HBASE-25713 Make an hbase-wal module
saintstack closed pull request #3105: URL: https://github.com/apache/hbase/pull/3105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3128: HBASE-25737 Backport HBASE-24305 to branch-2.3
Apache-HBase commented on pull request #3128: URL: https://github.com/apache/hbase/pull/3128#issuecomment-814433687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 8s | branch-2.3 passed | | +1 :green_heart: | compile | 2m 0s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 50s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 2m 0s | the patch passed | | +1 :green_heart: | javac | 2m 0s | the patch passed | | +1 :green_heart: | shadedjars | 5m 50s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 49s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 2m 28s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 135m 51s | hbase-server in the patch passed. | | | | 171m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3128 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 033e5cfc4fdc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 96773913ce | | Default Java | AdoptOpenJDK-11.0.10+9 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/testReport/ | | Max. process+thread count | 3676 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3128: HBASE-25737 Backport HBASE-24305 to branch-2.3
Apache-HBase commented on pull request #3128: URL: https://github.com/apache/hbase/pull/3128#issuecomment-814432101 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 33s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 45s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 24s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 1m 43s | the patch passed | | +1 :green_heart: | javac | 1m 43s | the patch passed | | +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 24s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 2m 16s | hbase-client in the patch passed. | | -1 :x: | unit | 138m 7s | hbase-server in the patch failed. | | | | 168m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3128 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1e101445ef8a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 96773913ce | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/testReport/ | | Max. process+thread count | 4359 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3126: HBASE-25735 Add target Region to connection exceptions
Apache-HBase commented on pull request #3126: URL: https://github.com/apache/hbase/pull/3126#issuecomment-814407581 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | branch-2 passed | | +1 :green_heart: | compile | 1m 44s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 45s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 54s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | compile | 1m 43s | the patch passed | | +1 :green_heart: | javac | 1m 43s | the patch passed | | -0 :warning: | checkstyle | 0m 35s | hbase-client: The patch generated 1 new + 10 unchanged - 0 fixed = 11 total (was 10) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 59s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 40m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3126 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux b3101aafb9da 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 18882d6f9a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | Max. process+thread count | 86 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-endpoint U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3126: HBASE-25735 Add target Region to connection exceptions
Apache-HBase commented on pull request #3126: URL: https://github.com/apache/hbase/pull/3126#issuecomment-814405623 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 43s | branch-2 passed | | +1 :green_heart: | compile | 0m 58s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 7m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 57s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 2m 49s | hbase-endpoint in the patch passed. | | | | 36m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3126 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux caaea6480276 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 18882d6f9a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/testReport/ | | Max. process+thread count | 1707 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-endpoint U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3126: HBASE-25735 Add target Region to connection exceptions
Apache-HBase commented on pull request #3126: URL: https://github.com/apache/hbase/pull/3126#issuecomment-814402517 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 37s | branch-2 passed | | +1 :green_heart: | compile | 0m 53s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 6m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 46s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 2m 47s | hbase-endpoint in the patch passed. | | | | 31m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3126 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7768fa12d3ae 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 18882d6f9a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/testReport/ | | Max. process+thread count | 2355 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-endpoint U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3128: HBASE-25737 Backport HBASE-24305 to branch-2.3
Apache-HBase commented on pull request #3128: URL: https://github.com/apache/hbase/pull/3128#issuecomment-814367911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 49s | branch-2.3 passed | | +1 :green_heart: | compile | 5m 0s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 2m 17s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 4m 5s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | compile | 4m 56s | the patch passed | | +1 :green_heart: | javac | 4m 56s | the patch passed | | +1 :green_heart: | checkstyle | 0m 22s | hbase-common: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25) | | +1 :green_heart: | checkstyle | 0m 35s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 18s | hbase-server: The patch generated 0 new + 275 unchanged - 3 fixed = 275 total (was 278) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 33s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 4m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 60m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3128 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux c790f2770e3a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 96773913ce | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] HorizonNet opened a new pull request #3129: HBASE-25738 Backport HBASE-24305 to branch-2.2
HorizonNet opened a new pull request #3129: URL: https://github.com/apache/hbase/pull/3129 Signed-off-by: Duo Zhang Signed-off-by: stack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-25738) Backport HBASE-24305 to branch-2.2
[ https://issues.apache.org/jira/browse/HBASE-25738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25738 started by Jan Hentschel. - > Backport HBASE-24305 to branch-2.2 > -- > > Key: HBASE-25738 > URL: https://issues.apache.org/jira/browse/HBASE-25738 > Project: HBase > Issue Type: Task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Labels: backport > Fix For: 2.2.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] HorizonNet opened a new pull request #3128: HBASE-25737 Backport HBASE-24305 to branch-2.3
HorizonNet opened a new pull request #3128: URL: https://github.com/apache/hbase/pull/3128 Signed-off-by: Duo Zhang Signed-off-by: stack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24305) Handle deprecations in ServerName
[ https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315752#comment-17315752 ] Hudson commented on HBASE-24305: Results for branch branch-2 [build #220 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/220/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/220/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/220/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/220/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/220/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Handle deprecations in ServerName > - > > Key: HBASE-24305 > URL: https://issues.apache.org/jira/browse/HBASE-24305 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0-alpha-1 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > Some functions in {{ServerName}} were deprecated in 2.0.0 and should be > removed for version 3.0.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25738) Backport HBASE-24305 to branch-2.2
[ https://issues.apache.org/jira/browse/HBASE-25738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-25738: -- Fix Version/s: (was: 2.3.6) 2.2.7 > Backport HBASE-24305 to branch-2.2 > -- > > Key: HBASE-25738 > URL: https://issues.apache.org/jira/browse/HBASE-25738 > Project: HBase > Issue Type: Task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Labels: backport > Fix For: 2.2.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25738) Backport HBASE-24305 to branch-2.2
Jan Hentschel created HBASE-25738: - Summary: Backport HBASE-24305 to branch-2.2 Key: HBASE-25738 URL: https://issues.apache.org/jira/browse/HBASE-25738 Project: HBase Issue Type: Task Reporter: Jan Hentschel Assignee: Jan Hentschel Fix For: 2.3.6 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25737) Backport HBASE-24305 to branch-2.3
Jan Hentschel created HBASE-25737: - Summary: Backport HBASE-24305 to branch-2.3 Key: HBASE-25737 URL: https://issues.apache.org/jira/browse/HBASE-25737 Project: HBase Issue Type: Task Reporter: Jan Hentschel Assignee: Jan Hentschel Fix For: 2.3.6 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-25737) Backport HBASE-24305 to branch-2.3
[ https://issues.apache.org/jira/browse/HBASE-25737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25737 started by Jan Hentschel. - > Backport HBASE-24305 to branch-2.3 > -- > > Key: HBASE-25737 > URL: https://issues.apache.org/jira/browse/HBASE-25737 > Project: HBase > Issue Type: Task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Labels: backport > Fix For: 2.3.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25734) Backport HBASE-24305 to branch-2.4
[ https://issues.apache.org/jira/browse/HBASE-25734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-25734. --- Resolution: Fixed > Backport HBASE-24305 to branch-2.4 > -- > > Key: HBASE-25734 > URL: https://issues.apache.org/jira/browse/HBASE-25734 > Project: HBase > Issue Type: Task >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > Labels: backport > Fix For: 2.4.3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] HorizonNet merged pull request #3125: HBASE-25734 Backport HBASE-24305 to branch-2.4
HorizonNet merged pull request #3125: URL: https://github.com/apache/hbase/pull/3125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25731) TestConnectionImplementation BadHostname tests fail in branch-1
[ https://issues.apache.org/jira/browse/HBASE-25731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315665#comment-17315665 ] Hudson commented on HBASE-25731: Results for branch branch-1 [build #110 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/110/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/110//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/110//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/110//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > TestConnectionImplementation BadHostname tests fail in branch-1 > --- > > Key: HBASE-25731 > URL: https://issues.apache.org/jira/browse/HBASE-25731 > Project: HBase > Issue Type: Test >Affects Versions: 1.7.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 1.7.0 > > > TestConnectionImplementation.testGetAdminBadHostname and > testGetClientBadHostname are consistently failing in branch-1. > This is because they're assuming that the validity of the host is checked > immediately upon getting the protobuf service object, when instead the > service code purposefully waits until the first service call to check. > I'll revise the tests to make service calls and verify that they return the > correct exceptions (ServiceException wrapping an UnknownHostException). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3127: HBASE-25736 Scan should be limited by read capacity unit quota if read size quota is not set
Apache-HBase commented on pull request #3127: URL: https://github.com/apache/hbase/pull/3127#issuecomment-814105333 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | shadedjars | 8m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 8m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 213m 25s | hbase-server in the patch passed. | | | | 245m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3127 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c974f381b638 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/testReport/ | | Max. process+thread count | 3684 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3127: HBASE-25736 Scan should be limited by read capacity unit quota if read size quota is not set
Apache-HBase commented on pull request #3127: URL: https://github.com/apache/hbase/pull/3127#issuecomment-814058352 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 27s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 7m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 7m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 138m 19s | hbase-server in the patch passed. | | | | 169m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3127 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a7d788b1fc25 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/testReport/ | | Max. process+thread count | 3622 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3127: HBASE-25736 Scan should be limited by read capacity unit quota if read size quota is not set
Apache-HBase commented on pull request #3127: URL: https://github.com/apache/hbase/pull/3127#issuecomment-813987895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | master passed | | +1 :green_heart: | compile | 3m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 2m 6s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | compile | 3m 12s | the patch passed | | +1 :green_heart: | javac | 3m 12s | the patch passed | | +1 :green_heart: | checkstyle | 1m 2s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 43s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 46m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3127 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3af459748d5a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 048ca4e43f | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3127/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] mymeiyi opened a new pull request #3127: HBASE-25736 Scan should be limited by read capacity unit quota if read size quota is not set
mymeiyi opened a new pull request #3127: URL: https://github.com/apache/hbase/pull/3127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25708) Bytes.toInt(byte[] bytes)-why set default offset as zero
[ https://issues.apache.org/jira/browse/HBASE-25708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] larry chen updated HBASE-25708: --- Priority: Blocker (was: Major) > Bytes.toInt(byte[] bytes)-why set default offset as zero > > > Key: HBASE-25708 > URL: https://issues.apache.org/jira/browse/HBASE-25708 > Project: HBase > Issue Type: Improvement > Components: community >Reporter: larry chen >Priority: Blocker > > As we know, when using Bytes.tobytes(int), the method convert the int value > to byte-array with big endian. > So, when we try to extract the right int-value from byte-array, we use method > 'Bytes.toInt(byte[] bytes)', and int the method, it sets the offset as zero. > > it shows like this > /** > * Converts a byte array to an int value > * @param bytes byte array > * @return the int value > */ > public static int toInt(byte[] bytes) { > return toInt(bytes, 0, SIZEOF_INT); > } > My question is : > why don't we set the offset as (bytes.length - SIZEOF_INT)? > > Recently, we have long-value stored in hbase, as we try to extract, we decode > the byte-array as int-value, it leads some incorrect-value like 0. > > The usage of decoding-int-value from long-value-byte-array is wrong, I'm just > curious about the start point of setting offset as 0 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3126: HBASE-25735 Add target Region to connection exceptions
Apache-HBase commented on pull request #3126: URL: https://github.com/apache/hbase/pull/3126#issuecomment-813895186 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 1s | branch-2 passed | | +1 :green_heart: | compile | 1m 59s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 51s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 2s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 28s | the patch passed | | +1 :green_heart: | compile | 1m 53s | the patch passed | | +1 :green_heart: | javac | 1m 53s | the patch passed | | -0 :warning: | checkstyle | 0m 36s | hbase-client: The patch generated 1 new + 10 unchanged - 0 fixed = 11 total (was 10) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 49m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3126 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1af21ccb6929 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 18882d6f9a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | Max. process+thread count | 86 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-endpoint U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25687) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 and branch-1
[ https://issues.apache.org/jira/browse/HBASE-25687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315309#comment-17315309 ] Baiqiang Zhao commented on HBASE-25687: --- Hi [~stack] , the rebuild for branch-2 seems good now. > Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 > and branch-1 > > > Key: HBASE-25687 > URL: https://issues.apache.org/jira/browse/HBASE-25687 > Project: HBase > Issue Type: Sub-task >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3126: HBASE-25735 Add target Region to connection exceptions
Apache-HBase commented on pull request #3126: URL: https://github.com/apache/hbase/pull/3126#issuecomment-813886423 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 45s | branch-2 passed | | +1 :green_heart: | compile | 0m 58s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 7m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 1m 29s | hbase-client in the patch failed. | | +1 :green_heart: | unit | 2m 53s | hbase-endpoint in the patch passed. | | | | 35m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3126 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 030707cdfbf0 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 18882d6f9a | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/testReport/ | | Max. process+thread count | 1750 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-endpoint U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3126: HBASE-25735 Add target Region to connection exceptions
Apache-HBase commented on pull request #3126: URL: https://github.com/apache/hbase/pull/3126#issuecomment-813883760 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 23s | branch-2 passed | | +1 :green_heart: | compile | 0m 57s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 0m 51s | the patch passed | | +1 :green_heart: | javac | 0m 51s | the patch passed | | +1 :green_heart: | shadedjars | 6m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 1m 19s | hbase-client in the patch failed. | | +1 :green_heart: | unit | 2m 47s | hbase-endpoint in the patch passed. | | | | 31m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3126 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0122c5c01fd6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 18882d6f9a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/testReport/ | | Max. process+thread count | 2404 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-endpoint U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3126/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-25736) Scan should be limited by read capacity unit quota if read size quota is not set
[ https://issues.apache.org/jira/browse/HBASE-25736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Mei reassigned HBASE-25736: -- Assignee: Yi Mei > Scan should be limited by read capacity unit quota if read size quota is not > set > > > Key: HBASE-25736 > URL: https://issues.apache.org/jira/browse/HBASE-25736 > Project: HBase > Issue Type: Improvement > Components: Quotas >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Minor > > Scan is currently limited by available size of quota, and quota size only > considers the READ_SIZE type: > {code:java} > long maxQuotaResultSize = Math.min(maxScannerResultSize, > quota.getReadAvailable()); > {code} > If read size is not set, we should limit the result size by read capacity > unit to avoid exceeding quota. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25736) Scan should be limited by read capacity unit quota if read size quota is not set
Yi Mei created HBASE-25736: -- Summary: Scan should be limited by read capacity unit quota if read size quota is not set Key: HBASE-25736 URL: https://issues.apache.org/jira/browse/HBASE-25736 Project: HBase Issue Type: Improvement Components: Quotas Reporter: Yi Mei Scan is currently limited by available size of quota, and quota size only considers the READ_SIZE type: {code:java} long maxQuotaResultSize = Math.min(maxScannerResultSize, quota.getReadAvailable()); {code} If read size is not set, we should limit the result size by read capacity unit to avoid exceeding quota. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack opened a new pull request #3126: HBASE-25735 Add target Region to connection exceptions
saintstack opened a new pull request #3126: URL: https://github.com/apache/hbase/pull/3126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25735) Add target Region to connection exceptions
Michael Stack created HBASE-25735: - Summary: Add target Region to connection exceptions Key: HBASE-25735 URL: https://issues.apache.org/jira/browse/HBASE-25735 Project: HBase Issue Type: Bug Components: rpc Reporter: Michael Stack Assignee: Michael Stack We spent a bit of time making it so exceptions included the remote host name. Looks like we can add the target Region name too with a bit of manipulation; will help figuring hot-spotting or problem Region on serverside. For example, here is what I was seeing recently on client-side when a RS was was timing out requests: {code} 2021-04-06T02:18:23.533Z, RpcRetryingCaller{globalStartTime=1617675482894, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to ps0989.example.org/1.1.1.1:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:145) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:383) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:357) ... Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to ps0989.bot.parsec.apple.com/17.58.114.206:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:209) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:378) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:89) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:409) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:405) at org.apache.hadoop.hbase.ipc.Call.setTimeout(Call.java:110) at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:136) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:672) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:747) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:472) ... 1 more Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:137) ... 4 more {code} I wanted the region it was hitting. I wanted to know if it was a server problem or a Region issue. If clients only having issue w/ one Region, then I could focus on it. After the PR the exception (from another context) looks like this: {code} org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to address=127.0.0.1:12345, regionInfo=hbase:meta,,1.1588230740 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: error {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)