[GitHub] [hbase] tomscut commented on pull request #4423: HBASE-27026 Disable Style/FrozenStringLiteralComment for ruby

2022-05-12 Thread GitBox
tomscut commented on PR #4423: URL: https://github.com/apache/hbase/pull/4423#issuecomment-1125534685 Thanks @apurtell for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] tomscut commented on pull request #4416: HBASE-27018 Add a tool command list_liveservers

2022-05-12 Thread GitBox
tomscut commented on PR #4416: URL: https://github.com/apache/hbase/pull/4416#issuecomment-1125544145 Thanks @pankaj72981 for your review. I filed a jira HBASE-27026 for discussing the rubocop warn. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] bitterfox commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory

2022-05-12 Thread GitBox
bitterfox commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1125609642 Thank you for checking this. We need this change in both branches. - branch-2.4 uses hbase-thirdparty.version = 3.5.1 which contains jetty 9.4.41.v20210516 -

[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536432#comment-17536432 ] Hudson commented on HBASE-27021: Results for branch branch-2 [build #539 on

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125615012 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache9 commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory

2022-05-12 Thread GitBox
Apache9 commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1125586002 Which branches should this change be applied? Branch-2.4+ or branch-2.5+? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536389#comment-17536389 ] Hudson commented on HBASE-27021: Results for branch master [build #585 on

[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125602451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] joshelser commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
joshelser commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125532727 My bad -- Stephen chatted me and we got on the same page. I thought Stephen was going to override the config in PrefetchExecutor/HFileReaderImpl automatically, but he clarified that the

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125540469 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125615550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[jira] [Commented] (HBASE-27013) Introduce read all bytes when using pread for prefetch

2022-05-12 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536438#comment-17536438 ] Tak-Lon (Stephen) Wu commented on HBASE-27013: -- {quote}I think what you're saying is the

[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535905#comment-17535905 ] Duo Zhang commented on HBASE-27023: --- The files with 'Copyright Google Inc' are

[GitHub] [hbase] Apache9 opened a new pull request, #4424: HBASE-27024 The User API and Developer API links are broken on hbase.…

2022-05-12 Thread GitBox
Apache9 opened a new pull request, #4424: URL: https://github.com/apache/hbase/pull/4424 …apache.org -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (HBASE-27027) Deprecated jetty SslContextFactory cause HMaster startup failure due to multiple certificates in KeyStores

2022-05-12 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida updated HBASE-27027: --- Affects Version/s: 2.4.11 > Deprecated jetty SslContextFactory cause HMaster startup

[jira] [Created] (HBASE-27027) Deprecated jetty SslContextFactory cause HMaster startup failure due to multiple certificates in KeyStores

2022-05-12 Thread Shinya Yoshida (Jira)
Shinya Yoshida created HBASE-27027: -- Summary: Deprecated jetty SslContextFactory cause HMaster startup failure due to multiple certificates in KeyStores Key: HBASE-27027 URL:

[jira] [Updated] (HBASE-27027) Deprecated jetty SslContextFactory cause HMaster startup failure due to multiple certificates in KeyStores

2022-05-12 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida updated HBASE-27027: --- Description: When we start hbase 2.4.11 masters with secure configuration (using https), we

[GitHub] [hbase] Apache-HBase commented on pull request #4424: HBASE-27024 The User API and Developer API links are broken on hbase.…

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4424: URL: https://github.com/apache/hbase/pull/4424#issuecomment-1124603946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[jira] [Commented] (HBASE-27024) The User API and Developer API links are broken on hbase.apache.org

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535883#comment-17535883 ] Duo Zhang commented on HBASE-27024: --- OK, upgrade javadoc and site plugin can solve the problem for

[jira] [Updated] (HBASE-27027) Deprecated jetty SslContextFactory cause HMaster startup failure due to multiple certificates in KeyStores

2022-05-12 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida updated HBASE-27027: --- Description: When we start hbase 2.4.11 masters with secure configuration (using https), we

[GitHub] [hbase] bitterfox opened a new pull request, #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory

2022-05-12 Thread GitBox
bitterfox opened a new pull request, #4425: URL: https://github.com/apache/hbase/pull/4425 https://issues.apache.org/jira/browse/HBASE-27027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535901#comment-17535901 ] Duo Zhang commented on HBASE-27023: --- I downloaded the PR for

[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535887#comment-17535887 ] Duo Zhang commented on HBASE-27023: --- The license header feature in spotless will do this. Let me see

[jira] [Assigned] (HBASE-27027) Deprecated jetty SslContextFactory cause HMaster startup failure due to multiple certificates in KeyStores

2022-05-12 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida reassigned HBASE-27027: -- Assignee: Shinya Yoshida > Deprecated jetty SslContextFactory cause HMaster startup

[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27021: - Affects Version/s: 3.0.0-alpha-2 > StoreFileInfo should set its initialPath in

[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27021: - Affects Version/s: 2.5.0 2.6.0 > StoreFileInfo should

[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27021: - Fix Version/s: 3.0.0-alpha-3 > StoreFileInfo should set its initialPath in a

[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535974#comment-17535974 ] Duo Zhang commented on HBASE-27021: --- Please stop cherry-picking to branch-2.x. [~wchevreuil] >

[GitHub] [hbase] Apache-HBase commented on pull request #4422: HBASE-26905 ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4422: URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124699055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache-HBase commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1124621725 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s |

[GitHub] [hbase] Apache-HBase commented on pull request #4422: HBASE-26905 ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4422: URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124650380 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

[jira] [Resolved] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-27021. -- Resolution: Fixed Merged into master, branch-2 and branch-2.5. Thanks for

[GitHub] [hbase] Apache-HBase commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1124623515 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] wchevreuil merged pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread GitBox
wchevreuil merged PR #4419: URL: https://github.com/apache/hbase/pull/4419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535977#comment-17535977 ] Duo Zhang commented on HBASE-27021: --- I've reverted the commit to master as it breaks the

[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536012#comment-17536012 ] Wellington Chevreuil commented on HBASE-27021: -- Right, decided to run the spotless fix,

[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27021: - Fix Version/s: 2.6.0 > StoreFileInfo should set its initialPath in a consistent

[GitHub] [hbase] Apache-HBase commented on pull request #4425: HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1124622319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s |

[jira] [Commented] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535990#comment-17535990 ] Wellington Chevreuil commented on HBASE-27021: -- {quote} I've already commented on the PR

[GitHub] [hbase] tomscut commented on pull request #4423: HBASE-27026 Disable Style/FrozenStringLiteralComment for ruby

2022-05-12 Thread GitBox
tomscut commented on PR #4423: URL: https://github.com/apache/hbase/pull/4423#issuecomment-1124743189 I sent an email `[DISCUSS] Disable Style/FrozenStringLiteralComment for ruby` for discussing this. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-12 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27021: - Fix Version/s: 2.5.0 > StoreFileInfo should set its initialPath in a consistent

[GitHub] [hbase] Apache-HBase commented on pull request #4424: HBASE-27024 The User API and Developer API links are broken on hbase.…

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4424: URL: https://github.com/apache/hbase/pull/4424#issuecomment-1124842211 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #4424: HBASE-27024 The User API and Developer API links are broken on hbase.…

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4424: URL: https://github.com/apache/hbase/pull/4424#issuecomment-1124951667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s |

[jira] [Commented] (HBASE-26233) The region replication framework should not be built upon the general replication framework

2022-05-12 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536279#comment-17536279 ] Huaxiang Sun commented on HBASE-26233: -- Sorry, [~zhangduo], catching up the topic so late! I am

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-05-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536286#comment-17536286 ] Viraj Jasani commented on HBASE-25465: -- Got it, let me explore if I can find it, I thought it was

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-05-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536275#comment-17536275 ] Viraj Jasani commented on HBASE-25465: -- In order to backport this to 2.4 release line, we need to

[jira] [Comment Edited] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-05-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536275#comment-17536275 ] Viraj Jasani edited comment on HBASE-25465 at 5/12/22 6:12 PM: --- In order

[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125249774 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation

2022-05-12 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536282#comment-17536282 ] Andrew Kyle Purtell commented on HBASE-25465: - [~vjasani] I believe there is a patch to

[jira] [Assigned] (HBASE-27024) The User API and Developer API links are broken on hbase.apache.org

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27024: - Assignee: Duo Zhang > The User API and Developer API links are broken on hbase.apache.org >

[jira] [Updated] (HBASE-27024) The User API and Developer API links are broken on hbase.apache.org

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27024: -- Status: Patch Available (was: Open) > The User API and Developer API links are broken on

[jira] [Commented] (HBASE-25192) s390x support for HBase CI

2022-05-12 Thread Vasudha Nikam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536157#comment-17536157 ] Vasudha Nikam commented on HBASE-25192: --- As s390x nodes are now added to Apache Jenkins CI (

[jira] [Assigned] (HBASE-26933) Remove all ref guide stuff on branch other than master

2022-05-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26933: - Assignee: Duo Zhang > Remove all ref guide stuff on branch other than master >

[jira] [Created] (HBASE-27029) When HMaster is stopped, the HMaster local region cache cannot be flushed normally

2022-05-12 Thread LiangJun He (Jira)
LiangJun He created HBASE-27029: --- Summary: When HMaster is stopped, the HMaster local region cache cannot be flushed normally Key: HBASE-27029 URL: https://issues.apache.org/jira/browse/HBASE-27029

[jira] [Assigned] (HBASE-27028) Add a shell command for flushing master local region

2022-05-12 Thread LiangJun He (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiangJun He reassigned HBASE-27028: --- Assignee: LiangJun He > Add a shell command for flushing master local region >

[jira] [Created] (HBASE-27028) Add a shell command for flushing master local region

2022-05-12 Thread LiangJun He (Jira)
LiangJun He created HBASE-27028: --- Summary: Add a shell command for flushing master local region Key: HBASE-27028 URL: https://issues.apache.org/jira/browse/HBASE-27028 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125329578 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s |

[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125427834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125453866 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125458246 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] Apache-HBase commented on pull request #4426: HBASE-26933 Remove all ref guide stuff on branch other than master

2022-05-12 Thread GitBox
Apache-HBase commented on PR #4426: URL: https://github.com/apache/hbase/pull/4426#issuecomment-1125488785 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[GitHub] [hbase] taklwu commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-12 Thread GitBox
taklwu commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1125519726 > I think you're missing the addition to update HFileReaderImpl, where we created the Runnable to pass to PrefetchExecutor? do you mean `ReaderContextBuilder`? I may be wrong, but