[GitHub] [hbase] kiran-maturi commented on pull request #4450: HBASE-18045 Added default SSH connection timeout in Integration tests

2022-07-04 Thread GitBox
kiran-maturi commented on PR #4450: URL: https://github.com/apache/hbase/pull/4450#issuecomment-1173405444 @virajjasani can you please look into this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] ramon-garcia commented on pull request #4594: Fix build under OpenJDK 17

2022-07-04 Thread GitBox
ramon-garcia commented on PR #4594: URL: https://github.com/apache/hbase/pull/4594#issuecomment-1173394341 > Thank you for your quick response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1173678793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[GitHub] [hbase] Apache-HBase commented on pull request #4594: Fix build under OpenJDK 17

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4594: URL: https://github.com/apache/hbase/pull/4594#issuecomment-1173444707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 16s |

[jira] [Comment Edited] (HBASE-26950) Use AsyncConnection in ReplicationSink

2022-07-04 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561993#comment-17561993 ] chenglei edited comment on HBASE-26950 at 7/4/22 7:28 AM: -- [~bbeaudreault],

[jira] [Updated] (HBASE-26950) Use AsyncConnection in ReplicationSink

2022-07-04 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-26950: - Labels: branch-2 replication (was: ) > Use AsyncConnection in ReplicationSink >

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1173492667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[GitHub] [hbase] SiCheng-Zheng commented on pull request #4558: HBASE-27144 Improvement bulkload rpc

2022-07-04 Thread GitBox
SiCheng-Zheng commented on PR #4558: URL: https://github.com/apache/hbase/pull/4558#issuecomment-1173603536 Can this PR be merged into the master branch? @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1173699897 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[GitHub] [hbase] virajjasani commented on pull request #4593: HBASE-27175 - Failure to cleanup WAL split dir log should be at INFO level

2022-07-04 Thread GitBox
virajjasani commented on PR #4593: URL: https://github.com/apache/hbase/pull/4593#issuecomment-1173942479 Awaiting any more review. If no one has any objections, will merge this in 24 hr. Thanks @ujjawal4046 for taking this up. -- This is an automated message from the Apache Git

[jira] [Reopened] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-23330: --- The fix version is marked as 2.3.0 but we never have this commit on any branch-2.x... > Expose

[GitHub] [hbase-connectors] Apache9 opened a new pull request, #98: HBASE-27176 [hbase-connectors] Fail to build hbase-connectors because…

2022-07-04 Thread GitBox
Apache9 opened a new pull request, #98: URL: https://github.com/apache/hbase-connectors/pull/98 … of checkstyle error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (HBASE-27177) [hbase-connectors] Add checkstyle check in hbase-connectors pre commit build

2022-07-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27177: - Summary: [hbase-connectors] Add checkstyle check in hbase-connectors pre commit build Key: HBASE-27177 URL: https://issues.apache.org/jira/browse/HBASE-27177 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1173915412 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1173934168 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s |

[jira] [Created] (HBASE-27176) [hbase-connectors] Fail to build hbase-connectors because of checkstyle error

2022-07-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27176: - Summary: [hbase-connectors] Fail to build hbase-connectors because of checkstyle error Key: HBASE-27176 URL: https://issues.apache.org/jira/browse/HBASE-27176 Project:

[jira] [Assigned] (HBASE-27176) [hbase-connectors] Fail to build hbase-connectors because of checkstyle error

2022-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27176: - Assignee: Duo Zhang > [hbase-connectors] Fail to build hbase-connectors because of checkstyle

[jira] [Work started] (HBASE-27176) [hbase-connectors] Fail to build hbase-connectors because of checkstyle error

2022-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27176 started by Duo Zhang. - > [hbase-connectors] Fail to build hbase-connectors because of checkstyle error >

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #97: HBASE-27114 Upgrade scalatest maven plugin for thread-safety

2022-07-04 Thread GitBox
Apache-HBase commented on PR #97: URL: https://github.com/apache/hbase-connectors/pull/97#issuecomment-1173824106 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s

[jira] [Created] (HBASE-27178) [hbase-connectors] Use spotless to format code

2022-07-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27178: - Summary: [hbase-connectors] Use spotless to format code Key: HBASE-27178 URL: https://issues.apache.org/jira/browse/HBASE-27178 Project: HBase Issue Type:

[GitHub] [hbase] bbeaudreault commented on pull request #4594: Fix build under OpenJDK 17

2022-07-04 Thread GitBox
bbeaudreault commented on PR #4594: URL: https://github.com/apache/hbase/pull/4594#issuecomment-1173803310 Is there a jira associated with this work? Typically a commit message and PR title follow the pattern: "HBASE-12345 fix build for jdk17" or something like that -- This is an

[jira] [Commented] (HBASE-23330) Expose cluster ID for clients using it for delegation token based auth

2022-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562218#comment-17562218 ] Duo Zhang commented on HBASE-23330: --- [~apurtell] [~bharathv] So what is the plan here? I think at

[GitHub] [hbase] Apache-HBase commented on pull request #4595: HBASE-26950 Use AsyncConnection in ReplicationSink

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4595: URL: https://github.com/apache/hbase/pull/4595#issuecomment-1173743837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

[jira] [Commented] (HBASE-27176) [hbase-connectors] Fail to build hbase-connectors because of checkstyle error

2022-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562181#comment-17562181 ] Duo Zhang commented on HBASE-27176: --- Let's set failOnViolation to false to resolve the build failure

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #98: HBASE-27176 [hbase-connectors] Fail to build hbase-connectors because…

2022-07-04 Thread GitBox
Apache-HBase commented on PR #98: URL: https://github.com/apache/hbase-connectors/pull/98#issuecomment-1173858769 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s

[GitHub] [hbase] Apache-HBase commented on pull request #4592: HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4592: URL: https://github.com/apache/hbase/pull/4592#issuecomment-1174200750 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[jira] [Updated] (HBASE-27170) ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse

2022-07-04 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27170: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master

[jira] [Commented] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering

2022-07-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562264#comment-17562264 ] Viraj Jasani commented on HBASE-26708: -- Thanks [~bbeaudreault] for the work on HBASE-27170. I just

[GitHub] [hbase] bbeaudreault merged pull request #4592: HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse

2022-07-04 Thread GitBox
bbeaudreault merged PR #4592: URL: https://github.com/apache/hbase/pull/4592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4592: HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4592: URL: https://github.com/apache/hbase/pull/4592#issuecomment-117817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[jira] [Commented] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering

2022-07-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562343#comment-17562343 ] Viraj Jasani commented on HBASE-26708: -- With PARANOID detection, and by adding some Bytebuf.touch()

[GitHub] [hbase] Apache-HBase commented on pull request #4592: HBASE-27170 ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4592: URL: https://github.com/apache/hbase/pull/4592#issuecomment-1174445720 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

[jira] [Created] (HBASE-27179) Issues building with OpenJDK 17

2022-07-04 Thread Jira
Ramón García Fernández created HBASE-27179: -- Summary: Issues building with OpenJDK 17 Key: HBASE-27179 URL: https://issues.apache.org/jira/browse/HBASE-27179 Project: HBase Issue

[GitHub] [hbase] ramon-garcia commented on pull request #4594: Fix build under OpenJDK 17

2022-07-04 Thread GitBox
ramon-garcia commented on PR #4594: URL: https://github.com/apache/hbase/pull/4594#issuecomment-1174464559 Added at request Jira issue HBASE-27179 Best regards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Assigned] (HBASE-27179) Issues building with OpenJDK 17

2022-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27179: - Assignee: Ramón García Fernández > Issues building with OpenJDK 17 >

[GitHub] [hbase] Apache-HBase commented on pull request #4596: HBASE-26708 Simplity wrap implementation

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1174610179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 48s |

[GitHub] [hbase] Apache-HBase commented on pull request #4596: HBASE-26708 Simplity wrap implementation

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1174610230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[jira] [Commented] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering

2022-07-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562355#comment-17562355 ] Duo Zhang commented on HBASE-26708: --- After learning the implementation of other encoder's in netty, I

[GitHub] [hbase] Apache9 commented on pull request #4596: HBASE-26708 Simplity wrap implementation

2022-07-04 Thread GitBox
Apache9 commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1174594001 @virajjasani FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] virajjasani commented on a diff in pull request #4596: HBASE-26708 Simplity wrap implementation

2022-07-04 Thread GitBox
virajjasani commented on code in PR #4596: URL: https://github.com/apache/hbase/pull/4596#discussion_r913374814 ## hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslWrapHandler.java: ## @@ -18,80 +18,31 @@ package org.apache.hadoop.hbase.security; import

[GitHub] [hbase] Apache-HBase commented on pull request #4596: HBASE-26708 Simplity wrap implementation

2022-07-04 Thread GitBox
Apache-HBase commented on PR #4596: URL: https://github.com/apache/hbase/pull/4596#issuecomment-1174615172 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |