[GitHub] [hbase] ragarkar commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
ragarkar commented on code in PR #5376: URL: https://github.com/apache/hbase/pull/5376#discussion_r1310115419 ## hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java: ## @@ -2906,6 +2907,25 @@ public boolean ensureSomeRegionServersAvailable(final int num)

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
wchevreuil commented on code in PR #5376: URL: https://github.com/apache/hbase/pull/5376#discussion_r1309943247 ## hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java: ## @@ -3642,6 +3662,110 @@ public boolean evaluate() throws IOException { }; }

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1698926631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
wchevreuil commented on code in PR #5376: URL: https://github.com/apache/hbase/pull/5376#discussion_r1309959061 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1477,6 +1477,7 @@ private void disableCache() { // If persistent

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1698853202 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1699051669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1698843236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1699257891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] guluo2016 opened a new pull request, #5377: HBASE-28051 The annotation about RegionProcedureStore.delete is not right

2023-08-30 Thread via GitHub
guluo2016 opened a new pull request, #5377: URL: https://github.com/apache/hbase/pull/5377 Details seeļ¼š HBASE-28051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (HBASE-28053) ServerCrashProcedure seems to fail when using Hadoop3.3.1+

2023-08-30 Thread aplio (Jira)
aplio created HBASE-28053: - Summary: ServerCrashProcedure seems to fail when using Hadoop3.3.1+ Key: HBASE-28053 URL: https://issues.apache.org/jira/browse/HBASE-28053 Project: HBase Issue Type: Bug

[jira] [Assigned] (HBASE-27177) [hbase-connectors] Add checkstyle check in hbase-connectors pre commit build

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain reassigned HBASE-27177: -- Assignee: (was: Nihal Jain) > [hbase-connectors] Add checkstyle check in

[jira] [Created] (HBASE-28052) Removing the useless parameters from ProcedureExecutor.loadProcedures

2023-08-30 Thread guluo (Jira)
guluo created HBASE-28052: - Summary: Removing the useless parameters from ProcedureExecutor.loadProcedures Key: HBASE-28052 URL: https://issues.apache.org/jira/browse/HBASE-28052 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #5378: HBASE-28052 Removing the useless parameters from ProcedureExecutor.loadProcedures

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5378: URL: https://github.com/apache/hbase/pull/5378#issuecomment-1699399424 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s |

[jira] [Updated] (HBASE-28054) [hbase-connectors] Add spotless in hbase-connectors pre commit check

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28054: --- Summary: [hbase-connectors] Add spotless in hbase-connectors pre commit check (was:

[jira] [Updated] (HBASE-28054) [hbase-connectors] Add spotless in hbase-connectors pre commit check

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28054: --- Component/s: build community hbase-connectors

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1699449773 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

[GitHub] [hbase] ragarkar commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
ragarkar commented on code in PR #5376: URL: https://github.com/apache/hbase/pull/5376#discussion_r1310267557 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1477,6 +1477,7 @@ private void disableCache() { // If persistent

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client

2023-08-30 Thread via GitHub
wchevreuil commented on code in PR #5370: URL: https://github.com/apache/hbase/pull/5370#discussion_r1310281661 ## hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java: ## @@ -330,4 +341,27 @@ public static String

[jira] [Work started] (HBASE-28054) [hbase-connectors] Add spotless in hbase-connectors pre commit build

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28054 started by Nihal Jain. -- > [hbase-connectors] Add spotless in hbase-connectors pre commit build >

[GitHub] [hbase] Apache-HBase commented on pull request #5378: HBASE-28052 Removing the useless parameters from ProcedureExecutor.loadProcedures

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5378: URL: https://github.com/apache/hbase/pull/5378#issuecomment-1699391089 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache-HBase commented on pull request #5378: HBASE-28052 Removing the useless parameters from ProcedureExecutor.loadProcedures

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5378: URL: https://github.com/apache/hbase/pull/5378#issuecomment-1699410500 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[jira] [Updated] (HBASE-28053) ServerCrashProcedure seems to fail when using Hadoop3.3.1+

2023-08-30 Thread aplio (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aplio updated HBASE-28053: -- Description: HBase Cluster Issue with Server Crash Procedure After Region Server Goes Down We are running an

[jira] [Created] (HBASE-28054) [hbase-connectors] Add spotless in hbase-connectors pre commit build

2023-08-30 Thread Nihal Jain (Jira)
Nihal Jain created HBASE-28054: -- Summary: [hbase-connectors] Add spotless in hbase-connectors pre commit build Key: HBASE-28054 URL: https://issues.apache.org/jira/browse/HBASE-28054 Project: HBase

[jira] [Commented] (HBASE-27177) [hbase-connectors] Add spotless in hbase-connectors pre commit build

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760535#comment-17760535 ] Nihal Jain commented on HBASE-27177: Seems this was for checkstyle, will add spotless as part of

[jira] [Updated] (HBASE-27177) [hbase-connectors] Add checkstyle check in hbase-connectors pre commit build

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27177: --- Summary: [hbase-connectors] Add checkstyle check in hbase-connectors pre commit build (was:

[GitHub] [hbase] ankitsinghal commented on a diff in pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-30 Thread via GitHub
ankitsinghal commented on code in PR #5371: URL: https://github.com/apache/hbase/pull/5371#discussion_r1310571851 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1700,17 +1853,17 @@ public BucketEntry writeToCache(final IOEngine

[GitHub] [hbase] Apache-HBase commented on pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5371: URL: https://github.com/apache/hbase/pull/5371#issuecomment-1699325323 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[jira] [Updated] (HBASE-28053) ServerCrashProcedure seems to fail when using Hadoop3.3.1+

2023-08-30 Thread aplio (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aplio updated HBASE-28053: -- Description: HBase Cluster Issue with Server Crash Procedure After Region Server Goes Down We are running an

[jira] [Updated] (HBASE-28053) ServerCrashProcedure seems to fail when using Hadoop3.3.1+

2023-08-30 Thread aplio (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aplio updated HBASE-28053: -- Description: HBase Cluster Issue with Server Crash Procedure After Region Server Goes Down We are running an

[jira] [Created] (HBASE-28051) The annotation about RegionProcedureStore.delete is not right

2023-08-30 Thread guluo (Jira)
guluo created HBASE-28051: - Summary: The annotation about RegionProcedureStore.delete is not right Key: HBASE-28051 URL: https://issues.apache.org/jira/browse/HBASE-28051 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #5377: HBASE-28051 The annotation about RegionProcedureStore.delete is not right

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5377: URL: https://github.com/apache/hbase/pull/5377#issuecomment-1699335446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[GitHub] [hbase] Apache-HBase commented on pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5376: URL: https://github.com/apache/hbase/pull/5376#issuecomment-1699462765 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] ankitsinghal commented on a diff in pull request #5371: HBASE-28044 Reduce frequency of saving backing map in persistence cache

2023-08-30 Thread via GitHub
ankitsinghal commented on code in PR #5371: URL: https://github.com/apache/hbase/pull/5371#discussion_r1310496448 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -1285,12 +1320,104 @@ void persistToFile() throws IOException {

[jira] [Assigned] (HBASE-27177) [hbase-connectors] Add checkstyle check in hbase-connectors pre commit build

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain reassigned HBASE-27177: -- Assignee: Nihal Jain > [hbase-connectors] Add checkstyle check in hbase-connectors pre

[jira] [Assigned] (HBASE-27978) [hbase-operator-tools] Add spotless in hbase-operator-tools pre-commit build

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain reassigned HBASE-27978: -- Assignee: Nihal Jain > [hbase-operator-tools] Add spotless in hbase-operator-tools

[jira] [Updated] (HBASE-27177) [hbase-connectors] Add spotless in hbase-connectors pre commit build

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27177: --- Summary: [hbase-connectors] Add spotless in hbase-connectors pre commit build (was:

[jira] [Work started] (HBASE-28055) Performance improvement for scan over several stores.

2023-08-30 Thread Sergey Soldatov (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28055 started by Sergey Soldatov. --- > Performance improvement for scan over several stores. >

[GitHub] [hbase] Apache-HBase commented on pull request #5379: HBASE-28055 Performance improvement for scan over several stores.

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5379: URL: https://github.com/apache/hbase/pull/5379#issuecomment-1700406741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[jira] [Created] (HBASE-28055) Performance improvement for scan over several stores.

2023-08-30 Thread Sergey Soldatov (Jira)
Sergey Soldatov created HBASE-28055: --- Summary: Performance improvement for scan over several stores. Key: HBASE-28055 URL: https://issues.apache.org/jira/browse/HBASE-28055 Project: HBase

[GitHub] [hbase-connectors] NihalJain commented on pull request #122: HBASE-28054 Add spotless in hbase-connectors pre commit check

2023-08-30 Thread via GitHub
NihalJain commented on PR #122: URL: https://github.com/apache/hbase-connectors/pull/122#issuecomment-1699672530 Ran spotless locally and ensured it failed with a bad patch ``` | Vote |Subsystem | Runtime | Comment

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #123: [DO NOT MERGE] HBASE-28054 Test spotless fail

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #123: URL: https://github.com/apache/hbase-connectors/pull/123#issuecomment-1699762633 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2023-08-30 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760627#comment-17760627 ] Andrew Kyle Purtell commented on HBASE-28048: - bq. Let's assume we are moving all regions

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #122: HBASE-28054 Add spotless in hbase-connectors pre commit check

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #122: URL: https://github.com/apache/hbase-connectors/pull/122#issuecomment-1699673447 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hbase-connectors] NihalJain commented on pull request #122: HBASE-28054 Add spotless in hbase-connectors pre commit check

2023-08-30 Thread via GitHub
NihalJain commented on PR #122: URL: https://github.com/apache/hbase-connectors/pull/122#issuecomment-1699677789 Hi @Apache9, @Reidd Could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HBASE-27966) HBase Master/RS JVM metrics populated incorrectly

2023-08-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760616#comment-17760616 ] Hudson commented on HBASE-27966: Results for branch branch-2.5 [build #395 on

[GitHub] [hbase] Apache-HBase commented on pull request #5377: HBASE-28051 The annotation about RegionProcedureStore.delete is not right

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5377: URL: https://github.com/apache/hbase/pull/5377#issuecomment-1699633815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5377: HBASE-28051 The annotation about RegionProcedureStore.delete is not right

2023-08-30 Thread via GitHub
Apache-HBase commented on PR #5377: URL: https://github.com/apache/hbase/pull/5377#issuecomment-1699641050 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Updated] (HBASE-28054) [hbase-connectors] Add spotless in hbase-connectors pre commit check

2023-08-30 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28054: --- Status: Patch Available (was: In Progress) > [hbase-connectors] Add spotless in hbase-connectors

[jira] [Updated] (HBASE-28051) The javadoc about RegionProcedureStore.delete is incorrect

2023-08-30 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28051: -- Summary: The javadoc about RegionProcedureStore.delete is incorrect (was: The annotation about

[GitHub] [hbase-connectors] Reidddddd merged pull request #122: HBASE-28054 Add spotless in hbase-connectors pre commit check

2023-08-30 Thread via GitHub
Reidd merged PR #122: URL: https://github.com/apache/hbase-connectors/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2023-08-30 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760676#comment-17760676 ] Duo Zhang commented on HBASE-28048: --- If we want to recover then the only safe way is to kill the

[jira] [Commented] (HBASE-27966) HBase Master/RS JVM metrics populated incorrectly

2023-08-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760251#comment-17760251 ] Hudson commented on HBASE-27966: Results for branch branch-2 [build #872 on