date:20120209

[
https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204609#comment-13204609
]

Hadoop QA commented on HBASE-3134:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513966/3134.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 156 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/928//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/928//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/928//console

This message is automatically generated.

[replication] Add the ability to enable/disable streams
---

Key: HBASE-3134
URL: https://issues.apache.org/jira/browse/HBASE-3134
Project: HBase
Issue Type: New Feature
Components: replication
Reporter: Jean-Daniel Cryans
Assignee: Teruyoshi Zenmyo
Priority: Minor
Labels: replication
Fix For: 0.94.0

Attachments: 3134.txt, HBASE-3134.patch, HBASE-3134.patch,
HBASE-3134.patch, HBASE-3134.patch

This jira was initially in the scope of HBASE-2201, but was pushed out since
it has low value compared to the required effort (and when want to ship
0.90.0 rather soonish).
We need to design a way to enable/disable replication streams in a
determinate fashion.

[jira] [Created] (HBASE-5362) ZK connection leak

2012-02-09 Thread Ionut Ignatescu (Created) (JIRA)

ZK connection leak
--

 Key: HBASE-5362
 URL: https://issues.apache.org/jira/browse/HBASE-5362
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.90.3
Reporter: Ionut Ignatescu


I have an application like a scheduler that starts periodically some MR jobs 
that reads from one HBase table and write in more tables, changing the row key 
and the columns list. 
I have encounted a problem with this: after each MR job, I have +1 connections 
open to ZK and after a period of time, I have received IOException. I saw that 
I am not the first that had had this problem, but I didn't see any fix. No in 
HBase 0.90.4, nor in HBase 0.92.
To fix this issue I wrote a custom TableInputFormat that forces to close the 
connection to ZK after each getSplits call. 
Also, the initTableMapperJob was overwritten.
I found an open JIRA issue here: 
https://issues.apache.org/jira/browse/HBASE-3792

Regards,
Ionut I. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Jonathan Hsieh (Created) (JIRA)

Add rat check to run automatically on mvn build.


 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.92.0, 0.90.5
Reporter: Jonathan Hsieh


Some of the recent hbase release failed rat checks (mvn rat:check).  We should 
add checks likely in the mvn package phase so that this becomes a non-issue in 
the future.

Here's an example from Whirr:
https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5364) Fix source files missing licenses

2012-02-09 Thread Jonathan Hsieh (Created) (JIRA)

Fix source files missing licenses
-

 Key: HBASE-5364
 URL: https://issues.apache.org/jira/browse/HBASE-5364
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.92.0, 0.90.5, 0.94.0
Reporter: Jonathan Hsieh
Priority: Blocker


running 'mvn rat:check' shows that a few files have snuck in that do not have 
proper apache licenses.  Ideally we should fix these before we cut another 
release/release candidate.

This is a blocker for 0.94, and probably should be for the other branches as 
well.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3134) [replication] Add the ability to enable/disable streams

2012-02-09 Thread Zhihong Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204642#comment-13204642
 ] 

Zhihong Yu commented on HBASE-3134:
---

@J-D:
Do you want to take another look at the patch ?

 [replication] Add the ability to enable/disable streams
 ---

 Key: HBASE-3134
 URL: https://issues.apache.org/jira/browse/HBASE-3134
 Project: HBase
  Issue Type: New Feature
  Components: replication
Reporter: Jean-Daniel Cryans
Assignee: Teruyoshi Zenmyo
Priority: Minor
  Labels: replication
 Fix For: 0.94.0

 Attachments: 3134.txt, HBASE-3134.patch, HBASE-3134.patch, 
 HBASE-3134.patch, HBASE-3134.patch


 This jira was initially in the scope of HBASE-2201, but was pushed out since 
 it has low value compared to the required effort (and when want to ship 
 0.90.0 rather soonish).
 We need to design a way to enable/disable replication streams in a 
 determinate fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5362) ZK connection leak

2012-02-09 Thread Zhihong Yu (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204666#comment-13204666
]

Zhihong Yu commented on HBASE-5362:
---

HBASE-4508 was integrated into 0.90.5
Can you perform your test using 0.90.5 ?

Thanks

ZK connection leak
--

Key: HBASE-5362
URL: https://issues.apache.org/jira/browse/HBASE-5362
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.90.3
Reporter: Ionut Ignatescu

I have an application like a scheduler that starts periodically some MR jobs
that reads from one HBase table and write in more tables, changing the row
key and the columns list.
I have encounted a problem with this: after each MR job, I have +1
connections open to ZK and after a period of time, I have received
IOException. I saw that I am not the first that had had this problem, but I
didn't see any fix. No in HBase 0.90.4, nor in HBase 0.92.
To fix this issue I wrote a custom TableInputFormat that forces to close the
connection to ZK after each getSplits call.
Also, the initTableMapperJob was overwritten.
I found an open JIRA issue here:
https://issues.apache.org/jira/browse/HBASE-3792
Regards,
Ionut I.

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204671#comment-13204671
 ] 

stack commented on HBASE-5363:
--

We already have this.  See our pom:

{code}
plugin
  groupIdorg.apache.rat/groupId
  artifactIdapache-rat-plugin/artifactId
  version0.7/version
configuration
  excludes
exclude**/.*/exclude
exclude**/target/**/exclude
exclude**/CHANGES.txt/exclude
exclude**/CHANGES.txt/exclude
exclude**/generated/**/exclude
exclude**/conf/*/exclude
exclude**/*.avpr/exclude
exclude**/control/exclude
exclude**/conffile/exclude
exclude**/8e8ab58dcf39412da19833fcd8f687ac/exclude
!--It don't like freebsd license--
excludesrc/site/resources/css/freebsd_docbook.css/exclude
  /excludes
/configuration
/plugin
{code}

And see the generated report: http://hbase.apache.org/rat-report.html

Here is the issue where I messed w/ this stuff on trunk: HBASE-4647

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh

 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204687#comment-13204687
 ] 

Jonathan Hsieh commented on HBASE-5363:
---

Stack.  I see but I believe the part that I want to add is the part that 
executes it (executions section) and fails the tarballs are built ('mvn 
package').

{code}
   plugin
groupIdorg.apache.rat/groupId
artifactIdapache-rat-plugin/artifactId
version0.8/version
executions
  execution
phasepackage/phase
goals
  goalcheck/goal
/goals
  /execution
/executions
{code}

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh

 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204688#comment-13204688
 ] 

Jonathan Hsieh commented on HBASE-5363:
---

.. fails the tarballs when being built ('mvn package').

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh

 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Todd Lipcon (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204695#comment-13204695
 ] 

Todd Lipcon commented on HBASE-5363:


Can we enable this only with a -Prelease build? Or part of the assembly phase? 
The package phase runs for every mvn install, which is already super slow.. I 
think we could move this and the source jar generation to a different phase, or 
selectively enable with a -Prelease profile?

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh

 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store

2012-02-09 Thread Doug Meil (Created) (JIRA)

[book] adding description of compaction file selection to refGuide in 
Arch/Regions/Store


 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil


book.xml
* adding description of compaction selection algorithm with examples (based on 
existing unit tests) 
* also added a few links to the compaction section from other places in the 
book that already mention compaction.

configuration.xml
* added link to compaction section from the entry that discusses configuring 
major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5365:
-

Status: Patch Available  (was: Open)

 [book] adding description of compaction file selection to refGuide in 
 Arch/Regions/Store
 

 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
 Attachments: docbkx_hbase_5365.patch


 book.xml
 * adding description of compaction selection algorithm with examples (based 
 on existing unit tests) 
 * also added a few links to the compaction section from other places in the 
 book that already mention compaction.
 configuration.xml
 * added link to compaction section from the entry that discusses configuring 
 major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5365:
-

Attachment: docbkx_hbase_5365.patch

 [book] adding description of compaction file selection to refGuide in 
 Arch/Regions/Store
 

 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
 Attachments: docbkx_hbase_5365.patch


 book.xml
 * adding description of compaction selection algorithm with examples (based 
 on existing unit tests) 
 * also added a few links to the compaction section from other places in the 
 book that already mention compaction.
 configuration.xml
 * added link to compaction section from the entry that discusses configuring 
 major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5365:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

 [book] adding description of compaction file selection to refGuide in 
 Arch/Regions/Store
 

 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
 Attachments: docbkx_hbase_5365.patch


 book.xml
 * adding description of compaction selection algorithm with examples (based 
 on existing unit tests) 
 * also added a few links to the compaction section from other places in the 
 book that already mention compaction.
 configuration.xml
 * added link to compaction section from the entry that discusses configuring 
 major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2375) Make decision to split based on aggregate size of all StoreFiles and revisit related config params

2012-02-09 Thread Jean-Daniel Cryans (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204701#comment-13204701
]

Jean-Daniel Cryans commented on HBASE-2375:
---

A bunch of things changed since this jira was created:
- we now split based on the store size
- regions split at 1GB
- memstores flush at 128MB
- there's been a lot of work on tuning the store file selection algorithm

My understanding of this jira is that it aims at making the out of the box
mass import experience better. Now that we have bulk loads and pre-splitting
this use case is becoming less and less important... although we still see
people trying to benchmark it (hi hypertable).

I see three things we could do:
- Trigger splits after flushes, I hacked a patch and it works awesomely
- Have a lower split size for newly created tables. Hypertable does this with
a soft limit that gets doubled every time the table splits until it reaches the
normal split size
- Have multi-way splits (Todd's idea), so that if you have enough data that
you know you're going to be splitting after the current split then just spawn
as many daughters as you need.

I'm planning on just fixing the first bullet point in the context of this
jira. Maybe there's another stuff from the patch in this jira that we could fit
in.

Make decision to split based on aggregate size of all StoreFiles and revisit
related config params
--

Key: HBASE-2375
URL: https://issues.apache.org/jira/browse/HBASE-2375
Project: HBase
Issue Type: Improvement
Components: regionserver
Affects Versions: 0.20.3
Reporter: Jonathan Gray
Assignee: Jonathan Gray
Priority: Critical
Labels: moved_from_0_20_5
Attachments: HBASE-2375-v8.patch

Currently we will make the decision to split a region when a single StoreFile
in a single family exceeds the maximum region size. This issue is about
changing the decision to split to be based on the aggregate size of all
StoreFiles in a single family (but still not aggregating across families).
This would move a check to split after flushes rather than after compactions.
This issue should also deal with revisiting our default values for some
related configuration parameters.
The motivating factor for this change comes from watching the behavior of
RegionServers during heavy write scenarios.
Today the default behavior goes like this:
- We fill up regions, and as long as you are not under global RS heap
pressure, you will write out 64MB (hbase.hregion.memstore.flush.size)
StoreFiles.
- After we get 3 StoreFiles (hbase.hstore.compactionThreshold) we trigger a
compaction on this region.
- Compaction queues notwithstanding, this will create a 192MB file, not
triggering a split based on max region size (hbase.hregion.max.filesize).
- You'll then flush two more 64MB MemStores and hit the compactionThreshold
and trigger a compaction.
- You end up with 192 + 64 + 64 in a single compaction. This will create a
single 320MB and will trigger a split.
- While you are performing the compaction (which now writes out 64MB more
than the split size, so is about 5X slower than the time it takes to do a
single flush), you are still taking on additional writes into MemStore.
- Compaction finishes, decision to split is made, region is closed. The
region now has to flush whichever edits made it to MemStore while the
compaction ran. This flushing, in our tests, is by far the dominating factor
in how long data is unavailable during a split. We measured about 1 second
to do the region closing, master assignment, reopening. Flushing could take
5-6 seconds, during which time the region is unavailable.
- The daughter regions re-open on the same RS. Immediately when the
StoreFiles are opened, a compaction is triggered across all of their
StoreFiles because they contain references. Since we cannot currently split
a split, we need to not hang on to these references for long.
This described behavior is really bad because of how often we have to rewrite
data onto HDFS. Imports are usually just IO bound as the RS waits to flush
and compact. In the above example, the first cell to be inserted into this
region ends up being written to HDFS 4 times (initial flush, first compaction
w/ no split decision, second compaction w/ split decision, third compaction
on daughter region). In addition, we leave a large window where we take on
edits (during the second compaction of 320MB) and then must make the region
unavailable as we flush it.
If we increased the compactionThreshold to be 5 and determined splits based
on aggregate size, the behavior becomes:
- We

[jira] [Updated] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio


 [ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5330:
-

Attachment: TestCompactSelection_hbase_5330_v2.java.patch

 TestCompactSelection - adding 2 test cases to testCompactionRatio
 -

 Key: HBASE-5330
 URL: https://issues.apache.org/jira/browse/HBASE-5330
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: TestCompactSelection_hbase_5330.java.patch, 
 TestCompactSelection_hbase_5330_v2.java.patch


 There were three existing assertions in TestCompactSelection 
 testCompactionRatio that did max # of files assertions...
 {code}
 assertEquals(maxFiles,
 
 store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
 {code}
 ... and for references ...
 {code}
   assertEquals(maxFiles,
 store.compactSelection(sfCreate(true, 
 7,6,5,4,3,2,1)).getFilesToCompact().size());
 {code}
  
 ... but they didn't assert against which StoreFiles got selected.  While the 
 number of StoreFiles is the same, the files selected are actually different, 
 and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5366) Improving bulk table disable/enable/drop in shell

2012-02-09 Thread Zhihong Yu (Created) (JIRA)

Improving bulk table disable/enable/drop in shell
-

 Key: HBASE-5366
 URL: https://issues.apache.org/jira/browse/HBASE-5366
 Project: HBase
  Issue Type: Task
Reporter: Zhihong Yu


HBASE-3506 added regex support for disabling, enabling and dropping tables.
Currently the list of tables are shown one on each line, this may lead to too 
many lines:
{code}
tychangTable998 
  
tychangTable999 
 

Enable the above 901 tables (y/n)?
y
{code}
When the number of tables is high, each line should display multiple tables.

Disabling tables may take a long time. We should show the tables that have been 
disabled in batches so that user knows the operation didn't hang.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio


 [ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5330:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committing this update to the unit test

 TestCompactSelection - adding 2 test cases to testCompactionRatio
 -

 Key: HBASE-5330
 URL: https://issues.apache.org/jira/browse/HBASE-5330
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: TestCompactSelection_hbase_5330.java.patch, 
 TestCompactSelection_hbase_5330_v2.java.patch


 There were three existing assertions in TestCompactSelection 
 testCompactionRatio that did max # of files assertions...
 {code}
 assertEquals(maxFiles,
 
 store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
 {code}
 ... and for references ...
 {code}
   assertEquals(maxFiles,
 store.compactSelection(sfCreate(true, 
 7,6,5,4,3,2,1)).getFilesToCompact().size());
 {code}
  
 ... but they didn't assert against which StoreFiles got selected.  While the 
 number of StoreFiles is the same, the files selected are actually different, 
 and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store

2012-02-09 Thread Doug Meil (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204707#comment-13204707
 ] 

Doug Meil commented on HBASE-5365:
--

Many thanks to Nicholas Spiegelberg for clarifying much of this!


 [book] adding description of compaction file selection to refGuide in 
 Arch/Regions/Store
 

 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
 Attachments: docbkx_hbase_5365.patch


 book.xml
 * adding description of compaction selection algorithm with examples (based 
 on existing unit tests) 
 * also added a few links to the compaction section from other places in the 
 book that already mention compaction.
 configuration.xml
 * added link to compaction section from the entry that discusses configuring 
 major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5366) Improve bulk table disable/enable/drop in shell

2012-02-09 Thread Zhihong Yu (Updated) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zhihong Yu updated HBASE-5366:
--

Description:
HBASE-3506 added regex support for disabling, enabling and dropping tables.
Currently the list of tables are shown one on each line, this may lead to too
many lines:
{code}
tychangTable998

tychangTable999

Enable the above 901 tables (y/n)?
y
{code}
When the number of tables is high, each line should display multiple tables.

Disabling/enabling tables may take a long time. We should show the tables that
have been disabled/enabled in batches so that user knows the operation didn't
hang.

was:
HBASE-3506 added regex support for disabling, enabling and dropping tables.
Currently the list of tables are shown one on each line, this may lead to too
many lines:
{code}
tychangTable998

tychangTable999

Enable the above 901 tables (y/n)?
y
{code}
When the number of tables is high, each line should display multiple tables.

Disabling tables may take a long time. We should show the tables that have been
disabled in batches so that user knows the operation didn't hang.

Summary: Improve bulk table disable/enable/drop in shell (was:
Improving bulk table disable/enable/drop in shell)

Improve bulk table disable/enable/drop in shell
---

Key: HBASE-5366
URL: https://issues.apache.org/jira/browse/HBASE-5366
Project: HBase
Issue Type: Task
Reporter: Zhihong Yu

HBASE-3506 added regex support for disabling, enabling and dropping tables.
Currently the list of tables are shown one on each line, this may lead to too
many lines:
{code}
tychangTable998

tychangTable999

Enable the above 901 tables (y/n)?
y
{code}
When the number of tables is high, each line should display multiple tables.
Disabling/enabling tables may take a long time. We should show the tables
that have been disabled/enabled in batches so that user knows the operation
didn't hang.

[jira] [Updated] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed

2012-02-09 Thread Jimmy Xiang (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5327:
---

Attachment: hbase-5327_v2.txt

 Print a message when an invalid hbase.rootdir is passed
 ---

 Key: HBASE-5327
 URL: https://issues.apache.org/jira/browse/HBASE-5327
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.5
Reporter: Jean-Daniel Cryans
Assignee: Jimmy Xiang
 Fix For: 0.94.0, 0.90.7, 0.92.1

 Attachments: hbase-5327.txt, hbase-5327_v2.txt


 As seen on the mailing list: 
 http://comments.gmane.org/gmane.comp.java.hadoop.hbase.user/24124
 If hbase.rootdir doesn't specify a folder on hdfs we crash while opening a 
 path to .oldlogs:
 {noformat}
 2012-02-02 23:07:26,292 FATAL org.apache.hadoop.hbase.master.HMaster: 
 Unhandled exception. Starting shutdown.
 java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative 
 path in absolute URI: hdfs://sv4r11s38:9100.oldlogs
 at org.apache.hadoop.fs.Path.initialize(Path.java:148)
 at org.apache.hadoop.fs.Path.init(Path.java:71)
 at org.apache.hadoop.fs.Path.init(Path.java:50)
 at 
 org.apache.hadoop.hbase.master.MasterFileSystem.init(MasterFileSystem.java:112)
 at 
 org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:448)
 at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:326)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.net.URISyntaxException: Relative path in absolute URI: 
 hdfs://sv4r11s38:9100.oldlogs
 at java.net.URI.checkPath(URI.java:1787)
 at java.net.URI.init(URI.java:735)
 at org.apache.hadoop.fs.Path.initialize(Path.java:145)
 ... 6 more
 {noformat}
 It could also crash anywhere else, this just happens to be the first place we 
 use hbase.rootdir. We need to verify that it's an actual folder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed

2012-02-09 Thread Jimmy Xiang (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204714#comment-13204714
 ] 

Jimmy Xiang commented on HBASE-5327:


This patch fix two issues:
(1) check the root dir to make sure it is valid before generating the old log 
dir.  So that it can give a meaningful error message.
(2) make sure the root dir is a dir instead of a file.  If it is a file, the 
master will hang and try to create the version file forever.

@Jon,  I added some actionable log message.

 Print a message when an invalid hbase.rootdir is passed
 ---

 Key: HBASE-5327
 URL: https://issues.apache.org/jira/browse/HBASE-5327
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.5
Reporter: Jean-Daniel Cryans
Assignee: Jimmy Xiang
 Fix For: 0.94.0, 0.90.7, 0.92.1

 Attachments: hbase-5327.txt, hbase-5327_v2.txt


 As seen on the mailing list: 
 http://comments.gmane.org/gmane.comp.java.hadoop.hbase.user/24124
 If hbase.rootdir doesn't specify a folder on hdfs we crash while opening a 
 path to .oldlogs:
 {noformat}
 2012-02-02 23:07:26,292 FATAL org.apache.hadoop.hbase.master.HMaster: 
 Unhandled exception. Starting shutdown.
 java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative 
 path in absolute URI: hdfs://sv4r11s38:9100.oldlogs
 at org.apache.hadoop.fs.Path.initialize(Path.java:148)
 at org.apache.hadoop.fs.Path.init(Path.java:71)
 at org.apache.hadoop.fs.Path.init(Path.java:50)
 at 
 org.apache.hadoop.hbase.master.MasterFileSystem.init(MasterFileSystem.java:112)
 at 
 org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:448)
 at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:326)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.net.URISyntaxException: Relative path in absolute URI: 
 hdfs://sv4r11s38:9100.oldlogs
 at java.net.URI.checkPath(URI.java:1787)
 at java.net.URI.init(URI.java:735)
 at org.apache.hadoop.fs.Path.initialize(Path.java:145)
 ... 6 more
 {noformat}
 It could also crash anywhere else, this just happens to be the first place we 
 use hbase.rootdir. We need to verify that it's an actual folder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204719#comment-13204719
]

Jonathan Hsieh commented on HBASE-5363:
---

The rat site suggests running it in the mvn verify phase.

http://incubator.apache.org/rat/apache-rat-plugin/examples/verify.html

I added the chunk above and rat didn't seem to be run or fail the build.
Investigating further to figure out which phase seems reasonable..

As an aside, we should probably update the
http://wiki.apache.org/hadoop/Hbase/HowToRelease wiki page now that the build
has diverged from hadoop's now (we don't have any ant).

Add rat check to run automatically on mvn build.

Key: HBASE-5363
URL: https://issues.apache.org/jira/browse/HBASE-5363
Project: HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh

Some of the recent hbase release failed rat checks (mvn rat:check). We
should add checks likely in the mvn package phase so that this becomes a
non-issue in the future.
Here's an example from Whirr:
https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

[jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed


[ 
https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204722#comment-13204722
 ] 

stack commented on HBASE-5327:
--

+1

 Print a message when an invalid hbase.rootdir is passed
 ---

 Key: HBASE-5327
 URL: https://issues.apache.org/jira/browse/HBASE-5327
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.5
Reporter: Jean-Daniel Cryans
Assignee: Jimmy Xiang
 Fix For: 0.94.0, 0.90.7, 0.92.1

 Attachments: hbase-5327.txt, hbase-5327_v2.txt


 As seen on the mailing list: 
 http://comments.gmane.org/gmane.comp.java.hadoop.hbase.user/24124
 If hbase.rootdir doesn't specify a folder on hdfs we crash while opening a 
 path to .oldlogs:
 {noformat}
 2012-02-02 23:07:26,292 FATAL org.apache.hadoop.hbase.master.HMaster: 
 Unhandled exception. Starting shutdown.
 java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative 
 path in absolute URI: hdfs://sv4r11s38:9100.oldlogs
 at org.apache.hadoop.fs.Path.initialize(Path.java:148)
 at org.apache.hadoop.fs.Path.init(Path.java:71)
 at org.apache.hadoop.fs.Path.init(Path.java:50)
 at 
 org.apache.hadoop.hbase.master.MasterFileSystem.init(MasterFileSystem.java:112)
 at 
 org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:448)
 at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:326)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.net.URISyntaxException: Relative path in absolute URI: 
 hdfs://sv4r11s38:9100.oldlogs
 at java.net.URI.checkPath(URI.java:1787)
 at java.net.URI.init(URI.java:735)
 at org.apache.hadoop.fs.Path.initialize(Path.java:145)
 ... 6 more
 {noformat}
 It could also crash anywhere else, this just happens to be the first place we 
 use hbase.rootdir. We need to verify that it's an actual folder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204723#comment-13204723
 ] 

stack commented on HBASE-5363:
--

The rat plugin is pretty crappy in my experience too.  Its hard to get it 
behave.

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh

 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204724#comment-13204724
 ] 

Jonathan Hsieh commented on HBASE-5288:
---

Tested:

mvn package -Dskiptests
tar xvfz target hbase-0.93.0-SNAPSHOT.tar.gz | grep security

Saw security sources.

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Gary Helmling
Priority: Blocker
 Fix For: 0.94.0, 0.92.1


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Elliott Clark (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204728#comment-13204728
 ] 

Elliott Clark commented on HBASE-5363:
--

Though it is getting several files that need licenses.

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh

 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.


 [ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5288:
--

Attachment: hbase-5288.patch

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Gary Helmling
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204727#comment-13204727
 ] 

Jonathan Hsieh commented on HBASE-5288:
---

Hey Gary, I was working on some mvn related things and just did this patch 
along the way.  Hope you don't mind.

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Gary Helmling
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.


 [ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5288:
--

Status: Patch Available  (was: Open)

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.92.0, 0.94.0
Reporter: Jonathan Hsieh
Assignee: Gary Helmling
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread Jonathan Hsieh (Assigned) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh reassigned HBASE-5288:
-

Assignee: Jonathan Hsieh  (was: Gary Helmling)

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread Gary Helmling (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204730#comment-13204730
 ] 

Gary Helmling commented on HBASE-5288:
--

+1 on patch.

Thanks, Jon!  Sorry I've been a bad contributor lately.

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Gary Helmling
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204731#comment-13204731
 ] 

Jonathan Hsieh commented on HBASE-5288:
---

patch also applies on 0.92 and similar test includes sources.

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Gary Helmling
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204732#comment-13204732
 ] 

Jonathan Hsieh commented on HBASE-5288:
---

no worries. :)  

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Elliott Clark (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5363:
-

Attachment: HBASE-5363-1.patch

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
 Attachments: HBASE-5363-1.patch


 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Elliott Clark (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204736#comment-13204736
 ] 

Elliott Clark commented on HBASE-5363:
--

Attached a patch to add headers to some files that were missing it according to 
rat.
I couldn't get the rat plugin to run automatically on the first try so the 
patch doesn't have any pom changes in it.

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
 Attachments: HBASE-5363-1.patch


 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.


 [ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5288:
--

Resolution: Fixed
Status: Resolved  (was: Patch Available)

 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5349) Automagically tweak global memstore and block cache sizes based on workload

2012-02-09 Thread Mubarak Seyed (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204740#comment-13204740
 ] 

Mubarak Seyed commented on HBASE-5349:
--

For reference:
Cassandra 1.0.0 supports self-tunes memtable sizes 
([CASSANDRA-2787|https://issues.apache.org/jira/browse/CASSANDRA-2787]). It 
uses Java agent ([Jamm|https://github.com/jbellis/jamm])

 Automagically tweak global memstore and block cache sizes based on workload
 ---

 Key: HBASE-5349
 URL: https://issues.apache.org/jira/browse/HBASE-5349
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
 Fix For: 0.94.0


 Hypertable does a neat thing where it changes the size given to the CellCache 
 (our MemStores) and Block Cache based on the workload. If you need an image, 
 scroll down at the bottom of this link: 
 http://www.hypertable.com/documentation/architecture/
 That'd be one less thing to configure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204744#comment-13204744
 ] 

stack commented on HBASE-5365:
--

This doc patch is excellent.

I thought default flush size in trunk 128M, not (134 mb)?  Its done twice.  
What is '(e.g., 10F)'?  Is that float?



 [book] adding description of compaction file selection to refGuide in 
 Arch/Regions/Store
 

 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
 Attachments: docbkx_hbase_5365.patch


 book.xml
 * adding description of compaction selection algorithm with examples (based 
 on existing unit tests) 
 * also added a few links to the compaction section from other places in the 
 book that already mention compaction.
 configuration.xml
 * added link to compaction section from the entry that discusses configuring 
 major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed


[ 
https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204749#comment-13204749
 ] 

Hadoop QA commented on HBASE-5327:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12513982/hbase-5327_v2.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 javadoc.  The javadoc tool appears to have generated -136 warning 
messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 156 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.replication.TestReplication
  org.apache.hadoop.hbase.io.hfile.TestHFileBlock
  org.apache.hadoop.hbase.mapreduce.TestImportTsv
  org.apache.hadoop.hbase.mapred.TestTableMapReduce
  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/929//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/929//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/929//console

This message is automatically generated.

 Print a message when an invalid hbase.rootdir is passed
 ---

 Key: HBASE-5327
 URL: https://issues.apache.org/jira/browse/HBASE-5327
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.5
Reporter: Jean-Daniel Cryans
Assignee: Jimmy Xiang
 Fix For: 0.94.0, 0.90.7, 0.92.1

 Attachments: hbase-5327.txt, hbase-5327_v2.txt


 As seen on the mailing list: 
 http://comments.gmane.org/gmane.comp.java.hadoop.hbase.user/24124
 If hbase.rootdir doesn't specify a folder on hdfs we crash while opening a 
 path to .oldlogs:
 {noformat}
 2012-02-02 23:07:26,292 FATAL org.apache.hadoop.hbase.master.HMaster: 
 Unhandled exception. Starting shutdown.
 java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative 
 path in absolute URI: hdfs://sv4r11s38:9100.oldlogs
 at org.apache.hadoop.fs.Path.initialize(Path.java:148)
 at org.apache.hadoop.fs.Path.init(Path.java:71)
 at org.apache.hadoop.fs.Path.init(Path.java:50)
 at 
 org.apache.hadoop.hbase.master.MasterFileSystem.init(MasterFileSystem.java:112)
 at 
 org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:448)
 at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:326)
 at java.lang.Thread.run(Thread.java:662)
 Caused by: java.net.URISyntaxException: Relative path in absolute URI: 
 hdfs://sv4r11s38:9100.oldlogs
 at java.net.URI.checkPath(URI.java:1787)
 at java.net.URI.init(URI.java:735)
 at org.apache.hadoop.fs.Path.initialize(Path.java:145)
 ... 6 more
 {noformat}
 It could also crash anywhere else, this just happens to be the first place we 
 use hbase.rootdir. We need to verify that it's an actual folder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store

2012-02-09 Thread Doug Meil (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204759#comment-13204759
 ] 

Doug Meil commented on HBASE-5365:
--

Thanks!

Yeah, the F in 10F is float.  I should probably just take the F out because 
it looks like a typo.

As for the other number, actually it's  (HTableDescriptor)
{code}
  public static final long DEFAULT_MEMSTORE_FLUSH_SIZE = 1024*1024*64L;
{code}
... not 128.  As for the 134, I had this in my notes as the default from 
earlier research.  H.

I will fix both in another ticket.


 [book] adding description of compaction file selection to refGuide in 
 Arch/Regions/Store
 

 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
 Attachments: docbkx_hbase_5365.patch


 book.xml
 * adding description of compaction selection algorithm with examples (based 
 on existing unit tests) 
 * also added a few links to the compaction section from other places in the 
 book that already mention compaction.
 configuration.xml
 * added link to compaction section from the entry that discusses configuring 
 major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

[
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204769#comment-13204769
]

Hadoop QA commented on HBASE-5288:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513987/hbase-5288.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.

-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 156 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/930//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/930//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/930//console

This message is automatically generated.

Security source code dirs missing from 0.92.0 release tarballs.
---

Key: HBASE-5288
URL: https://issues.apache.org/jira/browse/HBASE-5288
Project: HBase
Issue Type: Bug
Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Priority: Blocker
Fix For: 0.94.0, 0.92.1

Attachments: hbase-5288.patch

The release tarballs have a compiled version of the hbase jars and the
security tarball seems to have the compiled security bits. However, the
source code and resources for security implementation are missing from the
release tarballs in both distributions. They should be included in both.

[jira] [Created] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store

2012-02-09 Thread Doug Meil (Created) (JIRA)

[book] small formatting changes to compaction description in Arch/Regions/Store
---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor


Fixing a few small-but-important things that came out of a post-commit comment 
in HBASE-5365

book.xml
* corrected default region flush size (it's actually 64mb)
* removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5346) Fix testColumnFamilyCompression and test_TIMERANGE in TestHFileOutputFormat

2012-02-09 Thread Gregory Chanan (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204775#comment-13204775
 ] 

Gregory Chanan commented on HBASE-5346:
---

It looks like the tests testColumnFamilyCompression and test_TIMERANGE passed, 
if my reading of the results is correct.

  Fix testColumnFamilyCompression and test_TIMERANGE in TestHFileOutputFormat
 

 Key: HBASE-5346
 URL: https://issues.apache.org/jira/browse/HBASE-5346
 Project: HBase
  Issue Type: Sub-task
  Components: mapreduce, test
Affects Versions: 0.90.4, 0.92.0
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Attachments: HBASE-5346-v0.patch


 Running
 mvn -Dhadoop.profile=23 test -P localTests 
 -Dtest=org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
 yields this on 0.92 (for testColumnFamilyCompression and test_TIMERANGE):
 Failed tests: 
 testColumnFamilyCompression(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
  HFile for column family info-A not found
 Tests in error: 
 test_TIMERANGE(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat): 
 /home/gchanan/workspace/apache92/target/test-data/276cbd0c-c771-4f81-9ba8-c464c9dd7486/test_TIMERANGE_present/_temporary/0/_temporary/_attempt_200707121733_0001_m_00_0
  (Is a directory)
 The problem is that these tests make incorrect assumptions about the output 
 of mapreduce jobs.  Prior to 0.23, temporary data was in, for example:
 ./_temporary/_attempt___r_00_0/b/1979617994050536795
 Now that has changed.  The correct way to get that path is based on 
 getDefaultWorkFile.
 Also, the data is not moved into the outputPath until both the Task and Job 
 are committed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5367:
-

Attachment: book_hbase_5367.xml.patch

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5367:
-

Status: Patch Available  (was: Open)

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5367:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2375) Make decision to split based on aggregate size of all StoreFiles and revisit related config params

[
https://issues.apache.org/jira/browse/HBASE-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204779#comment-13204779
]

stack commented on HBASE-2375:
--

Doing first bullet point only sounds good. Lets file issues for the split
other suggestions.

What about the other recommendations made up in the issue regards
compactionThreshold.

Upping compactionThreshold from 3 to 5 where 5 is than the number of flushes
it would take to make us splittable; i.e. the intent is no compaction before
first split.

Should we do this too as part of this issue? We could make our flush size 256M
and compactionThreshold 5. Or perhaps thats too rad (thats a big Map to be
carrying around)? Instead up the compactionThreshold and down the default
regionsize from 1G to 512M and keep flush at 128M?

I took a look at patch and its pretty stale now given changes that have gone in
since.

Make decision to split based on aggregate size of all StoreFiles and revisit
related config params
--

[jira] [Commented] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204782#comment-13204782
 ] 

stack commented on HBASE-5367:
--

In trunk this is 128M:

{code}
   codehbase.hregion.memstore.flush.size/code (64 mb). /listitem
{code}

{code}
namehbase.hregion.memstore.flush.size/name
value134217728/value
description
{code}

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store

2012-02-09 Thread Doug Meil (Reopened) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil reopened HBASE-5367:
--


Doh!  Re-opening.  I'll fix it.

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5367:
-

Attachment: book_hbase_5367_2.xml.patch

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5367:
-

Status: Patch Available  (was: Reopened)

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


 [ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Meil updated HBASE-5367:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

This time it's really fixed.

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2375) Make decision to split based on aggregate size of all StoreFiles and revisit related config params

2012-02-09 Thread Jean-Daniel Cryans (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204797#comment-13204797
]

Jean-Daniel Cryans commented on HBASE-2375:
---

bq. Doing first bullet point only sounds good. Lets file issues for the split
other suggestions.

Kewl.

bq. Upping compactionThreshold from 3 to 5 where 5 is than the number of
flushes it would take to make us splittable; i.e. the intent is no compaction
before first split.

Sounds like a change that can have a bigger impact but that mostly helps this
specific use case...

bq. Instead up the compactionThreshold and down the default regionsize from 1G
to 512M and keep flush at 128M?

I'd rather split earlier for the first regions.

Make decision to split based on aggregate size of all StoreFiles and revisit
related config params
--

[jira] [Commented] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204800#comment-13204800
 ] 

stack commented on HBASE-5367:
--

{code}
long flushSize = this.htableDescriptor.getMemStoreFlushSize();
if (flushSize == HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE) {
  flushSize = conf.getLong(HConstants.HREGION_MEMSTORE_FLUSH_SIZE,
 HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE);
}
{code}

So, looks like DEFAULT_MEMSTORE_FLUSH_SIZE is 64M which is confusing and we'll 
use whats in HTD IFF its different from this default.

Yeah, easy to get confused.

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204802#comment-13204802
 ] 

stack commented on HBASE-5367:
--

{code}
long flushSize = this.htableDescriptor.getMemStoreFlushSize();
if (flushSize == HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE) {
  flushSize = conf.getLong(HConstants.HREGION_MEMSTORE_FLUSH_SIZE,
 HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE);
}
{code}

So, looks like DEFAULT_MEMSTORE_FLUSH_SIZE is 64M which is confusing and we'll 
use whats in HTD IFF its different from this default.

Yeah, easy to get confused.

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204801#comment-13204801
 ] 

stack commented on HBASE-5367:
--

{code}
long flushSize = this.htableDescriptor.getMemStoreFlushSize();
if (flushSize == HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE) {
  flushSize = conf.getLong(HConstants.HREGION_MEMSTORE_FLUSH_SIZE,
 HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE);
}
{code}

So, looks like DEFAULT_MEMSTORE_FLUSH_SIZE is 64M which is confusing and we'll 
use whats in HTD IFF its different from this default.

Yeah, easy to get confused.

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204803#comment-13204803
 ] 

stack commented on HBASE-5367:
--

{code}
long flushSize = this.htableDescriptor.getMemStoreFlushSize();
if (flushSize == HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE) {
  flushSize = conf.getLong(HConstants.HREGION_MEMSTORE_FLUSH_SIZE,
 HTableDescriptor.DEFAULT_MEMSTORE_FLUSH_SIZE);
}
{code}

So, looks like DEFAULT_MEMSTORE_FLUSH_SIZE is 64M which is confusing and we'll 
use whats in HTD IFF its different from this default.

Yeah, easy to get confused.

 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5362) ZK connection leak

2012-02-09 Thread Ionut Ignatescu (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204823#comment-13204823
]

Ionut Ignatescu commented on HBASE-5362:

No,I can't. We have a different version deployed on our Hadoop cluster, so it's
almost impossible to perform this test.
Anyway, thanks for your suggestion, I'll look into source to check.

ZK connection leak
--

Key: HBASE-5362
URL: https://issues.apache.org/jira/browse/HBASE-5362
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.90.3
Reporter: Ionut Ignatescu

[jira] [Commented] (HBASE-2375) Make decision to split based on aggregate size of all StoreFiles and revisit related config params

[
https://issues.apache.org/jira/browse/HBASE-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204820#comment-13204820
]

stack commented on HBASE-2375:
--

bq. Upping compactionThreshold from 3 to 5... Sounds like a change that can
have a bigger impact but that mostly helps this specific use case...

Dunno. 3 strikes me as one of those decisions that made sense long time ago
but a bunch has changed since... We should test it I suppose.

On changing flush/regionsize, you'd rather have us split faster then slow as
count of regions goes up. Ok.

Make decision to split based on aggregate size of all StoreFiles and revisit
related config params
--

[jira] [Created] (HBASE-5368) Move PrefixSplitKeyPolicy out of the src/test into src, so it is accessible in HBase installs

2012-02-09 Thread Lars Hofhansl (Created) (JIRA)

Move PrefixSplitKeyPolicy out of the src/test into src, so it is accessible in 
HBase installs
-

 Key: HBASE-5368
 URL: https://issues.apache.org/jira/browse/HBASE-5368
 Project: HBase
  Issue Type: Sub-task
  Components: regionserver
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor


Very simple change to make PrefixSplitKeyPolicy accessible in HBase installs 
(user still needs to setup the table(s) accordingly).

Right now it is in src/test/org.apache.hadoop.hbase.regionserver, I propose 
moving it to src/org.apache.hadoop.hbase.regionserver (alongside 
ConstantSizeRegionSplitPolicy), and maybe renaming it too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.

2012-02-09 Thread Jonathan Hsieh (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204846#comment-13204846
 ] 

Jonathan Hsieh commented on HBASE-5363:
---

Hey Elliott, thanks for the patch! Let me ask a favor -- could you post the 
license fixes patch to this jira HBASE-5364? 

Thanks!

 Add rat check to run automatically on mvn build.
 

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
 Attachments: HBASE-5363-1.patch


 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

[
https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204852#comment-13204852
]

stack commented on HBASE-5270:
--

bq. So when assigning regions, some regionplans whose destination is the dead
server will be failed.

True. They'll fail and get retried elsewhere which shouldn't be too bad. But
need to keep it in mind. This all doesn't work (I think) if we need to scan
meta and its on a server that has just gone down.

Handle potential data loss due to concurrent processing of processFaileOver
and ServerShutdownHandler
-

Key: HBASE-5270
URL: https://issues.apache.org/jira/browse/HBASE-5270
Project: HBase
Issue Type: Sub-task
Components: master
Reporter: Zhihong Yu
Fix For: 0.94.0, 0.92.1

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread Lars Hofhansl (Issue Comment Edited) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204876#comment-13204876
 ] 

Hudson commented on HBASE-5288:
---

Integrated in HBase-0.92 #275 (See 
[https://builds.apache.org/job/HBase-0.92/275/])
HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs

jmhsieh : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/assembly/all.xml


 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (HBASE-5229) Provide basic building blocks for multi-row local transactions.


[ 
https://issues.apache.org/jira/browse/HBASE-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199514#comment-13199514
 ] 

Lars Hofhansl edited comment on HBASE-5229 at 2/9/12 9:15 PM:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4788
---



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
https://reviews.apache.org/r/3748/#comment10525

Should be ' to mutateRows'



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
https://reviews.apache.org/r/3748/#comment10526

Should read ' the mutations'



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10529

Can the two add() methods be combined into one which accepts Mutation ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10527

Is this method thread-safe ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10528

This comment can be removed, right ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RowMutation.java
https://reviews.apache.org/r/3748/#comment10531

From its name, RowMutation seems to refer to single row. It is a little 
confusing RowMutation extends MultiRowMutation.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RowMutation.java
https://reviews.apache.org/r/3748/#comment10530

version would be read / written twice, right ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
https://reviews.apache.org/r/3748/#comment10532

Should be 'within the region', right ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
https://reviews.apache.org/r/3748/#comment10533

rowsToLock.size() could be smaller than mutations.size(), right ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/3748/#comment10535

Can we refer regionName from rm (the MultiRowMutation) ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/3748/#comment10534

Should be mutateRows



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
https://reviews.apache.org/r/3748/#comment10536

Should read atomic mutation


- Ted


  was (Author: jirapos...@reviews.apache.org):

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4788
---



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
https://reviews.apache.org/r/3748/#comment10525

Should be ' to mutateRows'



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
https://reviews.apache.org/r/3748/#comment10526

Should read ' the mutations'



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10529

Can the two add() methods be combined into one which accepts Mutation ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10527

Is this method thread-safe ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10528

This comment can be removed, right ?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RowMutation.java
https://reviews.apache.org/r/3748/#comment10531

From its name, RowMutation seems to refer to single row. It is a little 
confusing RowMutation extends MultiRowMutation.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RowMutation.java
https://reviews.apache.org/r/3748/#comment10530

version would be read / written twice, right ?

[jira] [Issue Comment Edited] (HBASE-5229) Provide basic building blocks for multi-row local transactions.

2012-02-09 Thread Lars Hofhansl (Issue Comment Edited) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201354#comment-13201354
 ] 

Lars Hofhansl edited comment on HBASE-5229 at 2/9/12 9:18 PM:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4833
---



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
https://reviews.apache.org/r/3748/#comment10616

Do we need to be sorting rowsToLock?

I'm thinking of multiple concurrent mutateRows operation, trying to lock 
the same set of rows.

Perhaps, throwing IOException is going to prevent us from a situation where 
we end up with a deadlock. But, we still might want to sort it to ensure 
(better) progress (no livelock).


- Amitanand


  was (Author: jirapos...@reviews.apache.org):

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4833
---



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
https://reviews.apache.org/r/3748/#comment10616

Do we need to be sorting rowsToLock?

I'm thinking of multiple concurrent mutateRows operation, trying to lock 
the same set of rows.

Perhaps, throwing IOException is going to prevent us from a situation where 
we end up with a deadlock. But, we still might want to sort it to ensure 
(better) progress (no livelock).


- Amitanand


On 2012-02-03 19:59:55, Lars Hofhansl wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3748/
bq.  ---
bq.  
bq.  (Updated 2012-02-03 19:59:55)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This builds on HBASE-3584, HBASE-5203, and HBASE-5304.
bq.  
bq.  Multiple Rows can be locked and applied atomically as long as the 
application ensures that all rows reside in the same Region (by presplitting or 
a custom RegionSplitPolicy).
bq.  At SFDC we can use this to colocate subsets of a tenant's data and allow 
atomic operations over these subsets.
bq.  
bq.  Obviously this is an advanced features and this prominently called out in 
the Javadoc.
bq.  
bq.  
bq.  This addresses bug HBASE-5229.
bq.  https://issues.apache.org/jira/browse/HBASE-5229
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
 1239953 
bq.  
bq.  Diff: https://reviews.apache.org/r/3748/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Tests added to TestFromClientSide and TestAtomicOperation
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Lars
bq.  
bq.


  
 Provide basic building blocks for multi-row local transactions.
 -

 Key: HBASE-5229
 URL: https://issues.apache.org/jira/browse/HBASE-5229
 Project: HBase
  Issue Type: New Feature
  Components: client, regionserver
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.0

[jira] [Issue Comment Edited] (HBASE-5229) Provide basic building blocks for multi-row local transactions.

2012-02-09 Thread Lars Hofhansl (Issue Comment Edited) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13200911#comment-13200911
]

Lars Hofhansl edited comment on HBASE-5229 at 2/9/12 9:17 PM:
--

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq. A couple of nits and small implementation details, but overall looks
pretty good.

You're looking at an old version of the patch. :)

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java,
line 3160
bq. https://reviews.apache.org/r/3748/diff/1/?file=72045#file72045line3160
bq.
bq. But in the comments on the MultiRowMutation you push that checking
off onto the RS, so no checking really happens then (except, I guess when you
try to mutate rows on the region and it fails b/c those rows aren't there, but
that seems kinda late for the check).

Checking is happening the region.internalMutate.

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java,
line 786
bq. https://reviews.apache.org/r/3748/diff/1/?file=72037#file72037line786
bq.
bq. I think is this unnecessary, javadoc should handle inheriting the
docs.

It's done elsewhere, it is good to call out that no doc was added here, because
the interface has the doc.

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java,
line 284
bq. https://reviews.apache.org/r/3748/diff/1/?file=72038#file72038line284
bq.
bq. or presplitting as is described in other documenttation.

Yes, should add this.

Sure.

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java,
line 45
bq. https://reviews.apache.org/r/3748/diff/1/?file=72039#file72039line45
bq.
bq. A javadoc here might be nice to indicate that the nullary
constructor is actually completely ok to use (as opposed to the more common
state of being reserved for readFields).

Good point. Although unless it is called out that you cannot use a constructor
there should be no reason whyt you couldn't.

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java,
line 64
bq. https://reviews.apache.org/r/3748/diff/1/?file=72039#file72039line64
bq.
bq. Even though it uses protected structures doesn't mean that its
necessarily thread safe. In fact, because it is using the standard ArrayList,
there is no guarantee of safety. Either the class should be marked as not
thread safe OR the mutations should be wrapped as a concurrent list.

I disagree.
This is a client side object and none of the client side objects are threadsafe
nor should they be (see Put.java/Delete.java/Increment.java/Append.java/etc),
that's the task of client application.

I misread Ted's comment before, of course this method is not threadsafe.

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RowMutation.java,
line 95
bq. https://reviews.apache.org/r/3748/diff/1/?file=72040#file72040line95
bq.
bq. You really don't need to keep around the row anymore either because
you can get that from the mutations as you already do mutateRows with
MultiRowMutation. Its nice to store it, but is only going to be checked
infrequently and saves you a little bit over the wire (which could add up,
depending on row size).

Same as Put and Delete (where every KV already has the row).
There is room optimization, but this is not the jira to do that.

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java,
line 4161
bq. https://reviews.apache.org/r/3748/diff/1/?file=72044#file72044line4161
bq.
bq. Suprised this isn't a utility method in HRegion - it seems really
useful. Maybe worth pulling out for general use.

internalMutate?

bq. On 2012-02-05 07:26:08, Jesse Yates wrote:
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java,
line 4181
bq. https://reviews.apache.org/r/3748/diff/1/?file=72044#file72044line4181
bq.
bq. This

[jira] [Issue Comment Edited] (HBASE-5229) Provide basic building blocks for multi-row local transactions.

2012-02-09 Thread Lars Hofhansl (Issue Comment Edited) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13200681#comment-13200681
 ] 

Lars Hofhansl edited comment on HBASE-5229 at 2/9/12 9:17 PM:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4822
---


A couple of nits and small implementation details, but overall looks pretty 
good.


http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
https://reviews.apache.org/r/3748/#comment10588

I think is this unnecessary, javadoc should handle inheriting the docs.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
https://reviews.apache.org/r/3748/#comment10587

or presplitting as is described in other documenttation.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10586

Probably want to wrap NOTE in b tags to call it out.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10590

A javadoc here might be nice to indicate that the nullary constructor is 
actually completely ok to use (as opposed to the more common state of being 
reserved for readFields).



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
https://reviews.apache.org/r/3748/#comment10585

Even though it uses protected structures doesn't mean that its necessarily 
thread safe. In fact, because it is using the standard ArrayList, there is no 
guarantee of safety. Either the class should be marked as not thread safe OR 
the mutations should be wrapped as a concurrent list.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RowMutation.java
https://reviews.apache.org/r/3748/#comment10591

You really don't need to keep around the row anymore either because you can 
get that from the mutations as you already do mutateRows with MultiRowMutation. 
Its nice to store it, but is only going to be checked infrequently and saves 
you a little bit over the wire (which could add up, depending on row size).



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
https://reviews.apache.org/r/3748/#comment10592

Suprised this isn't a utility method in HRegion - it seems really useful. 
Maybe worth pulling out for general use.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
https://reviews.apache.org/r/3748/#comment10593

This isn't actually true, right? With multirow, you are actually going to 
lock more than one row (and the lockId null seems kind of a hack around that as 
it is always null, so far).



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
https://reviews.apache.org/r/3748/#comment10594

nit: lockID rather than just lid would be slightly descriptive.



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/3748/#comment10595

But in the comments on the MultiRowMutation you push that checking off onto 
the RS, so no checking really happens then (except, I guess when you try to 
mutate rows on the region and it fails b/c those rows aren't there, but that 
seems kinda late for the check).



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/3748/#comment10596

Wow, this is ugly. Maybe we should consider some refactoring of this later?



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
https://reviews.apache.org/r/3748/#comment10597

This class can get easily bloated as we add more types. Might be worth 
considering refactoring this out into its own test.


- Jesse


  was (Author: jirapos...@reviews.apache.org):

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4822
---


A couple of nits and small implementation details, but overall looks pretty 
good.


http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
https://reviews.apache.org/r/3748/#comment10588

I think is this unnecessary, javadoc should handle

[jira] [Issue Comment Edited] (HBASE-5229) Provide basic building blocks for multi-row local transactions.

2012-02-09 Thread Lars Hofhansl (Issue Comment Edited) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201365#comment-13201365
 ] 

Lars Hofhansl edited comment on HBASE-5229 at 2/9/12 9:18 PM:
--


bq.  On 2012-02-06 15:52:43, Amitanand Aiyer wrote:
bq.   
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java,
 line 4212
bq.   https://reviews.apache.org/r/3748/diff/2/?file=72266#file72266line4212
bq.  
bq.   Do we need to be sorting rowsToLock?
bq.   
bq.   I'm thinking of multiple concurrent mutateRows operation, trying to 
lock the same set of rows.
bq.   
bq.   Perhaps, throwing IOException is going to prevent us from a 
situation where we end up with a deadlock. But, we still might want to sort it 
to ensure (better) progress (no livelock).

MutateRows sorts them (by using a TreeSet with Bytes.BYTES_COMPARATOR, for 
exactly this reason.
Maybe this should be called out here, by making the argument a SortedSet.


- Lars


  was (Author: jirapos...@reviews.apache.org):


bq.  On 2012-02-06 15:52:43, Amitanand Aiyer wrote:
bq.   
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java,
 line 4212
bq.   https://reviews.apache.org/r/3748/diff/2/?file=72266#file72266line4212
bq.  
bq.   Do we need to be sorting rowsToLock?
bq.   
bq.   I'm thinking of multiple concurrent mutateRows operation, trying to 
lock the same set of rows.
bq.   
bq.   Perhaps, throwing IOException is going to prevent us from a 
situation where we end up with a deadlock. But, we still might want to sort it 
to ensure (better) progress (no livelock).

MutateRows sorts them (by using a TreeSet with Bytes.BYTES_COMPARATOR, for 
exactly this reason.
Maybe this should be called out here, by making the argument a SortedSet.


- Lars


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4833
---


On 2012-02-03 19:59:55, Lars Hofhansl wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3748/
bq.  ---
bq.  
bq.  (Updated 2012-02-03 19:59:55)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This builds on HBASE-3584, HBASE-5203, and HBASE-5304.
bq.  
bq.  Multiple Rows can be locked and applied atomically as long as the 
application ensures that all rows reside in the same Region (by presplitting or 
a custom RegionSplitPolicy).
bq.  At SFDC we can use this to colocate subsets of a tenant's data and allow 
atomic operations over these subsets.
bq.  
bq.  Obviously this is an advanced features and this prominently called out in 
the Javadoc.
bq.  
bq.  
bq.  This addresses bug HBASE-5229.
bq.  https://issues.apache.org/jira/browse/HBASE-5229
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
 PRE-CREATION 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
 1239953 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
 1239953 
bq.  
bq.  Diff: https://reviews.apache.org/r/3748/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Tests added to TestFromClientSide and TestAtomicOperation
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Lars
bq.  
bq.


  
 Provide basic building blocks for multi-row local transactions.

[jira] [Commented] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204903#comment-13204903
 ] 

Hudson commented on HBASE-5367:
---

Integrated in HBase-TRUNK-security #103 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/103/])
hbase-5367 book.xml - this time, really fixing the default 
compaction.min.size
hbase-5367.  book.xml - minor formatting in Arch/Region/Store compaction 
description


 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5365) [book] adding description of compaction file selection to refGuide in Arch/Regions/Store


[ 
https://issues.apache.org/jira/browse/HBASE-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204904#comment-13204904
 ] 

Hudson commented on HBASE-5365:
---

Integrated in HBase-TRUNK-security #103 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/103/])
hbase-5365.  book - Arch/Region/Store adding description of compaction file 
selection


 [book] adding description of compaction file selection to refGuide in 
 Arch/Regions/Store
 

 Key: HBASE-5365
 URL: https://issues.apache.org/jira/browse/HBASE-5365
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
 Attachments: docbkx_hbase_5365.patch


 book.xml
 * adding description of compaction selection algorithm with examples (based 
 on existing unit tests) 
 * also added a few links to the compaction section from other places in the 
 book that already mention compaction.
 configuration.xml
 * added link to compaction section from the entry that discusses configuring 
 major compaction interval.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio


[ 
https://issues.apache.org/jira/browse/HBASE-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204902#comment-13204902
 ] 

Hudson commented on HBASE-5330:
---

Integrated in HBase-TRUNK-security #103 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/103/])
hbase-5330.  Update to TestCompactSelection unit test for selection SF 
assertions.


 TestCompactSelection - adding 2 test cases to testCompactionRatio
 -

 Key: HBASE-5330
 URL: https://issues.apache.org/jira/browse/HBASE-5330
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: TestCompactSelection_hbase_5330.java.patch, 
 TestCompactSelection_hbase_5330_v2.java.patch


 There were three existing assertions in TestCompactSelection 
 testCompactionRatio that did max # of files assertions...
 {code}
 assertEquals(maxFiles,
 
 store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
 {code}
 ... and for references ...
 {code}
   assertEquals(maxFiles,
 store.compactSelection(sfCreate(true, 
 7,6,5,4,3,2,1)).getFilesToCompact().size());
 {code}
  
 ... but they didn't assert against which StoreFiles got selected.  While the 
 number of StoreFiles is the same, the files selected are actually different, 
 and I thought that there should be explicit assertions showing that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5288) Security source code dirs missing from 0.92.0 release tarballs.

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204905#comment-13204905
 ] 

Hudson commented on HBASE-5288:
---

Integrated in HBase-TRUNK-security #103 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/103/])
HBASE-5288 Security source code dirs missing from 0.92.0 release tarballs

jmhsieh : 
Files : 
* /hbase/trunk/src/assembly/all.xml


 Security source code dirs missing from 0.92.0 release tarballs.
 ---

 Key: HBASE-5288
 URL: https://issues.apache.org/jira/browse/HBASE-5288
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
Priority: Blocker
 Fix For: 0.94.0, 0.92.1

 Attachments: hbase-5288.patch


 The release tarballs have a compiled version of the hbase jars and the 
 security tarball seems to have the compiled security bits.  However, the 
 source code and resources for security implementation are missing from the 
 release tarballs in both distributions.  They should be included in both.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5199) Delete out of TTL store files before compaction selection

2012-02-09 Thread Liyin Tang (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204926#comment-13204926
 ] 

Liyin Tang commented on HBASE-5199:
---

Ping committers !

 Delete out of TTL store files before compaction selection
 -

 Key: HBASE-5199
 URL: https://issues.apache.org/jira/browse/HBASE-5199
 Project: HBase
  Issue Type: Improvement
Reporter: Liyin Tang
Assignee: Liyin Tang
 Attachments: D1311.1.patch, D1311.2.patch, D1311.3.patch, 
 D1311.4.patch, D1311.5.patch, D1311.5.patch, HBASE-5199.patch


 Currently, HBase deletes the out of TTL store files after compaction. We can 
 change the sequence to delete the out of TTL store files before selecting 
 store files for compactions. 
 In this way, HBase can keep deleting the old invalid store files without 
 compaction, and also prevent from unnecessary compactions since the out of 
 TTL store files will be deleted before the compaction selection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5325) Expose basic information about the master-status through jmx beans

2012-02-09 Thread Enis Soztutar (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204929#comment-13204929
]

Enis Soztutar commented on HBASE-5325:
--

My 2 cents:
bq. @Enis metrics2 seems a bit out there for us (hadoop 0.23?). We want to run
on 0.23 and 1.0 and 2.0, etc., so it'd be a while before we could lean on it.
metrics2 has facility that would help? (I've not studied it).
It seems that Hadoop-1.0 includes some of the metrics2 changes but not all, so
I agree that without going full 0.23, it is not possible to use metrics2.

bq. I'd be interested in what you think. We need to figure being able to config
a running cluster; i.e. change Configuration values and have hbase notice.
Having this go via jmx would likely be like taking the 'killarney road to
dingle' as my grandma used to say (its shorter if you take the tralee road) so
maybe jmx is read-only rather than 'management'.
With an offline discussion with Hitesh, we completely agree on the roadmap for
managing the cluster configuration in one place, but I think JMX is not
suitable for this. We can keep the current approach of read-only JMX beans, and
deal with the issue of configuration management in another ticket. I'll try to
read up on how other distributed software projects approach this problem.

I totally agree that we might want to aggregate some of the metrics in master,
and possibly redesign the HServerLoad using metrics, but we can deal with that
in yet another issue. Since all of the metrics are collected via MasterMetrics,
and exposed via MasterStatistics, I think we will not need any API change for
that, no?

I think the current patch, as it is, is enough for defining a base for future
work. It only exposes data that is available in the webapi, and with it we
would have 3 API endpoints/JMX beans that we can query relevant info.
HBaseInfo for common information
HBaseMasterInfo for master level status information
MasterStatistics for metrics

Expose basic information about the master-status through jmx beans
---

Key: HBASE-5325
URL: https://issues.apache.org/jira/browse/HBASE-5325
Project: HBase
Issue Type: Improvement
Reporter: Hitesh Shah
Assignee: Hitesh Shah
Priority: Minor
Fix For: 0.94.0

Attachments: HBASE-5325.1.patch, HBASE-5325.wip.patch

Similar to the Namenode and Jobtracker, it would be good if the hbase master
could expose some information through mbeans.

[jira] [Commented] (HBASE-5199) Delete out of TTL store files before compaction selection

2012-02-09 Thread Zhihong Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204934#comment-13204934
 ] 

Zhihong Yu commented on HBASE-5199:
---

HBASE-5199.patch doesn't apply cleanly:
{code}
3 out of 6 hunks FAILED -- saving rejects to file 
src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java.rej
patching file 
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file 
src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java.rej
{code}
Can you rebase patch ?

 Delete out of TTL store files before compaction selection
 -

 Key: HBASE-5199
 URL: https://issues.apache.org/jira/browse/HBASE-5199
 Project: HBase
  Issue Type: Improvement
Reporter: Liyin Tang
Assignee: Liyin Tang
 Attachments: D1311.1.patch, D1311.2.patch, D1311.3.patch, 
 D1311.4.patch, D1311.5.patch, D1311.5.patch, HBASE-5199.patch


 Currently, HBase deletes the out of TTL store files after compaction. We can 
 change the sequence to delete the out of TTL store files before selecting 
 store files for compactions. 
 In this way, HBase can keep deleting the old invalid store files without 
 compaction, and also prevent from unnecessary compactions since the out of 
 TTL store files will be deleted before the compaction selection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously


[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204943#comment-13204943
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--



bq.  On 2012-02-09 02:16:29, Ted Yu wrote:
bq.   src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line 
606
bq.   https://reviews.apache.org/r/3811/diff/2/?file=73392#file73392line606
bq.  
bq.   Should we validate length ?

It is not validated in other array/list read operations. The allocation will 
fail anyway if the length is off, no? 


bq.  On 2012-02-09 02:16:29, Ted Yu wrote:
bq.   src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java, 
line 246
bq.   https://reviews.apache.org/r/3811/diff/2/?file=73393#file73393line246
bq.  
bq.   What does InSeq mean ?

Oh, it comes from SegT from Scala, where ArrayT and ListT extends. I'll 
change the method name to testPolymorphismInSequences(), and add some comments, 
if you don't have any suggestion. 


bq.  On 2012-02-09 02:16:29, Ted Yu wrote:
bq.   src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line 
445
bq.   https://reviews.apache.org/r/3811/diff/2/?file=73392#file73392line445
bq.  
bq.   What if componentType is another Array ?

The test case for A[][] already covers for this i believe. 


- enis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4952
---


On 2012-02-09 01:38:18, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 01:38:18)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



 HBaseObjectWritable should be able to serialize generic arrays not defined 
 previously
 -

 Key: HBASE-5358
 URL: https://issues.apache.org/jira/browse/HBASE-5358
 Project: HBase
  Issue Type: Improvement
  Components: coprocessors, io
Reporter: Enis Soztutar
Assignee: Enis Soztutar

 HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
 A extends Writable. This becomes an issue for example when adding a 
 coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204942#comment-13204942
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--



bq.  On 2012-02-09 07:02:48, Michael Stack wrote:
bq.   src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java, line 
446
bq.   https://reviews.apache.org/r/3811/diff/2/?file=73392#file73392line446
bq.  
bq.   We are changing what is on the line now when we serialize?  All 
arrays now serialize their type ahead of array length?  In our public API what 
arrays will this effect?  Do you know?  Does it require our upping the version 
on the Interface that uses HBaseObjectWritable?

We are not changing the serialized bytes for the arrays that are already in 
CLASS_TO_CODE. This only affects the arrays that are not defined there. For 
them, when you serialize, the deserializer throws an erroneous 
ClassNotFoundException. So, I don't think wire compatibility will be affected. 


- enis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4960
---


On 2012-02-09 01:38:18, enis wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  ---
bq.  
bq.  (Updated 2012-02-09 01:38:18)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] 
where A extends Writable. This becomes an issue for example when adding a 
coprocessor method which takes A[] (see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.  https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 
78513ce 
bq.src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 
260f982 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.



 HBaseObjectWritable should be able to serialize generic arrays not defined 
 previously
 -

 Key: HBASE-5358
 URL: https://issues.apache.org/jira/browse/HBASE-5358
 Project: HBase
  Issue Type: Improvement
  Components: coprocessors, io
Reporter: Enis Soztutar
Assignee: Enis Soztutar

 HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
 A extends Writable. This becomes an issue for example when adding a 
 coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3134) [replication] Add the ability to enable/disable streams

2012-02-09 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204948#comment-13204948
]

Hadoop QA commented on HBASE-3134:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12514010/3134-v2.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 156 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/931//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/931//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/931//console

This message is automatically generated.

[replication] Add the ability to enable/disable streams
---

Attachments: 3134-v2.txt, 3134.txt, HBASE-3134.patch,
HBASE-3134.patch, HBASE-3134.patch, HBASE-3134.patch

[jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously


[ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204956#comment-13204956
 ] 

jirapos...@reviews.apache.org commented on HBASE-5358:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/
---

(Updated 2012-02-09 22:18:10.009110)


Review request for hbase.


Changes
---

Incoprorated review comments, optimized the serialization of Arrays of know 
types, and added a few more test cases


Summary
---

HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where A 
extends Writable. This becomes an issue for example when adding a coprocessor 
method which takes A[] (see HBASE-5352).


This addresses bug HBASE-5358.
https://issues.apache.org/jira/browse/HBASE-5358


Diffs (updated)
-

  src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 260f982 
  src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 78513ce 

Diff: https://reviews.apache.org/r/3811/diff


Testing
---


Thanks,

enis



 HBaseObjectWritable should be able to serialize generic arrays not defined 
 previously
 -

 Key: HBASE-5358
 URL: https://issues.apache.org/jira/browse/HBASE-5358
 Project: HBase
  Issue Type: Improvement
  Components: coprocessors, io
Reporter: Enis Soztutar
Assignee: Enis Soztutar

 HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
 A extends Writable. This becomes an issue for example when adding a 
 coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5369) Compaction selection based on the hotness of the HFile's block in the block cache

2012-02-09 Thread Liyin Tang (Created) (JIRA)

Compaction selection based on the hotness of the HFile's block in the block 
cache
-

 Key: HBASE-5369
 URL: https://issues.apache.org/jira/browse/HBASE-5369
 Project: HBase
  Issue Type: Improvement
Reporter: Liyin Tang
Assignee: Liyin Tang


HBase reserves a large set memory for the block cache and the cached blocks 
will be age out in a LRU fashion. Obviously, we don't want to age out the 
blocks which are still hot. However, when the compactions are starting, these 
hot blocks may naturally be invalid. Considering that the block cache has 
already known which HFiles these hot blocks come from, the compaction selection 
algorithm could just simply skip compact these HFiles until these block cache 
become cold.
Furthermore, the HBase could compact multiple HFiles into two HFiles. One of 
them only contains hot blocks which are supposed be cached directly.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5364) Fix source files missing licenses

2012-02-09 Thread Elliott Clark (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5364:
-

Attachment: HBASE-5364-1.patch

 Fix source files missing licenses
 -

 Key: HBASE-5364
 URL: https://issues.apache.org/jira/browse/HBASE-5364
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0, 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Priority: Blocker
 Attachments: HBASE-5364-1.patch


 running 'mvn rat:check' shows that a few files have snuck in that do not have 
 proper apache licenses.  Ideally we should fix these before we cut another 
 release/release candidate.
 This is a blocker for 0.94, and probably should be for the other branches as 
 well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5367) [book] small formatting changes to compaction description in Arch/Regions/Store

2012-02-09 Thread Doug Meil (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204979#comment-13204979
 ] 

Doug Meil commented on HBASE-5367:
--

Should I change this back to 64M?


 [book] small formatting changes to compaction description in 
 Arch/Regions/Store
 ---

 Key: HBASE-5367
 URL: https://issues.apache.org/jira/browse/HBASE-5367
 Project: HBase
  Issue Type: Improvement
Reporter: Doug Meil
Assignee: Doug Meil
Priority: Minor
 Attachments: book_hbase_5367.xml.patch, book_hbase_5367_2.xml.patch


 Fixing a few small-but-important things that came out of a post-commit 
 comment in HBASE-5365
 book.xml
 * corrected default region flush size (it's actually 64mb)
 * removed trailing 'F' in a ratio discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread Enis Soztutar (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated HBASE-5358:
-

Attachment: HBASE-5358_v3.patch

Attaching the latest version of the patch from review. Incorporates a trivial 
javadoc fix as suggested. 

 HBaseObjectWritable should be able to serialize generic arrays not defined 
 previously
 -

 Key: HBASE-5358
 URL: https://issues.apache.org/jira/browse/HBASE-5358
 Project: HBase
  Issue Type: Improvement
  Components: coprocessors, io
Reporter: Enis Soztutar
Assignee: Enis Soztutar
 Attachments: HBASE-5358_v3.patch


 HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
 A extends Writable. This becomes an issue for example when adding a 
 coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously

2012-02-09 Thread Enis Soztutar (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated HBASE-5358:
-

Affects Version/s: 0.94.0
   Status: Patch Available  (was: Open)

 HBaseObjectWritable should be able to serialize generic arrays not defined 
 previously
 -

 Key: HBASE-5358
 URL: https://issues.apache.org/jira/browse/HBASE-5358
 Project: HBase
  Issue Type: Improvement
  Components: coprocessors, io
Affects Versions: 0.94.0
Reporter: Enis Soztutar
Assignee: Enis Soztutar
 Attachments: HBASE-5358_v3.patch


 HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where 
 A extends Writable. This becomes an issue for example when adding a 
 coprocessor method which takes A[] (see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5370) Allow HBase shell set HTableDescriptor values

2012-02-09 Thread Lars Hofhansl (Created) (JIRA)

Allow HBase shell set HTableDescriptor values
-

 Key: HBASE-5370
 URL: https://issues.apache.org/jira/browse/HBASE-5370
 Project: HBase
  Issue Type: Improvement
Reporter: Lars Hofhansl
Priority: Minor


Currently it does not seem to be possible to set value on a table's 
HTableDescriptor (either on creation or afterwards).

The syntax I have in mind is something like:
create {NAME='table', 'somekey'='somevalue'}, 'column'

In analogy to how we allow a column to either a string ('column') or an 
association {NAME='column', ...}

alter would be changed to allow setting arbitrary values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn release builds


 [ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5363:
--

Summary: Automatically run rat check on mvn release builds  (was: Add rat 
check run automatically on mvn release build.)

 Automatically run rat check on mvn release builds
 -

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
 Attachments: HBASE-5363-1.patch


 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5363) Add rat check run automatically on mvn release build.


 [ 
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-5363:
--

Summary: Add rat check run automatically on mvn release build.  (was: Add 
rat check to run automatically on mvn build.)

 Add rat check run automatically on mvn release build.
 -

 Key: HBASE-5363
 URL: https://issues.apache.org/jira/browse/HBASE-5363
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
 Attachments: HBASE-5363-1.patch


 Some of the recent hbase release failed rat checks (mvn rat:check).  We 
 should add checks likely in the mvn package phase so that this becomes a 
 non-issue in the future.
 Here's an example from Whirr:
 https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5370) Allow HBase shell to set HTableDescriptor values

2012-02-09 Thread Lars Hofhansl (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-5370:
-

Summary: Allow HBase shell to set HTableDescriptor values  (was: Allow 
HBase shell set HTableDescriptor values)

 Allow HBase shell to set HTableDescriptor values
 

 Key: HBASE-5370
 URL: https://issues.apache.org/jira/browse/HBASE-5370
 Project: HBase
  Issue Type: Improvement
Reporter: Lars Hofhansl
Priority: Minor

 Currently it does not seem to be possible to set value on a table's 
 HTableDescriptor (either on creation or afterwards).
 The syntax I have in mind is something like:
 create {NAME='table', 'somekey'='somevalue'}, 'column'
 In analogy to how we allow a column to either a string ('column') or an 
 association {NAME='column', ...}
 alter would be changed to allow setting arbitrary values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4720) Implement atomic update operations (checkAndPut, checkAndDelete) for REST client/server

2012-02-09 Thread Mubarak Seyed (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204998#comment-13204998
 ] 

Mubarak Seyed commented on HBASE-4720:
--

The following scenarios are tested:

1. 5 nodes dev cluster, running trunk
   * Generated load with curl for checkAndPut/checkAndDelete, tested for 
functional verification
   * Developed a test client, which uses HBaseAdmin APIs to test the atomic 
operations functionality (for   positive/negative testcases)

2. 7 nodes perf cluster, running trunk
   * Developed a test client, which uses HBaseAdmin APIs to test the atomic 
operations functionality (for positive/negative testcases).

 Implement atomic update operations (checkAndPut, checkAndDelete) for REST 
 client/server 
 

 Key: HBASE-4720
 URL: https://issues.apache.org/jira/browse/HBASE-4720
 Project: HBase
  Issue Type: Improvement
Reporter: Daniel Lord
Assignee: Mubarak Seyed
 Fix For: 0.94.0

 Attachments: HBASE-4720.trunk.v1.patch, HBASE-4720.trunk.v2.patch, 
 HBASE-4720.trunk.v3.patch, HBASE-4720.trunk.v4.patch, 
 HBASE-4720.trunk.v5.patch, HBASE-4720.trunk.v6.patch, 
 HBASE-4720.trunk.v7.patch, HBASE-4720.v1.patch, HBASE-4720.v3.patch


 I have several large application/HBase clusters where an application node 
 will occasionally need to talk to HBase from a different cluster.  In order 
 to help ensure some of my consistency guarantees I have a sentinel table that 
 is updated atomically as users interact with the system.  This works quite 
 well for the regular hbase client but the REST client does not implement 
 the checkAndPut and checkAndDelete operations.  This exposes the application 
 to some race conditions that have to be worked around.  It would be ideal if 
 the same checkAndPut/checkAndDelete operations could be supported by the REST 
 client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5364) Fix source files missing licenses

2012-02-09 Thread Elliott Clark (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205002#comment-13205002
 ] 

Elliott Clark commented on HBASE-5364:
--

Attach patch to fix files on master.

 Fix source files missing licenses
 -

 Key: HBASE-5364
 URL: https://issues.apache.org/jira/browse/HBASE-5364
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0, 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Priority: Blocker
 Attachments: HBASE-5364-1.patch


 running 'mvn rat:check' shows that a few files have snuck in that do not have 
 proper apache licenses.  Ideally we should fix these before we cut another 
 release/release candidate.
 This is a blocker for 0.94, and probably should be for the other branches as 
 well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5363) Automatically run rat check on mvn release builds