[jira] [Commented] (HBASE-19088) move_tables_rsgroup will throw an exception when the table is disabled
[
https://issues.apache.org/jira/browse/HBASE-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243485#comment-16243485
]
Hudson commented on HBASE-19088:
FAILURE: Integrated in Jenkins build HBase-2.0 #817 (See
[https://builds.apache.org/job/HBase-2.0/817/])
HBASE-19088 move_tables_rsgroup will throw an exception when the table
(apurtell: rev 8095f96289ac2fb1f5d9cd15b3ef55ddf791020f)
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
> move_tables_rsgroup will throw an exception when the table is disabled
> --
>
> Key: HBASE-19088
> URL: https://issues.apache.org/jira/browse/HBASE-19088
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-19088.branch-1.001.patch,
> HBASE-19088.branch-1.001.patch, HBASE-19088.branch-1.002.patch,
> HBASE-19088.master.001.patch, HBASE-19088.master.002.patch,
> HBASE-19088.master.003.patch
>
>
> When the table is disabled, *move_tables_rsgroup* will throw an exception,
> but the table has been moved to the new group successfully.
> {code:java}
> hbase(main):009:0> move_tables_rsgroup 'default',['t1']
> ERROR: java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos$MoveRegionStateData$Builder.setSourceServer(MasterProcedureProtos.java:26022)
> at
> org.apache.hadoop.hbase.master.assignment.MoveRegionProcedure.serializeStateData(MoveRegionProcedure.java:133)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProtoProcedure(ProcedureUtil.java:198)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeEntry(ProcedureWALFormat.java:211)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeInsert(ProcedureWALFormat.java:222)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.insert(WALProcedureStore.java:470)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:866)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:835)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitAndWaitProcedure(ProcedureSyncWait.java:120)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.move(AssignmentManager.java:557)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:413)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.moveTables(RSGroupAdminEndpoint.java:190)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:12786)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:786)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> ... 3 more
> Reassign tables from one RegionServer group to another.
> Example:
> hbase> move_tables_rsgroup 'dest',['table1','table2']
> Took 0.0297 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242913#comment-16242913
]
Hadoop QA commented on HBASE-14964:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 21m
30s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
3s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
47s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
19s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
0s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} hbase-client: The patch generated 7 new + 5 unchanged
- 3 fixed = 12 total (was 8) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
17s{color} | {color:red} hbase-server: The patch generated 5 new + 61 unchanged
- 0 fixed = 66 total (was 61) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
15s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 0s{color}
| {color:red}
[jira] [Commented] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243332#comment-16243332 ] Reid Chan commented on HBASE-18309: --- bq. for a reasonable test please use a larger scale and include your reasoning, 10 doesn't seem like enough to simulate what will happen in a deployment. e.g. X regions per server, Y servers means Z directories to clean up. No need to use a real large scale, it can be simulated by creating 1000 sub dirs under root dir, and each sub dirs contains up to 1000 files and sub dirs. WDYT? I will provide statistics later. bq. At what point will tuning this parameter cause a NameNode to fall over? How do we stop folks from doing that accidentally? I'm not sure, and that's why parameter upper limit is machine's available cores. But observation from my production cluster(1000+ nodes) NameNode(24 cores) running for months and dealing with hundreds of jobs with deletion and creation every day shows that it is not easy for cleaner chore to get that achievement, XD. And i would suggest to set it less than or equals to NameNodes's core number for safety concern. bq. These details should probably be in the documentation about the config. Get it, i will write it in hbase-default.xml with description. > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: binlijin >Assignee: Reid Chan > Attachments: HBASE-18309.master.001.patch, > HBASE-18309.master.002.patch > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243181#comment-16243181
]
Andrew Purtell commented on HBASE-19194:
This is a really important find. Thanks [~mdrob] for keeping up error-prone and
filing an issue for this problem.
In HBASE-15631 we dropped a hunk from HMaster in review because it was a core
change that didn't have any coverage in the RSGroups tests. A test which should
have failed passed because it was silently broken in the way error-prone
identified. Attaching a patch with the test fixes and the inclusion of that
dropped hunk as fix for the now correctly failing test.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18309) Support multi threads in CleanerChore
[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243351#comment-16243351
]
Yu Li commented on HBASE-18309:
---
I think we should focus on {{LogCleaner}} instead of {{CleanerChore}} here
(misleading title...), since it's hard to unify the clean policy for hfile/wal.
And in the implementation we're using in production we made LogCleaner supports
online configuration change, which I think is a must-have (restarting RS is
something we better avoid for online/near-line service).
Sorry for the late response since we're busy supporting Singles' Day. Thanks
for taking the task and good on you [~reidchan].
[~aoxiang] please also help review the patch when time allows, thanks.
> Support multi threads in CleanerChore
> -
>
> Key: HBASE-18309
> URL: https://issues.apache.org/jira/browse/HBASE-18309
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: binlijin
>Assignee: Reid Chan
> Attachments: HBASE-18309.master.001.patch,
> HBASE-18309.master.002.patch
>
>
> There is only one thread in LogCleaner to clean oldWALs and in our big
> cluster we find this is not enough. The number of files under oldWALs reach
> the max-directory-items limit of HDFS and cause region server crash, so we
> use multi threads for LogCleaner and the crash not happened any more.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19194:
---
Priority: Blocker (was: Minor)
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19206) Add bytesEvicted to CacheEvictionStats after HBASE-17819
Zach York created HBASE-19206: - Summary: Add bytesEvicted to CacheEvictionStats after HBASE-17819 Key: HBASE-19206 URL: https://issues.apache.org/jira/browse/HBASE-19206 Project: HBase Issue Type: Improvement Components: BlockCache, BucketCache Reporter: Zach York Assignee: Zach York Priority: Minor As part of HBASE-18624, bytesEvicted was removed from CacheEvictionStats due to the chance of an incorrect value. HBASE-17819 is adding support for more information being returned from evicting HFiles and will allow us to add this back. This JIRA is to add bytesEvicted back into CacheEvictionStats. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243185#comment-16243185
]
Andrew Purtell edited comment on HBASE-19194 at 11/8/17 12:57 AM:
--
In retrospect the need for that hunk is clear [~lhofhansl]. The new call to the
balancer ahead of assignment allows the subclassed balancer for RSGroups to
correctly adjust the plan in case the region would otherwise move to an
inappropriate group.
was (Author: apurtell):
In retrospect the need for that hunk is clear [~lhofhansl]. The new call to the
balancer ahead of assignment allows the overridden balancer for RSGroup to
correctly adjust the plan in case the region would otherwise move to an
inappropriate group.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19128) Purge Distributed Log Replay from codebase, configurations, text; mark the feature as unsupported, broken.
[ https://issues.apache.org/jira/browse/HBASE-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19128: - Release Note: Removes Distributed Log Replay feature. Disable the feature before upgrading. (was: Disable Distributed Log Replay before upgrading since it has been removed in 2.0) > Purge Distributed Log Replay from codebase, configurations, text; mark the > feature as unsupported, broken. > -- > > Key: HBASE-19128 > URL: https://issues.apache.org/jira/browse/HBASE-19128 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: stack >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0 > > Attachments: HBASE-19128.master.001.patch, > HBASE-19128.master.002.patch, HBASE-19128.master.003.patch, > HBASE-19128.master.004.patch, HBASE-19128.master.005.patch, > HBASE-19128.master.006.patch > > > Kill it. It keeps coming up and over again. Needs proper burial. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19210) TestNamespacesInstanceResource fails
[
https://issues.apache.org/jira/browse/HBASE-19210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1624#comment-1624
]
Mike Drob commented on HBASE-19210:
---
Something about line 307 sets the rest server into a bad state:
{noformat}
response = client.put(namespacePath2, Constants.MIMETYPE_JSON,
Bytes.toBytes(jsonString));
{noformat}
> TestNamespacesInstanceResource fails
>
>
> Key: HBASE-19210
> URL: https://issues.apache.org/jira/browse/HBASE-19210
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>
> This is the top flaky test.
> The following can be reproduced:
> {code}
> java.net.SocketException: Connection reset
> at
> org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
> {code}
> With commit e320df5a0c267258c03909da8d0eee4c0e287532, the test passes.
> With commit 5facaded902a13556952b1f9d26b768cb86e6599, the test fails.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19200) Let ZooKeeperRegistry depend on ZKAsyncRegistry to get data from zookeeper
[
https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243437#comment-16243437
]
Hadoop QA commented on HBASE-19200:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m
26s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
34s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 5m
0s{color} | {color:red} branch has 11 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m
42s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
27s{color} | {color:red} hbase-client: The patch generated 1 new + 191
unchanged - 13 fixed = 192 total (was 204) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
30s{color} | {color:red} patch has 11 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 52m
26s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.4. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}125m 7s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}210m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19200 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896564/HBASE-19200-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 46c0911251f9 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4132314f51 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| mvninstall |
[jira] [Commented] (HBASE-19201) BulkLoading in HBaseContext in hbase-spark does not close connection
[ https://issues.apache.org/jira/browse/HBASE-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243432#comment-16243432 ] Yung-An He commented on HBASE-19201: Hi Could you post the needed code which you copied into the scala project? > BulkLoading in HBaseContext in hbase-spark does not close connection > > > Key: HBASE-19201 > URL: https://issues.apache.org/jira/browse/HBASE-19201 > Project: HBase > Issue Type: Bug > Components: hbase >Affects Versions: 1.1.12 > Environment: I was using the cdh 5.11.1 version but I checken on > newest branch and problem persists >Reporter: Lucas Resch > Labels: newbie > Original Estimate: 2h > Remaining Estimate: 2h > > Within the hbase-spark module an HBaseContext exists that provides utility > functions to do bulkLoading data in HBase. I tried using this function in a > streaming context, but after a while Zookeeper denies further connections > since the maximum of connections per client is exhausted. > This issue seems to be within HBaseContext, since the functions bulkLoad and > bulkLoadThinRows open a connection via the ConnectionFactory, but never > closes that connection. > I copied the needed code into a new scala project and added a conn.close() at > the end of the function and the problem is gone. > It seems like no one else has had this problem before. I'm guessing thats > because almost no one uses its function within a streaming context. And a one > time call to it with RDDs might never reach that upper limit on connections. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19147) All branch-2 unit tests pass
[ https://issues.apache.org/jira/browse/HBASE-19147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243447#comment-16243447 ] stack commented on HBASE-19147: --- Tried a run on a physical machine. Total time: 07:52 h Tests run: 2450, Failures: 53, Errors: 66, Skipped: 36 ... loads of spew here too with tests getting killed. Maybe my host is sick (though that'd make two in this cluster...) > All branch-2 unit tests pass > > > Key: HBASE-19147 > URL: https://issues.apache.org/jira/browse/HBASE-19147 > Project: HBase > Issue Type: Bug > Components: test >Reporter: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243423#comment-16243423 ] stack commented on HBASE-19204: --- Just finished a run. Took 6.32 hours. On hbase-server second part: Tests run: 1912, Failures: 7, Errors: 20, Skipped: 37, Flakes: 16 The backport of the zk interrupt seems to get us further -- more tests and less failures -- but still loads of timeout mess on end of the run. Loads of tests get killed off. surefire now writes .dump files which talk about self-kills that don't correlate too well w/ what I'm seeing (not enough and times don't align). This is mvn 3.5 so mvn version doesn't seem to matter. Trying an old 1.2.x to see if it as bad from back in May. > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19211) B: update configuration string in BackupRestoreConstants
Vladimir Rodionov created HBASE-19211: - Summary: B: update configuration string in BackupRestoreConstants Key: HBASE-19211 URL: https://issues.apache.org/jira/browse/HBASE-19211 Project: HBase Issue Type: Bug Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov Priority: Minor Fix For: 2.0.0-beta-1 To include custom region observer implementation for tracking bulk loading events. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19088) move_tables_rsgroup will throw an exception when the table is disabled
[
https://issues.apache.org/jira/browse/HBASE-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243421#comment-16243421
]
Hudson commented on HBASE-19088:
FAILURE: Integrated in Jenkins build HBase-1.5 #144 (See
[https://builds.apache.org/job/HBase-1.5/144/])
HBASE-19088 move_tables_rsgroup will throw an exception when the table
(apurtell: rev dc1310f48731c6855d7df7a93dea773e4d46e579)
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
> move_tables_rsgroup will throw an exception when the table is disabled
> --
>
> Key: HBASE-19088
> URL: https://issues.apache.org/jira/browse/HBASE-19088
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-19088.branch-1.001.patch,
> HBASE-19088.branch-1.001.patch, HBASE-19088.branch-1.002.patch,
> HBASE-19088.master.001.patch, HBASE-19088.master.002.patch,
> HBASE-19088.master.003.patch
>
>
> When the table is disabled, *move_tables_rsgroup* will throw an exception,
> but the table has been moved to the new group successfully.
> {code:java}
> hbase(main):009:0> move_tables_rsgroup 'default',['t1']
> ERROR: java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos$MoveRegionStateData$Builder.setSourceServer(MasterProcedureProtos.java:26022)
> at
> org.apache.hadoop.hbase.master.assignment.MoveRegionProcedure.serializeStateData(MoveRegionProcedure.java:133)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProtoProcedure(ProcedureUtil.java:198)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeEntry(ProcedureWALFormat.java:211)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeInsert(ProcedureWALFormat.java:222)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.insert(WALProcedureStore.java:470)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:866)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:835)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitAndWaitProcedure(ProcedureSyncWait.java:120)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.move(AssignmentManager.java:557)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:413)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.moveTables(RSGroupAdminEndpoint.java:190)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:12786)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:786)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> ... 3 more
> Reassign tables from one RegionServer group to another.
> Example:
> hbase> move_tables_rsgroup 'dest',['table1','table2']
> Took 0.0297 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19205) Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243392#comment-16243392
]
Hudson commented on HBASE-19205:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #268 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/268/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev eb8560cab55018236f502f25a77c69610f3c56da)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
> Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw
> exception
> -
>
> Key: HBASE-19205
> URL: https://issues.apache.org/jira/browse/HBASE-19205
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Reporter: stack
>Assignee: stack
> Fix For: 1.3.2, 1.2.7
>
>
> In a branch-1.2 test run, I see a bunch of this in timed out test run:
>709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
> zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
> quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
>doing nothing here
> 710 java.lang.InterruptedException
> Which is us swallowing interrupts out of zk.
> The suppression of the interrupt is messing us up We start to see this:
> {code}
> 5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
> zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
> baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
> rs/ve0528.halxg.cloudera.com,36704,1510086438842
> 5019 java.lang.InterruptedException
> 5020 at java.lang.Object.wait(Native Method)
> 5021 at java.lang.Object.wait(Object.java:502)
> 5022 at
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
> 5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
> 5024 at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> 5025 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
> 5026 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 5027 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5028 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5029 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5030 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5031 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5032 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5033 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5034 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5035 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5036 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5037 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> ...
> {code}
> Later I'm getting
> {code}
> 15578737 Caused by: java.lang.StackOverflowError
> 15578738 at java.security.AccessController.doPrivileged(Native Method)
> 15578739 at java.io.PrintWriter.(PrintWriter.java:116)
> 15578740 at java.io.PrintWriter.(PrintWriter.java:100)
> 15578741 at
> org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
> 15578742 at
> org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
> 15578743 at
> org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
> 15578744 at
> org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
> 15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> 15578746 at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> 15578747 at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> 15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
> 15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
> 15578750 at org.apache.log4j.Category.log(Category.java:856)
> 15578751 at
>
[jira] [Resolved] (HBASE-19205) Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack resolved HBASE-19205.
---
Resolution: Fixed
Fix Version/s: 1.3.2
Pushed to branch-1.2 and branch-1.3
> Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw
> exception
> -
>
> Key: HBASE-19205
> URL: https://issues.apache.org/jira/browse/HBASE-19205
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Reporter: stack
>Assignee: stack
> Fix For: 1.3.2, 1.2.7
>
>
> In a branch-1.2 test run, I see a bunch of this in timed out test run:
>709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
> zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
> quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
>doing nothing here
> 710 java.lang.InterruptedException
> Which is us swallowing interrupts out of zk.
> The suppression of the interrupt is messing us up We start to see this:
> {code}
> 5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
> zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
> baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
> rs/ve0528.halxg.cloudera.com,36704,1510086438842
> 5019 java.lang.InterruptedException
> 5020 at java.lang.Object.wait(Native Method)
> 5021 at java.lang.Object.wait(Object.java:502)
> 5022 at
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
> 5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
> 5024 at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> 5025 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
> 5026 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 5027 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5028 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5029 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5030 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5031 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5032 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5033 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5034 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5035 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5036 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5037 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> ...
> {code}
> Later I'm getting
> {code}
> 15578737 Caused by: java.lang.StackOverflowError
> 15578738 at java.security.AccessController.doPrivileged(Native Method)
> 15578739 at java.io.PrintWriter.(PrintWriter.java:116)
> 15578740 at java.io.PrintWriter.(PrintWriter.java:100)
> 15578741 at
> org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
> 15578742 at
> org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
> 15578743 at
> org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
> 15578744 at
> org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
> 15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> 15578746 at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> 15578747 at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> 15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
> 15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
> 15578750 at org.apache.log4j.Category.log(Category.java:856)
> 15578751 at
> org.apache.commons.logging.impl.Log4JLogger.warn(Log4JLogger.java:208)
> 15578752 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:378)
> 15578753 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 15578754 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 15578755 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 15578756 at
>
[jira] [Commented] (HBASE-18441) ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243397#comment-16243397
]
Hudson commented on HBASE-18441:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #339 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/339/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev 557194830654842379b1ce82942ff74ea3615bb5)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
> ZookeeperWatcher#interruptedException should throw exception
>
>
> Key: HBASE-18441
> URL: https://issues.apache.org/jira/browse/HBASE-18441
> Project: HBase
> Issue Type: Bug
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18441.patch, HBASE-18441.trivial.patch
>
>
> Currently Zookeeper#interruptedException will swallow the
> InterruptedException and only log, which might cause unexpected behavior,
> such as when invoking {{ZKUtil#checkExists}} and the watcher thread somehow
> interrupted, the method will return -1 which means the checked znode doesn't
> exist, while actually the znode exists.
> We could also see a TODO tag in the javadoc, which indicates we need some
> fix/improvement here:
> {code}
> /**
>* Handles InterruptedExceptions in client calls.
>*
>* This may be temporary but for now this gives one place to deal with
> these.
>*
>* TODO: Currently, this method does nothing.
>* Is this ever expected to happen? Do we abort or can we let it run?
>* Maybe this should be logged as WARN? It shouldn't happen?
>*
>* @param ie
>*/
> {code}
> Here we propose to throw a {{KeeperException$SystemErrorException}} in
> {{ZookeeperWatcher#interruptedException}}, and will add a UT case to cover
> the interruption scenario.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19203) Update Hadoop version used for build to 2.7.4
[
https://issues.apache.org/jira/browse/HBASE-19203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243415#comment-16243415
]
Hadoop QA commented on HBASE-19203:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
6s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
27s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
28s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
3s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
51s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m
50s{color} | {color:red} patch has 12 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
55s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
45s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}459m 34s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}518m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:4bf71c3 |
| JIRA Issue | HBASE-19203 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896492/HBASE-19203-branch-1.patch
|
| Optional Tests | asflicense shellcheck shelldocs javac javadoc unit
shadedjars hadoopcheck xml compile |
| uname | Linux cd5887c96a30 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build
[jira] [Commented] (HBASE-19088) move_tables_rsgroup will throw an exception when the table is disabled
[
https://issues.apache.org/jira/browse/HBASE-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243430#comment-16243430
]
Hudson commented on HBASE-19088:
SUCCESS: Integrated in Jenkins build HBase-1.4 #1003 (See
[https://builds.apache.org/job/HBase-1.4/1003/])
HBASE-19088 move_tables_rsgroup will throw an exception when the table
(apurtell: rev 7c8d76994a29add97c77b240c9b61dbb568f2828)
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
> move_tables_rsgroup will throw an exception when the table is disabled
> --
>
> Key: HBASE-19088
> URL: https://issues.apache.org/jira/browse/HBASE-19088
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-19088.branch-1.001.patch,
> HBASE-19088.branch-1.001.patch, HBASE-19088.branch-1.002.patch,
> HBASE-19088.master.001.patch, HBASE-19088.master.002.patch,
> HBASE-19088.master.003.patch
>
>
> When the table is disabled, *move_tables_rsgroup* will throw an exception,
> but the table has been moved to the new group successfully.
> {code:java}
> hbase(main):009:0> move_tables_rsgroup 'default',['t1']
> ERROR: java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos$MoveRegionStateData$Builder.setSourceServer(MasterProcedureProtos.java:26022)
> at
> org.apache.hadoop.hbase.master.assignment.MoveRegionProcedure.serializeStateData(MoveRegionProcedure.java:133)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProtoProcedure(ProcedureUtil.java:198)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeEntry(ProcedureWALFormat.java:211)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeInsert(ProcedureWALFormat.java:222)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.insert(WALProcedureStore.java:470)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:866)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:835)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitAndWaitProcedure(ProcedureSyncWait.java:120)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.move(AssignmentManager.java:557)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:413)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.moveTables(RSGroupAdminEndpoint.java:190)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:12786)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:786)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> ... 3 more
> Reassign tables from one RegionServer group to another.
> Example:
> hbase> move_tables_rsgroup 'dest',['table1','table2']
> Took 0.0297 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18441) ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243404#comment-16243404
]
Hudson commented on HBASE-18441:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #277 (See
[https://builds.apache.org/job/HBase-1.3-IT/277/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev 557194830654842379b1ce82942ff74ea3615bb5)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
> ZookeeperWatcher#interruptedException should throw exception
>
>
> Key: HBASE-18441
> URL: https://issues.apache.org/jira/browse/HBASE-18441
> Project: HBase
> Issue Type: Bug
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18441.patch, HBASE-18441.trivial.patch
>
>
> Currently Zookeeper#interruptedException will swallow the
> InterruptedException and only log, which might cause unexpected behavior,
> such as when invoking {{ZKUtil#checkExists}} and the watcher thread somehow
> interrupted, the method will return -1 which means the checked znode doesn't
> exist, while actually the znode exists.
> We could also see a TODO tag in the javadoc, which indicates we need some
> fix/improvement here:
> {code}
> /**
>* Handles InterruptedExceptions in client calls.
>*
>* This may be temporary but for now this gives one place to deal with
> these.
>*
>* TODO: Currently, this method does nothing.
>* Is this ever expected to happen? Do we abort or can we let it run?
>* Maybe this should be logged as WARN? It shouldn't happen?
>*
>* @param ie
>*/
> {code}
> Here we propose to throw a {{KeeperException$SystemErrorException}} in
> {{ZookeeperWatcher#interruptedException}}, and will add a UT case to cover
> the interruption scenario.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-12091) Optionally ignore edits for dropped tables for replication.
[ https://issues.apache.org/jira/browse/HBASE-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated HBASE-12091: -- Attachment: 12091-v7-master.txt Same for master. Passes all the new tests. > Optionally ignore edits for dropped tables for replication. > --- > > Key: HBASE-12091 > URL: https://issues.apache.org/jira/browse/HBASE-12091 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Fix For: 2.0.0, 3.0.0, 1.4.1, 1.5.0 > > Attachments: 12091-branch-2.patch, 12091-v2-branch-1.txt, > 12091-v3-branch-1.txt, 12091-v4-branch-1.txt, 12091-v5-branch-1.txt, > 12091-v6-branch-1.txt, 12091-v7-branch-1.txt, 12091-v7-master.txt, 12091.txt > > > We just ran into a scenario where we dropped a table from both the source and > the sink, but the source still has outstanding edits that now it could not > get rid of. Now all replication is backed up behind these unreplicatable > edits. > We should have an option to ignore edits for tables dropped at the source. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19203) Update Hadoop version used for build to 2.7.4
[ https://issues.apache.org/jira/browse/HBASE-19203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243244#comment-16243244 ] Hudson commented on HBASE-19203: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4016 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4016/]) HBASE-19203 Update Hadoop version used for build to 2.7.4 (from 2.5.1) (apurtell: rev 46408e021d73abb648914a0465318516cf8eef21) * (edit) pom.xml * (edit) dev-support/hbase-personality.sh > Update Hadoop version used for build to 2.7.4 > - > > Key: HBASE-19203 > URL: https://issues.apache.org/jira/browse/HBASE-19203 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0 > > Attachments: HBASE-19203-branch-1.patch, HBASE-19203-branch-1.patch, > HBASE-19203.patch > > > See parent. > 2.5 is really old. > Based on discussions I've seen on the Hadoop *-dev@ lists, Hadoop is thinking > about maintaining 2.8 and up, not 2.7. Using 2.7 for convenience binary > builds is fine. We should probably update it to 2.8.2, but that's not > strictly necessary so I'll opt for the oldest. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.
[ https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18993: Issue Type: Improvement (was: Bug) > Backport patches in HBASE-18410 to branch-1.x branches. > --- > > Key: HBASE-18993 > URL: https://issues.apache.org/jira/browse/HBASE-18993 > Project: HBase > Issue Type: Improvement > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18993-branch-1.1.v1.patch, > HBASE-18993-branch-1.1.v2.patch, HBASE-18993-branch-1.2.v1.patch, > HBASE-18993-branch-1.2.v2.patch, HBASE-18993-branch-1.3.v1.patch, > HBASE-18993-branch-1.3.v2.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19207) Create Minimal HBase REST Client
[ https://issues.apache.org/jira/browse/HBASE-19207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243232#comment-16243232 ] Sean Busbey commented on HBASE-19207: - bq. The requirement to use Apache Commons Logging should also be removed in place of SLF4J to allow the client to choose logging implementation. This would require the client to be in a different repo. The logging for the main repo is Commons Logging (see HBASE-2608, HBASE-11334, and some discussion on dev@hbase https://s.apache.org/JCCr ). Recent Log4j 2.x conversations might have changed the community view though, if you'd like to start a DISCUSS thread on dev@hbase. > Create Minimal HBase REST Client > > > Key: HBASE-19207 > URL: https://issues.apache.org/jira/browse/HBASE-19207 > Project: HBase > Issue Type: New Feature > Components: Client, REST >Reporter: Rick Kellogg > > Create a minimal REST client with only contents of > org.apache.hadoop.hbase.rest.client and > org.apache.hadoop.hbase.rest.client.models packages in the hbase-rest > project. > Attempt to reduce the number of third party dependencies and allow user to > bring their own Apache HttpClient/Core. The HttpClient is frequently updated > and therefore should not be shaded to allow for upgrades. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243224#comment-16243224
]
Andrew Purtell commented on HBASE-19194:
Maven enforcer failure in precommit, not related to this patch.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.
[ https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243229#comment-16243229 ] Sean Busbey commented on HBASE-18993: - IMHO, redefining NEXT_ROW means we should save this for minor releases. > Backport patches in HBASE-18410 to branch-1.x branches. > --- > > Key: HBASE-18993 > URL: https://issues.apache.org/jira/browse/HBASE-18993 > Project: HBase > Issue Type: Improvement > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18993-branch-1.1.v1.patch, > HBASE-18993-branch-1.1.v2.patch, HBASE-18993-branch-1.2.v1.patch, > HBASE-18993-branch-1.2.v2.patch, HBASE-18993-branch-1.3.v1.patch, > HBASE-18993-branch-1.3.v2.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19203) Update Hadoop version used for build to 2.7.4
[ https://issues.apache.org/jira/browse/HBASE-19203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243248#comment-16243248 ] Hudson commented on HBASE-19203: FAILURE: Integrated in Jenkins build HBase-2.0 #816 (See [https://builds.apache.org/job/HBase-2.0/816/]) HBASE-19203 Update Hadoop version used for build to 2.7.4 (from 2.5.1) (apurtell: rev e3bd47531797801a0c97226849de9f29e37361f1) * (edit) dev-support/hbase-personality.sh * (edit) pom.xml > Update Hadoop version used for build to 2.7.4 > - > > Key: HBASE-19203 > URL: https://issues.apache.org/jira/browse/HBASE-19203 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0 > > Attachments: HBASE-19203-branch-1.patch, HBASE-19203-branch-1.patch, > HBASE-19203.patch > > > See parent. > 2.5 is really old. > Based on discussions I've seen on the Hadoop *-dev@ lists, Hadoop is thinking > about maintaining 2.8 and up, not 2.7. Using 2.7 for convenience binary > builds is fine. We should probably update it to 2.8.2, but that's not > strictly necessary so I'll opt for the oldest. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19128) Purge Distributed Log Replay from codebase, configurations, text; mark the feature as unsupported, broken.
[ https://issues.apache.org/jira/browse/HBASE-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243413#comment-16243413 ] Hudson commented on HBASE-19128: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4017 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4017/]) HBASE-19128 Purge Distributed Log Replay from codebase, configurations, (appy: rev 4132314f51951af43f4f56d9886233b3ba417903) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZNodePaths.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitWalDataLoss.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperWatcher.java * (delete) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsEditsReplaySourceImpl.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-protocol/src/main/protobuf/ZooKeeper.proto * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * (edit) src/main/asciidoc/_chapters/architecture.adoc * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoveringRegionWatcher.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/FinishRegionRecoveringHandler.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpointNoMaster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordination.java * (edit) hbase-protocol-shaded/src/main/protobuf/Admin.proto * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-protocol/src/main/protobuf/Admin.proto * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/WALSplitterHandler.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWALEditsReplay.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java * (delete) hbase-hadoop2-compat/src/main/resources/META-INF/services/org.apache.hadoop.hbase.regionserver.wal.MetricsEditsReplaySource * (edit) hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/SplitLogTask.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java * (edit) hbase-common/src/main/resources/hbase-default.xml * (edit) src/main/asciidoc/_chapters/hbase-default.adoc * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/SplitLogManagerCoordination.java * (edit)
[jira] [Commented] (HBASE-19088) move_tables_rsgroup will throw an exception when the table is disabled
[
https://issues.apache.org/jira/browse/HBASE-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243412#comment-16243412
]
Hudson commented on HBASE-19088:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4017 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4017/])
HBASE-19088 move_tables_rsgroup will throw an exception when the table
(apurtell: rev dc127df077490640a808d540fa56abbe888c9730)
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
> move_tables_rsgroup will throw an exception when the table is disabled
> --
>
> Key: HBASE-19088
> URL: https://issues.apache.org/jira/browse/HBASE-19088
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-19088.branch-1.001.patch,
> HBASE-19088.branch-1.001.patch, HBASE-19088.branch-1.002.patch,
> HBASE-19088.master.001.patch, HBASE-19088.master.002.patch,
> HBASE-19088.master.003.patch
>
>
> When the table is disabled, *move_tables_rsgroup* will throw an exception,
> but the table has been moved to the new group successfully.
> {code:java}
> hbase(main):009:0> move_tables_rsgroup 'default',['t1']
> ERROR: java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos$MoveRegionStateData$Builder.setSourceServer(MasterProcedureProtos.java:26022)
> at
> org.apache.hadoop.hbase.master.assignment.MoveRegionProcedure.serializeStateData(MoveRegionProcedure.java:133)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProtoProcedure(ProcedureUtil.java:198)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeEntry(ProcedureWALFormat.java:211)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeInsert(ProcedureWALFormat.java:222)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.insert(WALProcedureStore.java:470)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:866)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:835)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitAndWaitProcedure(ProcedureSyncWait.java:120)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.move(AssignmentManager.java:557)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:413)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.moveTables(RSGroupAdminEndpoint.java:190)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:12786)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:786)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> ... 3 more
> Reassign tables from one RegionServer group to another.
> Example:
> hbase> move_tables_rsgroup 'dest',['table1','table2']
> Took 0.0297 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19009) implement enable/disableTableReplication for AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19009: --- Attachment: HBASE-19009.master.007.patch > implement enable/disableTableReplication for AsyncAdmin > --- > > Key: HBASE-19009 > URL: https://issues.apache.org/jira/browse/HBASE-19009 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19009.master.001.patch, > HBASE-19009.master.002.patch, HBASE-19009.master.003.patch, > HBASE-19009.master.004.patch, HBASE-19009.master.005.patch, > HBASE-19009.master.006.patch, HBASE-19009.master.007.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18441) ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243395#comment-16243395
]
Hudson commented on HBASE-18441:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #271 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/271/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev eb8560cab55018236f502f25a77c69610f3c56da)
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
> ZookeeperWatcher#interruptedException should throw exception
>
>
> Key: HBASE-18441
> URL: https://issues.apache.org/jira/browse/HBASE-18441
> Project: HBase
> Issue Type: Bug
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18441.patch, HBASE-18441.trivial.patch
>
>
> Currently Zookeeper#interruptedException will swallow the
> InterruptedException and only log, which might cause unexpected behavior,
> such as when invoking {{ZKUtil#checkExists}} and the watcher thread somehow
> interrupted, the method will return -1 which means the checked znode doesn't
> exist, while actually the znode exists.
> We could also see a TODO tag in the javadoc, which indicates we need some
> fix/improvement here:
> {code}
> /**
>* Handles InterruptedExceptions in client calls.
>*
>* This may be temporary but for now this gives one place to deal with
> these.
>*
>* TODO: Currently, this method does nothing.
>* Is this ever expected to happen? Do we abort or can we let it run?
>* Maybe this should be logged as WARN? It shouldn't happen?
>*
>* @param ie
>*/
> {code}
> Here we propose to throw a {{KeeperException$SystemErrorException}} in
> {{ZookeeperWatcher#interruptedException}}, and will add a UT case to cover
> the interruption scenario.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19205) Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243405#comment-16243405
]
Hudson commented on HBASE-19205:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1010 (See
[https://builds.apache.org/job/HBase-1.2-IT/1010/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev eb8560cab55018236f502f25a77c69610f3c56da)
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
> Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw
> exception
> -
>
> Key: HBASE-19205
> URL: https://issues.apache.org/jira/browse/HBASE-19205
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Reporter: stack
>Assignee: stack
> Fix For: 1.3.2, 1.2.7
>
>
> In a branch-1.2 test run, I see a bunch of this in timed out test run:
>709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
> zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
> quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
>doing nothing here
> 710 java.lang.InterruptedException
> Which is us swallowing interrupts out of zk.
> The suppression of the interrupt is messing us up We start to see this:
> {code}
> 5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
> zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
> baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
> rs/ve0528.halxg.cloudera.com,36704,1510086438842
> 5019 java.lang.InterruptedException
> 5020 at java.lang.Object.wait(Native Method)
> 5021 at java.lang.Object.wait(Object.java:502)
> 5022 at
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
> 5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
> 5024 at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> 5025 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
> 5026 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 5027 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5028 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5029 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5030 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5031 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5032 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5033 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5034 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5035 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5036 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5037 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> ...
> {code}
> Later I'm getting
> {code}
> 15578737 Caused by: java.lang.StackOverflowError
> 15578738 at java.security.AccessController.doPrivileged(Native Method)
> 15578739 at java.io.PrintWriter.(PrintWriter.java:116)
> 15578740 at java.io.PrintWriter.(PrintWriter.java:100)
> 15578741 at
> org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
> 15578742 at
> org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
> 15578743 at
> org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
> 15578744 at
> org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
> 15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> 15578746 at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> 15578747 at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> 15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
> 15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
> 15578750 at org.apache.log4j.Category.log(Category.java:856)
> 15578751 at
>
[jira] [Commented] (HBASE-18441) ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243406#comment-16243406
]
Hudson commented on HBASE-18441:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1010 (See
[https://builds.apache.org/job/HBase-1.2-IT/1010/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev eb8560cab55018236f502f25a77c69610f3c56da)
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
> ZookeeperWatcher#interruptedException should throw exception
>
>
> Key: HBASE-18441
> URL: https://issues.apache.org/jira/browse/HBASE-18441
> Project: HBase
> Issue Type: Bug
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18441.patch, HBASE-18441.trivial.patch
>
>
> Currently Zookeeper#interruptedException will swallow the
> InterruptedException and only log, which might cause unexpected behavior,
> such as when invoking {{ZKUtil#checkExists}} and the watcher thread somehow
> interrupted, the method will return -1 which means the checked znode doesn't
> exist, while actually the znode exists.
> We could also see a TODO tag in the javadoc, which indicates we need some
> fix/improvement here:
> {code}
> /**
>* Handles InterruptedExceptions in client calls.
>*
>* This may be temporary but for now this gives one place to deal with
> these.
>*
>* TODO: Currently, this method does nothing.
>* Is this ever expected to happen? Do we abort or can we let it run?
>* Maybe this should be logged as WARN? It shouldn't happen?
>*
>* @param ie
>*/
> {code}
> Here we propose to throw a {{KeeperException$SystemErrorException}} in
> {{ZookeeperWatcher#interruptedException}}, and will add a UT case to cover
> the interruption scenario.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19205) Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243403#comment-16243403
]
Hudson commented on HBASE-19205:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #277 (See
[https://builds.apache.org/job/HBase-1.3-IT/277/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev 557194830654842379b1ce82942ff74ea3615bb5)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
> Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw
> exception
> -
>
> Key: HBASE-19205
> URL: https://issues.apache.org/jira/browse/HBASE-19205
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Reporter: stack
>Assignee: stack
> Fix For: 1.3.2, 1.2.7
>
>
> In a branch-1.2 test run, I see a bunch of this in timed out test run:
>709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
> zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
> quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
>doing nothing here
> 710 java.lang.InterruptedException
> Which is us swallowing interrupts out of zk.
> The suppression of the interrupt is messing us up We start to see this:
> {code}
> 5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
> zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
> baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
> rs/ve0528.halxg.cloudera.com,36704,1510086438842
> 5019 java.lang.InterruptedException
> 5020 at java.lang.Object.wait(Native Method)
> 5021 at java.lang.Object.wait(Object.java:502)
> 5022 at
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
> 5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
> 5024 at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> 5025 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
> 5026 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 5027 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5028 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5029 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5030 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5031 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5032 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5033 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5034 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5035 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5036 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5037 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> ...
> {code}
> Later I'm getting
> {code}
> 15578737 Caused by: java.lang.StackOverflowError
> 15578738 at java.security.AccessController.doPrivileged(Native Method)
> 15578739 at java.io.PrintWriter.(PrintWriter.java:116)
> 15578740 at java.io.PrintWriter.(PrintWriter.java:100)
> 15578741 at
> org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
> 15578742 at
> org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
> 15578743 at
> org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
> 15578744 at
> org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
> 15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> 15578746 at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> 15578747 at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> 15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
> 15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
> 15578750 at org.apache.log4j.Category.log(Category.java:856)
> 15578751 at
>
[jira] [Commented] (HBASE-19205) Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243398#comment-16243398
]
Hudson commented on HBASE-19205:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #358 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/358/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev 557194830654842379b1ce82942ff74ea3615bb5)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
> Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw
> exception
> -
>
> Key: HBASE-19205
> URL: https://issues.apache.org/jira/browse/HBASE-19205
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Reporter: stack
>Assignee: stack
> Fix For: 1.3.2, 1.2.7
>
>
> In a branch-1.2 test run, I see a bunch of this in timed out test run:
>709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
> zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
> quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
>doing nothing here
> 710 java.lang.InterruptedException
> Which is us swallowing interrupts out of zk.
> The suppression of the interrupt is messing us up We start to see this:
> {code}
> 5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
> zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
> baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
> rs/ve0528.halxg.cloudera.com,36704,1510086438842
> 5019 java.lang.InterruptedException
> 5020 at java.lang.Object.wait(Native Method)
> 5021 at java.lang.Object.wait(Object.java:502)
> 5022 at
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
> 5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
> 5024 at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> 5025 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
> 5026 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 5027 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5028 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5029 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5030 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5031 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5032 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5033 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5034 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5035 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5036 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5037 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> ...
> {code}
> Later I'm getting
> {code}
> 15578737 Caused by: java.lang.StackOverflowError
> 15578738 at java.security.AccessController.doPrivileged(Native Method)
> 15578739 at java.io.PrintWriter.(PrintWriter.java:116)
> 15578740 at java.io.PrintWriter.(PrintWriter.java:100)
> 15578741 at
> org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
> 15578742 at
> org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
> 15578743 at
> org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
> 15578744 at
> org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
> 15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> 15578746 at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> 15578747 at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> 15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
> 15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
> 15578750 at org.apache.log4j.Category.log(Category.java:856)
> 15578751 at
>
[jira] [Commented] (HBASE-18441) ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243399#comment-16243399
]
Hudson commented on HBASE-18441:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #358 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/358/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev 557194830654842379b1ce82942ff74ea3615bb5)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
> ZookeeperWatcher#interruptedException should throw exception
>
>
> Key: HBASE-18441
> URL: https://issues.apache.org/jira/browse/HBASE-18441
> Project: HBase
> Issue Type: Bug
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18441.patch, HBASE-18441.trivial.patch
>
>
> Currently Zookeeper#interruptedException will swallow the
> InterruptedException and only log, which might cause unexpected behavior,
> such as when invoking {{ZKUtil#checkExists}} and the watcher thread somehow
> interrupted, the method will return -1 which means the checked znode doesn't
> exist, while actually the znode exists.
> We could also see a TODO tag in the javadoc, which indicates we need some
> fix/improvement here:
> {code}
> /**
>* Handles InterruptedExceptions in client calls.
>*
>* This may be temporary but for now this gives one place to deal with
> these.
>*
>* TODO: Currently, this method does nothing.
>* Is this ever expected to happen? Do we abort or can we let it run?
>* Maybe this should be logged as WARN? It shouldn't happen?
>*
>* @param ie
>*/
> {code}
> Here we propose to throw a {{KeeperException$SystemErrorException}} in
> {{ZookeeperWatcher#interruptedException}}, and will add a UT case to cover
> the interruption scenario.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19205) Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243394#comment-16243394
]
Hudson commented on HBASE-19205:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #271 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/271/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev eb8560cab55018236f502f25a77c69610f3c56da)
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
> Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw
> exception
> -
>
> Key: HBASE-19205
> URL: https://issues.apache.org/jira/browse/HBASE-19205
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Reporter: stack
>Assignee: stack
> Fix For: 1.3.2, 1.2.7
>
>
> In a branch-1.2 test run, I see a bunch of this in timed out test run:
>709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
> zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
> quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
>doing nothing here
> 710 java.lang.InterruptedException
> Which is us swallowing interrupts out of zk.
> The suppression of the interrupt is messing us up We start to see this:
> {code}
> 5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
> zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
> baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
> rs/ve0528.halxg.cloudera.com,36704,1510086438842
> 5019 java.lang.InterruptedException
> 5020 at java.lang.Object.wait(Native Method)
> 5021 at java.lang.Object.wait(Object.java:502)
> 5022 at
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
> 5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
> 5024 at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> 5025 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
> 5026 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 5027 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5028 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5029 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5030 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5031 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5032 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5033 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5034 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5035 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5036 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5037 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> ...
> {code}
> Later I'm getting
> {code}
> 15578737 Caused by: java.lang.StackOverflowError
> 15578738 at java.security.AccessController.doPrivileged(Native Method)
> 15578739 at java.io.PrintWriter.(PrintWriter.java:116)
> 15578740 at java.io.PrintWriter.(PrintWriter.java:100)
> 15578741 at
> org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
> 15578742 at
> org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
> 15578743 at
> org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
> 15578744 at
> org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
> 15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> 15578746 at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> 15578747 at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> 15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
> 15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
> 15578750 at org.apache.log4j.Category.log(Category.java:856)
> 15578751 at
>
[jira] [Commented] (HBASE-18441) ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243393#comment-16243393
]
Hudson commented on HBASE-18441:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #268 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/268/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev eb8560cab55018236f502f25a77c69610f3c56da)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
> ZookeeperWatcher#interruptedException should throw exception
>
>
> Key: HBASE-18441
> URL: https://issues.apache.org/jira/browse/HBASE-18441
> Project: HBase
> Issue Type: Bug
>Reporter: Yu Li
>Assignee: Yu Li
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18441.patch, HBASE-18441.trivial.patch
>
>
> Currently Zookeeper#interruptedException will swallow the
> InterruptedException and only log, which might cause unexpected behavior,
> such as when invoking {{ZKUtil#checkExists}} and the watcher thread somehow
> interrupted, the method will return -1 which means the checked znode doesn't
> exist, while actually the znode exists.
> We could also see a TODO tag in the javadoc, which indicates we need some
> fix/improvement here:
> {code}
> /**
>* Handles InterruptedExceptions in client calls.
>*
>* This may be temporary but for now this gives one place to deal with
> these.
>*
>* TODO: Currently, this method does nothing.
>* Is this ever expected to happen? Do we abort or can we let it run?
>* Maybe this should be logged as WARN? It shouldn't happen?
>*
>* @param ie
>*/
> {code}
> Here we propose to throw a {{KeeperException$SystemErrorException}} in
> {{ZookeeperWatcher#interruptedException}}, and will add a UT case to cover
> the interruption scenario.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19205) Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw exception
[
https://issues.apache.org/jira/browse/HBASE-19205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243396#comment-16243396
]
Hudson commented on HBASE-19205:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #339 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/339/])
HBASE-19205 Backport HBASE-18441 ZookeeperWatcher#interruptedException (stack:
rev 557194830654842379b1ce82942ff74ea3615bb5)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServer.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* (edit)
hbase-client/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java
> Backport HBASE-18441 ZookeeperWatcher#interruptedException should throw
> exception
> -
>
> Key: HBASE-19205
> URL: https://issues.apache.org/jira/browse/HBASE-19205
> Project: HBase
> Issue Type: Sub-task
> Components: Zookeeper
>Reporter: stack
>Assignee: stack
> Fix For: 1.3.2, 1.2.7
>
>
> In a branch-1.2 test run, I see a bunch of this in timed out test run:
>709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
> zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
> quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
>doing nothing here
> 710 java.lang.InterruptedException
> Which is us swallowing interrupts out of zk.
> The suppression of the interrupt is messing us up We start to see this:
> {code}
> 5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
> zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
> baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
> rs/ve0528.halxg.cloudera.com,36704,1510086438842
> 5019 java.lang.InterruptedException
> 5020 at java.lang.Object.wait(Native Method)
> 5021 at java.lang.Object.wait(Object.java:502)
> 5022 at
> org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
> 5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
> 5024 at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> 5025 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
> 5026 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
> 5027 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5028 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5029 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5030 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5031 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5032 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5033 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5034 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5035 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5036 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> 5037 at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
> ...
> {code}
> Later I'm getting
> {code}
> 15578737 Caused by: java.lang.StackOverflowError
> 15578738 at java.security.AccessController.doPrivileged(Native Method)
> 15578739 at java.io.PrintWriter.(PrintWriter.java:116)
> 15578740 at java.io.PrintWriter.(PrintWriter.java:100)
> 15578741 at
> org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
> 15578742 at
> org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
> 15578743 at
> org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
> 15578744 at
> org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
> 15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> 15578746 at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> 15578747 at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> 15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
> 15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
> 15578750 at org.apache.log4j.Category.log(Category.java:856)
> 15578751 at
>
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243185#comment-16243185
]
Andrew Purtell commented on HBASE-19194:
In retrospect the need for that hunk is clear [~lhofhansl]. The new call to the
balancer ahead of assignment allows the overridden balancer for RSGroup to
correctly adjust the plan in case the region would otherwise move to an
inappropriate group.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18624) Added support for clearing BlockCache based on table name
[ https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242904#comment-16242904 ] Zach York commented on HBASE-18624: --- [~chia7712] I opened HBASE-19206 to address the follow-up. [~apurtell] Thanks for the ping on 1.4.0. This backport might be a little involved as it has spiraled into a larger change :) > Added support for clearing BlockCache based on table name > - > > Key: HBASE-18624 > URL: https://issues.apache.org/jira/browse/HBASE-18624 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0, 1.3.0 >Reporter: Ajay Jadhav >Assignee: Zach York > Fix For: 2.0.0, 3.0.0, 1.5.0 > > Attachments: HBASE-18624.branch-1.001.patch, > HBASE-18624.master.001.patch, HBASE-18624.master.002.patch, > HBASE-18624.master.003.patch, HBASE-18624.master.004.patch, > HBASE-18624.master.005.patch, HBASE-18624.master.006.patch, > HBASE-18624.master.007.patch, HBASE-18624.master.008.patch, > HBASE-18624.master.009.patch, HBASE-18624.master.010.patch, > HBASE-18624.master.011.patch, HBASE-18624.master.012.patch, > HBASE-18624.master.013.patch > > > Bulk loading the primary HBase cluster triggers a lot of compactions > resulting in archival/ creation > of multiple HFiles. This process will cause a lot of items to become stale in > replica’s BlockCache. > This patch will help users to clear the block cache for a given table by > either using shell or API. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19194:
---
Attachment: HBASE-19194-branch-1.patch
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243366#comment-16243366 ] Reid Chan commented on HBASE-18309: --- I think both can be unified, since they have same chore() methods, the differences are how to validate file and how to delete them. [~carp84] Thanks for your advice, i'm doing tests mentioned above, and then will see the online configuration change. > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: binlijin >Assignee: Reid Chan > Attachments: HBASE-18309.master.001.patch, > HBASE-18309.master.002.patch > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243191#comment-16243191
]
Andrew Purtell commented on HBASE-19194:
Without the change in HMaster, the corrected test fails in
TestRSGroups#testRegionMove. With fixed test and change in HMaster,
testRegionMove passes.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19210) TestNamespacesInstanceResource fails
Ted Yu created HBASE-19210:
--
Summary: TestNamespacesInstanceResource fails
Key: HBASE-19210
URL: https://issues.apache.org/jira/browse/HBASE-19210
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
This is the top flaky test.
The following can be reproduced:
{code}
java.net.SocketException: Connection reset
at
org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
{code}
With commit e320df5a0c267258c03909da8d0eee4c0e287532, the test passes.
With commit 5facaded902a13556952b1f9d26b768cb86e6599, the test fails.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-19164) Avoid UUID.randomUUID in tests
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sahil Aggarwal reassigned HBASE-19164:
--
Assignee: Sahil Aggarwal
> Avoid UUID.randomUUID in tests
> --
>
> Key: HBASE-19164
> URL: https://issues.apache.org/jira/browse/HBASE-19164
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
> Labels: beginner
>
> We have a lot of places in our test code where we use {{UUID.randomUUID}} to
> generate table names or paths for uniqueness. Unfortunately, this uses up a
> good chunk of system entropy, since Sun chose that random UUID's should use
> the NativePRNGBlocking implementation.
> We don't need to block on entropy for random bits to pick a random table name
> in a test, so we can use something that doesn't strain the system too much -
> secure random can be a source of problems on some VM or containers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19210) TestNamespacesInstanceResource fails
[
https://issues.apache.org/jira/browse/HBASE-19210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243287#comment-16243287
]
Ted Yu commented on HBASE-19210:
Please use -Dtest=TestNamespacesInstanceResource
Even if there is no other test running, this test still fails - in the same
place each time.
> TestNamespacesInstanceResource fails
>
>
> Key: HBASE-19210
> URL: https://issues.apache.org/jira/browse/HBASE-19210
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>
> This is the top flaky test.
> The following can be reproduced:
> {code}
> java.net.SocketException: Connection reset
> at
> org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
> {code}
> With commit e320df5a0c267258c03909da8d0eee4c0e287532, the test passes.
> With commit 5facaded902a13556952b1f9d26b768cb86e6599, the test fails.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243191#comment-16243191
]
Andrew Purtell edited comment on HBASE-19194 at 11/8/17 1:03 AM:
-
Without the change in HMaster, the corrected test fails on branch-1 /
branch-1.4 in TestRSGroups#testRegionMove. With fixed test and change in
HMaster, testRegionMove passes on branch-1 / branch-1.4. All other RSGroups
tests pass on branch-1 / branch-1.4
was (Author: apurtell):
Without the change in HMaster, the corrected test fails in
TestRSGroups#testRegionMove. With fixed test and change in HMaster,
testRegionMove passes.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243283#comment-16243283
]
Hadoop QA commented on HBASE-19194:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 5m
41s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m
16s{color} | {color:red} branch has 11 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 5m
16s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m
18s{color} | {color:red} patch has 11 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 54m
6s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
7s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 81m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19194 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896552/HBASE-19194.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 95de45c8e2c1 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 46408e021d |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9677/artifact/patchprocess/branch-mvninstall-root.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9677/artifact/patchprocess/patch-mvninstall-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9677/testReport/ |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9677/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> TestRSGroupsBase has some
[jira] [Comment Edited] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243202#comment-16243202
]
Andrew Purtell edited comment on HBASE-19194 at 11/8/17 1:02 AM:
-
RSGroups tests with changes here pass on master / branch-2:
{noformat}
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.694 s
- in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.148
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.473 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
{noformat}
was (Author: apurtell):
RSGroups with updated tests pass on master / branch-2:
{noformat}
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.694 s
- in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.148
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.473 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
{noformat}
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19199) RatioBasedCompactionPolicy#shouldPerformMajorCompaction() always return true when only one file needs to compact
[
https://issues.apache.org/jira/browse/HBASE-19199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243284#comment-16243284
]
Guangxu Cheng commented on HBASE-19199:
---
All tests pass locally. The failed test is unrelated to this jira.Thanks
> RatioBasedCompactionPolicy#shouldPerformMajorCompaction() always return true
> when only one file needs to compact
>
>
> Key: HBASE-19199
> URL: https://issues.apache.org/jira/browse/HBASE-19199
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 1.3.1, 1.4.1, 1.5.0, 2.0.0-beta-1
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-19199.patch
>
>
> {code:title=RatioBasedCompactionPolicy.java|borderStyle=solid}
> public boolean shouldPerformMajorCompaction(Collection
> filesToCompact)
> throws IOException {
> boolean result = false;
> long mcTime = getNextMajorCompactTime(filesToCompact);
> if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
> return result;
> }
> // TODO: Use better method for determining stamp of last major
> (HBASE-2990)
> long lowTimestamp = StoreUtils.getLowestTimestamp(filesToCompact);
> long now = EnvironmentEdgeManager.currentTime();
> if (lowTimestamp > 0L && lowTimestamp < (now - mcTime)) {
> String regionInfo;
> if (this.storeConfigInfo != null && this.storeConfigInfo instanceof
> HStore) {
> regionInfo =
> ((HStore)this.storeConfigInfo).getRegionInfo().getRegionNameAsString();
> } else {
> regionInfo = this.toString();
> }
> // Major compaction time has elapsed.
> long cfTTL = HConstants.FOREVER;
> if (this.storeConfigInfo != null) {
> cfTTL = this.storeConfigInfo.getStoreFileTtl();
> }
> if (filesToCompact.size() == 1) {
> // Single file
> HStoreFile sf = filesToCompact.iterator().next();
> OptionalLong minTimestamp = sf.getMinimumTimestamp();
> long oldest = minTimestamp.isPresent() ? now -
> minTimestamp.getAsLong() : Long.MIN_VALUE;
> if (sf.isMajorCompactionResult() && (cfTTL == Long.MAX_VALUE ||
> oldest < cfTTL)) {
> float blockLocalityIndex =
> sf.getHDFSBlockDistribution().getBlockLocalityIndex(
> RSRpcServices.getHostname(comConf.conf, false));
> if (blockLocalityIndex < comConf.getMinLocalityToForceCompact()) {
> LOG.debug("Major compaction triggered on only store " + regionInfo
> + "; to make hdfs blocks local, current blockLocalityIndex is "
> + blockLocalityIndex + " (min " +
> comConf.getMinLocalityToForceCompact() + ")");
> result = true;
> } else {
> LOG.debug("Skipping major compaction of " + regionInfo
> + " because one (major) compacted file only, oldestTime " +
> oldest
> + "ms is < TTL=" + cfTTL + " and blockLocalityIndex is " +
> blockLocalityIndex
> + " (min " + comConf.getMinLocalityToForceCompact() + ")");
> }
> } else if (cfTTL != HConstants.FOREVER && oldest > cfTTL) {
> LOG.debug("Major compaction triggered on store " + regionInfo
> + ", because keyvalues outdated; time since last major compaction
> "
> + (now - lowTimestamp) + "ms");
> result = true;
> }
> } else {
> LOG.debug("Major compaction triggered on store " + regionInfo
> + "; time since last major compaction " + (now - lowTimestamp) +
> "ms");
> }
> result = true;
> }
> return result;
> }
> {code}
> {code}
>} else {
> LOG.debug("Major compaction triggered on store " + regionInfo
> + "; time since last major compaction " + (now - lowTimestamp) +
> "ms");
> }
> result = true;
> {code}
> if (lowTimestamp > 0L && lowTimestamp < (now - mcTime)), the result always
> equal true.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243336#comment-16243336 ] stack commented on HBASE-19204: --- [~Apache9] Let me get you samples. Async tests fail in test setup trying to connect to zk to find cluster id. Tests fail with 'clusterid is null'. If I up the retries, this class of problems goes away. Let me get you samples. Will open new issue w/ proposed change. > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19210) TestNamespacesInstanceResource fails
[
https://issues.apache.org/jira/browse/HBASE-19210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243319#comment-16243319
]
Mike Drob commented on HBASE-19210:
---
Yes, I see that now, thanks for the pointer.
Interesting discovery here - if I {{@Ignore
testNamespaceCreateAndDeleteXMLAndJSON}} (a _different_ test}} then suddenly
{{testInvalidNamespacePostsAndPuts}} starts passing for me.
> TestNamespacesInstanceResource fails
>
>
> Key: HBASE-19210
> URL: https://issues.apache.org/jira/browse/HBASE-19210
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>
> This is the top flaky test.
> The following can be reproduced:
> {code}
> java.net.SocketException: Connection reset
> at
> org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
> {code}
> With commit e320df5a0c267258c03909da8d0eee4c0e287532, the test passes.
> With commit 5facaded902a13556952b1f9d26b768cb86e6599, the test fails.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243332#comment-16243332 ] Reid Chan edited comment on HBASE-18309 at 11/8/17 3:32 AM: bq. for a reasonable test please use a larger scale and include your reasoning, 10 doesn't seem like enough to simulate what will happen in a deployment. e.g. X regions per server, Y servers means Z directories to clean up. No need to use a real large scale, it can be simulated by creating 1000 sub dirs under root dir, and each sub dirs contains up to 1000 files and sub dirs. WDYT? I will provide statistics later. bq. At what point will tuning this parameter cause a NameNode to fall over? How do we stop folks from doing that accidentally? I'm not sure, and that's why parameter upper limit is machine's available cores. But observation from my production cluster(1000+ nodes) NameNode(24 cores) running for months and dealing with hundreds of jobs with deletion and creation every day shows that it is not easy for cleaner chore to get that achievement, XD. And i would suggest to set it less than or equals to NameNodes's core number for safety concern. bq. These details should probably be in the documentation about the config. Get it, i will also write it in hbase-default.xml with description if required. was (Author: reidchan): bq. for a reasonable test please use a larger scale and include your reasoning, 10 doesn't seem like enough to simulate what will happen in a deployment. e.g. X regions per server, Y servers means Z directories to clean up. No need to use a real large scale, it can be simulated by creating 1000 sub dirs under root dir, and each sub dirs contains up to 1000 files and sub dirs. WDYT? I will provide statistics later. bq. At what point will tuning this parameter cause a NameNode to fall over? How do we stop folks from doing that accidentally? I'm not sure, and that's why parameter upper limit is machine's available cores. But observation from my production cluster(1000+ nodes) NameNode(24 cores) running for months and dealing with hundreds of jobs with deletion and creation every day shows that it is not easy for cleaner chore to get that achievement, XD. And i would suggest to set it less than or equals to NameNodes's core number for safety concern. bq. These details should probably be in the documentation about the config. Get it, i will also write it in hbase-default.xml with description. > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: binlijin >Assignee: Reid Chan > Attachments: HBASE-18309.master.001.patch, > HBASE-18309.master.002.patch > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18309) Support multi threads in CleanerChore
[ https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243332#comment-16243332 ] Reid Chan edited comment on HBASE-18309 at 11/8/17 3:15 AM: bq. for a reasonable test please use a larger scale and include your reasoning, 10 doesn't seem like enough to simulate what will happen in a deployment. e.g. X regions per server, Y servers means Z directories to clean up. No need to use a real large scale, it can be simulated by creating 1000 sub dirs under root dir, and each sub dirs contains up to 1000 files and sub dirs. WDYT? I will provide statistics later. bq. At what point will tuning this parameter cause a NameNode to fall over? How do we stop folks from doing that accidentally? I'm not sure, and that's why parameter upper limit is machine's available cores. But observation from my production cluster(1000+ nodes) NameNode(24 cores) running for months and dealing with hundreds of jobs with deletion and creation every day shows that it is not easy for cleaner chore to get that achievement, XD. And i would suggest to set it less than or equals to NameNodes's core number for safety concern. bq. These details should probably be in the documentation about the config. Get it, i will also write it in hbase-default.xml with description. was (Author: reidchan): bq. for a reasonable test please use a larger scale and include your reasoning, 10 doesn't seem like enough to simulate what will happen in a deployment. e.g. X regions per server, Y servers means Z directories to clean up. No need to use a real large scale, it can be simulated by creating 1000 sub dirs under root dir, and each sub dirs contains up to 1000 files and sub dirs. WDYT? I will provide statistics later. bq. At what point will tuning this parameter cause a NameNode to fall over? How do we stop folks from doing that accidentally? I'm not sure, and that's why parameter upper limit is machine's available cores. But observation from my production cluster(1000+ nodes) NameNode(24 cores) running for months and dealing with hundreds of jobs with deletion and creation every day shows that it is not easy for cleaner chore to get that achievement, XD. And i would suggest to set it less than or equals to NameNodes's core number for safety concern. bq. These details should probably be in the documentation about the config. Get it, i will write it in hbase-default.xml with description. > Support multi threads in CleanerChore > - > > Key: HBASE-18309 > URL: https://issues.apache.org/jira/browse/HBASE-18309 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: binlijin >Assignee: Reid Chan > Attachments: HBASE-18309.master.001.patch, > HBASE-18309.master.002.patch > > > There is only one thread in LogCleaner to clean oldWALs and in our big > cluster we find this is not enough. The number of files under oldWALs reach > the max-directory-items limit of HDFS and cause region server crash, so we > use multi threads for LogCleaner and the crash not happened any more. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19200) Let ZooKeeperRegistry depend on ZKAsyncRegistry to get data from zookeeper
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19200: -- Attachment: HBASE-19200-v1.patch Remove the unused imports. Introduce a dumb change in hbase-server to triigger the pre commit to run UTs in hbase-server. > Let ZooKeeperRegistry depend on ZKAsyncRegistry to get data from zookeeper > -- > > Key: HBASE-19200 > URL: https://issues.apache.org/jira/browse/HBASE-19200 > Project: HBase > Issue Type: Bug > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19200-v1.patch, HBASE-19200.patch > > > So that we can move most of the zookeeper related code out of hbase-client > module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243303#comment-16243303
]
Ted Yu commented on HBASE-19194:
+1
Looked at
https://builds.apache.org/job/PreCommit-HBASE-Build/9677/artifact/patchprocess/branch-mvninstall-root.txt
but didn't see which enforcer rule was broken.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.
[ https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243328#comment-16243328 ] Hudson commented on HBASE-18993: SUCCESS: Integrated in Jenkins build HBase-1.4 #1002 (See [https://builds.apache.org/job/HBase-1.4/1002/]) HBASE-18993 Backport patches in HBASE-18410 to branch-1.x branches (apurtell: rev 0a6e93801440f7662817a87fa2c7d8928de40449) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterListOnMini.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java > Backport patches in HBASE-18410 to branch-1.x branches. > --- > > Key: HBASE-18993 > URL: https://issues.apache.org/jira/browse/HBASE-18993 > Project: HBase > Issue Type: Improvement > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18993-branch-1.1.v1.patch, > HBASE-18993-branch-1.1.v2.patch, HBASE-18993-branch-1.2.v1.patch, > HBASE-18993-branch-1.2.v2.patch, HBASE-18993-branch-1.3.v1.patch, > HBASE-18993-branch-1.3.v2.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19203) Update Hadoop version used for build to 2.7.4
[ https://issues.apache.org/jira/browse/HBASE-19203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243327#comment-16243327 ] Hudson commented on HBASE-19203: SUCCESS: Integrated in Jenkins build HBase-1.4 #1002 (See [https://builds.apache.org/job/HBase-1.4/1002/]) HBASE-19203 Update Hadoop version used for build to 2.7.4 (from 2.5.1) (apurtell: rev 7953daa52c8e98803d4f0b73096c381e3de315f2) * (edit) pom.xml * (edit) dev-support/hbase-personality.sh > Update Hadoop version used for build to 2.7.4 > - > > Key: HBASE-19203 > URL: https://issues.apache.org/jira/browse/HBASE-19203 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0 > > Attachments: HBASE-19203-branch-1.patch, HBASE-19203-branch-1.patch, > HBASE-19203.patch > > > See parent. > 2.5 is really old. > Based on discussions I've seen on the Hadoop *-dev@ lists, Hadoop is thinking > about maintaining 2.8 and up, not 2.7. Using 2.7 for convenience binary > builds is fine. We should probably update it to 2.8.2, but that's not > strictly necessary so I'll opt for the oldest. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18410) FilterList Improvement.
[ https://issues.apache.org/jira/browse/HBASE-18410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243329#comment-16243329 ] Hudson commented on HBASE-18410: SUCCESS: Integrated in Jenkins build HBase-1.4 #1002 (See [https://builds.apache.org/job/HBase-1.4/1002/]) HBASE-18993 Backport patches in HBASE-18410 to branch-1.x branches (apurtell: rev 0a6e93801440f7662817a87fa2c7d8928de40449) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterListOnMini.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java > FilterList Improvement. > - > > Key: HBASE-18410 > URL: https://issues.apache.org/jira/browse/HBASE-18410 > Project: HBase > Issue Type: Umbrella > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: 2.0.0-alpha-4 > > > FilterList.java is complex now, and we have found some improvements for it. > So create an issue to address it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18410) FilterList Improvement.
[ https://issues.apache.org/jira/browse/HBASE-18410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243326#comment-16243326 ] Hudson commented on HBASE-18410: SUCCESS: Integrated in Jenkins build HBase-1.5 #143 (See [https://builds.apache.org/job/HBase-1.5/143/]) HBASE-18993 Backport patches in HBASE-18410 to branch-1.x branches (apurtell: rev 264cf0d4739ae9ad4343755d654efd73a9e623e0) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterListOnMini.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java > FilterList Improvement. > - > > Key: HBASE-18410 > URL: https://issues.apache.org/jira/browse/HBASE-18410 > Project: HBase > Issue Type: Umbrella > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: 2.0.0-alpha-4 > > > FilterList.java is complex now, and we have found some improvements for it. > So create an issue to address it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.
[ https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243325#comment-16243325 ] Hudson commented on HBASE-18993: SUCCESS: Integrated in Jenkins build HBase-1.5 #143 (See [https://builds.apache.org/job/HBase-1.5/143/]) HBASE-18993 Backport patches in HBASE-18410 to branch-1.x branches (apurtell: rev 264cf0d4739ae9ad4343755d654efd73a9e623e0) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterListOnMini.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java * (add) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java > Backport patches in HBASE-18410 to branch-1.x branches. > --- > > Key: HBASE-18993 > URL: https://issues.apache.org/jira/browse/HBASE-18993 > Project: HBase > Issue Type: Improvement > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18993-branch-1.1.v1.patch, > HBASE-18993-branch-1.1.v2.patch, HBASE-18993-branch-1.2.v1.patch, > HBASE-18993-branch-1.2.v2.patch, HBASE-18993-branch-1.3.v1.patch, > HBASE-18993-branch-1.3.v2.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19203) Update Hadoop version used for build to 2.7.4
[ https://issues.apache.org/jira/browse/HBASE-19203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243324#comment-16243324 ] Hudson commented on HBASE-19203: SUCCESS: Integrated in Jenkins build HBase-1.5 #143 (See [https://builds.apache.org/job/HBase-1.5/143/]) HBASE-19203 Update Hadoop version used for build to 2.7.4 (from 2.5.1) (apurtell: rev c5ab70d19353fc916b9edd739945875b5d081d85) * (edit) dev-support/hbase-personality.sh * (edit) pom.xml > Update Hadoop version used for build to 2.7.4 > - > > Key: HBASE-19203 > URL: https://issues.apache.org/jira/browse/HBASE-19203 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0 > > Attachments: HBASE-19203-branch-1.patch, HBASE-19203-branch-1.patch, > HBASE-19203.patch > > > See parent. > 2.5 is really old. > Based on discussions I've seen on the Hadoop *-dev@ lists, Hadoop is thinking > about maintaining 2.8 and up, not 2.7. Using 2.7 for convenience binary > builds is fine. We should probably update it to 2.8.2, but that's not > strictly necessary so I'll opt for the oldest. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243305#comment-16243305 ] Duo Zhang commented on HBASE-19204: --- So you mean that the retry limit is too low so the async client tests will be very easy to fail? I'm OK with change it to a greater value, but if the mini cluster is already up, it is strange that why we can not connect to zk? The mini cluster itself needs the zk to be up? > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18978) Align the methods in Table and AsyncTable
[ https://issues.apache.org/jira/browse/HBASE-18978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243297#comment-16243297 ] Mike Drob commented on HBASE-18978: --- Let's file JIRAs for them and then discuss in the subtasks? > Align the methods in Table and AsyncTable > - > > Key: HBASE-18978 > URL: https://issues.apache.org/jira/browse/HBASE-18978 > Project: HBase > Issue Type: Task > Components: asyncclient, Client >Reporter: Duo Zhang >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-beta-1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19127) Set State.SPLITTING, MERGING, MERGING_NEW, SPLITTING_NEW properly in RegionStatesNode
[
https://issues.apache.org/jira/browse/HBASE-19127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243220#comment-16243220
]
Hadoop QA commented on HBASE-19127:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} hbase-server: The patch generated 0 new + 206
unchanged - 9 fixed = 206 total (was 215) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
72m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
32s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}106m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}218m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19127 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896507/region_state.patch |
|
[jira] [Commented] (HBASE-17883) release 1.4.0
[ https://issues.apache.org/jira/browse/HBASE-17883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243250#comment-16243250 ] Andrew Purtell commented on HBASE-17883: HBASE-19194 blocks, otherwise good to go > release 1.4.0 > - > > Key: HBASE-17883 > URL: https://issues.apache.org/jira/browse/HBASE-17883 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.4.0 >Reporter: Sean Busbey >Assignee: Andrew Purtell >Priority: Critical > Fix For: 1.4.0 > > > Let's start working through doing the needful; it's been almost 3 months sine > 1.3.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243282#comment-16243282 ] stack commented on HBASE-19204: --- Sorry, the above is a question about branch-2 builds. Yeah, I should make an issue outside of this umbrella [~Apache9] > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[ https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243281#comment-16243281 ] Duo Zhang commented on HBASE-19204: --- We do not have async registry in 1.2 I believe? Or you are telling about another problem? > branch-1.2 times out and is taking 6-7 hours to complete > > > Key: HBASE-19204 > URL: https://issues.apache.org/jira/browse/HBASE-19204 > Project: HBase > Issue Type: Umbrella > Components: test >Reporter: stack > > Sean has been looking at tooling and infra. This Umbrellas is about looking > at actual tests. For example, running locally on dedicated machine I picked a > random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It > seems to be having zk issues but it is catching interrupts and ignoring them > ([~carp84] fixed this in later versions over in HBASE-18441). > Let me try and do some fixup under this umbrella so we can get a 1.2.7 out > the door. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243188#comment-16243188
]
Andrew Purtell commented on HBASE-19194:
Blocker for 1.4.
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19194:
---
Status: Patch Available (was: Open)
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19128) Purge Distributed Log Replay from codebase, configurations, text; mark the feature as unsupported, broken.
[ https://issues.apache.org/jira/browse/HBASE-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19128: - Resolution: Fixed Status: Resolved (was: Patch Available) > Purge Distributed Log Replay from codebase, configurations, text; mark the > feature as unsupported, broken. > -- > > Key: HBASE-19128 > URL: https://issues.apache.org/jira/browse/HBASE-19128 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: stack >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19128.master.001.patch, > HBASE-19128.master.002.patch, HBASE-19128.master.003.patch, > HBASE-19128.master.004.patch, HBASE-19128.master.005.patch, > HBASE-19128.master.006.patch > > > Kill it. It keeps coming up and over again. Needs proper burial. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19128) Purge Distributed Log Replay from codebase, configurations, text; mark the feature as unsupported, broken.
[ https://issues.apache.org/jira/browse/HBASE-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243256#comment-16243256 ] Appy commented on HBASE-19128: -- Wohoo, all tests fixed. Net checkstyle diff is about -100. Committed to master and branch-2. Thanks for reviews [~stack] and [~Apache9]. > Purge Distributed Log Replay from codebase, configurations, text; mark the > feature as unsupported, broken. > -- > > Key: HBASE-19128 > URL: https://issues.apache.org/jira/browse/HBASE-19128 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: stack >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0 > > Attachments: HBASE-19128.master.001.patch, > HBASE-19128.master.002.patch, HBASE-19128.master.003.patch, > HBASE-19128.master.004.patch, HBASE-19128.master.005.patch, > HBASE-19128.master.006.patch > > > Kill it. It keeps coming up and over again. Needs proper burial. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19200) Let ZooKeeperRegistry depend on ZKAsyncRegistry to get data from zookeeper
[ https://issues.apache.org/jira/browse/HBASE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243279#comment-16243279 ] Duo Zhang commented on HBASE-19200: --- Ping [~appy]. What do you think of this patch? After this you can start working on HBASE-19114 to move the zk related code to another module as client will not need to depend it any more. Thanks. > Let ZooKeeperRegistry depend on ZKAsyncRegistry to get data from zookeeper > -- > > Key: HBASE-19200 > URL: https://issues.apache.org/jira/browse/HBASE-19200 > Project: HBase > Issue Type: Bug > Components: Client, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19200.patch > > > So that we can move most of the zookeeper related code out of hbase-client > module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19210) TestNamespacesInstanceResource fails
[
https://issues.apache.org/jira/browse/HBASE-19210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243271#comment-16243271
]
Mike Drob commented on HBASE-19210:
---
This is passing locally on tip of master for me with command:
{{mvn clean test
-Dtest=TestNamespacesInstanceResource\#testInvalidNamespacePostsAndPuts -pl
hbase-rest -am}}
Connection reset looks like a resourcing issue? How do you reproduce this one,
[~tedyu]?
> TestNamespacesInstanceResource fails
>
>
> Key: HBASE-19210
> URL: https://issues.apache.org/jira/browse/HBASE-19210
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>
> This is the top flaky test.
> The following can be reproduced:
> {code}
> java.net.SocketException: Connection reset
> at
> org.apache.hadoop.hbase.rest.TestNamespacesInstanceResource.testInvalidNamespacePostsAndPuts(TestNamespacesInstanceResource.java:271)
> {code}
> With commit e320df5a0c267258c03909da8d0eee4c0e287532, the test passes.
> With commit 5facaded902a13556952b1f9d26b768cb86e6599, the test fails.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17591) Update documentation to say distributed log replay defaults to 'false'
[
https://issues.apache.org/jira/browse/HBASE-17591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243258#comment-16243258
]
Appy edited comment on HBASE-17591 at 11/8/17 1:56 AM:
---
I deleted this configuration when purging DLR code. Closing this one.
was (Author: appy):
I delete this configuration when purging DLR code. Closing this one.
> Update documentation to say distributed log replay defaults to 'false'
> --
>
> Key: HBASE-17591
> URL: https://issues.apache.org/jira/browse/HBASE-17591
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Aki Ariga
>Priority: Trivial
> Fix For: 2.0.0
>
>
> As consequence of HBASE-12577, `hbase.master.distributed.log.replay` is no
> longer default true. But in the documentation, it is still noted as default
> true as follows:
> {quote}
> To enable distributed log replay, set hbase.master.distributed.log.replay to
> true. This will be the default for HBase 0.99 (HBASE-10888).
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19194:
---
Attachment: HBASE-19194.patch
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19204) branch-1.2 times out and is taking 6-7 hours to complete
[
https://issues.apache.org/jira/browse/HBASE-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243267#comment-16243267
]
stack commented on HBASE-19204:
---
[~Apache9] The async client retries are three with a second in between for the
async registry. Makes it so async tests seem to fail easy enough. Doing below
for the test config seems to help:
{code}
diff --git a/hbase-server/src/test/resources/hbase-site.xml
b/hbase-server/src/test/resources/hbase-site.xml
index 64a1964..3cec604 100644
--- a/hbase-server/src/test/resources/hbase-site.xml
+++ b/hbase-server/src/test/resources/hbase-site.xml
@@ -129,6 +129,10 @@
+zookeeper.recovery.retry
+30
+
+
hbase.defaults.for.version.skip
true
{code}
I should probably up the default of '3' to 10 or more? At least up on jenkins
it can take a while to connect to zk it seems.
> branch-1.2 times out and is taking 6-7 hours to complete
>
>
> Key: HBASE-19204
> URL: https://issues.apache.org/jira/browse/HBASE-19204
> Project: HBase
> Issue Type: Umbrella
> Components: test
>Reporter: stack
>
> Sean has been looking at tooling and infra. This Umbrellas is about looking
> at actual tests. For example, running locally on dedicated machine I picked a
> random test, TestPerColumnFamilyFlush. In my test run, it wrote 16M lines. It
> seems to be having zk issues but it is catching interrupts and ignoring them
> ([~carp84] fixed this in later versions over in HBASE-18441).
> Let me try and do some fixup under this umbrella so we can get a 1.2.7 out
> the door.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243202#comment-16243202
]
Andrew Purtell edited comment on HBASE-19194 at 11/8/17 1:02 AM:
-
RSGroups with updated tests pass on master / branch-2:
{noformat}
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.694 s
- in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.148
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.473 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
{noformat}
was (Author: apurtell):
RSGroups with updates pass on master / branch-2:
{noformat}
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.694 s
- in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.148
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.473 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
{noformat}
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-19187) Remove option to create on heap bucket cache
[ https://issues.apache.org/jira/browse/HBASE-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John reassigned HBASE-19187: -- Assignee: Anoop Sam John > Remove option to create on heap bucket cache > > > Key: HBASE-19187 > URL: https://issues.apache.org/jira/browse/HBASE-19187 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Biju Nair >Assignee: Anoop Sam John >Priority: Minor > Fix For: 2.1.0 > > > Since we are moving read and write paths to use direct memory, option to > configure on heap bucket cache is irrelevant. We should remove that option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19187) Remove option to create on heap bucket cache
[ https://issues.apache.org/jira/browse/HBASE-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243270#comment-16243270 ] Anoop Sam John commented on HBASE-19187: Better we can remove in 2.0 itself. We are trying to remove some other stuff like DLR, Prefix tree. (Reasons are diff there though).. Will give patch soon. > Remove option to create on heap bucket cache > > > Key: HBASE-19187 > URL: https://issues.apache.org/jira/browse/HBASE-19187 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Biju Nair >Priority: Minor > Fix For: 2.1.0 > > > Since we are moving read and write paths to use direct memory, option to > configure on heap bucket cache is irrelevant. We should remove that option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243202#comment-16243202
]
Andrew Purtell commented on HBASE-19194:
RSGroups with updates pass on master / branch-2:
{noformat}
[INFO] Running
org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.694 s
- in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.148
s - in org.apache.hadoop.hbase.rsgroup.TestRSGroups
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.473 s
- in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode
{noformat}
> TestRSGroupsBase has some always false checks
> -
>
> Key: HBASE-19194
> URL: https://issues.apache.org/jira/browse/HBASE-19194
> Project: HBase
> Issue Type: Bug
> Components: rsgroup, test
>Reporter: Mike Drob
>Assignee: Andrew Purtell
>Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
> (default-testCompile) on project hbase-rsgroup: Compilation failure:
> Compilation failure:
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
> [CollectionIncompatibleType] Argument 'region' should not be passed to this
> method; its type RegionInfo is not compatible with its collection's type
> argument String
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
> [CollectionIncompatibleType] Argument 'targetRegion' should not be passed to
> this method; its type String is not compatible with its collection's type
> argument RegionInfo
> [ERROR] (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List.contains}} with an element of the wrong
> type so they will always return false. The first is an optimization that we
> can probably live without (or short circuit on the Master, at least) the
> second is an assertion that will never fail, rendering the test ineffective.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (HBASE-17591) Update documentation to say distributed log replay defaults to 'false'
[
https://issues.apache.org/jira/browse/HBASE-17591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy resolved HBASE-17591.
--
Resolution: Invalid
Assignee: Appy
> Update documentation to say distributed log replay defaults to 'false'
> --
>
> Key: HBASE-17591
> URL: https://issues.apache.org/jira/browse/HBASE-17591
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Aki Ariga
>Assignee: Appy
>Priority: Trivial
> Fix For: 2.0.0
>
>
> As consequence of HBASE-12577, `hbase.master.distributed.log.replay` is no
> longer default true. But in the documentation, it is still noted as default
> true as follows:
> {quote}
> To enable distributed log replay, set hbase.master.distributed.log.replay to
> true. This will be the default for HBase 0.99 (HBASE-10888).
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17591) Update documentation to say distributed log replay defaults to 'false'
[
https://issues.apache.org/jira/browse/HBASE-17591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243258#comment-16243258
]
Appy edited comment on HBASE-17591 at 11/8/17 1:56 AM:
---
I delete this configuration when purging DLR code. Closing this one.
was (Author: appy):
Purged DLR code. This configuration is no more. Closing this one.
> Update documentation to say distributed log replay defaults to 'false'
> --
>
> Key: HBASE-17591
> URL: https://issues.apache.org/jira/browse/HBASE-17591
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Aki Ariga
>Priority: Trivial
> Fix For: 2.0.0
>
>
> As consequence of HBASE-12577, `hbase.master.distributed.log.replay` is no
> longer default true. But in the documentation, it is still noted as default
> true as follows:
> {quote}
> To enable distributed log replay, set hbase.master.distributed.log.replay to
> true. This will be the default for HBase 0.99 (HBASE-10888).
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17591) Update documentation to say distributed log replay defaults to 'false'
[
https://issues.apache.org/jira/browse/HBASE-17591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243258#comment-16243258
]
Appy commented on HBASE-17591:
--
Purged DLR code. This configuration is no more. Closing this one.
> Update documentation to say distributed log replay defaults to 'false'
> --
>
> Key: HBASE-17591
> URL: https://issues.apache.org/jira/browse/HBASE-17591
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Aki Ariga
>Priority: Trivial
> Fix For: 2.0.0
>
>
> As consequence of HBASE-12577, `hbase.master.distributed.log.replay` is no
> longer default true. But in the documentation, it is still noted as default
> true as follows:
> {quote}
> To enable distributed log replay, set hbase.master.distributed.log.replay to
> true. This will be the default for HBase 0.99 (HBASE-10888).
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19128) Purge Distributed Log Replay from codebase, configurations, text; mark the feature as unsupported, broken.
[ https://issues.apache.org/jira/browse/HBASE-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19128: - Fix Version/s: (was: 2.0.0) 2.0.0-beta-1 > Purge Distributed Log Replay from codebase, configurations, text; mark the > feature as unsupported, broken. > -- > > Key: HBASE-19128 > URL: https://issues.apache.org/jira/browse/HBASE-19128 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: stack >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19128.master.001.patch, > HBASE-19128.master.002.patch, HBASE-19128.master.003.patch, > HBASE-19128.master.004.patch, HBASE-19128.master.005.patch, > HBASE-19128.master.006.patch > > > Kill it. It keeps coming up and over again. Needs proper burial. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19170) [hbase-thirdparty] Change the relocation offset of shaded artifacts
[
https://issues.apache.org/jira/browse/HBASE-19170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242914#comment-16242914
]
Hadoop QA commented on HBASE-19170:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s{color}
| {color:red} HBASE-19170 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19170 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896498/HBASE-19170.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9673/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> [hbase-thirdparty] Change the relocation offset of shaded artifacts
> ---
>
> Key: HBASE-19170
> URL: https://issues.apache.org/jira/browse/HBASE-19170
> Project: HBase
> Issue Type: Bug
>Affects Versions: thirdparty-1.0.1
>Reporter: Jerry He
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 2.0.0-beta-1, thirdparty-1.0.2
>
> Attachments: HBASE-19170.patch
>
>
> On the dev@hbase list, we conclude that we need to change the relocation
> offset in hbase-thirdparty to avoid shading conflicts with the other hbase
> shaded components (hbase-shaded-client and hbase-shaded-mapreduce components).
> https://lists.apache.org/thread.html/1aa5d1d7f6d176df49e72096926b011cafe1315932515346d06e8342@%3Cdev.hbase.apache.org%3E
> The suggestion is to use "o.a.h.hbase.thirdparty" in hbase-thirdparty to
> differentiate between "shaded" for downstream of us vs "thirdparty" for our
> internal use.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19088) move_tables_rsgroup will throw an exception when the table is disabled
[
https://issues.apache.org/jira/browse/HBASE-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243249#comment-16243249
]
Guangxu Cheng commented on HBASE-19088:
---
Thanks [~apurtell] and [~yuzhih...@gmail.com] for review.
> move_tables_rsgroup will throw an exception when the table is disabled
> --
>
> Key: HBASE-19088
> URL: https://issues.apache.org/jira/browse/HBASE-19088
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-19088.branch-1.001.patch,
> HBASE-19088.branch-1.001.patch, HBASE-19088.branch-1.002.patch,
> HBASE-19088.master.001.patch, HBASE-19088.master.002.patch,
> HBASE-19088.master.003.patch
>
>
> When the table is disabled, *move_tables_rsgroup* will throw an exception,
> but the table has been moved to the new group successfully.
> {code:java}
> hbase(main):009:0> move_tables_rsgroup 'default',['t1']
> ERROR: java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos$MoveRegionStateData$Builder.setSourceServer(MasterProcedureProtos.java:26022)
> at
> org.apache.hadoop.hbase.master.assignment.MoveRegionProcedure.serializeStateData(MoveRegionProcedure.java:133)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProtoProcedure(ProcedureUtil.java:198)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeEntry(ProcedureWALFormat.java:211)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeInsert(ProcedureWALFormat.java:222)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.insert(WALProcedureStore.java:470)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:866)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:835)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitAndWaitProcedure(ProcedureSyncWait.java:120)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.move(AssignmentManager.java:557)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:413)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.moveTables(RSGroupAdminEndpoint.java:190)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:12786)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:786)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> ... 3 more
> Reassign tables from one RegionServer group to another.
> Example:
> hbase> move_tables_rsgroup 'dest',['table1','table2']
> Took 0.0297 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19205) Backport BASE-18441 ZookeeperWatcher#interruptedException should throw exception
stack created HBASE-19205:
-
Summary: Backport BASE-18441 ZookeeperWatcher#interruptedException
should throw exception
Key: HBASE-19205
URL: https://issues.apache.org/jira/browse/HBASE-19205
Project: HBase
Issue Type: Sub-task
Components: Zookeeper
Reporter: stack
Assignee: stack
Fix For: 1.2.7
In a branch-1.2 test run, I see a bunch of this in timed out test run:
709 2017-11-07 12:27:16,152 DEBUG [Time-limited test]
zookeeper.ZooKeeperWatcher(760): hconnection-0xb1ad4ca0x0,
quorum=localhost:50828, baseZNode=/hbase Received InterruptedException,
doing nothing here
710 java.lang.InterruptedException
Which is us swallowing interrupts out of zk.
The suppression of the interrupt is messing us up We start to see this:
{code}
5018 2017-11-07 12:30:18,276 WARN [Time-limited test]
zookeeper.ZKUtil(378): master:367040x0, quorum=localhost:56068,
baseZNode=/hbase Unable to set watcher on znode /hbase/backup-maste
rs/ve0528.halxg.cloudera.com,36704,1510086438842
5019 java.lang.InterruptedException
5020 at java.lang.Object.wait(Native Method)
5021 at java.lang.Object.wait(Object.java:502)
5022 at
org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342)
5023 at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1040)
5024 at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
5025 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:365)
5026 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
5027 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5028 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5029 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5030 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5031 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5032 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5033 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5034 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5035 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5036 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
5037 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
...
{code}
Later I'm getting
{code}
15578737 Caused by: java.lang.StackOverflowError
15578738 at java.security.AccessController.doPrivileged(Native Method)
15578739 at java.io.PrintWriter.(PrintWriter.java:116)
15578740 at java.io.PrintWriter.(PrintWriter.java:100)
15578741 at
org.apache.log4j.DefaultThrowableRenderer.render(DefaultThrowableRenderer.java:58)
15578742 at
org.apache.log4j.spi.ThrowableInformation.getThrowableStrRep(ThrowableInformation.java:87)
15578743 at
org.apache.log4j.spi.LoggingEvent.getThrowableStrRep(LoggingEvent.java:413)
15578744 at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:313)
15578745 at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
15578746 at
org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
15578747 at
org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
15578748 at org.apache.log4j.Category.callAppenders(Category.java:206)
15578749 at org.apache.log4j.Category.forcedLog(Category.java:391)
15578750 at org.apache.log4j.Category.log(Category.java:856)
15578751 at
org.apache.commons.logging.impl.Log4JLogger.warn(Log4JLogger.java:208)
15578752 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:378)
15578753 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:978)
15578754 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
15578755 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
15578756 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
15578757 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
15578758 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
15578759 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
15578760 at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:980)
[jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
[
https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243217#comment-16243217
]
Hadoop QA commented on HBASE-19194:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
9s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} master passed with JDK v1.8.0_141 {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
9s{color} | {color:red} hbase-rsgroup in master failed with JDK v1.7.0_151.
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
20s{color} | {color:red} branch has 7 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
9s{color} | {color:red} hbase-rsgroup in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed with JDK v1.8.0_141 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
8s{color} | {color:red} hbase-rsgroup in master failed with JDK v1.7.0_151.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
7s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
9s{color} | {color:red} hbase-rsgroup in the patch failed with JDK v1.7.0_151.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 9s{color}
| {color:red} hbase-rsgroup in the patch failed with JDK v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
7s{color} | {color:red} patch has 7 errors when building our shaded downstream
artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
14s{color} | {color:red} The patch causes 7 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
22s{color} | {color:red} The patch causes 7 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
28s{color} | {color:red} The patch causes 7 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
35s{color} | {color:red} The patch causes 7 errors with Hadoop v2.6.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
42s{color} | {color:red} The patch causes 7 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
50s{color} | {color:red} The patch causes 7 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
57s{color} | {color:red} The patch causes 7 errors with Hadoop v2.7.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
4s{color} | {color:red} The patch causes 7 errors with Hadoop v2.7.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
10s{color} | {color:red} The patch causes 7 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} |
[jira] [Updated] (HBASE-19088) move_tables_rsgroup will throw an exception when the table is disabled
[
https://issues.apache.org/jira/browse/HBASE-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-19088:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed to branch-1.4 and up
> move_tables_rsgroup will throw an exception when the table is disabled
> --
>
> Key: HBASE-19088
> URL: https://issues.apache.org/jira/browse/HBASE-19088
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
>Affects Versions: 3.0.0
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.5.0
>
> Attachments: HBASE-19088.branch-1.001.patch,
> HBASE-19088.branch-1.001.patch, HBASE-19088.branch-1.002.patch,
> HBASE-19088.master.001.patch, HBASE-19088.master.002.patch,
> HBASE-19088.master.003.patch
>
>
> When the table is disabled, *move_tables_rsgroup* will throw an exception,
> but the table has been moved to the new group successfully.
> {code:java}
> hbase(main):009:0> move_tables_rsgroup 'default',['t1']
> ERROR: java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:465)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos$MoveRegionStateData$Builder.setSourceServer(MasterProcedureProtos.java:26022)
> at
> org.apache.hadoop.hbase.master.assignment.MoveRegionProcedure.serializeStateData(MoveRegionProcedure.java:133)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProtoProcedure(ProcedureUtil.java:198)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeEntry(ProcedureWALFormat.java:211)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.writeInsert(ProcedureWALFormat.java:222)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.insert(WALProcedureStore.java:470)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:866)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:835)
> at
> org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitAndWaitProcedure(ProcedureSyncWait.java:120)
> at
> org.apache.hadoop.hbase.master.assignment.AssignmentManager.move(AssignmentManager.java:557)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:413)
> at
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.moveTables(RSGroupAdminEndpoint.java:190)
> at
> org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:12786)
> at
> org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:786)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> ... 3 more
> Reassign tables from one RegionServer group to another.
> Example:
> hbase> move_tables_rsgroup 'dest',['table1','table2']
> Took 0.0297 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-9465) Push entries to peer clusters serially
[ https://issues.apache.org/jira/browse/HBASE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243233#comment-16243233 ] Duo Zhang commented on HBASE-9465: -- I'm OK with pull it out from 1.4 even branch-1. But for 2.0 we'd like keep it there, we will add document for it as we have already deployed it in our cluster. Thanks. > Push entries to peer clusters serially > -- > > Key: HBASE-9465 > URL: https://issues.apache.org/jira/browse/HBASE-9465 > Project: HBase > Issue Type: New Feature > Components: regionserver, Replication >Affects Versions: 2.0.0, 1.4.0 >Reporter: Honghua Feng >Assignee: Phil Yang >Priority: Critical > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-9465-branch-1-v1.patch, > HBASE-9465-branch-1-v1.patch, HBASE-9465-branch-1-v2.patch, > HBASE-9465-branch-1-v3.patch, HBASE-9465-branch-1-v4.patch, > HBASE-9465-branch-1-v4.patch, HBASE-9465-v1.patch, HBASE-9465-v2.patch, > HBASE-9465-v2.patch, HBASE-9465-v3.patch, HBASE-9465-v4.patch, > HBASE-9465-v5.patch, HBASE-9465-v6.patch, HBASE-9465-v6.patch, > HBASE-9465-v7.patch, HBASE-9465-v7.patch, HBASE-9465.pdf > > > When region-move or RS failure occurs in master cluster, the hlog entries > that are not pushed before region-move or RS-failure will be pushed by > original RS(for region move) or another RS which takes over the remained hlog > of dead RS(for RS failure), and the new entries for the same region(s) will > be pushed by the RS which now serves the region(s), but they push the hlog > entries of a same region concurrently without coordination. > This treatment can possibly lead to data inconsistency between master and > peer clusters: > 1. there are put and then delete written to master cluster > 2. due to region-move / RS-failure, they are pushed by different > replication-source threads to peer cluster > 3. if delete is pushed to peer cluster before put, and flush and > major-compact occurs in peer cluster before put is pushed to peer cluster, > the delete is collected and the put remains in peer cluster > In this scenario, the put remains in peer cluster, but in master cluster the > put is masked by the delete, hence data inconsistency between master and peer > clusters -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18844) Release hbase-2.0.0-alpha-4; Theme "Coprocessor API Cleanup"
[ https://issues.apache.org/jira/browse/HBASE-18844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242890#comment-16242890 ] Josh Elser commented on HBASE-18844: [~stack] doesn't look like orgapachehbase-1181 was closed on Nexus. You miss that? > Release hbase-2.0.0-alpha-4; Theme "Coprocessor API Cleanup" > > > Key: HBASE-18844 > URL: https://issues.apache.org/jira/browse/HBASE-18844 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-4 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19127) Set State.SPLITTING, MERGING, MERGING_NEW, SPLITTING_NEW properly in RegionStatesNode
[
https://issues.apache.org/jira/browse/HBASE-19127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242946#comment-16242946
]
Yi Liang commented on HBASE-19127:
--
[~stack]
{quote}What does the change in AM do? (Adding state for daughters)?{quote}
Yes, this is to add state for daughters
{quote}Don't change numbering in protobufs.{quote}
The reason why I remove MERGE_TABLE_REGIONS_MOVE_REGION_TO_SAME_RS = 3 in
proto, because it has never been used in the current code. Do you think this
will cause some compatibility issues? If you think it is better to keep them, I
will keep it. Otherwise, I think it is safe to remove them, since
MergeTableRegionsProcedure is newly added since hbase-2.0.
> Set State.SPLITTING, MERGING, MERGING_NEW, SPLITTING_NEW properly in
> RegionStatesNode
> -
>
> Key: HBASE-19127
> URL: https://issues.apache.org/jira/browse/HBASE-19127
> Project: HBase
> Issue Type: Sub-task
>Reporter: Yi Liang
>Assignee: Yi Liang
> Attachments: state.patch
>
>
> In current code, we did not set above states to a region node at all, but we
> still have statements like below to check if node have above states.
> {code}
> else if (!regionNode.isInState(State.CLOSING, State.SPLITTING)) {
>
> }
> {code}
> We need to set above states in a correct place.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19207) Create Minimal HBase REST Client
Rick Kellogg created HBASE-19207: Summary: Create Minimal HBase REST Client Key: HBASE-19207 URL: https://issues.apache.org/jira/browse/HBASE-19207 Project: HBase Issue Type: New Feature Components: Client, REST Reporter: Rick Kellogg Create a minimal REST client with only contents of org.apache.hadoop.hbase.rest.client and org.apache.hadoop.hbase.rest.client.models packages in the hbase-rest project. Attempt to reduce the number of third party dependencies and allow user to bring their own Apache HttpClient/Core. The HttpClient is frequently updated and therefore should not be shaded to allow for upgrades. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19127) Set State.SPLITTING, MERGING, MERGING_NEW, SPLITTING_NEW properly in RegionStatesNode
[
https://issues.apache.org/jira/browse/HBASE-19127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242962#comment-16242962
]
stack commented on HBASE-19127:
---
If this protobuf is new to 2.0, go ahead with the remove. Otherwise, leave them
in place. Thanks [~easyliangjob]
> Set State.SPLITTING, MERGING, MERGING_NEW, SPLITTING_NEW properly in
> RegionStatesNode
> -
>
> Key: HBASE-19127
> URL: https://issues.apache.org/jira/browse/HBASE-19127
> Project: HBase
> Issue Type: Sub-task
>Reporter: Yi Liang
>Assignee: Yi Liang
> Attachments: region_state.patch, state.patch
>
>
> In current code, we did not set above states to a region node at all, but we
> still have statements like below to check if node have above states.
> {code}
> else if (!regionNode.isInState(State.CLOSING, State.SPLITTING)) {
>
> }
> {code}
> We need to set above states in a correct place.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-19187) Remove option to create on heap bucket cache
[ https://issues.apache.org/jira/browse/HBASE-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-19187: --- Fix Version/s: (was: 2.0.0-beta-1) 2.1.0 > Remove option to create on heap bucket cache > > > Key: HBASE-19187 > URL: https://issues.apache.org/jira/browse/HBASE-19187 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Biju Nair >Priority: Minor > Fix For: 2.1.0 > > > Since we are moving read and write paths to use direct memory, option to > configure on heap bucket cache is irrelevant. We should remove that option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16574) Add backup / restore feature to refguide
[ https://issues.apache.org/jira/browse/HBASE-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243149#comment-16243149 ] Vladimir Rodionov commented on HBASE-16574: --- [~fwelsch], Thank you for your help, feel free to reassign this JIRA back to yourself. Two sections need to be updated: command usage and backup configuration For up-to-date command usage you can take a look at the following classes: https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreConstants.java https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreDriver.java I will post correct configuration description later on today. cc: [~elserj] > Add backup / restore feature to refguide > > > Key: HBASE-16574 > URL: https://issues.apache.org/jira/browse/HBASE-16574 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Vladimir Rodionov > Labels: backup > Fix For: 2.0.0-beta-1 > > Attachments: Backup-and-Restore-Apache_19Sep2016.pdf, > HBASE-16574.001.patch, HBASE-16574.002.patch, hbase_reference_guide.v1.pdf > > > This issue is to add backup / restore feature description to hbase refguide. > The description should cover: > scenarios where backup / restore is used > backup / restore commands and sample usage > considerations in setup -- This message was sent by Atlassian JIRA (v6.4.14#64029)
