[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Status: Patch Available (was: Open) > Rewrite ReplicationPeer with the new replication

[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Fix Version/s: HBASE-19397 > Rewrite ReplicationPeer with the new replication storage

[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Attachment: HBASE-19573.HBASE-19397.001.patch > Rewrite ReplicationPeer with the new

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303114#comment-16303114 ] Hudson commented on HBASE-19608: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4282 (See

[jira] [Updated] (HBASE-19579) Add peer lock test for shell command list_locks

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19579: --- Attachment: HBASE-19579.HBASE-19397.002.patch Retry for Hadoop QA. > Add peer lock test for

[jira] [Commented] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303107#comment-16303107 ] Guanghao Zhang commented on HBASE-19573: Meanwhile, handle the ReplicationPeers in HBASE-19622.

[jira] [Updated] (HBASE-19622) Reimplement ReplicationPeers with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19622: --- Issue Type: Sub-task (was: Bug) Parent: HBASE-19397 > Reimplement ReplicationPeers

[jira] [Created] (HBASE-19622) Reimplement ReplicationPeers with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
Guanghao Zhang created HBASE-19622: -- Summary: Reimplement ReplicationPeers with the new replication storage interface Key: HBASE-19622 URL: https://issues.apache.org/jira/browse/HBASE-19622 Project:

[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Summary: Rewrite ReplicationPeer with the new replication storage interface (was: Rewrite

[jira] [Updated] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19621: --- Status: Patch Available (was: Open) > Revisit the methods in ReplicationPeerConfigBuilder >

[jira] [Assigned] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-19573: -- Assignee: Guanghao Zhang > Rewrite ReplicationPeer with the new replication storage

[jira] [Commented] (HBASE-19573) Rewrite ReplicationPeer with the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303097#comment-16303097 ] Guanghao Zhang commented on HBASE-19573: Changed the title to "Rewrite ReplicationPeer with the

[jira] [Updated] (HBASE-19573) Rewrite ReplicationPeerwith the new replication storage interface

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19573: --- Summary: Rewrite ReplicationPeerwith the new replication storage interface (was: Rewrite

[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303091#comment-16303091 ] Guanghao Zhang commented on HBASE-19619: [~tedyu] Open a issue HBASE-19621 for keep the methods

[jira] [Updated] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19621: --- Attachment: HBASE-19621.master.001.patch > Revisit the methods in

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303077#comment-16303077 ] Hadoop QA commented on HBASE-19608: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303076#comment-16303076 ] Guanghao Zhang commented on HBASE-19618: bq. Let's also remove the table based implementation We

[jira] [Updated] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19621: --- Priority: Minor (was: Major) Issue Type: Improvement (was: Bug) > Revisit the

[jira] [Created] (HBASE-19621) Revisit the methods in ReplicationPeerConfigBuilder

2017-12-24 Thread Guanghao Zhang (JIRA)
Guanghao Zhang created HBASE-19621: -- Summary: Revisit the methods in ReplicationPeerConfigBuilder Key: HBASE-19621 URL: https://issues.apache.org/jira/browse/HBASE-19621 Project: HBase

[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303069#comment-16303069 ] Ted Yu commented on HBASE-19619: With patch v4, TestReplicationShell passes. > Modify

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Status: Patch Available (was: Open) > Modify replication_admin.rb to use ReplicationPeerConfigBuilder >

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: 19619.v4.txt > Modify replication_admin.rb to use ReplicationPeerConfigBuilder >

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Fix Version/s: 2.0.0-beta-1 > Modify replication_admin.rb to use ReplicationPeerConfigBuilder >

[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303061#comment-16303061 ] Ted Yu commented on HBASE-19619: If I use the following for creating Map for merging the peer data:

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Priority: Critical (was: Major) > Modify replication_admin.rb to use ReplicationPeerConfigBuilder >

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: (was: 19619.v3.txt) > Modify replication_admin.rb to use ReplicationPeerConfigBuilder >

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: 19619.v3.txt > Modify replication_admin.rb to use ReplicationPeerConfigBuilder >

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: 19619.v3.txt In patch v3, I use a new Map to merge two configs in update_peer_config > Modify

[jira] [Updated] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Summary: Modify replication_admin.rb to use ReplicationPeerConfigBuilder (was: TestReplicationShell fails

[jira] [Commented] (HBASE-19619) Modify replication_admin.rb to use ReplicationPeerConfigBuilder

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303054#comment-16303054 ] Duo Zhang commented on HBASE-19619: --- {quote} Wouldn't it be better if we add the following method to

[jira] [Commented] (HBASE-19599) Remove ReplicationQueuesClient, use ReplicationQueueStorage directly

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303053#comment-16303053 ] Hadoop QA commented on HBASE-19599: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303052#comment-16303052 ] Duo Zhang commented on HBASE-19618: --- Let's also remove the table based implementation? It is useless

[jira] [Updated] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19608: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available)

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303049#comment-16303049 ] Ted Yu commented on HBASE-19619: Wouldn't it be better if we add the following method to

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303048#comment-16303048 ] Guanghao Zhang commented on HBASE-19619: bq. I looked at ReplicationPeerConfigBuilder but there

[jira] [Comment Edited] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303041#comment-16303041 ] Ted Yu edited comment on HBASE-19619 at 12/25/17 3:55 AM: -- What pattern should

[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: 19619.v2.txt > TestReplicationShell fails due to calling >

[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: (was: 19619.v2.txt) > TestReplicationShell fails due to calling >

[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303046#comment-16303046 ] Guanghao Zhang commented on HBASE-19618: Add a 001 patch. Ignore the table based replication

[jira] [Updated] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19618: --- Assignee: Guanghao Zhang Status: Patch Available (was: Open) > Remove

[jira] [Updated] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19618: --- Attachment: HBASE-19618.master.001.patch > Remove

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303041#comment-16303041 ] Ted Yu commented on HBASE-19619: I am a bit puzzled by the following seen in the test output: {code}

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303039#comment-16303039 ] Hadoop QA commented on HBASE-19608: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303038#comment-16303038 ] Ted Yu commented on HBASE-19619: Currently I am in Utah. Expect delay in future patches. >

[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: 19619.v2.txt > TestReplicationShell fails due to calling >

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303035#comment-16303035 ] Ted Yu commented on HBASE-19619: In patch v2, I use ReplicationPeerConfigBuilder for the two methods

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303031#comment-16303031 ] Zheng Hu commented on HBASE-19608: -- OK, +1 for this patch. > Race in

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303030#comment-16303030 ] Guanghao Zhang commented on HBASE-19619: I prefer to resolve this by use

[jira] [Updated] (HBASE-19620) Add UT to confirm the race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19620: -- Priority: Minor (was: Major) Issue Type: Task (was: Bug) > Add UT to confirm the race in

[jira] [Created] (HBASE-19620) Add UT to confirm the race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-19620: - Summary: Add UT to confirm the race in MasterRpcServices.getProcedureResult Key: HBASE-19620 URL: https://issues.apache.org/jira/browse/HBASE-19620 Project: HBase

[jira] [Updated] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19608: -- Attachment: HBASE-19608-v2.patch > Race in MasterRpcServices.getProcedureResult >

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303028#comment-16303028 ] Duo Zhang commented on HBASE-19608: --- We already have UTs can run into the problems otherwise I can not

[jira] [Commented] (HBASE-19358) Improve the stability of splitting log when do fail over

2017-12-24 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303027#comment-16303027 ] Yu Li commented on HBASE-19358: --- Please fix the checkstyle issues and check UT failures [~tianjingyun] >

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303026#comment-16303026 ] Guanghao Zhang commented on HBASE-19619: My fault... This was introduced by HBASE-19576. >

[jira] [Commented] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303025#comment-16303025 ] Ted Yu commented on HBASE-19619: Need to plug in builder to get over: {code} Error:

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303024#comment-16303024 ] Zheng Hu commented on HBASE-19608: -- Any existed UT for addressing this case ? If no, I think we can add

[jira] [Updated] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19619: --- Attachment: 19619.v1.txt Fix a few places in replication_admin.rb Need to figure out how to align

[jira] [Created] (HBASE-19619) TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add

2017-12-24 Thread Ted Yu (JIRA)
Ted Yu created HBASE-19619: -- Summary: TestReplicationShell fails due to calling Collections$UnmodifiableCollection.add Key: HBASE-19619 URL: https://issues.apache.org/jira/browse/HBASE-19619 Project: HBase

[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303014#comment-16303014 ] Guanghao Zhang commented on HBASE-19618: Meanwhile, we can pick up "table based replication"

[jira] [Commented] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303013#comment-16303013 ] Duo Zhang commented on HBASE-19618: --- +1. > Remove

[jira] [Commented] (HBASE-19483) Add proper privilege check for rsgroup commands

2017-12-24 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303011#comment-16303011 ] Appy commented on HBASE-19483: -- Thinking about it, i think it's great that this topic came up at this time

[jira] [Updated] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-19618: --- Description: When implement the procedure of replication admin operations, we abstract a

[jira] [Created] (HBASE-19618) Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory

2017-12-24 Thread Guanghao Zhang (JIRA)
Guanghao Zhang created HBASE-19618: -- Summary: Remove replicationQueuesClient.class/replicationQueues.class config from ReplicationFactory Key: HBASE-19618 URL: https://issues.apache.org/jira/browse/HBASE-19618

[jira] [Commented] (HBASE-19473) Review of ClientScanner Class

2017-12-24 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302999#comment-16302999 ] Appy commented on HBASE-19473: -- Sure, added to list. (will start new reviews after holidays :) ) > Review

[jira] [Commented] (HBASE-19483) Add proper privilege check for rsgroup commands

2017-12-24 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302997#comment-16302997 ] Appy commented on HBASE-19483: -- Need to give another thorough review, holidays in US right now so getting

[jira] [Updated] (HBASE-19594) [webui] HMaster webui should show splitting regions than split completed regions

2017-12-24 Thread Daisuke Kobayashi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daisuke Kobayashi updated HBASE-19594: -- Labels: supportability (was: ) > [webui] HMaster webui should show splitting regions

[jira] [Updated] (HBASE-19594) [webui] HMaster webui should show splitting regions than split completed regions

2017-12-24 Thread Daisuke Kobayashi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daisuke Kobayashi updated HBASE-19594: -- Attachment: improving-region-status-in-master.002.patch Apologies for the delay. Yes

[jira] [Created] (HBASE-19617) Remove ReplicationQueues, use ReplicationQueueStorage directly

2017-12-24 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-19617: - Summary: Remove ReplicationQueues, use ReplicationQueueStorage directly Key: HBASE-19617 URL: https://issues.apache.org/jira/browse/HBASE-19617 Project: HBase

[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302983#comment-16302983 ] Duo Zhang commented on HBASE-19554: --- Still failed in countRows. There may be a problem with the

[jira] [Commented] (HBASE-19554) AbstractTestDLS.testThreeRSAbort sometimes fails in pre commit

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302982#comment-16302982 ] Duo Zhang commented on HBASE-19554: ---

[jira] [Updated] (HBASE-19594) [webui] HMaster webui should show splitting regions than split completed regions

2017-12-24 Thread Daisuke Kobayashi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daisuke Kobayashi updated HBASE-19594: -- Attachment: Screen Shot 2017-12-22 at 20.05.59.png > [webui] HMaster webui should show

[jira] [Updated] (HBASE-19599) Remove ReplicationQueuesClient, use ReplicationQueueStorage directly

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19599: -- Attachment: HBASE-19599-HBASE-19397-v2.patch Rename UT. > Remove ReplicationQueuesClient, use

[jira] [Commented] (HBASE-19599) Remove ReplicationQueuesClient, use ReplicationQueueStorage directly

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302980#comment-16302980 ] Duo Zhang commented on HBASE-19599: --- Will commit after HBASE-19608 is resolved. > Remove

[jira] [Updated] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-19608: -- Attachment: HBASE-19608-v1.patch > Race in MasterRpcServices.getProcedureResult >

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302977#comment-16302977 ] Duo Zhang commented on HBASE-19608: --- Oh, there is a typo. Let me fix. > Race in

[jira] [Commented] (HBASE-19608) Race in MasterRpcServices.getProcedureResult

2017-12-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302976#comment-16302976 ] Duo Zhang commented on HBASE-19608: --- Need a review [~zghaobac] [~openinx]. The american are offline for

[jira] [Commented] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList

2017-12-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302975#comment-16302975 ] Ted Yu commented on HBASE-19614: Can you group changes of using ArrayDeque under one JIRA ? Thanks >

[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2

2017-12-24 Thread Xu Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302870#comment-16302870 ] Xu Jiang edited comment on HBASE-19188 at 12/25/17 12:03 AM: - My

[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2

2017-12-24 Thread Xu Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302966#comment-16302966 ] Xu Jiang commented on HBASE-19188: -- @Pater Somogyi sorry,Is Hbase 1.1.9/1.4.0/1.2.6 building problem? >

[jira] [Comment Edited] (HBASE-19188) Build fails on branch-1 using maven-3.5.2

2017-12-24 Thread Xu Jiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302870#comment-16302870 ] Xu Jiang edited comment on HBASE-19188 at 12/25/17 12:00 AM: - My

[jira] [Commented] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302963#comment-16302963 ] Hadoop QA commented on HBASE-19614: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19616) Review of LogCleaner Class

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302962#comment-16302962 ] Hadoop QA commented on HBASE-19616: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302961#comment-16302961 ] Hadoop QA commented on HBASE-19613: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19188) Build fails on branch-1 using maven-3.5.2

2017-12-24 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302960#comment-16302960 ] Peter Somogyi commented on HBASE-19188: --- Hi [~xujiang], could you double check the versions you

[jira] [Commented] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302959#comment-16302959 ] Hadoop QA commented on HBASE-19615: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19612) Review of ZKUtil Class

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302950#comment-16302950 ] Hadoop QA commented on HBASE-19612: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Updated] (HBASE-19616) Review of LogCleaner Class

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19616: Attachment: HBASE-19616.1.patch > Review of LogCleaner Class > -- > >

[jira] [Updated] (HBASE-19616) Review of LogCleaner Class

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19616: Status: Patch Available (was: Open) > Review of LogCleaner Class > -- > >

[jira] [Created] (HBASE-19616) Review of LogCleaner Class

2017-12-24 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HBASE-19616: --- Summary: Review of LogCleaner Class Key: HBASE-19616 URL: https://issues.apache.org/jira/browse/HBASE-19616 Project: HBase Issue Type: Improvement

[jira] [Assigned] (HBASE-19616) Review of LogCleaner Class

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR reassigned HBASE-19616: --- Assignee: BELUGA BEHR > Review of LogCleaner Class > -- > >

[jira] [Updated] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19615: Attachment: HBASE-19615.1.patch > CompositeImmutableSegment ArrayList Instead of LinkedList >

[jira] [Updated] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19615: Status: Patch Available (was: Open) > CompositeImmutableSegment ArrayList Instead of LinkedList >

[jira] [Assigned] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR reassigned HBASE-19615: --- Assignee: BELUGA BEHR > CompositeImmutableSegment ArrayList Instead of LinkedList >

[jira] [Created] (HBASE-19615) CompositeImmutableSegment ArrayList Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HBASE-19615: --- Summary: CompositeImmutableSegment ArrayList Instead of LinkedList Key: HBASE-19615 URL: https://issues.apache.org/jira/browse/HBASE-19615 Project: HBase

[jira] [Updated] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19614: Attachment: HBASE-19614.1.patch > CompoundBloomFilterWriter Array Instead of LinkedList >

[jira] [Updated] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19614: Description: {quote} ArrayDeque: Resizable-array implementation of the Deque interface. Array

[jira] [Updated] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19614: Status: Patch Available (was: Open) > CompoundBloomFilterWriter Array Instead of LinkedList >

[jira] [Assigned] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR reassigned HBASE-19614: --- Assignee: BELUGA BEHR > CompoundBloomFilterWriter Array Instead of LinkedList >

[jira] [Created] (HBASE-19614) CompoundBloomFilterWriter Array Instead of LinkedList

2017-12-24 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HBASE-19614: --- Summary: CompoundBloomFilterWriter Array Instead of LinkedList Key: HBASE-19614 URL: https://issues.apache.org/jira/browse/HBASE-19614 Project: HBase Issue

[jira] [Updated] (HBASE-19612) Review of ZKUtil Class

2017-12-24 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19612: Status: Open (was: Patch Available) > Review of ZKUtil Class > -- > >

  1   2   >