[jira] [Updated] (HBASE-22670) JDK 11 and CellComparator

2019-07-11 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-22670: --- Labels: jdk11 (was: ) > JDK 11 and CellComparator >

[GitHub] [hbase-operator-tools] saintstack commented on issue #7: HBASE-22674 precommit docker image installs JRE over JDK

2019-07-11 Thread GitBox
saintstack commented on issue #7: HBASE-22674 precommit docker image installs JRE over JDK URL: https://github.com/apache/hbase-operator-tools/pull/7#issuecomment-510750429 Pushed it for you @busbey This is an automated

[GitHub] [hbase-operator-tools] saintstack merged pull request #7: HBASE-22674 precommit docker image installs JRE over JDK

2019-07-11 Thread GitBox
saintstack merged pull request #7: HBASE-22674 precommit docker image installs JRE over JDK URL: https://github.com/apache/hbase-operator-tools/pull/7 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase-operator-tools] busbey commented on issue #7: HBASE-22674 precommit docker image installs JRE over JDK

2019-07-11 Thread GitBox
busbey commented on issue #7: HBASE-22674 precommit docker image installs JRE over JDK URL: https://github.com/apache/hbase-operator-tools/pull/7#issuecomment-510748014 well that's an interesting failure. Couldn't find a jdk installed in the docker image for maven:3.6-jdk-8?

[jira] [Comment Edited] (HBASE-22567) HBCK2 addMissingRegionsToMeta

2019-07-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883529#comment-16883529 ] stack edited comment on HBASE-22567 at 7/12/19 5:10 AM: [~wchevreuil] I added an

[GitHub] [hbase-operator-tools] asfgit commented on issue #7: HBASE-22674 precommit docker image installs JRE over JDK

2019-07-11 Thread GitBox
asfgit commented on issue #7: HBASE-22674 precommit docker image installs JRE over JDK URL: https://github.com/apache/hbase-operator-tools/pull/7#issuecomment-510746846 Refer to this link for build results (access rights to CI server needed):

[GitHub] [hbase-operator-tools] busbey commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
busbey commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-510746596 PR #7 will fix that bit, if you want to review, merge, and rebase.

[jira] [Updated] (HBASE-22674) precommit docker image installs JRE over JDK (multiple repos)

2019-07-11 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22674: Fix Version/s: operator-1.0.0 > precommit docker image installs JRE over JDK (multiple repos) >

[jira] [Updated] (HBASE-22674) precommit docker image installs JRE over JDK (multiple repos)

2019-07-11 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22674: Summary: precommit docker image installs JRE over JDK (multiple repos) (was: HBase connectors

[jira] [Updated] (HBASE-22674) precommit docker image installs JRE over JDK (multiple repos)

2019-07-11 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22674: Affects Version/s: operator-1.0.0 > precommit docker image installs JRE over JDK (multiple repos)

[GitHub] [hbase-operator-tools] busbey opened a new pull request #7: HBASE-22674 precommit docker image installs JRE over JDK

2019-07-11 Thread GitBox
busbey opened a new pull request #7: HBASE-22674 precommit docker image installs JRE over JDK URL: https://github.com/apache/hbase-operator-tools/pull/7 * remove findbugs because it pulls in a JRE * remove bats because we don't use it.

[GitHub] [hbase-operator-tools] busbey commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
busbey commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-510746077 yeah PR builds are generally broken right now. I started working on them in HBASE-22674 (which I think is the issue

[jira] [Commented] (HBASE-22567) HBCK2 addMissingRegionsToMeta

2019-07-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883529#comment-16883529 ] stack commented on HBASE-22567: --- [~wchevreuil] I added an OfflineMetaRepair to hbck over in HBASE-22680.

[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-07-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883522#comment-16883522 ] stack commented on HBASE-21665: --- On the issue of an OfflineMetaRebuild tool in hbase2/hbck2, HBASE-22680

[GitHub] [hbase-operator-tools] saintstack commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-510738961 Test fail because of "[ERROR] Failed to execute goal on project hbase-hbck2: Could not resolve dependencies for

[GitHub] [hbase-operator-tools] saintstack closed pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack closed pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase-operator-tools] saintstack commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#issuecomment-510737410 Hey @busbey closing this one. Opened a new one. This was missing a bunch of adds. New PR has the missing recipe and

[GitHub] [hbase-operator-tools] asfgit commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
asfgit commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-510737377 Refer to this link for build results (access rights to CI server needed):

[GitHub] [hbase-operator-tools] asfgit commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
asfgit commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-510736870 Refer to this link for build results (access rights to CI server needed):

[jira] [Commented] (HBASE-22681) The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883509#comment-16883509 ] Duo Zhang commented on HBASE-22681: --- Upload the UT here. The progress now is that, sometimes we may

[jira] [Assigned] (HBASE-22681) The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-22681: - Assignee: Duo Zhang > The 'assert highestUnsyncedTxid < entry.getTxid();' in

[jira] [Updated] (HBASE-22681) The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22681: -- Priority: Critical (was: Major) > The 'assert highestUnsyncedTxid < entry.getTxid();' in

[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#discussion_r302820003 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java.rej ## @@ -0,0

[jira] [Updated] (HBASE-22681) The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22681: -- Fix Version/s: 2.1.6 2.2.1 2.0.6 2.3.0

[jira] [Updated] (HBASE-22681) The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22681: -- Attachment: HBASE-22665-UT.patch > The 'assert highestUnsyncedTxid < entry.getTxid();' in

[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#discussion_r302819952 ## File path: hbase-hbck2/README.md ## @@ -337,11 +334,28 @@ The Master is unable

[GitHub] [hbase-operator-tools] saintstack opened a new pull request #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack opened a new pull request #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6 This commit checks-in hbck1 code with modifications under a new package. Changes included here allow rebuild of meta from

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

2019-07-11 Thread GitBox
busbey commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r302818560 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -164,6 +178,99 @@ int setRegionState(String region,

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

2019-07-11 Thread GitBox
busbey commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r302819489 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -334,6 +441,58 @@ private static final String

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

2019-07-11 Thread GitBox
busbey commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r302819052 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -334,6 +469,51 @@ private static final String

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

2019-07-11 Thread GitBox
busbey commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r302818806 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -334,6 +469,51 @@ private static final String

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

2019-07-11 Thread GitBox
busbey commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r302818315 ## File path: hbase-hbck2/pom.xml ## @@ -147,6 +147,11 @@ junit 4.12 + + org.mockito +

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

2019-07-11 Thread GitBox
busbey commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r302819041 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -334,6 +469,51 @@ private static final String

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
busbey commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#discussion_r302817833 ## File path: hbase-hbck2/README.md ## @@ -337,11 +334,28 @@ The Master is unable to

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
busbey commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#discussion_r302817966 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java.rej ## @@ -0,0

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
busbey commented on a change in pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#discussion_r302818022 ## File path: hbase-hbck2/README.md ## @@ -337,11 +334,28 @@ The Master is unable to

[GitHub] [hbase-operator-tools] busbey commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
busbey commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#issuecomment-510732994 I thought one of the limitations of #3 was that it has to have a running master, which presumably the old offline meta

[GitHub] [hbase-operator-tools] saintstack commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#issuecomment-510731410 @busbey Not this patch. This is a total rebuild of meta only. It is how it was done in hbase1. It is one of the items

[jira] [Created] (HBASE-22682) clover task failed at clover2:setup

2019-07-11 Thread luhuachao (JIRA)
luhuachao created HBASE-22682: - Summary: clover task failed at clover2:setup Key: HBASE-22682 URL: https://issues.apache.org/jira/browse/HBASE-22682 Project: HBase Issue Type: Bug Affects

[jira] [Commented] (HBASE-22682) clover task failed at clover2:setup

2019-07-11 Thread luhuachao (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883487#comment-16883487 ] luhuachao commented on HBASE-22682: --- It goes well with build without clover, the failure seems caused

[jira] [Updated] (HBASE-22682) clover task failed at clover2:setup

2019-07-11 Thread luhuachao (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luhuachao updated HBASE-22682: -- Environment: Java version: 1.8.0_77 Apache Maven 3.5.4 OS name: "linux" maven-clover2-plugin:4.0.6

[jira] [Updated] (HBASE-22682) clover task failed at clover2:setup

2019-07-11 Thread luhuachao (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luhuachao updated HBASE-22682: -- Description:   when exec "mvn clover2:setup test"  ,error message 'unexpected token:

[jira] [Updated] (HBASE-22682) clover task failed at clover2:setup

2019-07-11 Thread luhuachao (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luhuachao updated HBASE-22682: -- Description:   when exec "mvn clover2:setup test"  ,error message 'unexpected token:

[jira] [Created] (HBASE-22681) The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL

2019-07-11 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-22681: - Summary: The 'assert highestUnsyncedTxid < entry.getTxid();' in AbstractFWAL.append may fail when using AsyncFSWAL Key: HBASE-22681 URL:

[GitHub] [hbase] sunhelly commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-07-11 Thread GitBox
sunhelly commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#issuecomment-510715927 @wchevreuil I have updated the codes as replied in all the comments. Please review again. But I waited

[jira] [Comment Edited] (HBASE-22460) Reopen a region if store reader references may have leaked

2019-07-11 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882461#comment-16882461 ] Mingliang Liu edited comment on HBASE-22460 at 7/12/19 1:31 AM: Curious,

[jira] [Commented] (HBASE-22460) Reopen a region if store reader references may have leaked

2019-07-11 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883450#comment-16883450 ] Andrew Purtell commented on HBASE-22460: {quote}Curious, once leaked, is there any other

[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #3: Hbase 22567

2019-07-11 Thread GitBox
busbey commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r302789154 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -334,6 +469,51 @@ private static final String

[GitHub] [hbase-operator-tools] busbey commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
busbey commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#issuecomment-510698096 Isn't this going to have a bunch of overlap with #3? Why not add a "and first run a master in maintenance mode" to

[GitHub] [hbase-operator-tools] asfgit commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
asfgit commented on issue #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5#issuecomment-510695589 Refer to this link for build results (access rights to CI server needed):

[jira] [Commented] (HBASE-22680) [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883422#comment-16883422 ] stack commented on HBASE-22680: --- Put up a PR against hbase-operator-tools (See link above). {code} This

[GitHub] [hbase-operator-tools] saintstack opened a new pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread GitBox
saintstack opened a new pull request #5: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/5 This commit checks-in hbck1 code with modifications under a new package. Changes included here allow rebuild of meta from

[jira] [Created] (HBASE-22680) [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-11 Thread stack (JIRA)
stack created HBASE-22680: - Summary: [HBCK2] OfflineMetaRepair for hbase2/hbck2 Key: HBASE-22680 URL: https://issues.apache.org/jira/browse/HBASE-22680 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-12169) Document IPC binding options

2019-07-11 Thread Sakthi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883355#comment-16883355 ] Sakthi commented on HBASE-12169: [~busbey], can we get this in? with the one suggested change? >

[GitHub] [hbase] jatsakthi commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-07-11 Thread GitBox
jatsakthi commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#issuecomment-510581312 LGTM This is an automated message from the Apache Git Service. To

[GitHub] [hbase] jatsakthi commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements

2019-07-11 Thread GitBox
jatsakthi commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#issuecomment-510579506 The latest patch looks good! +1 This is an automated message from the Apache

[GitHub] [hbase] jatsakthi commented on a change in pull request #369: HBASE-21606 document meta table load metrics

2019-07-11 Thread GitBox
jatsakthi commented on a change in pull request #369: HBASE-21606 document meta table load metrics URL: https://github.com/apache/hbase/pull/369#discussion_r302657538 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -1738,6 +1738,85 @@

[jira] [Created] (HBASE-22679) Remove usages of creating cell with CellUtil.createCell()

2019-07-11 Thread Viraj Jasani (JIRA)
Viraj Jasani created HBASE-22679: Summary: Remove usages of creating cell with CellUtil.createCell() Key: HBASE-22679 URL: https://issues.apache.org/jira/browse/HBASE-22679 Project: HBase

[GitHub] [hbase] meszibalu commented on a change in pull request #356: HBASE-15666 shaded dependencies for hbase-testing-util

2019-07-11 Thread GitBox
meszibalu commented on a change in pull request #356: HBASE-15666 shaded dependencies for hbase-testing-util URL: https://github.com/apache/hbase/pull/356#discussion_r302604086 ## File path:

[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #4: HBASE-22675 Use the commons-cli from hbase-thirdparty

2019-07-11 Thread GitBox
wchevreuil commented on a change in pull request #4: HBASE-22675 Use the commons-cli from hbase-thirdparty URL: https://github.com/apache/hbase-operator-tools/pull/4#discussion_r302593940 ## File path: hbase-hbck2/pom.xml ## @@ -32,6 +32,7 @@ Apache HBase - HBCK2

[GitHub] [hbase] virajjasani commented on issue #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-11 Thread GitBox
virajjasani commented on issue #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#issuecomment-510523850 > New round of reviews: > > * Current tests are correctly asserting the expected return now, but I think

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883018#comment-16883018 ] Duo Zhang commented on HBASE-22665: --- At least I must find a another bug with the new UT... {noformat}

[jira] [Updated] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22665: -- Attachment: HBASE-22665-UT.patch > RegionServer abort failed when AbstractFSWAL.shutdown hang >

[GitHub] [hbase] wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-11 Thread GitBox
wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#discussion_r302564590 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-11 Thread GitBox
wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#discussion_r302562850 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-11 Thread GitBox
wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#discussion_r302562480 ## File path:

[GitHub] [hbase] virajjasani commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-11 Thread GitBox
virajjasani commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#discussion_r302562653 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-11 Thread GitBox
wchevreuil commented on a change in pull request #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#discussion_r302548318 ## File path:

[GitHub] [hbase] busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions

2019-07-11 Thread GitBox
busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions URL: https://github.com/apache/hbase/pull/373#discussion_r302538769 ## File path:

[GitHub] [hbase] busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions

2019-07-11 Thread GitBox
busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions URL: https://github.com/apache/hbase/pull/373#discussion_r302538195 ## File path:

[GitHub] [hbase] busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions

2019-07-11 Thread GitBox
busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions URL: https://github.com/apache/hbase/pull/373#discussion_r302537768 ## File path:

[jira] [Updated] (HBASE-22678) Integration tests - error starting minicluster when trying to run with maven

2019-07-11 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated HBASE-22678: --- Description: If I try to run Integration Tests (tried multiple tests like Replication,

[GitHub] [hbase] busbey commented on a change in pull request #356: HBASE-15666 shaded dependencies for hbase-testing-util

2019-07-11 Thread GitBox
busbey commented on a change in pull request #356: HBASE-15666 shaded dependencies for hbase-testing-util URL: https://github.com/apache/hbase/pull/356#discussion_r302527049 ## File path:

[jira] [Created] (HBASE-22678) Integration tests - error starting minicluster when trying to run with maven

2019-07-11 Thread Norbert Kalmar (JIRA)
Norbert Kalmar created HBASE-22678: -- Summary: Integration tests - error starting minicluster when trying to run with maven Key: HBASE-22678 URL: https://issues.apache.org/jira/browse/HBASE-22678

[GitHub] [hbase] busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions

2019-07-11 Thread GitBox
busbey commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions URL: https://github.com/apache/hbase/pull/373#discussion_r302504813 ## File path:

[jira] [Updated] (HBASE-22638) Zookeeper Utility enhancements

2019-07-11 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22638: - Description: * final arguments for Constructor with args * try with resources * removal of

[jira] [Updated] (HBASE-22638) Zookeeper Utility enhancements

2019-07-11 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22638: - Summary: Zookeeper Utility enhancements (was: Checkstyle changes for hbase-zookeeper util

[jira] [Commented] (HBASE-22638) Checkstyle changes for hbase-zookeeper util classes

2019-07-11 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882856#comment-16882856 ] Viraj Jasani commented on HBASE-22638: -- I have updated the patch. Could you please take a final

[jira] [Updated] (HBASE-22638) Checkstyle changes for hbase-zookeeper util classes

2019-07-11 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22638: - Fix Version/s: 3.0.0 Status: Patch Available (was: In Progress) > Checkstyle

[jira] [Work started] (HBASE-22638) Checkstyle changes for hbase-zookeeper util classes

2019-07-11 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22638 started by Viraj Jasani. > Checkstyle changes for hbase-zookeeper util classes >

[jira] [Updated] (HBASE-22638) Checkstyle changes for hbase-zookeeper util classes

2019-07-11 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22638: - Description: * final arguments for Constructor with args * try with resources * removal of

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-11 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882852#comment-16882852 ] Wellington Chevreuil commented on HBASE-22665: -- {quote}After 3), the new writer is up and

[GitHub] [hbase-connectors] meszibalu commented on issue #34: HBASE-22599 Let hbase-connectors compile against HBase 2.2.0

2019-07-11 Thread GitBox
meszibalu commented on issue #34: HBASE-22599 Let hbase-connectors compile against HBase 2.2.0 URL: https://github.com/apache/hbase-connectors/pull/34#issuecomment-510434832 retest build This is an automated message from the

[jira] [Work started] (HBASE-22653) compile failure using JDK7 and errorProne

2019-07-11 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22653 started by Peter Somogyi. - > compile failure using JDK7 and errorProne >

[jira] [Assigned] (HBASE-22653) compile failure using JDK7 and errorProne

2019-07-11 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reassigned HBASE-22653: - Assignee: Peter Somogyi > compile failure using JDK7 and errorProne >

[jira] [Commented] (HBASE-22653) compile failure using JDK7 and errorProne

2019-07-11 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882833#comment-16882833 ] Peter Somogyi commented on HBASE-22653: --- It is odd, but I noticed that for branch-1.4 and branch-1

[GitHub] [hbase] Apache9 commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions

2019-07-11 Thread GitBox
Apache9 commented on a change in pull request #373: HBASE-22527 [hbck2] Add a master web ui to show the problematic regions URL: https://github.com/apache/hbase/pull/373#discussion_r302472597 ## File path:

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882821#comment-16882821 ] Duo Zhang commented on HBASE-22665: --- This is expected behavior. We can not just throw exception to

[GitHub] [hbase] syedmurtazahassan commented on a change in pull request #370: HBASE-19230 Write up fixVersion policy from dev discussion in refguide

2019-07-11 Thread GitBox
syedmurtazahassan commented on a change in pull request #370: HBASE-19230 Write up fixVersion policy from dev discussion in refguide URL: https://github.com/apache/hbase/pull/370#discussion_r302463178 ## File path: src/main/asciidoc/_chapters/developer.adoc ## @@ -1783,6

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-11 Thread binlijin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882803#comment-16882803 ] binlijin commented on HBASE-22665: -- Add the unackedAppends back to toWriteAppends, will make some edit

[jira] [Commented] (HBASE-22665) RegionServer abort failed when AbstractFSWAL.shutdown hang

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882799#comment-16882799 ] Duo Zhang commented on HBASE-22665: --- After 3), the new writer is up and we will schedule a new consume

[GitHub] [hbase] Braavos96 opened a new pull request #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes

2019-07-11 Thread GitBox
Braavos96 opened a new pull request #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374 I've analysed your codebase and noticed that `org.apache.hadoop.hbase.util.ByteRangeUtils` and `Classes` is not

[jira] [Created] (HBASE-22677) Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and org.apache.hadoop.hbase.util.Classes

2019-07-11 Thread Eric Hettiaratchi (JIRA)
Eric Hettiaratchi created HBASE-22677: - Summary: Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and org.apache.hadoop.hbase.util.Classes Key: HBASE-22677 URL:

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-07-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882762#comment-16882762 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #7 on

[GitHub] [hbase] symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics

2019-07-11 Thread GitBox
symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics URL: https://github.com/apache/hbase/pull/369#discussion_r302421549 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -1738,6 +1738,83 @@

[GitHub] [hbase] symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics

2019-07-11 Thread GitBox
symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics URL: https://github.com/apache/hbase/pull/369#discussion_r302413308 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -1738,6 +1738,83 @@

[GitHub] [hbase] symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics

2019-07-11 Thread GitBox
symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics URL: https://github.com/apache/hbase/pull/369#discussion_r302412712 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -1738,6 +1738,83 @@

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-07-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882724#comment-16882724 ] Duo Zhang commented on HBASE-22514: --- Talked with [~zghaobac] offline, we both agree that the current

[GitHub] [hbase] symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics

2019-07-11 Thread GitBox
symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics URL: https://github.com/apache/hbase/pull/369#discussion_r302410437 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -1738,6 +1738,83 @@

[GitHub] [hbase] symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics

2019-07-11 Thread GitBox
symat commented on a change in pull request #369: HBASE-21606 document meta table load metrics URL: https://github.com/apache/hbase/pull/369#discussion_r302410216 ## File path: src/main/asciidoc/_chapters/ops_mgt.adoc ## @@ -1738,6 +1738,83 @@

  1   2   >