[jira] [Updated] (HBASE-22648) Snapshot TTL

2019-07-15 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22648: - Attachment: HBASE-22648-master-v5.patch > Snapshot TTL > > > Key:

[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-15 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22527: --- Attachment: HBASE-22527.master.003.patch > [hbck2] Add a master web ui to show the

[jira] [Updated] (HBASE-22648) Snapshot TTL

2019-07-15 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22648: - Attachment: Screen Shot 2019-07-16 at 11.06.03 AM.png > Snapshot TTL > > >

[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-07-15 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885847#comment-16885847 ] Sean Busbey commented on HBASE-21665: - the current patches on HBASE-22690 doesn't just deprecate it

[jira] [Commented] (HBASE-22688) [HBCK2] Add filesystem fixup to hbck2

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885845#comment-16885845 ] stack commented on HBASE-22688: --- Tried to test these changes against an hbase1 big cluster but

[jira] [Commented] (HBASE-21665) OfflineMetaRepair tool fails with NPE

2019-07-15 Thread Pankaj Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885843#comment-16885843 ] Pankaj Kumar commented on HBASE-21665: -- Yeah, closing it as "won't fix" should be fine. But if OMR 

[jira] [Commented] (HBASE-22652) Flakey TestLockManager; test timed out after 780 seconds

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885842#comment-16885842 ] stack commented on HBASE-22652: --- Opened HBASE-22696 to deal w/ LockProcedure suggestions made above by

[jira] [Updated] (HBASE-22696) LockProcedure cleanups

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22696: -- Environment: (was: Our Duo made some comments in the parent issue: "The unlock method should not be able

[jira] [Updated] (HBASE-22696) LockProcedure cleanups

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22696: -- Description: Our Duo made some comments in the parent issue: * "The unlock method should not be able to

[jira] [Updated] (HBASE-22696) LockProcedure cleanups

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22696: -- Description: And I think we should remove the dependency on it for our internal usage. I think the main usage

[jira] [Created] (HBASE-22696) LockProcedure cleanups

2019-07-15 Thread stack (JIRA)
stack created HBASE-22696: - Summary: LockProcedure cleanups Key: HBASE-22696 URL: https://issues.apache.org/jira/browse/HBASE-22696 Project: HBase Issue Type: Sub-task Environment: Our Duo

[GitHub] [hbase] infraio commented on a change in pull request #375: HBASE-21426 TestEncryptionKeyRotation.testCFKeyRotation is flaky

2019-07-15 Thread GitBox
infraio commented on a change in pull request #375: HBASE-21426 TestEncryptionKeyRotation.testCFKeyRotation is flaky URL: https://github.com/apache/hbase/pull/375#discussion_r303721445 ## File path:

[jira] [Commented] (HBASE-22642) Make move operations of RSGroup idempotent

2019-07-15 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885827#comment-16885827 ] Xiaolin Ha commented on HBASE-22642: Thanks [~xucang]! I have fixed the conflicts and updated the

[GitHub] [hbase] sunhelly opened a new pull request #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-07-15 Thread GitBox
sunhelly opened a new pull request #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] sunhelly closed pull request #350: Make move operations of RSGroup idempotent

2019-07-15 Thread GitBox
sunhelly closed pull request #350: Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/350 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] saintstack commented on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-15 Thread GitBox
saintstack commented on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/381#issuecomment-511653332 Ok. Good by me. Long as other concerns addressed, +1 from me @brfrn169

[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885803#comment-16885803 ] Hudson commented on HBASE-20952: Results for branch HBASE-20952 [build #98 on

[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-15 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22527: --- Attachment: HBASE-22527.master.002.patch > [hbck2] Add a master web ui to show the

[GitHub] [hbase] Reidddddd commented on issue #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize.

2019-07-15 Thread GitBox
Reidd commented on issue #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize. URL: https://github.com/apache/hbase/pull/386#issuecomment-511643653 Usually, we don't actual remove an old attribute, the way we prefer is marking the old attribute deprecated, then

[jira] [Comment Edited] (HBASE-22479) Release sycLatch too early in CreateTable() to get table state failed in postCreateTable

2019-07-15 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885791#comment-16885791 ] Xiaolin Ha edited comment on HBASE-22479 at 7/16/19 2:50 AM: - This problem

[jira] [Commented] (HBASE-22479) Release sycLatch too early in CreateTable() to get table state failed in postCreateTable

2019-07-15 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885791#comment-16885791 ] Xiaolin Ha commented on HBASE-22479: This problem still exists, {quote}2019-07-16 10:35:22,094 ERROR

[GitHub] [hbase] openinx commented on issue #365: HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator name

2019-07-15 Thread GitBox
openinx commented on issue #365: HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator named HEAP URL: https://github.com/apache/hbase/pull/365#issuecomment-511636881 Thanks the +1 from @anoopsjohn

[GitHub] [hbase] brfrn169 edited a comment on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-15 Thread GitBox
brfrn169 edited a comment on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/381#issuecomment-511632237 Thank you for reviewing @saintstack > The removed methods are only used by OMR? Yes.

[GitHub] [hbase] brfrn169 commented on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-15 Thread GitBox
brfrn169 commented on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/381#issuecomment-511632237 Thank you for reviewing @saintstack > The removed methods are only used by OMR? Yes.

[GitHub] [hbase] brfrn169 commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-15 Thread GitBox
brfrn169 commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/380#issuecomment-511631980 > Should we squash this PR @brfrn169 given you opened new one sir. Does new one address above comments? Thanks.

[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-15 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22527: --- Attachment: HBASE-22527.master.001.patch > [hbck2] Add a master web ui to show the

[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-15 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22527: --- Status: Patch Available (was: Open) > [hbck2] Add a master web ui to show the problematic

[jira] [Commented] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-15 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885762#comment-16885762 ] Guanghao Zhang commented on HBASE-22527: Pushed a new patch to fix the meta region problem. >

[GitHub] [hbase] brfrn169 commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-15 Thread GitBox
brfrn169 commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/380#issuecomment-511630866 Thank you for reviewing guys. I modified the patch for the review. Could you please review it? @busbey @HorizonNet

[jira] [Commented] (HBASE-22661) list_regions command in hbase shell is broken

2019-07-15 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885757#comment-16885757 ] Guanghao Zhang commented on HBASE-22661: +1 > list_regions command in hbase shell is broken >

[jira] [Commented] (HBASE-22630) Restore TestReplicationDroppedTables coverage to branch-1

2019-07-15 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885746#comment-16885746 ] Xu Cang commented on HBASE-22630: - ACK, will work on it.  > Restore TestReplicationDroppedTables

[jira] [Created] (HBASE-22695) Store the rsgroup of a table in table configuration

2019-07-15 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-22695: - Summary: Store the rsgroup of a table in table configuration Key: HBASE-22695 URL: https://issues.apache.org/jira/browse/HBASE-22695 Project: HBase Issue Type:

[jira] [Commented] (HBASE-22640) Random init hstore lastFlushTime

2019-07-15 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885744#comment-16885744 ] Xu Cang commented on HBASE-22640: - Nice idea. I'd suggest adding one line comment above your change to

[jira] [Commented] (HBASE-22661) list_regions command in hbase shell is broken

2019-07-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885745#comment-16885745 ] Duo Zhang commented on HBASE-22661: --- For the rubocop, the first is not related to the patch, and for

[jira] [Comment Edited] (HBASE-22642) Make move operations of RSGroup idempotent

2019-07-15 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885741#comment-16885741 ] Xu Cang edited comment on HBASE-22642 at 7/16/19 1:03 AM: -- This is an

[jira] [Commented] (HBASE-22642) Make move operations of RSGroup idempotent

2019-07-15 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885741#comment-16885741 ] Xu Cang commented on HBASE-22642: - this is an interesting angle to look at this issue. thanks. can you

[jira] [Commented] (HBASE-22644) if region split fails, the directories of daughterRegions will not be deleted

2019-07-15 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885734#comment-16885734 ] Xu Cang commented on HBASE-22644: - Agree with [~stack] that we should examine all possibilities that

[jira] [Updated] (HBASE-22527) [hbck2] Add a master web ui to show the problematic regions

2019-07-15 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22527: --- Attachment: 2019-07-16 08-50-07屏幕截图.png > [hbck2] Add a master web ui to show the

[jira] [Commented] (HBASE-22650) NPE in AssignmentManager (master crash on startup)

2019-07-15 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885727#comment-16885727 ] Xu Cang commented on HBASE-22650: - [~sveyrie] good catch. Can you please rename patch name to

[GitHub] [hbase] xcangCRM commented on issue #348: HBASE-22643 : Delete region without archiving only if regiondir is pr…

2019-07-15 Thread GitBox
xcangCRM commented on issue #348: HBASE-22643 : Delete region without archiving only if regiondir is pr… URL: https://github.com/apache/hbase/pull/348#issuecomment-511617881 +1 This is an automated message from the Apache

[jira] [Commented] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885711#comment-16885711 ] Hudson commented on HBASE-21606: Results for branch branch-2.2 [build #434 on

[jira] [Commented] (HBASE-22684) The log rolling request maybe canceled immediately in LogRoller due to a race

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885710#comment-16885710 ] Hudson commented on HBASE-22684: Results for branch branch-2.2 [build #434 on

[jira] [Commented] (HBASE-22623) Add RegionObserver coprocessor hook for preWALAppend

2019-07-15 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885696#comment-16885696 ] Geoffrey Jacoby commented on HBASE-22623: - Upon looking more closely, it doesn't seem like my

[jira] [Commented] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885695#comment-16885695 ] Hudson commented on HBASE-21606: Results for branch branch-2 [build #2076 on

[jira] [Commented] (HBASE-22684) The log rolling request maybe canceled immediately in LogRoller due to a race

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885687#comment-16885687 ] Hudson commented on HBASE-22684: Results for branch branch-2.1 [build #1369 on

[jira] [Commented] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885688#comment-16885688 ] Hudson commented on HBASE-21606: Results for branch branch-2.1 [build #1369 on

[jira] [Commented] (HBASE-22648) Snapshot TTL

2019-07-15 Thread HBase QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885681#comment-16885681 ] HBase QA commented on HBASE-22648: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22567) HBCK2 addMissingRegionsToMeta

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885675#comment-16885675 ] stack commented on HBASE-22567: --- bq. we can invest on this onlineMetaRepair the way it is now, and

[jira] [Commented] (HBASE-22691) [hbase-operator-tools] Move Checkstyle suppression file to different location

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885668#comment-16885668 ] stack commented on HBASE-22691: --- Letting this one sit [~Jan Hentschel]. Waiting on another opinion. I'm

[GitHub] [hbase] saintstack commented on a change in pull request #378: HBASE-22684 The log rolling request maybe canceled immediately in Log…

2019-07-15 Thread GitBox
saintstack commented on a change in pull request #378: HBASE-22684 The log rolling request maybe canceled immediately in Log… URL: https://github.com/apache/hbase/pull/378#discussion_r303667355 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #378: HBASE-22684 The log rolling request maybe canceled immediately in Log…

2019-07-15 Thread GitBox
saintstack commented on a change in pull request #378: HBASE-22684 The log rolling request maybe canceled immediately in Log… URL: https://github.com/apache/hbase/pull/378#discussion_r303667196 ## File path:

[jira] [Commented] (HBASE-22537) Split happened Replica region can not be deleted after deleting table successfully and restarting RegionServer

2019-07-15 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885657#comment-16885657 ] Wellington Chevreuil commented on HBASE-22537: -- Thanks [~sreenivasulureddy]. It seems

[jira] [Commented] (HBASE-22680) [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885654#comment-16885654 ] stack commented on HBASE-22680: --- Asked up on PR for a +1 on merging [~wchevreuil]... if good by you. >

[GitHub] [hbase-operator-tools] saintstack commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-15 Thread GitBox
saintstack commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-511585697 Ok if I merge this @wchevreuil ? This is an

[GitHub] [hbase-operator-tools] asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-15 Thread GitBox
asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-511584966 Refer to this link for build results (access rights to CI server needed):

[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #3: Hbase 22567

2019-07-15 Thread GitBox
wchevreuil commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r303653540 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -334,6 +469,51 @@ private static final String

[GitHub] [hbase-operator-tools] wchevreuil commented on issue #3: Hbase 22567

2019-07-15 Thread GitBox
wchevreuil commented on issue #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#issuecomment-511584463 Had pushed a new commit d40cfb1, addressing latest suggestions and adding more UTs. This is an

[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #3: Hbase 22567

2019-07-15 Thread GitBox
wchevreuil commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r303652863 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -164,6 +178,99 @@ int setRegionState(String region,

[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #3: Hbase 22567

2019-07-15 Thread GitBox
wchevreuil commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r303652806 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -496,6 +672,51 @@ private static String toString(List

[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #3: Hbase 22567

2019-07-15 Thread GitBox
wchevreuil commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r303652577 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -334,6 +441,58 @@ private static final String

[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #3: Hbase 22567

2019-07-15 Thread GitBox
wchevreuil commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r303652344 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java ## @@ -164,6 +178,99 @@ int setRegionState(String region,

[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #3: Hbase 22567

2019-07-15 Thread GitBox
wchevreuil commented on a change in pull request #3: Hbase 22567 URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r303652272 ## File path: hbase-hbck2/pom.xml ## @@ -147,6 +147,11 @@ junit 4.12 + + org.mockito +

[GitHub] [hbase-operator-tools] asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-15 Thread GitBox
asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-511580985 Refer to this link for build results (access rights to CI server needed):

[GitHub] [hbase] gjacoby126 commented on a change in pull request #352: HBASE-22622 - WALKey Extended Attributes

2019-07-15 Thread GitBox
gjacoby126 commented on a change in pull request #352: HBASE-22622 - WALKey Extended Attributes URL: https://github.com/apache/hbase/pull/352#discussion_r303643171 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java ## @@ -86,6 +86,21 @@

[GitHub] [hbase-operator-tools] asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-15 Thread GitBox
asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-511570352 Refer to this link for build results (access rights to CI server needed):

[jira] [Commented] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885607#comment-16885607 ] Hudson commented on HBASE-21606: Results for branch master [build #1226 on

[jira] [Commented] (HBASE-22414) Interruption of moving regions in RSGroup will cause regions on wrong rs

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885606#comment-16885606 ] Hudson commented on HBASE-22414: Results for branch branch-2 [build #2075 on

[jira] [Commented] (HBASE-22684) The log rolling request maybe canceled immediately in LogRoller due to a race

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885605#comment-16885605 ] Hudson commented on HBASE-22684: Results for branch branch-2 [build #2075 on

[jira] [Commented] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885601#comment-16885601 ] Hudson commented on HBASE-21606: Results for branch branch-2.0 [build #1759 on

[jira] [Commented] (HBASE-22684) The log rolling request maybe canceled immediately in LogRoller due to a race

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885600#comment-16885600 ] Hudson commented on HBASE-22684: Results for branch branch-2.0 [build #1759 on

[GitHub] [hbase-operator-tools] asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-15 Thread GitBox
asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-511563385 Refer to this link for build results (access rights to CI server needed):

[jira] [Resolved] (HBASE-22694) Use hbase.zookeeper.quorum if fs.hboss.sync.zk.connectionString is not defined

2019-07-15 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-22694. Resolution: Fixed Hadoop Flags: Reviewed Tested by hand using the following: {noformat} for

[GitHub] [hbase-filesystem] joshelser closed pull request #6: HBASE-22694 Fallback to hbase.zookeeper.quorum if fs.hboss.sync.zk.co…

2019-07-15 Thread GitBox
joshelser closed pull request #6: HBASE-22694 Fallback to hbase.zookeeper.quorum if fs.hboss.sync.zk.co… URL: https://github.com/apache/hbase-filesystem/pull/6 This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885592#comment-16885592 ] Hudson commented on HBASE-21606: Results for branch branch-1.4 [build #906 on

[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885593#comment-16885593 ] Hudson commented on HBASE-15666: Results for branch branch-1 [build #954 on

[jira] [Commented] (HBASE-21606) Document use of the meta table load metrics added in HBASE-19722

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885594#comment-16885594 ] Hudson commented on HBASE-21606: Results for branch branch-1 [build #954 on

[jira] [Commented] (HBASE-15666) shaded dependencies for hbase-testing-util

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885591#comment-16885591 ] Hudson commented on HBASE-15666: Results for branch branch-1.4 [build #906 on

[GitHub] [hbase-filesystem] joshelser commented on issue #6: HBASE-22694 Fallback to hbase.zookeeper.quorum if fs.hboss.sync.zk.co…

2019-07-15 Thread GitBox
joshelser commented on issue #6: HBASE-22694 Fallback to hbase.zookeeper.quorum if fs.hboss.sync.zk.co… URL: https://github.com/apache/hbase-filesystem/pull/6#issuecomment-511556436 Fast review. Thanks Busbey! This is an

[jira] [Commented] (HBASE-22694) Use hbase.zookeeper.quorum if fs.hboss.sync.zk.connectionString is not defined

2019-07-15 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885561#comment-16885561 ] Josh Elser commented on HBASE-22694: FYI [~wchevreuil], [~busbey] > Use hbase.zookeeper.quorum if

[GitHub] [hbase-filesystem] joshelser opened a new pull request #6: HBASE-22694 Fallback to hbase.zookeeper.quorum if fs.hboss.sync.zk.co…

2019-07-15 Thread GitBox
joshelser opened a new pull request #6: HBASE-22694 Fallback to hbase.zookeeper.quorum if fs.hboss.sync.zk.co… URL: https://github.com/apache/hbase-filesystem/pull/6 …nnectionString is undefined Simple code change, but some refactoring to add testing for the change.

[jira] [Created] (HBASE-22694) Use hbase.zookeeper.quorum if fs.hboss.sync.zk.connectionString is not defined

2019-07-15 Thread Josh Elser (JIRA)
Josh Elser created HBASE-22694: -- Summary: Use hbase.zookeeper.quorum if fs.hboss.sync.zk.connectionString is not defined Key: HBASE-22694 URL: https://issues.apache.org/jira/browse/HBASE-22694 Project:

[GitHub] [hbase-operator-tools] asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2

2019-07-15 Thread GitBox
asf-ci commented on issue #6: HBASE-22680 [HBCK2] OfflineMetaRepair for hbase2/hbck2 URL: https://github.com/apache/hbase-operator-tools/pull/6#issuecomment-511540689 Refer to this link for build results (access rights to CI server needed):

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303592367 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303592755 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303594344 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/SnapshotCleanerChore.java ## @@

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303594642 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/SnapshotCleanerChore.java ## @@

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303593588 ## File path: hbase-protocol-shaded/src/main/protobuf/Snapshot.proto ## @@ -44,6 +44,7 @@ message

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303595006 ## File path: hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp ## @@ -99,6 +100,7 @@

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303594585 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/SnapshotCleanerChore.java ## @@

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303594142 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/SnapshotCleanerChore.java ## @@

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303593397 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1864,4 +1864,25 @@ possible

[GitHub] [hbase] apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
apurtell commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303593699 ## File path: hbase-protocol/src/main/protobuf/HBase.proto ## @@ -184,6 +184,7 @@ message SnapshotDescription {

[jira] [Commented] (HBASE-22537) Split happened Replica region can not be deleted after deleting table successfully and restarting RegionServer

2019-07-15 Thread HBase QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885537#comment-16885537 ] HBase QA commented on HBASE-22537: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM…

2019-07-15 Thread GitBox
Apache-HBase commented on issue #354: HBASE-20368 Fix RIT stuck when a rsgroup has no online servers but AM… URL: https://github.com/apache/hbase/pull/354#issuecomment-511531296 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22684) The log rolling request maybe canceled immediately in LogRoller due to a race

2019-07-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885528#comment-16885528 ] Hudson commented on HBASE-22684: Results for branch master [build #1225 on

[GitHub] [hbase] srdo commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-07-15 Thread GitBox
srdo commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-511529497 The failure on Jenkins seems to be the hbase-server not compiling because it can't find the new ClientTokenUtil class

[GitHub] [hbase] Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples

2019-07-15 Thread GitBox
Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples URL: https://github.com/apache/hbase/pull/315#issuecomment-511529151 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] petersomogyi commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-15 Thread GitBox
petersomogyi commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#discussion_r303588110 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1445,6 +1445,9 @@

[GitHub] [hbase] Apache-HBase commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-15 Thread GitBox
Apache-HBase commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/380#issuecomment-511527250 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table

2019-07-15 Thread GitBox
Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table URL: https://github.com/apache/hbase/pull/336#issuecomment-511523990 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

  1   2   3   >