[jira] [Commented] (HBASE-22658) region_mover.rb should choose same rsgroup servers as target servers

2019-07-20 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889643#comment-16889643 ] Reid Chan commented on HBASE-22658: --- bq. How do we know they actually work? I tested

[GitHub] [hbase] Reidddddd commented on issue #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize.

2019-07-20 Thread GitBox
Reidd commented on issue #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize. URL: https://github.com/apache/hbase/pull/386#issuecomment-513522708 LGTM,will commit tomorrow if no further comment from other members.

[GitHub] [hbase] Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in TestFromClientSide

2019-07-20 Thread GitBox
Apache-HBase commented on issue #385: HBASE-22382 Refactor tests in TestFromClientSide URL: https://github.com/apache/hbase/pull/385#issuecomment-513508717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:---

[GitHub] [hbase] Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-07-20 Thread GitBox
Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#issuecomment-513508634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase] Apache-HBase commented on issue #360: HBASE-15666 shaded dependencies for hbase-testing-util

2019-07-20 Thread GitBox
Apache-HBase commented on issue #360: HBASE-15666 shaded dependencies for hbase-testing-util URL: https://github.com/apache/hbase/pull/360#issuecomment-513507969 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples

2019-07-20 Thread GitBox
Apache-HBase commented on issue #315: HBASE-22594 Clean up for backup examples URL: https://github.com/apache/hbase/pull/315#issuecomment-513507277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] Apache-HBase commented on issue #384: HBASE-22603 Javadoc Warnings related to @link tag

2019-07-20 Thread GitBox
Apache-HBase commented on issue #384: HBASE-22603 Javadoc Warnings related to @link tag URL: https://github.com/apache/hbase/pull/384#issuecomment-513506744 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hbase] Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table

2019-07-20 Thread GitBox
Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table URL: https://github.com/apache/hbase/pull/336#issuecomment-513506746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comm

[GitHub] [hbase] Apache-HBase commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-20 Thread GitBox
Apache-HBase commented on issue #380: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/380#issuecomment-513506028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[jira] [Commented] (HBASE-22613) Bump Apache Avro to 1.9.0

2019-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889607#comment-16889607 ] Hadoop QA commented on HBASE-22613: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[GitHub] [hbase] Apache-HBase commented on issue #326: HBASE-22613: Bump Apache Avro to 1.9.0

2019-07-20 Thread GitBox
Apache-HBase commented on issue #326: HBASE-22613: Bump Apache Avro to 1.9.0 URL: https://github.com/apache/hbase/pull/326#issuecomment-513505903 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| |

[GitHub] [hbase] Apache-HBase commented on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

2019-07-20 Thread GitBox
Apache-HBase commented on issue #381: HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+ URL: https://github.com/apache/hbase/pull/381#issuecomment-513505302 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hbase] Apache-HBase commented on issue #199: HBASE-22313 Add method to FsDelegation token to accept token kind

2019-07-20 Thread GitBox
Apache-HBase commented on issue #199: HBASE-22313 Add method to FsDelegation token to accept token kind URL: https://github.com/apache/hbase/pull/199#issuecomment-513504969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] Apache-HBase commented on issue #210: HBASE-22346 scanner priorities/deadline units are invalid for non-huge scanners

2019-07-20 Thread GitBox
Apache-HBase commented on issue #210: HBASE-22346 scanner priorities/deadline units are invalid for non-huge scanners URL: https://github.com/apache/hbase/pull/210#issuecomment-513504728 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:-

[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-07-20 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-513504474 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2019-07-20 Thread GitBox
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 URL: https://github.com/apache/hbase/pull/251#issuecomment-513502100 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hbase] Apache-HBase commented on issue #394: HBASE-22716:upgrade zookeeper version to 3.5.5

2019-07-20 Thread GitBox
Apache-HBase commented on issue #394: HBASE-22716:upgrade zookeeper version to 3.5.5 URL: https://github.com/apache/hbase/pull/394#issuecomment-513501122 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[jira] [Commented] (HBASE-22716) upgrade zookeeper version to 3.5.5

2019-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889596#comment-16889596 ] Hadoop QA commented on HBASE-22716: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[GitHub] [hbase] Apache-HBase commented on issue #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize.

2019-07-20 Thread GitBox
Apache-HBase commented on issue #386: HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize. URL: https://github.com/apache/hbase/pull/386#issuecomment-513499414 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[jira] [Commented] (HBASE-22663) The HeapAllocationRatio in WebUI is not accurate because all of the heap allocation will happen in another separated allocator named HEAP

2019-07-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889588#comment-16889588 ] Hudson commented on HBASE-22663: Results for branch master [build #1246 on buil

[GitHub] [hbase] Apache-HBase commented on issue #395: HBASE-22132 : Backport HBASE-22115 to branch-1

2019-07-20 Thread GitBox
Apache-HBase commented on issue #395: HBASE-22132 : Backport HBASE-22115 to branch-1 URL: https://github.com/apache/hbase/pull/395#issuecomment-513499189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hbase] Apache-HBase commented on issue #393: HBASE-22715 Use scan queues/executors for scans, when RWQueueRpcExecutor used

2019-07-20 Thread GitBox
Apache-HBase commented on issue #393: HBASE-22715 Use scan queues/executors for scans, when RWQueueRpcExecutor used URL: https://github.com/apache/hbase/pull/393#issuecomment-513498783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:---

[jira] [Commented] (HBASE-22663) The HeapAllocationRatio in WebUI is not accurate because all of the heap allocation will happen in another separated allocator named HEAP

2019-07-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889582#comment-16889582 ] Hudson commented on HBASE-22663: Results for branch branch-2 [build #2092 on bu

[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes

2019-07-20 Thread GitBox
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-513490631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment

[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-07-20 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-513490633 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-07-20 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-513490612 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] Apache-HBase commented on issue #202: HBASE-22280 Separate read/write handler for priority request(especial…

2019-07-20 Thread GitBox
Apache-HBase commented on issue #202: HBASE-22280 Separate read/write handler for priority request(especial… URL: https://github.com/apache/hbase/pull/202#issuecomment-513490209 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase] Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL directory (hbase.wal.dir) usage

2019-07-20 Thread GitBox
Apache-HBase commented on issue #391: HBASE-22628 Document the custom WAL directory (hbase.wal.dir) usage URL: https://github.com/apache/hbase/pull/391#issuecomment-513489235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] Apache-HBase commented on issue #367: region_mover.rb should choose same rsgroup servers as target servers

2019-07-20 Thread GitBox
Apache-HBase commented on issue #367: region_mover.rb should choose same rsgroup servers as target servers URL: https://github.com/apache/hbase/pull/367#issuecomment-513489031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo

2019-07-20 Thread GitBox
Apache-HBase commented on issue #392: HBASE-22714 - Fix opertationTimeout typo URL: https://github.com/apache/hbase/pull/392#issuecomment-513488999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file to bin directory

2019-07-20 Thread GitBox
Apache-HBase commented on issue #382: HBASE-22692 Added Rubocop definition file to bin directory URL: https://github.com/apache/hbase/pull/382#issuecomment-513488034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|---

[GitHub] [hbase] Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server open regions metric to AM 01

2019-07-20 Thread GitBox
Apache-HBase commented on issue #237: HBASE-22408 add dead and unknown server open regions metric to AM 01 URL: https://github.com/apache/hbase/pull/237#issuecomment-513487856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] Apache-HBase commented on issue #371: HBASE-22648 : Introducing Snapshot TTL

2019-07-20 Thread GitBox
Apache-HBase commented on issue #371: HBASE-22648 : Introducing Snapshot TTL URL: https://github.com/apache/hbase/pull/371#issuecomment-513487808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| |

[GitHub] [hbase] Apache-HBase commented on issue #238: HBASE-22410 add the notion of the expected # of servers for non-fixed server sets; report an alternative dead server metric 01

2019-07-20 Thread GitBox
Apache-HBase commented on issue #238: HBASE-22410 add the notion of the expected # of servers for non-fixed server sets; report an alternative dead server metric 01 URL: https://github.com/apache/hbase/pull/238#issuecomment-513487848 :broken_heart: **-1 overall**

[jira] [Commented] (HBASE-22132) Backport HBASE-22115 intent to branch-1

2019-07-20 Thread HBase QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889558#comment-16889558 ] HBase QA commented on HBASE-22132: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Resolved] (HBASE-22663) The HeapAllocationRatio in WebUI is not accurate because all of the heap allocation will happen in another separated allocator named HEAP

2019-07-20 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu resolved HBASE-22663. -- Resolution: Fixed Hadoop Flags: Reviewed > The HeapAllocationRatio in WebUI is not accurate beca

[jira] [Updated] (HBASE-22663) The HeapAllocationRatio in WebUI is not accurate because all of the heap allocation will happen in another separated allocator named HEAP

2019-07-20 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Hu updated HBASE-22663: - Fix Version/s: 2.3.0 3.0.0 > The HeapAllocationRatio in WebUI is not accurate because

[jira] [Commented] (HBASE-22663) The HeapAllocationRatio in WebUI is not accurate because all of the heap allocation will happen in another separated allocator named HEAP

2019-07-20 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889532#comment-16889532 ] Zheng Hu commented on HBASE-22663: -- Merged this patch into master & branch-2.3 now, Th

[GitHub] [hbase] openinx merged pull request #365: HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator nam

2019-07-20 Thread GitBox
openinx merged pull request #365: HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator named HEAP URL: https://github.com/apache/hbase/pull/365 ---

[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

2019-07-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889516#comment-16889516 ] Hudson commented on HBASE-21879: Results for branch HBASE-21879 [build #183 on

[jira] [Updated] (HBASE-22132) Backport HBASE-22115 intent to branch-1

2019-07-20 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22132: - Attachment: HBASE-22132-branch-1.patch Status: Patch Available (was: In Progress) > Bac

[jira] [Work started] (HBASE-22132) Backport HBASE-22115 intent to branch-1

2019-07-20 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22132 started by Viraj Jasani. > Backport HBASE-22115 intent to branch-1 > ---

[GitHub] [hbase] virajjasani opened a new pull request #395: HBASE-22132 : Backport HBASE-22115 to branch-1

2019-07-20 Thread GitBox
virajjasani opened a new pull request #395: HBASE-22132 : Backport HBASE-22115 to branch-1 URL: https://github.com/apache/hbase/pull/395 TraceScope for reclaimMemStoreMemory to be wrapped around by try-with-resources so that any Exception in reclaimMemStoreMemory() does not leave scope op

[jira] [Commented] (HBASE-22648) Snapshot TTL

2019-07-20 Thread HBase QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889500#comment-16889500 ] HBase QA commented on HBASE-22648: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Updated] (HBASE-22648) Snapshot TTL

2019-07-20 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22648: - Attachment: HBASE-22648-master-v7.patch > Snapshot TTL > > > Key: H

[GitHub] [hbase] maoling closed pull request #394: HBASE-22716:upgrade zookeeper version to 3.5.5

2019-07-20 Thread GitBox
maoling closed pull request #394: HBASE-22716:upgrade zookeeper version to 3.5.5 URL: https://github.com/apache/hbase/pull/394 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] maoling opened a new pull request #394: HBASE-22716:upgrade zookeeper version to 3.5.5

2019-07-20 Thread GitBox
maoling opened a new pull request #394: HBASE-22716:upgrade zookeeper version to 3.5.5 URL: https://github.com/apache/hbase/pull/394 - This zookeeper [3.5.5](http://zookeeper.apache.org/releases.html) release is a stable one and recommended for production use, which has no compatibility i

[GitHub] [hbase] gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend

2019-07-20 Thread GitBox
gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#discussion_r305577407 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.

[jira] [Commented] (HBASE-22622) WALKey Extended Attributes

2019-07-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889398#comment-16889398 ] Hudson commented on HBASE-22622: Results for branch master [build #1244 on buil